alexfh wrote: > Here is the new fix. #66321
Thanks! I think, I found another pattern where string literal breaking is not allowed - in parameters of `goog.module.get()` (https://google.github.io/closure-library/api/goog.module.html). I'm not completely sure, which tool produces the error I'm seeing and how relevant this is to the external users of Closure, but we definitely want a way to prevent breaking arguments of this function (or completely) - if not by default, then at least as a customizable style option. > If it is not urgent, I prefer to wait a few days for reviews and then commit > the patch myself. I used to work on this part of clang-format and now the code a bit, thus I feel comfortable approving this sort of a change. Another thing is that we need to get this fixed really soon. Another (safer and actually preferred) alternative is to revert the change and address problematic use cases before recommitting it, but I'm also fine with forward-fixing this as long as fixes don't require major changes that have potential for other problems to appear. https://github.com/llvm/llvm-project/pull/66168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
