[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/66195: Otherwise, the test doesn't actually do anything. >From 40d908d9b9019919a0196daea92606d13fe66855 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 13 Sep 2023 11:52:11 + Subject: [PATCH] [clang

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Otherwise, the test doesn't actually do anything. -- Full diff: https://github.com/llvm/llvm-project/pull/66195.diff 1 Files Affected: - (modified) clang/unittests/Analysis/FlowSensitive/TransferTest.cpp (+1-1) diff --git a

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/66197: Before, we were silently letting the test pass, which masks test bugs; for an example, see https://github.com/llvm/llvm-project/pull/66195. >From 5a827c9ea1543a5c52a89dbc15667e04b25df6d1 Mon Sep 17 00:00:0

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/65306: >From 0126977e7f0e21713609425202b6c6b940941d39 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Tue, 5 Sep 2023 08:19:11 + Subject: [PATCH] Separate PNR into it's own Register Class This patch separates

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 05a11f3 - [clang][Sema][NFC] Add missing docs to some FieldDecl methods.

Author: Timm Bäder Date: 2023-09-13T14:20:10+02:00 New Revision: 05a11f3e6dc234582f18ffeeccec192251cc8b48 URL: https://github.com/llvm/llvm-project/commit/05a11f3e6dc234582f18ffeeccec192251cc8b48 DIFF: https://github.com/llvm/llvm-project/commit/05a11f3e6dc234582f18ffeeccec192251cc8b48.diff LO

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Changes This patch separates PNR registers into their own register class instead of sharing a register class with PPR registers. This primarily allows us to return more accurate register classes when applying assembly constrai

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66203: It's usually a ConstantExpr with a saved constant integer anyway, so we can just return that. >From 7668b4e5eb09b05c50ef67b23671dc2d19e12046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date:

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

llvmbot wrote: @llvm/pr-subscribers-clang Changes It's usually a ConstantExpr with a saved constant integer anyway, so we can just return that. -- Full diff: https://github.com/llvm/llvm-project/pull/66203.diff 1 Files Affected: - (modified) clang/lib/AST/Decl.cpp (+8) dif

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158472/new/ https://reviews.llvm.org/D158472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556655. skatrak added a comment. Rebase and address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flan

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

tbaeder added a comment. In D158472#4605228 , @hazohelet wrote: > This breaks the one-note-for-one-overload-candidate rule of overload > resolution failure diagnostics > (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc221901f4ed1

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 556656. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/65306: >From 0126977e7f0e21713609425202b6c6b940941d39 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Tue, 5 Sep 2023 08:19:11 + Subject: [PATCH] Separate PNR into it's own Register Class This patch separates

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 556657. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

cor3ntin wrote: Hum... should we put that in `EvaluateKnownConstInt` directly? Bitfields are not the only use case https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

RKSimon wrote: Are there existing bug issues associated with this? https://github.com/llvm/llvm-project/pull/65465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

tbaederr wrote: > Hum... should we put that in `EvaluateKnownConstInt` directly? Bitfields are > not the only use case See https://reviews.llvm.org/D155548 - I can't really support any of this with performance numbers (from my testing, I can't even support that we short-circuit `IntegerLitera

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/cor3ntin commented: There are some whitespace-only that should be reverted + 1 small nitpick. And I have a question about `__has_cpp_attribute` https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -8368,6 +8368,20 @@ static void handleNoMergeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(NoMergeAttr::Create(S.Context, AL)); } +static void handleNoUniqueAddressAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + NoUniqueAddressAttr TmpAttr(S.Context, AL); +

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -55,7 +55,7 @@ CXX11(unlikely) // CHECK: likely: 201803L // CHECK: maybe_unused: 201603L // ITANIUM: no_unique_address: 201803L -// WINDOWS: no_unique_address: 0 +// WINDOWS: no_unique_address: 201803L cor3ntin wrote: don't we expect `__has_cpp_attribute(n

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH 1/3] [AArch64][SME]Update intrinsic interface for ld1

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH 1/3] [AArch64][SME]Update intrinsic interface for ld1

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[clang] d2c2fa9 - [clang][NFC] Replace deprected *cast_or_null casts

Author: Timm Bäder Date: 2023-09-13T14:54:21+02:00 New Revision: d2c2fa94ae11e1b84d0fda2c0366131cbc7cd8b7 URL: https://github.com/llvm/llvm-project/commit/d2c2fa94ae11e1b84d0fda2c0366131cbc7cd8b7 DIFF: https://github.com/llvm/llvm-project/commit/d2c2fa94ae11e1b84d0fda2c0366131cbc7cd8b7.diff LO

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

https://github.com/cor3ntin requested changes to this pull request. I knew there was a deja-vu here :) I'd rather we do the general solution then. Maybe we should pursue the discussion on phab. I can't imagine the general solution is going to ever be noticeably worse. I have the possibility t

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/66205: Summary: Currently, there is an assertion that prevents us from emitting an AMDGPU global with a non-target specific address space (i.e. numerical attribute). I'm unsure what the original intentions of this asser

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 review_requested https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Changes Summary: Currently, there is an assertion that prevents us from emitting an AMDGPU global with a non-target specific address space (i.e. numerical attribute). I'm unsure what the original intentions of this assertion were

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] e65e94f - [clang][dataflow] Rename test target function to `target()`. (#66195)

Author: martinboehme Date: 2023-09-13T15:07:44+02:00 New Revision: e65e94fddc92916c12ce82d0e2d2310bcdcce03d URL: https://github.com/llvm/llvm-project/commit/e65e94fddc92916c12ce82d0e2d2310bcdcce03d DIFF: https://github.com/llvm/llvm-project/commit/e65e94fddc92916c12ce82d0e2d2310bcdcce03d.diff

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/66197: >From 8285300a8b3960e1629287e3c173fd4c6b33b9f8 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 13 Sep 2023 11:57:16 + Subject: [PATCH] [clang][dataflow] In tests, error out if we didn't find an

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66205: >From 97642f663099cfb42792cd2415387170a146d9e2 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 13 Sep 2023 07:57:47 -0500 Subject: [PATCH] [Clang][AMDGPU] Permit language address spaces for AMDGPU global

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

@@ -0,0 +1,31 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 0; +int [[clang::opencl_

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

https://github.com/jhuber6 resolved https://github.com/llvm/llvm-project/pull/66205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "none" (PR #66162)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66162: >From 1aab90448afc0f072d194eb956f6543e82d76303 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 19:22:30 -0500 Subject: [PATCH] [Clang] Define AMDGPU ABI when referenced in CodeGen for ABI "no

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/martinboehme ready_for_review https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] In tests, error out if we didn't find any matching target functions. (PR #66197)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

@@ -0,0 +1,52 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals --version 3 +// RUN: %clang_cc1 -cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + +int [[clang::opencl_global]] a = 1; +int [[clang::opencl_

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 ___ cfe-commits mailing list cfe-comm

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Thanks for taking care of the other tests. I'm not sure how this could be reproduced not on AIX. I'll have to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand resolved https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to use `llvm::SmallVector` instead of `std::vector`. (PR #66014)

https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/65737: From 112dd3c57c28b467463ef39dfbc33560b652b1c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Fri, 8 Sep 2023 11:25:44 +0200 Subject: [PATCH] [Clang] Drop functions wi

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to use `llvm::SmallVector` instead of `std::vector`. (PR #66014)

https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

https://github.com/dkrupp review_requested https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

https://github.com/dkrupp review_requested https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

@@ -375,6 +375,11 @@ class ReturnValueSlot { bool isExternallyDestructed() const { return IsExternallyDestructed; } }; +/// If \p F "target-features" are incompatible with the \p TargetOpts features, jmmartinez wrote: I've updated the comment but I've reali

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -108,6 +108,16 @@ class DataflowAnalysisContext { /// A null `PointeeType` can be used for the pointee of `std::nullptr_t`. PointerValue &getOrCreateNullPointerValue(QualType PointeeType); + /// Adds `Constraint` to current and future flow conditions in this context. +

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/ymand resolved https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula &Val1, } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector &Constraints, -llvm::DenseSet &VisitedTokens) { - auto Res = VisitedTokens.

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66055: >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH 01/10] add --- .../bugprone/BugproneTidyModule.cpp

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

yxsamliu wrote: The assertion is for preventing language-specific address space e.g. OpenCL addr space from being used in addr space agnostic languages. The numerical addr space attr are mapped to target-specific AST addr space therefore won't cause assertion. I am OK to remove that assertion

[clang] [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (PR #66205)

arsenm wrote: > The assertion is for preventing language-specific address space e.g. OpenCL > addr space from being used in addr space agnostic languages. If the intent was to forbid this it should be a proper error. Part of the point is to use these from other languages https://github.com/l

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

bylaws added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:59 + +StringRef Name = Printer.getSymbol(GV)->getName(); +// Don't mangle ARM64EC runtime functions. This mangling logic is also necessary for dllimported functions,

[clang] [clang][dataflow] Change `diagnoseFunction` to use `llvm::SmallVector` instead of `std::vector`. (PR #66014)

https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/66014: >From 335f12e897d8d776dc476b468bc0dc1e7b8019df Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Mon, 11 Sep 2023 21:34:00 + Subject: [PATCH 1/2] [clang][dataflow] Change `diagnoseFunction` to take type

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -61,6 +61,6 @@ only advisable to employ ``nullptr`` for comparisons. Limitations --- -The check will not analyze values stored in a variable. For variable, the check -will analyze all virtual methods in the same ``class`` or ``struct`` and diagnose -when assigning

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

RKSimon wrote: > Split some tests for c/cpp; NFC Why was this necessary? https://github.com/llvm/llvm-project/pull/66036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/alexfh approved this pull request. LG. Thanks for the prompt fix! https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5db201f - [clang-format] Stop breaking unbreakable strings in JS (#66168)

Author: sstwcw Date: 2023-09-13T17:04:04+02:00 New Revision: 5db201fb75e6d1e2777bff8bc8df012174e905f3 URL: https://github.com/llvm/llvm-project/commit/5db201fb75e6d1e2777bff8bc8df012174e905f3 DIFF: https://github.com/llvm/llvm-project/commit/5db201fb75e6d1e2777bff8bc8df012174e905f3.diff LOG: [

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

https://github.com/alexfh closed https://github.com/llvm/llvm-project/pull/66168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a7f256f - [clang][Interp][NFC] Use delegate() once more

Author: Timm Bäder Date: 2023-09-13T17:08:40+02:00 New Revision: a7f256fb4c0c18fad9e654d62e0633735dddf4b8 URL: https://github.com/llvm/llvm-project/commit/a7f256fb4c0c18fad9e654d62e0633735dddf4b8 DIFF: https://github.com/llvm/llvm-project/commit/a7f256fb4c0c18fad9e654d62e0633735dddf4b8.diff LO

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

@@ -0,0 +1,38 @@ +; Check that we do not generate an extra indirection accessing the stack guard +; variable, when the relocation model is static. +; +; RUN: llvm-as < %s > %t.bc +; RUN: llvm-lto -O0 -relocation-model=static -o %t.o %t.bc +; RUN: llvm-objdump -d -r %t.o | FileChec

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget, return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/66222: The bounds of a c++ array is a _constant-expression_. And in C++ it is also a constant expression. But we also support VLAs, ie arrays with non-constant bounds. We need to take care to handle the case of a co

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin review_requested https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

https://github.com/balazske review_requested https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The bounds of a c++ array is a _constant-expression_. And in C++ it is also a constant expression. But we also support VLAs, ie arrays with non-constant bounds. We need to take care to handle the case of a consteval function (w

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

https://github.com/balazske review_requested https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >