[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. I've pushed some WIP change to inform that I'm still working on this topic :) Not sure if I also need to submit a comment to publish what I've marked as "done" via checkboxes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev added a subscriber: lkail. v.g.vassilev added a comment. In D159115#4642111 , @tuliom wrote: > In D159115#4641834 , @mgorny wrote: > >> Is that actually a regression, or merely the test wasn't checkin

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't see it at this point, though I get a whole lot of other uninitialized reads, so there's definitely some general problems in this space in the LLVM codebase Repository: rG LLVM Github Monor

[clang] cc2b09b - [Clang][LoongArch] Generate _mcount instead of mcount (#65657)

Author: Nathan Chancellor Date: 2023-09-08T10:54:35-07:00 New Revision: cc2b09bee017147527e7bd1eb5272f4f70a7b900 URL: https://github.com/llvm/llvm-project/commit/cc2b09bee017147527e7bd1eb5272f4f70a7b900 DIFF: https://github.com/llvm/llvm-project/commit/cc2b09bee017147527e7bd1eb5272f4f70a7b900.d

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/nathanchance closed https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD review_requested https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/65778: >From ebffa141090d5274db8a88b5450325e34316a18b Mon Sep 17 00:00:00 2001 From: eopXD Date: Fri, 8 Sep 2023 09:59:25 -0700 Subject: [PATCH] [Clang][RISCV] Use Decl for checkRVVTypeSupport Using ValueDecl will cause

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v \ +// RUN: -disable-O0-optnone -o - -fsyntax-only -fopenmp %s -verify +// REQUIRES: riscv-registered-target +// expected-no-diagnostics +#include alexey-bataev wrote: No includes of syste

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v \ +// RUN: -disable-O0-optnone -o - -fsyntax-only -fopenmp %s -verify +// REQUIRES: riscv-registered-target +// expected-no-diagnostics +#include jrtc27 wrote: This is shipped by Clang no

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/jrtc27 edited https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v \ +// RUN: -disable-O0-optnone -o - -fsyntax-only -fopenmp %s -verify jrtc27 wrote: -disable-O0-optnone is pointless unless you're generating code *and* piping it to opt, but you're doing

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/jrtc27 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v \ +// RUN: -disable-O0-optnone -o - -fsyntax-only -fopenmp %s -verify +// REQUIRES: riscv-registered-target +// expected-no-diagnostics jrtc27 wrote: ```suggestion // expected-no-diagnost

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/65778: >From 8226aecca0e5ebcf17465122cd2df6cfd1b5e5c9 Mon Sep 17 00:00:00 2001 From: eopXD Date: Fri, 8 Sep 2023 09:59:25 -0700 Subject: [PATCH] [Clang][RISCV] Use Decl for checkRVVTypeSupport Using ValueDecl will cause

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/65778: >From 90764baf1616f4a150a10f63df0b0ea6bde0a86a Mon Sep 17 00:00:00 2001 From: eopXD Date: Fri, 8 Sep 2023 09:59:25 -0700 Subject: [PATCH] [Clang][RISCV] Use Decl for checkRVVTypeSupport Using ValueDecl will cause

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState &State, } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 201

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rjmccall requested changes to this pull request. Functionally LGTM; just a minor request. https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [sema] Improve -Wsign-compare (PR #65684)

=?utf-8?q?Félix?= Cloutier https://github.com/apple-fcloutier updated https://github.com/llvm/llvm-project/pull/65684: >From 466a68e59891e0565b8de3201305d7a881785474 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Cloutier?= Date: Wed, 6 Sep 2023 13:22:42 -0400 Subject: [PATCH 1/2] [sem

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD review_requested https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

https://github.com/eopXD review_requested https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sema] Improve -Wsign-compare (PR #65684)

=?utf-8?q?Félix?= Cloutier @@ -14308,22 +14382,22 @@ static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, /// Analyze the given simple or compound assignment for warning-worthy /// operations. -static void AnalyzeAssignment(Sema &S, BinaryOperator

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v -fopenmp %s alexey-bataev wrote: Could you move the test to OpenMP directory? https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mail

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

@@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v -fopenmp %s jrtc27 wrote: Commenting here rather than the commit: What happened to -fsyntax-only -verify? https://github.com/llvm/llvm-project/pull/65778

[PATCH] D151834: Include math-errno with fast-math

thakis added a comment. This breaks check-clang on macOS: http://45.33.8.238/macm1/68762/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.or

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4642195 , @thakis wrote: > This breaks check-clang on macOS: http://45.33.8.238/macm1/68762/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I have a fix for it here: https://reviews.ll

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

https://github.com/nunoplopes updated https://github.com/llvm/llvm-project/pull/65596: >From 8585d37c6526d46e08efb2b573ca9ba50dd68a9b Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Thu, 7 Sep 2023 11:07:03 +0100 Subject: [PATCH 1/2] [clang][CodeGen] Switch declaration of vtable information to

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

@@ -14,8 +14,8 @@ class B : A { // NO-AS: @_ZTISt9type_info = external constant ptr // AS: @_ZTIi = external addrspace(1) constant ptr addrspace(1) // NO-AS: @_ZTIi = external constant ptr -// AS: @_ZTVN10__cxxabiv117__class_type_infoE = external addrspace(1) global ptr addrsp

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:125 * ``-Woverriding-t-option`` is renamed to ``-Woverriding-option``. * ``-Winterrupt-service-routine`` is renamed to ``-Wexcessive-regsave`` as a generalization ?? =

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. benlangmuir wrote: > Why do we need all this code now (I assume this is

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. iana wrote: > benlangmuir wrote: > > Why do we need all this code now (

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added a comment. In D159339#4642147 , @daltenty wrote: > FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't > see it at this point, though I get a whole lot of other uninitialized reads, > so there's definitely so

[clang] [clang] Better bitfield access units (PR #65742)

urnathan wrote: > Note that changing the memory accesses performed by clang (load or store) > _is_ an ABI change at IR level because of UB. Could you clarify why UB is a consideration here? https://github.com/llvm/llvm-project/pull/65742 ___ cfe-com

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/Xazax-hun resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Comment at: clang/test/Sema/warn-fortify-source.c:100-102 + __builtin_snprintf(buf, 2, "%#x", n); + __builtin_snprintf(buf, 2, "%#X"

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/Xazax-hun approved this pull request. Code looks fine to me, added some a comment about a potential TODO. https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,107 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Better bitfield access units (PR #65742)

efriedma-quic wrote: > > Note that changing the memory accesses performed by clang (load or store) > > _is_ an ABI change at IR level because of UB. > > Could you clarify why UB is a consideration here? There's some weirdness with poison values; see https://reviews.llvm.org/D129541 etc. This

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

philipp.tomsich added a comment. Should we move this to a GitHub PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ https://reviews.llvm.org/D159480 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo unlabeled https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/PiotrZSL requested changes to this pull request. To be honest you still didn't clarify how this check is different from an exist ones. Entire section "Regarding the checker specifications (especially as they compare the cppcoreguidelines-pro-type-member-init):" says only "the

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

carlosgalvezp wrote: Thanks for the detailed response @adriannistor ! > will soon become a lot of if-then-else blocks. In general the decision as to which checks to have should be based on Coding Guidelines and user-facing experience - not on implementation complexity. In that sense, as a use

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556297. zahiraam added a reviewer: thakis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c =

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: I've added a release note (with hopefully valid reST syntax) and made the source comment less terse as requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

benlangmuir added a comment. Other than the giant header in the test we're still discussing, this basically LGTM. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types.

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks review_requested https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks review_requested https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/65808: It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. From d0415b4436a11e649fbeae53b8060f70bae03254 Mon Sep 17 00:00:00 2001 From

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22575 +#if 0 + // FIXME: As long as all the non-lambda arguments fit on a single line, AlwaysBreak + // doesn't force an initial line break, even if lambdas span multiple lines. T

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. Generally it's preferred to either push bot failure fixes directly or revert the original commit (also without review), to get bots unblocked as soon as possible :) From what I can see, the test failure is because `dso_local` isn't emitted on Mac. That seems incidental

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556301. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c ===

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642305 , @smeenai wrote: > Generally it's preferred to either push bot failure fixes directly or revert > the original commit (also without review), to get bots unblocked as soon as > possible :) > > From what I can

[PATCH] D159486: Fix build error in CI.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The `-triple x86_64-unknown-unknown` shouldn't be required after the regex change, but I'm fine either way. I'd recommend pushing this to fix the bots, and Aaron/Nico can do a post-commit re

[clang] 210e7b3 - [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope

Author: Jon Phillips Date: 2023-09-08T14:34:00-07:00 New Revision: 210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc URL: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc DIFF: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc.diff

[PATCH] D148131: [clang-format] Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG210e7b3ca773: [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope (authored by jp4a50, committed by owenpan). Changed prior to

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642309 , @smeenai wrote: > The `-triple x86_64-unknown-unknown` shouldn't be required after the regex > change, but I'm fine either way. I'd recommend pushing this to fix the bots, > and Aaron/Nico can do a post-com

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. I don't think pre-merge testing covers Mac, only Linux and Windows (which is presumably how the original breakage got in). If the test passes for you locally I'd just push it and monitor the bots afterwards. (That isn't general advice, but in this specific case, since w

[clang] e94e790 - [clang][test] Don't write temporary (actually, unused) outputs into CWD

Author: Dmitri Gribenko Date: 2023-09-08T23:54:41+02:00 New Revision: e94e790e46d0afd073b706afa0cf91804e7826e0 URL: https://github.com/llvm/llvm-project/commit/e94e790e46d0afd073b706afa0cf91804e7826e0 DIFF: https://github.com/llvm/llvm-project/commit/e94e790e46d0afd073b706afa0cf91804e7826e0.dif

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65723: >From cf7cca96897d392fcc9bef85c534261afb372d30 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 8 Sep 2023 01:16:33 -0700 Subject: [PATCH] [clang-format] Fix a serious bug in git-clang-format When applying for

[clang] d4ff8f8 - Fix buildbot failure

Author: Zahira Ammarguellat Date: 2023-09-08T17:56:51-04:00 New Revision: d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 URL: https://github.com/llvm/llvm-project/commit/d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 DIFF: https://github.com/llvm/llvm-project/commit/d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65515)

https://github.com/quic-akaryaki updated https://github.com/llvm/llvm-project/pull/65515: >From 86d3cb57d89036700abf89fa31fe243bc9cb2c6c Mon Sep 17 00:00:00 2001 From: Alexey Karyakin Date: Tue, 5 Sep 2023 15:46:34 -0700 Subject: [PATCH] [llvm-objcopy] Add --gap-fill and --pad-to options `--ga

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642317 , @smeenai wrote: > I don't think pre-merge testing covers Mac, only Linux and Windows (which is > presumably how the original breakage got in). If the test passes for you > locally I'd just push it and monit

[PATCH] D159486: Fix build error in CI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff8f815c21: Fix buildbot failure (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65515)

https://github.com/quic-akaryaki closed https://github.com/llvm/llvm-project/pull/65515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 743659b - [clang-format] Fix a serious bug in git-clang-format (#65723)

Author: Owen Pan Date: 2023-09-08T15:05:22-07:00 New Revision: 743659be87daff4cc8861c525d4a6229d787ef14 URL: https://github.com/llvm/llvm-project/commit/743659be87daff4cc8861c525d4a6229d787ef14 DIFF: https://github.com/llvm/llvm-project/commit/743659be87daff4cc8861c525d4a6229d787ef14.diff LOG:

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

dexonsmith added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. benlangmuir wrote: > iana wrote: > > iana wrote: > > > benlangmui

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. dexonsmith wrote: > benlangmuir wrote: > > iana wrote: > > > iana wrote

[PATCH] D148381: [Clang] Add counted_by attribute

void updated this revision to Diff 556310. void added a comment. - Expand test to show the unsanitized version, - Unify the ways of finding a specific field based on a predicate, - Make sure we're using the correct types in a couple of key places. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556311. iana added a comment. Try deleting the module cache to fix the failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[PATCH] D148381: [Clang] Add counted_by attribute

void updated this revision to Diff 556312. void marked an inline comment as done. void added a comment. Remove unneded extern decl from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556313. iana added a comment. Add the header guard comment to __stddef_null.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp clang

[PATCH] D148381: [Clang] Add counted_by attribute

void added a comment. I changed more than just the testcase (not a lot, but non-trivial nonetheless). PTAL. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/65818: After commit 610ec954e1f8 ("[clang] allow const structs/unions/arrays to be constant expressions for C"), attempts to evaluate structs/unions/arrays as constants are also performed for C++98 and C++03. A

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >