benlangmuir added a comment. Other than the giant header in the test we're still discussing, this basically LGTM.
================ Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. ---------------- iana wrote: > iana wrote: > > benlangmuir wrote: > > > Why do we need all this code now (I assume this is copied from the real > > > header)? > > It's to support the tests I added to Modules/compiler_builtins.m. > > stdatomic.h and inttypes.h rely on stdint.h contents from the C library, > > and on complex.h and inttypes.h and math.h being present. I could just test > > the modules with `-ffreestanding` I think, would that be better? > (and yes I just copied it from the builtin header) I'm not sure what the best approach is here, but this seems heavy for a test. Do we expect to need to keep this up to date? If so maybe ffreestanding for the specific test cases this affects would be a better tradeoff. Maybe someone else has a suggestion here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
