[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

2023-09-06 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. Lgtm https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
NuriAmari wrote: I've tried this on a real application, and the output paths quickly get extremely long. So long that we fail to create the directory structure. Perhaps the nesting idea isn't the right choice after all. https://github.com/llvm/llvm-project/pull/65179 __

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

2023-09-06 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
NuriAmari wrote: I've tried this on a real application, and the output paths quickly get extremely long. So long that we fail to create the directory structure. Perhaps the nesting idea isn't the right choice after all. https://github.com/llvm/llvm-project/pull/65179 __

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-06 Thread via cfe-commits
https://github.com/adriannistor updated https://github.com/llvm/llvm-project/pull/65189: >From c6d70f6f851f0553e3e83b762618d48744a4f706 Mon Sep 17 00:00:00 2001 From: Adrian Nistor Date: Fri, 1 Sep 2023 15:35:59 -0700 Subject: [PATCH 1/2] Adding an initial version of the "Initialized Class Mem

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

2023-09-06 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/65409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-06 Thread via cfe-commits
https://github.com/mydeveloperday unresolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

2023-09-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/test/ExtractAPI/bool.c:14 +//--- input.h +#include +bool Foo; clang tests should not be including system headers since that makes the tests non-hermetic (this test fails in our internal builds that provide more

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-06 Thread via cfe-commits
adriannistor wrote: @PiotrZSL @carlosgalvezp Piotr, thank you for your feedback! You are right: if this was the entire checker, it would make no sense to add a new checker. It was my mistake, I should have added more context and explanations to this PR (doing that now!). This is only the f

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 created https://github.com/llvm/llvm-project/pull/65539: None >From 863a72b4e099f4aa24e43fdaaeb2ab0e171a0381 Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Wed, 30 Aug 2023 13:44:02 -0700 Subject: [PATCH 01/13] Add SyclRuntimeWrappers and Add CMake option MLIR_E

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 created https://github.com/llvm/llvm-project/pull/65539: None >From 863a72b4e099f4aa24e43fdaaeb2ab0e171a0381 Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Wed, 30 Aug 2023 13:44:02 -0700 Subject: [PATCH 01/13] Add SyclRuntimeWrappers and Add CMake option MLIR_E

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-06 Thread via cfe-commits
@@ -148,6 +148,16 @@ New checks Flags coroutines that suspend while a lock guard is in scope at the suspension point. +- New :doc:`google-cpp-init-class-members + ` check. + + Checks that class members are initialized in constructors (implicitly or Eugen

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[PATCH] D158883: [Matrix] Try to emit fmuladd for both vector and matrix types

2023-09-06 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In D158883#4638648 , @thegameg wrote: > In D158883#4635997 , @uweigand > wrote: > >> The newly added test cases in ffp-model.c fail on SystemZ, making CI red: > > Should be fixed, thanks

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

2023-09-06 Thread via cfe-commits
https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

2023-09-06 Thread via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65540: A typical test case goes through the format, stability, ObjC, and messUp tests. If any of theses tests fails, we should skip the rest of the tests for the same test case. >From a1c4eb75303966edbd3c3932e8791604f

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

2023-09-06 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D152246#4639495 , @tbaeder wrote: > Do you think warning on assignment of function pointers with mismatched > attributes would be a viable way forward? Yes, that sounds like the right approach. (Slightly relaxed perhaps,

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Jianhui Li via cfe-commits
Jianhui-Li wrote: @rengolin @joker-eph @Hardcode84 FYI that this PR enables the current GPU dialect on Intel GPU as is, without introducing stream/queue to the current GPU dialect. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

2023-09-06 Thread Matthew Voss via cfe-commits
https://github.com/ormris approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Jianhui Li via cfe-commits
Jianhui-Li wrote: @rengolin @joker-eph @Hardcode84 FYI that this PR enables the current GPU dialect on Intel GPU as is, without introducing stream/queue to the current GPU dialect. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

2023-09-06 Thread Brendan Dahl via Phabricator via cfe-commits
brendandahl updated this revision to Diff 556089. brendandahl added a comment. Rebase and fix unused variable warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 Files: clang/lib/CodeGen/CodeGenMod

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

2023-09-06 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 556090. akhuang added a comment. more code updates and added some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 Files: clang/include/clang/Basic/Attr.t

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Ivan Butygin via cfe-commits
Hardcode84 wrote: I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to 2 separate PRs. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Ivan Butygin via cfe-commits
Hardcode84 wrote: I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to 2 separate PRs. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
silee2 wrote: > I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to > 2 separate PRs. Agree. And the changes are originally from different authors so should be splitted. https://github.com/llvm/llvm-project/pull/65539 ___ cf

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
silee2 wrote: > I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to > 2 separate PRs. Agree. And the changes are originally from different authors so should be splitted. https://github.com/llvm/llvm-project/pull/65539 ___ cf

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/2] [libc++] Implement ranges::contains Differential Revision:

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/2] [libc++] Implement ranges::contains Differential Revision:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK unresolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK unresolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

2023-09-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Ping. Are there any further concerns here? (This obviously needs to be merged with trunk, and the `-fclang-abi-compat=` checks and release notes need to be updated to match the latest release version.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D157762: Implement [[msvc::no_unique_address]]

2023-09-06 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 556091. akhuang added a comment. add note to the docs about no ABI compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 Files: clang/include/clang/Basic/At

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

2023-09-06 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); uabelho wrote: > @brad : > I think thi

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

2023-09-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

2023-09-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: This looks good to me but I would like another set of eyes on it. https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

2023-09-06 Thread Shafik Yaghmour via cfe-commits
@@ -2158,8 +2158,10 @@ StmtResult Parser::ParseForStatement(SourceLocation *TrailingElseLoc) { // for-range-declaration next. bool MightBeForRangeStmt = !ForRangeInfo.ParsedForRangeDecl(); ColonProtectionRAIIObject ColonProtection(*this, MightBeForRange

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-06 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > > So it looks like some of these changes undo some of the change introduced > > by @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some more > > input here. > > Do you have a pointer to such changes? One of the commits is here: 15f3cd6bfc670 I know he did a lot

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-06 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > > > So it looks like some of these changes undo some of the change introduced > > > by @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some > > > more input here. > > > > > > Do you have a pointer to such changes? > > One of the commits is here: > [15f3cd6](htt

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; + th

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539 __

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; + th

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -1158,7 +1178,7 @@ LogicalResult ConvertLaunchFuncOpToGpuRuntimeCallPattern::matchAndRewrite( {function.getResult(), adaptor.getGridSizeX(), adaptor.getGridSizeY(), adaptor.getGridSizeZ(), adaptor.getBlockSizeX(), adaptor.getBlockSizeY(), adaptor.getBlo

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539 __

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Mehdi Amini via cfe-commits
@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-06 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: The change looks good and like a nice improvement to me. I don't think this is undoing any of the intended functional changes of @mizvekov's work. https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits m

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

2023-09-06 Thread via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65540: >From e67336055c73e9d8c1d1fccff24395ca0197e985 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 6 Sep 2023 14:53:39 -0700 Subject: [PATCH] [clang-format] Skip additional tests of the same case upon failure A

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. I'm seeing libcxx failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770673168839783889/overview # .---command stderr # | /b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/ranges/range.adaptors/rang

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

2023-09-06 Thread via cfe-commits
owenca wrote: Before: ``` .../llvm-project/clang/unittests/Format/FormatTestBase.h:93: Failure Expected equality of these values: Expected.str() Which is: "(\n \"x\t\");" format(Code, Style, SC_ExpectComplete, Ra

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-06 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >