[PATCH] D157518: Avoid running optimization passes in frontend test

wenlei added inline comments. Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148 -// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32 [[LIKELY]]} -// CHECK: ![[PROF_UNLIKELY]] = !{!"branch_weights", i32 [[LIKELY]], i32 [[UNLIKE

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -17,7 +17,7 @@ struct Base { int x; }; struct Derived : Base { int y; }; int o = __builtin_offsetof(Derived, x); // expected-warning{{offset of on non-POD type}} -const int o2 = sizeof(__builtin_offsetof(Derived, x)); +const int o2 = sizeof(__builtin_offsetof(Derived, x));

[clang] [clang-repl] Emit const variables only once (PR #65257)

AaronBallman wrote: > That looks good to me. Can we backport that to the llvm17 release branch? I > know at least one downstream project that jumps through hoops to support this. I'd say we should not backport to 17.0.0; we need to get the final rc out the door and this isn't fixing a critical

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

cor3ntin added a comment. @barannikov88 Don't forget to land this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154773/new/ https://reviews.llvm.org/D154773 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

cor3ntin added a subscriber: Fznamznon. cor3ntin added a comment. @Fznamznon This might be of interest to you @faisalv are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. I was going to hold this over for a bit longer. 2 weeks and if no one says anything then go ahead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 __

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Changing the type from `unsigned long long` to `uintptr_t` fix the test for me. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:246 + EXPECT_FALSE(!Addr); + EXPECT_EQ((unsigned long long)&printf, Addr->getValue()); } Re

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev added a comment. In D159115#4638323 , @mgorny wrote: > Changing the type from `unsigned long long` to `uintptr_t` fix the test for > me. Ah! Nice catch! Can you commit the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] [clang][dataflow][NFC] Remove stale comment. (PR #65322)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

@@ -99,6 +99,10 @@ TEST_EVALUATE(DoWhileCond, do {} while (some_cond < 10);); // expected-error // expected-error {{constexpr variable 'forceEvaluateDoWhileCond' must be initialized by a constant expression}} TE

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/sam-mccall approved this pull request. LGTM I don't have a strong opinion about keeping the old even-more-broken versions. They're not very likely, and we don't attempt to cover most things like that. A fuzzer is probably a better approach (we have one, it finds an ~infinite

[clang] 3403686 - [Clang] Fix JIT test on 32-bit systems

Author: Sam James Date: 2023-09-05T16:04:22+01:00 New Revision: 3403686b72507e3fdbcd69f21fb9235ffa0ca169 URL: https://github.com/llvm/llvm-project/commit/3403686b72507e3fdbcd69f21fb9235ffa0ca169 DIFF: https://github.com/llvm/llvm-project/commit/3403686b72507e3fdbcd69f21fb9235ffa0ca169.diff LOG

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

thesamesam added a comment. In D159115#4638325 , @v.g.vassilev wrote: > In D159115#4638323 , @mgorny wrote: > >> Changing the type from `unsigned long long` to `uintptr_t` fix the test for >> me. > > Ah! Nice ca

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158472/new/ https://reviews.llvm.org/D158472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/65333: I was trying to update a test that redirected stderr to a file and hit errors because the `2>%t.out` was being passed as a positional argument to clang. Instead of re-implementing basic shell parsing in this

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

arichardson wrote: Looks like only squash and merge is possible here, so I'll commit the baseline test separately before landing this. https://github.com/llvm/llvm-project/pull/65333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

yronglin wrote: Thanks a lot for your review! @sam-mccall @cor3ntin https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin resolved https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 111c1ba - [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (#65269)

Author: yronglin Date: 2023-09-05T23:21:44+08:00 New Revision: 111c1ba5b492bd4bf64dfccc675a9db32ff6a28a URL: https://github.com/llvm/llvm-project/commit/111c1ba5b492bd4bf64dfccc675a9db32ff6a28a DIFF: https://github.com/llvm/llvm-project/commit/111c1ba5b492bd4bf64dfccc675a9db32ff6a28a.diff LOG:

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c7cc756 - [CMake] Add option to disable driver build in Fuchsia cache file

Author: Alex Brachet Date: 2023-09-05T15:22:15Z New Revision: c7cc756ce343808d0369de1b45e2b0747f62 URL: https://github.com/llvm/llvm-project/commit/c7cc756ce343808d0369de1b45e2b0747f62 DIFF: https://github.com/llvm/llvm-project/commit/c7cc756ce343808d0369de1b45e2b0747f62.diff LOG:

[PATCH] D159130: [CMake] Add option to disable driver build in Fuchsia cache file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rGc7cc756ce343: [CMake] Add option to disable driver build in Fuchsia cache file (authored by abrachet). Her

[PATCH] D159130: [CMake] Add option to disable driver build in Fuchsia cache file

abrachet added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:34 set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") -else() + set(FUCHSIA_DISABLE_DRIVER_BUILD On) +endif() phosek wrote: > Nit: can you use `ON` for consistency? Done in commit

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

danix800 updated this revision to Diff 555867. danix800 edited the summary of this revision. danix800 added a comment. 1. Revert to internal set (not using `IncludeCleaner`); 2. Only do deduplication when not `areDiagsSelfContained()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156743/new/ https://reviews.llvm.org/D156743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159450 File

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added a comment. Ping~, could anyone have a look at this revision please? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158813/new/ https://reviews.llvm.org/D158813 ___ cfe-commits maili

[clang] c5cf4f7 - [clang][doc] Don't escape _ in .rst files. (#65277)

Author: Mark de Wever Date: 2023-09-05T17:54:46+02:00 New Revision: c5cf4f7e4f76abbee0cceaacb708d56b0dcb750d URL: https://github.com/llvm/llvm-project/commit/c5cf4f7e4f76abbee0cceaacb708d56b0dcb750d DIFF: https://github.com/llvm/llvm-project/commit/c5cf4f7e4f76abbee0cceaacb708d56b0dcb750d.diff

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a4605af - [CodeGen][LTO] Rename some misleading variables (#65185)

Author: Paul T Robinson Date: 2023-09-05T08:57:16-07:00 New Revision: a4605af26f7ebffe148d7b6025436a9a1ae6f089 URL: https://github.com/llvm/llvm-project/commit/a4605af26f7ebffe148d7b6025436a9a1ae6f089 DIFF: https://github.com/llvm/llvm-project/commit/a4605af26f7ebffe148d7b6025436a9a1ae6f089.dif

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/65242: >From 26d5891879583b9addd2a6d4d7caf4241ba55b85 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 31 Aug 2023 20:24:51 -0400 Subject: [PATCH 1/2] [lit] Are all RUN lines skipped in windows cmd? Key i

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Days since learning something new and horrifying about TypeLoc: zero You might consider deleting the '= nullptr' from `AutoTypeLocInfo::CR` since it appears we never actually run the con

[clang] 18a628e - [AST] Use correct APSInt width when evaluating string literals

Author: Sergei Barannikov Date: 2023-09-05T19:14:09+03:00 New Revision: 18a628ec4ef72bcc005e2e9d5757445c31c6e2f8 URL: https://github.com/llvm/llvm-project/commit/18a628ec4ef72bcc005e2e9d5757445c31c6e2f8 DIFF: https://github.com/llvm/llvm-project/commit/18a628ec4ef72bcc005e2e9d5757445c31c6e2f8.d

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18a628ec4ef7: [AST] Use correct APSInt width when evaluating string literals (authored by barannikov88). Repository: rG LLVM Github Monorepo CHAN

[clang] 54091d3 - [AST] Fix nested name specifiers printing as NamespaceNamespace (#65266)

Author: Sam McCall Date: 2023-09-05T18:15:06+02:00 New Revision: 54091d37f28c24fa810adf2914af9299c305dd83 URL: https://github.com/llvm/llvm-project/commit/54091d37f28c24fa810adf2914af9299c305dd83 DIFF: https://github.com/llvm/llvm-project/commit/54091d37f28c24fa810adf2914af9299c305dd83.diff LO

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/sam-mccall closed https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

steakhal added a comment. I don't have time this week, sorry. Maybe others can take this over. @donat.nagy could you please have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158813/new/ https://reviews.llvm.org/D158813 ___

[clang] 6d2e756 - Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

Author: Jens Massberg Date: 2023-09-05T18:17:44+02:00 New Revision: 6d2e756dacfd9276775a06bdd1fea4eccace5e0f URL: https://github.com/llvm/llvm-project/commit/6d2e756dacfd9276775a06bdd1fea4eccace5e0f DIFF: https://github.com/llvm/llvm-project/commit/6d2e756dacfd9276775a06bdd1fea4eccace5e0f.diff

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2e756dacfd: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159450/n

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

jdenny-ornl wrote: Thanks for everyone's comments so far. This PR is not ready to land. As discussed, it doesn't fully fix support for windows `cmd` as a lit external shell. Given how long that use case has been broken (apparently since April, 2022), it seems that's a use case no one cares

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added a comment. Should I create a github PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ldionne added a comment. (sorry, no idea why it says "this revision is now accepted and ready to land on my behalf, I was just removing the libc++ review group to clear our review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ h

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

cor3ntin added a comment. No, existing PRs can stay there. I'm waiting for @aaron.ballman, our resident attributes guru, to look at that - even if the changes look reasonably good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ ht

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar updated this revision to Diff 555879. miyengar marked an inline comment as done. miyengar added a comment. Moved v1f64 -> Dr (Vector to Scalar) Pattern from `SIMDTwoVectorSD` to `FRIntNNTVector` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; dmgreen wrote: > I think the instructions in this multiclass are the vect

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

probinson added a comment. @MaskRay thanks for the info! In D159054#4638322 , @brad wrote: > I was going to hold this over for a bit longer. 2 weeks and if no one says > anything then go ahead? The main thing to worry about, clearly, is what happens as

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. In D159054#4638511 , @probinson wrote: > The main thing to worry about, clearly, is what happens as the change > percolates downstream and into distros. But you probably know more about that > than I do anyhow. :) Yes, that is why

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/michaelmaitland unlabeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/michaelmaitland unlabeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][llvm-mca] Add llvm-mca tests for SiFive7 Vector Integer Arith… (PR #65283)

https://github.com/michaelmaitland unlabeled https://github.com/llvm/llvm-project/pull/65283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/65381: None >From ee5c987880d4c9d9fec1780e28833b30b2753faa Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH] [Clang] Fix the do while statement disappearing in AST when an

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin labeled https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

@@ -2158,8 +2158,10 @@ StmtResult Parser::ParseForStatement(SourceLocation *TrailingElseLoc) { // for-range-declaration next. bool MightBeForRangeStmt = !ForRangeInfo.ParsedForRangeDecl(); ColonProtectionRAIIObject ColonProtection(*this, MightBeForRange

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157518: Avoid running optimization passes in frontend test

aeubanks added inline comments. Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148 -// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32 [[LIKELY]]} -// CHECK: ![[PROF_UNLIKELY]] = !{!"branch_weights", i32 [[LIKELY]], i32 [[UNLI

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

wenlei added a comment. In D158668#4611988 , @MatzeB wrote: > And as another strawman / discussion-starter I put up D158680 > where I use `!{"branch_weights", i32 1, > i32 0}` to represent likely branches and the actua

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 555889. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/ https://reviews.llvm.org/D157913 Files: clang/lib/Cod

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added inline comments. Comment at: compiler-rt/test/profile/Darwin/coverage-debug-info-correlate.cpp:29 + +// RUN: llvm-cov report --instr-profile=%t.profdata %t | FileCheck %s -check-prefix=NONAME + ellis wrote: > Is it worth testing that `%t.normal.pr

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

phosek added a comment. In D157913#4626007 , @zequanwu wrote: >> It seems that the `__llvm_prf_names` is retained in this mode. What is the >> overhead of this section generally? Can we instead use debug info to lookup >> function names? > > With debug

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4632457 , @NoumanAmir657 wrote: > @aaron.ballman > This error gets generated on test cases even when a struct/class as no > virtual base class. > see this example on here: example

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

v.g.vassilev added a subscriber: Hahnfeld. v.g.vassilev added a comment. The issue goes away for non-CXXMethodDecls but still persists in the case where we process: CXXDestructorDecl 0x9ab0f48 col:11 implicit used ~shared_ptr 'void () noexcept' inline default `-CompoundStmt 0x9ac3ca0 He

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

carlosgalvezp added a comment. Thanks for the patch! I must admit I don't fully understand what problem it solves, i.e. parameters are already optional today (one just simply doesn't specify them in the config file). Why would we want to explicitly spell out parameters with some default value t

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/optional-parameter.cpp:18 +// RUN: -config='{CheckOptions: { \ +// RUN: bugprone-easily-swappable-parameters.MinimumLength: "false", \ +// RUN: }}' -- What i

[clang] f465a48 - [clang-format] Fix segmentation fault when formatting nested namespaces

Author: Arkadiy Yudintsev Date: 2023-09-05T11:12:14-07:00 New Revision: f465a482caa94d01a2dd74e4c673adeb1f222f2f URL: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f DIFF: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f.d

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGf465a482caa9: [clang-format] Fix segmentation fault when formatting nested namespaces (authored by d0nc1h0t, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D157518: Avoid running optimization passes in frontend test

MatzeB marked 2 inline comments as done. MatzeB added inline comments. Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148 -// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32 [[LIKELY]]} -// CHECK: ![[PROF_UNLIKELY]] = !{!"branc

[clang] c1eacc3 - [Matrix] Fix test on SystemZ

Author: Francis Visoiu Mistrih Date: 2023-09-05T14:22:55-04:00 New Revision: c1eacc3c409458cbd2de85c21af2df8562d73bef URL: https://github.com/llvm/llvm-project/commit/c1eacc3c409458cbd2de85c21af2df8562d73bef DIFF: https://github.com/llvm/llvm-project/commit/c1eacc3c409458cbd2de85c21af2df8562d73

[PATCH] D158883: [Matrix] Try to emit fmuladd for both vector and matrix types

thegameg added a comment. In D158883#4635997 , @uweigand wrote: > The newly added test cases in ffp-model.c fail on SystemZ, making CI red: Should be fixed, thanks for the report and sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:196-198 +if (Value == "" || Value == "none" || Value == "null" || + Value == "false" || (std::is_unsigned_v && Value == "-1")) + return std::nullopt; --

[PATCH] D159453: [Matrix] Fix test on SystemZ

kuhar created this revision. Herald added subscribers: hanchung, tschuett. Herald added a project: All. kuhar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As reported by @uweigand in https://reviews.llvm.org/D158883: The newly added t

[PATCH] D159453: [Matrix] Fix test on SystemZ

kuhar abandoned this revision. kuhar added a comment. Gah, disregard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159453/new/ https://reviews.llvm.org/D159453 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D157518: Avoid running optimization passes in frontend test

wenlei accepted this revision. wenlei added a comment. lgtm, thanks. Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148 -// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32 [[LIKELY]]} -// CHECK: ![[PROF_UNLIKELY]] = !{!"branc

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

ldionne abandoned this revision. ldionne added a comment. In D155713#4592852 , @hans wrote: >> I think this does actually matter for libc++, I think I have seen this >> pattern: >> >> template >> struct Foo { >> _LIBCPP_FUNC_VIS _LIBCPP_EXCLUDE_

[clang] 4146b30 - Revert "[Format] Modernize SpaceBeforeParensCustom (NFC)"

Author: Owen Pan Date: 2023-09-05T12:03:14-07:00 New Revision: 4146b30785fb5db6fa4da47e6198f7bd961559c5 URL: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5 DIFF: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5.diff LOG:

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp created https://github.com/llvm/llvm-project/pull/65401: I had to regenerate the include mapping while resolving a downstream merge conflict, and ran into two issue on my machine. These shouldn't change anything, just make things work on my config. - Move the `mu

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp review_requested https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp review_requested https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 33b02d7 - [NFC][Clang] Fix static code analyzer concern about null value dereference

Author: Manna, Soumi Date: 2023-09-05T12:48:43-07:00 New Revision: 33b02d766eb83656c2bb214ac3512311e99874a2 URL: https://github.com/llvm/llvm-project/commit/33b02d766eb83656c2bb214ac3512311e99874a2 DIFF: https://github.com/llvm/llvm-project/commit/33b02d766eb83656c2bb214ac3512311e99874a2.diff

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rG33b02d766eb8: [NFC][Clang] Fix static code analyzer concern about null value dereference (authored by Manna).

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna added a comment. In D158293#4629232 , @tahonermann wrote: > Thanks, Soumi, looks good to me! Thank you @tahonermann for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://re

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

https://github.com/ysyeda created https://github.com/llvm/llvm-project/pull/65407: This PR adds support for the PPA2 fields. >From 592e432e287b756102a12ed66a8f656021ed541e Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Tue, 5 Sep 2023 15:43:24 -0400 Subject: [PATCH] [SystemZ][z/OS] This chan

<    1   2   3   4   >