[clang] 5f667a5 - [clang][dataflow] Fix -Wunused-const-variable in WatchedLiteralsSolver.cpp (NFC)

Author: Jie Fu Date: 2023-09-05T15:03:07+08:00 New Revision: 5f667a57b5329f449d27f514d041d457b1ea9da6 URL: https://github.com/llvm/llvm-project/commit/5f667a57b5329f449d27f514d041d457b1ea9da6 DIFF: https://github.com/llvm/llvm-project/commit/5f667a57b5329f449d27f514d041d457b1ea9da6.diff LOG: [

[PATCH] D159414: Haiku: Fixes for header / library paths

trungnt2910 added a comment. I'm not the Haiku toolchain expert here 😅, all I can do is comparing this with what the GCC toolchain for Haiku does. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/li

[clang] 23915fe - [Serialization] Modernize ModuleInfo (NFC)

Author: Kazu Hirata Date: 2023-09-05T00:22:51-07:00 New Revision: 23915fe3015d3601c1b50d0ecfb8bf43c2fb03f4 URL: https://github.com/llvm/llvm-project/commit/23915fe3015d3601c1b50d0ecfb8bf43c2fb03f4 DIFF: https://github.com/llvm/llvm-project/commit/23915fe3015d3601c1b50d0ecfb8bf43c2fb03f4.diff L

[clang] a6fa39d - [StaticAnalyzer] Modernize NSErrorMethodChecker (NFC)

Author: Kazu Hirata Date: 2023-09-05T00:22:53-07:00 New Revision: a6fa39da39c40c50a750de51cc6224195fd9f166 URL: https://github.com/llvm/llvm-project/commit/a6fa39da39c40c50a750de51cc6224195fd9f166 DIFF: https://github.com/llvm/llvm-project/commit/a6fa39da39c40c50a750de51cc6224195fd9f166.diff L

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/kadircet approved this pull request. https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:688-690 + for ([[maybe_unused]] auto [Field, Loc] : FieldLocs) { +assert(ModeledFields.contains(cast_or_null(Field))); + } https://llvm.org/docs/CodingStand

[PATCH] D159441: [include-cleaner] Weaken signal for boosting preferred headers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Putting preferred header signal above completeness implied we would upra

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); + addSystem

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

nridge requested changes to this revision. nridge added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1297 +FunctionCanBeCall = +MaybeDerived == MaybeBase || MaybeDerived->isDerivedFrom(MaybeBase); + }

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#463 , @owenpan wrote: > We need the name and email you want to use in order to commit the patch for > you. Arkadiy Yudintsev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D158926: [clangd] Show parameter hints for operator()

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:626 + Method && Method->isInstance()) +Args = Args.drop_front(1); +processCall(Callee, Args); ---

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie updated this revision to Diff 555821. Discookie added a comment. Refactored the checkers to use a shared base class, otherwise I kept the same functionality. I'll push this diff in a way where the blame transfers between the files, but I don't think keeping the file name the same make

[clang] 8ad37a8 - [clang][Interp][NFC] Return array element type in Pointer::getType()

Author: Timm Bäder Date: 2023-09-05T10:28:47+02:00 New Revision: 8ad37a894b0b54fe71afa5ea3c003eea6ba76676 URL: https://github.com/llvm/llvm-project/commit/8ad37a894b0b54fe71afa5ea3c003eea6ba76676 DIFF: https://github.com/llvm/llvm-project/commit/8ad37a894b0b54fe71afa5ea3c003eea6ba76676.diff LO

[clang] c6ce32d - [clang][Interp][NFC] Fix a comment

Author: Timm Bäder Date: 2023-09-05T10:28:47+02:00 New Revision: c6ce32d9c348f69b19d8b3bfb4e0e3c3ea3bf679 URL: https://github.com/llvm/llvm-project/commit/c6ce32d9c348f69b19d8b3bfb4e0e3c3ea3bf679 DIFF: https://github.com/llvm/llvm-project/commit/c6ce32d9c348f69b19d8b3bfb4e0e3c3ea3bf679.diff LO

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie marked 8 inline comments as done. Discookie added a comment. Fixed the formatting issues as well. Comment at: clang/docs/analyzer/checkers.rst:1787-1804 +.. _alpha-cplusplus-ArrayDelete: + +alpha.cplusplus.ArrayDelete (C++) +"""

[PATCH] D159414: Haiku: Fixes for header / library paths

trungnt2910 added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); + ad

[clang] 12a7897 - [clang][Interp] BaseToDerived casts

Author: Timm Bäder Date: 2023-09-05T10:53:54+02:00 New Revision: 12a789710e2bafe9bb49adea5e634784b086eb6a URL: https://github.com/llvm/llvm-project/commit/12a789710e2bafe9bb49adea5e634784b086eb6a DIFF: https://github.com/llvm/llvm-project/commit/12a789710e2bafe9bb49adea5e634784b086eb6a.diff LO

[PATCH] D149133: [clang][Interp] BaseToDerived casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12a789710e2b: [clang][Interp] BaseToDerived casts (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D149133?vs=516701&id=55

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

kasuga-fj wrote: The CI failed because `libcxx` uses `offsetof`. https://github.com/kasuga-fj/llvm-project/blob/b9c767a6a128f57858273eb43d4383e83d0d086b/libcxx/include/__type_traits/datasizeof.h#L50 I investigated but couldn't figure out where to fix it (Should I change the compile time options?

[clang] a13f036 - [clang][Interp] Check one-past-the-end pointers in GetPtrField

Author: Timm Bäder Date: 2023-09-05T11:00:40+02:00 New Revision: a13f036949b05e5f9d1ac1e33fed465c939aca62 URL: https://github.com/llvm/llvm-project/commit/a13f036949b05e5f9d1ac1e33fed465c939aca62 DIFF: https://github.com/llvm/llvm-project/commit/a13f036949b05e5f9d1ac1e33fed465c939aca62.diff LO

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa13f036949b0: [clang][Interp] Check one-past-the-end pointers in GetPtrField (authored by tbaeder). Changed prior to commit: https://reviews.llvm.

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

tru wrote: Ping @llvm/pr-subscribers-libcxx https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder closed this revision. tbaeder added a comment. This landed as 673ef8ceaece6c9a7194474ef7d97b3b240c0dc5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://

[clang] 6d79f98 - [clang][Interp] Implement zero-init of record types

Author: Timm Bäder Date: 2023-09-05T11:20:35+02:00 New Revision: 6d79f985b53ef57f670ab7e4c7f59c953b49b4d6 URL: https://github.com/llvm/llvm-project/commit/6d79f985b53ef57f670ab7e4c7f59c953b49b4d6 DIFF: https://github.com/llvm/llvm-project/commit/6d79f985b53ef57f670ab7e4c7f59c953b49b4d6.diff LO

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d79f985b53e: [clang][Interp] Implement zero-init of record types (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D154189

[PATCH] D158156: [analyzer] Add C++ array delete checker

steakhal added a comment. Add a test where we have multiple imp derived to base casts but only one leads to a bug. Do it for both ways, once that the first is the offending, and once the second. Comment at: clang/docs/analyzer/checkers.rst:1793-1803 +.. code-block:: cpp + + B

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. This change is causing test regressions on 32-bit architectures (I've reproduced with `-m32` on amd64 and in 32-bit nspawn container on arm64): FAIL: Clang-Unit :: Interpreter/./ClangReplInterpreterTests/1/13 (1 of 1584) TEST 'Clang-Unit :: Inter

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555838. kinu marked an inline comment as done and an inline comment as not done. kinu added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: c

[clang] adb1fb4 - [clang][Interp] Handle mixed floating/integral compound assign operators

Author: Timm Bäder Date: 2023-09-05T12:10:00+02:00 New Revision: adb1fb40e84d40f9ec3ebfdb0546eadd9a1dc1c9 URL: https://github.com/llvm/llvm-project/commit/adb1fb40e84d40f9ec3ebfdb0546eadd9a1dc1c9 DIFF: https://github.com/llvm/llvm-project/commit/adb1fb40e84d40f9ec3ebfdb0546eadd9a1dc1c9.diff LO

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb1fb40e84d: [clang][Interp] Handle mixed floating/integral compound assign operators (authored by tbaeder). Changed prior to commit: https://rev

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555840. kinu marked 2 inline comments as done. kinu added a comment. More fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: clang/lib/Analysis/FlowSensitive

[clang] 5704dde - [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

Author: Timm Bäder Date: 2023-09-05T12:21:26+02:00 New Revision: 5704dde307359e9155e2fcd99c413c0cf932aa13 URL: https://github.com/llvm/llvm-project/commit/5704dde307359e9155e2fcd99c413c0cf932aa13 DIFF: https://github.com/llvm/llvm-project/commit/5704dde307359e9155e2fcd99c413c0cf932aa13.diff LO

[PATCH] D157619: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5704dde30735: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20 (authored by tbaeder). Repository: rG LLVM Github Monorepo

[clang] fde2b0d - [clang][Interp][NFC] Add [[nodiscard]] to a few Pointer methods

Author: Timm Bäder Date: 2023-09-05T12:35:06+02:00 New Revision: fde2b0d6dba709ee6d699a4d67657604b8c0a026 URL: https://github.com/llvm/llvm-project/commit/fde2b0d6dba709ee6d699a4d67657604b8c0a026 DIFF: https://github.com/llvm/llvm-project/commit/fde2b0d6dba709ee6d699a4d67657604b8c0a026.diff LO

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555842. kinu marked 5 inline comments as done. kinu added a comment. Updated again... very easy to overlook unaddressed comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu added a comment. Thanks, addressed the comments, PTAL~ Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:688-690 + for ([[maybe_unused]] auto [Field, Loc] : FieldLocs) { +assert(ModeledFields.contains(cast_or_null(Field))); + } mb

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev updated this revision to Diff 555844. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D155818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158730/new/ https://reviews.llvm.org/D158730 Files: clang/test/CodeGen

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 555845. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D158730. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder closed this revision. tbaeder added a comment. This has been pushed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder abandoned this revision. tbaeder added a comment. This was pushed as part of the initializer rework. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@l

[clang] clang-linker-wrapper/LinkerWrapperOpts.td: "--sysroot" => "--sysroot=" (PR #65313)

https://github.com/conversy review_requested https://github.com/llvm/llvm-project/pull/65313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-linker-wrapper/LinkerWrapperOpts.td: "--sysroot" => "--sysroot=" (PR #65313)

https://github.com/conversy created https://github.com/llvm/llvm-project/pull/65313: "--sysroot" should be "--sysroot=" since it's related to OPT_sysroot_EQ and not a OPT_sysroot >From 972be4aba034d35a10ee0f5e8c82e2be3cdf0d3a Mon Sep 17 00:00:00 2001 From: conversy Date: Tue, 5 Sep 2023 13:

[clang] 2fbd132 - [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

Author: Kristina Bessonova Date: 2023-09-05T12:48:38+02:00 New Revision: 2fbd1323e7bf6ec204867774db8aa9b7dc976da5 URL: https://github.com/llvm/llvm-project/commit/2fbd1323e7bf6ec204867774db8aa9b7dc976da5 DIFF: https://github.com/llvm/llvm-project/commit/2fbd1323e7bf6ec204867774db8aa9b7dc976da5.

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbd1323e7bf: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast… (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. So you can enable some of the sema source location tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D158156: [analyzer] Add C++ array delete checker

donat.nagy added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1793-1803 +.. code-block:: cpp + + Base *create() { + Base *x = new Derived[10]; // note: conversion from derived to base + // happened here + return x; + } -

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/cor3ntin approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. I do in https://reviews.llvm.org/D156045, but that depends on other commits (not sure which exactly right now though). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cf

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); } trungnt29

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

kadircet added a comment. Thanks a lot for the patch @danix800 ! I initially was rather focused on behavior of this check in workflows that require seeing "self-contained-diags", but also I rather see the bulk-apply use cases as always requiring clang-format afterwards. Hence didn't really try

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I like this as a simplification, too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D15

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

asb added a comment. In D152279#4612099 , @craig.topper wrote: > In D152279#4612087 , @MaskRay wrote: > >> I am still interested in moving this forward. What should be done here? If >> the decision is to keep th

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/AaronBallman approved this pull request. LGTM; I think this can be held out of 17.0.0 but would be fine to backport to a later 17.x release if desired. https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/65319: Now that prvalue expressions map directly to values (see https://reviews.llvm.org/D158977), it's no longer guaranteed that `RecordValue`s associated with the same expression will always have the same storage

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

budimirarandjelovicsyrmia added a comment. @chestnykh Are you still working on this issue? If not, I'm interested to continue working on issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cf

[PATCH] D159435: [NFC] remove unneded header includes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159435/new/ https://reviews.llvm.org/D159435 _

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Remove stale comment. (PR #65322)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/65322: None >From a92d3cf331714c4d1e83073f8674feb2ef419d66 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 5 Sep 2023 12:53:04 + Subject: [PATCH] [clang][dataflow][NFC] Remove stale comment. --- cl

[clang] [clang][dataflow][NFC] Remove stale comment. (PR #65322)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Remove stale comment. (PR #65322)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/65323: This upstreams a few Clang API Notes attributes that were recently added downstream in the Apple fork (https://github.com/apple/llvm-project/pull/7386). >From c0f45f6dcb2fc142df4f2f0ea30c03881b2126d7 Mon Sep

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/egorzhdan labeled https://github.com/llvm/llvm-project/pull/65323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

danix800 added a comment. In D159263#4638167 , @kadircet wrote: > Thanks a lot for the patch @danix800 ! > > I initially was rather focused on behavior of this check in workflows that > require seeing "self-contained-diags", but also I rather see the bul

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

dewen added inline comments. Comment at: clang/test/CXX/class.derived/class.member.lookup/p11.cpp:15 +struct D: I1, I2, B2 { + using B1::f; + using B2::f; ``` bool correctness{true}; struct A { bool operator==(A const&oth) const { return true; }

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Looks fine to me, please don't commit for a day or two to give @aaron.ballman a chance to make a final comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

kadircet added a comment. In D159263#4638199 , @danix800 wrote: > If we have further plans from upstream on these checker/clang-format related > logic, I can wait and abandon this revision. Not at the moment, so please don't! > Or if such issue does ne

[clang] [NVPTX] Add a warning that device debug info does not work with optimizations (PR #65327)

https://github.com/GeorgeWeb created https://github.com/llvm/llvm-project/pull/65327: Passing `-g` to `ptxas` with any optimizations enabled is not allowed because, `ptxas` does not support optimized debugging. >From 0efb5b6f3042224cf89978f607d5ff9cd1665351 Mon Sep 17 00:00:00 2001 From: Georg

[clang] [NVPTX] Add a warning that device debug info does not work with optimizations (PR #65327)

https://github.com/GeorgeWeb review_requested https://github.com/llvm/llvm-project/pull/65327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add a warning that device debug info does not work with optimizations (PR #65327)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/kinu edited https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/kinu commented: Thanks, this LGTM (confirmed that it makes it go through with one of the real code I hit this) https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/kinu edited https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add a warning that device debug info does not work with optimizations (PR #65327)

https://github.com/GeorgeWeb updated https://github.com/llvm/llvm-project/pull/65327: >From 757383fd9a9783c290fd4957e4e7526b854c9920 Mon Sep 17 00:00:00 2001 From: Georgi Mirazchiyski Date: Tue, 5 Sep 2023 14:21:24 +0100 Subject: [PATCH] [Driver][NVPTX] Add a warning that device debug info does

[clang] [Driver][NVPTX] Add a warning that device debug info does not work with optimizations (PR #65327)

https://github.com/GeorgeWeb edited https://github.com/llvm/llvm-project/pull/65327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [GlobalISel][AArch64] Combine unmerge(G_EXT v, undef) to unmerge(v). (PR #65263)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/65263: >From a88ee53623a3ff4774bc7a5df13379e55a0f9945 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Mon, 4 Sep 2023 12:35:48 +0200 Subject: [PATCH 1/2] [GlobalISel][AArch64] Combine unmerge(G_EXT v, unde

[clang] [GlobalISel][AArch64] Combine unmerge(G_EXT v, undef) to unmerge(v). (PR #65263)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [GlobalISel][AArch64] Combine unmerge(G_EXT v, undef) to unmerge(v). (PR #65263)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/65329: We want to work towards eliminating the `RecordStorageLocation` from `RecordValue`. These particular uses of `RecordValue::getChild()` can simply be replaced with `RecordStorageLocation::getChild()`. >From

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -50,9 +50,9 @@ struct Derived2 : public Base1, public Base2 { int z; }; -int derived1[__builtin_offsetof(Derived2, x) == 0? 1 : -1]; -int derived2[__builtin_offsetof(Derived2, y) == 4? 1 : -1]; -int derived3[__builtin_offsetof(Derived2, z) == 8? 1 : -1]; +int derived1[

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/AaronBallman approved this pull request. Hmmm, in some ways I think this is making the diagnostic needlessly chatty, and in other ways the new diagnostic behavior seems reasonable. On balance, I think the improvements outweigh the regressions, especially for code users are l

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -17,7 +17,7 @@ struct Base { int x; }; struct Derived : Base { int y; }; int o = __builtin_offsetof(Derived, x); // expected-warning{{offset of on non-POD type}} -const int o2 = sizeof(__builtin_offsetof(Derived, x)); +const int o2 = sizeof(__builtin_offsetof(Derived, x));

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -25,6 +25,7 @@ struct B : public A { static_assert(__builtin_offsetof(B, d) == 12, "We can't allocate the bitfield into the padding under ms_struct"); +// expected-warning@-2 {{offset of on non-standard-layout type 'B'}} AaronBallman wrote: I think this

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -17,7 +17,7 @@ struct Base { int x; }; struct Derived : Base { int y; }; int o = __builtin_offsetof(Derived, x); // expected-warning{{offset of on non-POD type}} -const int o2 = sizeof(__builtin_offsetof(Derived, x)); +const int o2 = sizeof(__builtin_offsetof(Derived, x));

  1   2   3   4   >