[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

2023-09-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[clang] f9f2fdc - [clang] [MinGW] Add the option -fno-auto-import

2023-09-01 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2023-09-01T22:39:38+03:00 New Revision: f9f2fdcf03d9a64741e24a5d480842551163ef4d URL: https://github.com/llvm/llvm-project/commit/f9f2fdcf03d9a64741e24a5d480842551163ef4d DIFF: https://github.com/llvm/llvm-project/commit/f9f2fdcf03d9a64741e24a5d480842551163ef4d.diff

[PATCH] D61670: [clang] [MinGW] Add the option -fno-auto-import

2023-09-01 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf9f2fdcf03d9: [clang] [MinGW] Add the option -fno-auto-import (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D61670?vs=553624&id=555462#toc Repository: rG LLVM Github Monor

[clang] d39a9e3 - [Driver] Support GNU ld on Solaris

2023-09-01 Thread Rainer Orth via cfe-commits
Author: Rainer Orth Date: 2023-09-01T21:42:05+02:00 New Revision: d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1 URL: https://github.com/llvm/llvm-project/commit/d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1 DIFF: https://github.com/llvm/llvm-project/commit/d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1.diff L

[PATCH] D85309: [Driver] Support GNU ld on Solaris

2023-09-01 Thread Rainer Orth via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd39a9e3b4d4a: [Driver] Support GNU ld on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D85309?vs=554946&id=555463#to

[clang] 1bc7b75 - [clang] Consistently use isOSSolaris()

2023-09-01 Thread Rainer Orth via cfe-commits
Author: Rainer Orth Date: 2023-09-01T21:45:22+02:00 New Revision: 1bc7b753a5cd1599ecf0575d629460ba08f7121e URL: https://github.com/llvm/llvm-project/commit/1bc7b753a5cd1599ecf0575d629460ba08f7121e DIFF: https://github.com/llvm/llvm-project/commit/1bc7b753a5cd1599ecf0575d629460ba08f7121e.diff L

[PATCH] D159222: [clang] Consistently use isOSSolaris()

2023-09-01 Thread Rainer Orth via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc7b753a5cd: [clang] Consistently use isOSSolaris() (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D159373: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

2023-09-01 Thread Kees Cook via Phabricator via cfe-commits
kees created this revision. kees added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. kees requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was deprecated in Clang 16 and scheduled for removal in Clang 18. Time

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

2023-09-01 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM as a workaround. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(g

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

2023-09-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[clang] 92246a9 - [CodeGen] First check the kind and then the llvm::Function properties.

2023-09-01 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2023-09-01T19:52:27Z New Revision: 92246a9be0ba47788ada9621bef58ce7819be526 URL: https://github.com/llvm/llvm-project/commit/92246a9be0ba47788ada9621bef58ce7819be526 DIFF: https://github.com/llvm/llvm-project/commit/92246a9be0ba47788ada9621bef58ce7819be526.diff LO

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH] [libc++] Implement ranges::contains Differential Revision: htt

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

2023-09-01 Thread Vassil Vassilev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG92246a9be0ba: [CodeGen] First check the kind and then the llvm::Function properties. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH] [libc++] Implement ranges::contains Differential Revision: htt

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 review_requested https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 opened https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH] [libc++] Implement ranges::contains Differential Revision: htt

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH] [libc++] Implement ranges::contains Differential Revision: htt

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 review_requested https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 review_requested https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi submitted https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan opened https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

2023-09-01 Thread Ronan Keryell via Phabricator via cfe-commits
keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:216 + +Given the following C++ code, which assumes the ``std`` namespace is included: + Since this does not sounds like an official wording and this is not a recommended practice https://isocp

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan labeled https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. In D159312#4634617 , @dalias wrote: > Please report what you're actually trying to do that's breaking rather than > sending patches to align definitions that are not intended to be aligned. Basically, we tried to use `stddef.h`

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added reviewers: iana, aaron.ballman, dalias. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes a comment added in D159

[PATCH] D159373: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

2023-09-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159373/new/ https://reviews.llvm.org/D159373 __

[clang] 6713652 - [NFC] Cleanup some #includes in header files

2023-09-01 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-01T15:23:46-07:00 New Revision: 671365225ccce00b063f7becfee4388aa7ab013a URL: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a DIFF: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a.diff

[PATCH] D159320: [NFC] Cleanup some #includes in header files

2023-09-01 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG671365225ccc: [NFC] Cleanup some #includes in header files (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159320/new/ https://reviews.llv

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd submitted https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -749,6 +750,17 @@ struct Context { Context(ContextID id, ContextKind kind) : id(id), kind(kind) {} }; + +/// A temporary reference to an Objective-C selector, suitable for +/// referencing selector data on the stack. +/// +/// Instances of this struct do not store referen

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -33,6 +33,7 @@ class APINotesWriter::Implementation { /// Mapping from strings to identifier IDs. llvm::StringMap IdentifierIDs; +public: compnerd wrote: Why make all this public? https://github.com/llvm/llvm-project/pull/65187 ___

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; compnerd wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd submitted https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/adriannistor opened https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added a comment. Are we keeping the comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. I uploaded D159383 , which removes the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

2023-09-01 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added reviewers: joerg, kallisti5, nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Derived from https://reviews.llvm.org/D49481, but added tests and simplified the diff a

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://reviews.llvm.org/D159383 ___

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added a comment. Thank you @aheejin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:141 + unsigned Line, Col; + std::string Filename; + There is an opportunity for optimization by avoiding the allocation of separate strings for each source location, especially si

[clang] e082973 - [Clang][libc] Add wrapper headers for `assert.h` for the GPU libc

2023-09-01 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-09-01T18:34:09-05:00 New Revision: e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 URL: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 DIFF: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0.diff

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: @Xazax-hun @gribozavr https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Really cool check! I can't wait to see how it turns out :) https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. Suggested edit to the commit description: "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at the same time" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://reviews.llvm.org/D159

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %check_clang_tidy %s google-cpp-init-class-members %t + +class PositiveDefaultedDefaultConstructor { +public: + PositiveDefaultedDefaultConstructor() = default; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor should initialize these fields: X

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. In D159383#4635703 , @dschuff wrote: > Suggested edit to the commit description: > "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at > the same time" Done (Both the CL description and the commit messa

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: @ymand https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: Thank you for the feedback @Xazax-hun ! Working on it! https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159108: [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

2023-09-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159108/new/ https://reviews.llvm.org/D159108 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D159109: [analyzer] CStringChecker buffer access checks should check the first bytes

2023-09-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159109/new/ https://reviews.llvm.org/D159109 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

2023-09-01 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB added a comment. I have a feeling @mtrofin would prefer pass-specific weights rather than a unified notion of "likely"/"unlikely"... So with the latest round of patches it's probably best to abandon this for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or EugeneZelenko wrote: Please synchronize first state

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,51 @@ +//===--- CppInitClassMembersCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
EugeneZelenko wrote: @PiotrZSL, @carlosgalvezp: Somehow label was not assigned automatically, so I mention you manually. https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

2023-09-01 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D159250#4634774 , @jyknight wrote: > In D159250#4633530 , @pengfei wrote: > >> In D159250#4631786 , @RKSimon >> wrote: >> >>> Would it be poss

[PATCH] D126586: [InstrProf] Single byte counters in coverage

2023-09-01 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem updated this revision to Diff 42. gulfem added a comment. 1. Use || to merge counters that refer to the same regions 2. Use || to merge counters from raw profiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126586/new/ https://reviews.

[PATCH] D126586: [InstrProf] Single byte counters in coverage

2023-09-01 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:1080-1081 +void CodeGenPGO::setProfileVersion(llvm::Module &M) { + if (CGM.getCodeGenOpts().hasProfileClangInstr() && + llvm::EnableSingleByteCoverage) { +

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e opened https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e converted_to_draft https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 created this revision. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls, krytarowski, arichardson, dylanmckay. Herald added a reviewer: aaron.ballman. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 updated this revision to Diff 51. barannikov88 added a comment. Update one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c cla

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:35 +CXX11(clang::warn_unused_result) + // CHECK: __gnu__::__const__: 1 For the context, the attribute is defined with the following spellings: ``` let Spellings = [CXX11<

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e updated https://github.com/llvm/llvm-project/pull/65193: >From a65cb213b6ea24a04e170a7cc210ed9d2d00a9ac Mon Sep 17 00:00:00 2001 From: Sheng Date: Wed, 30 Aug 2023 11:44:23 +0800 Subject: [PATCH] [clang][Sema] Fix a bug when instantiating a lambda with requires clau

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e ready_for_review https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

<    1   2   3   >