ributzka added inline comments.

================
Comment at: clang/include/clang/ExtractAPI/API.h:141
+  unsigned Line, Col;
+  std::string Filename;
+
----------------
There is an opportunity for optimization by avoiding the allocation of separate 
strings for each source location, especially since many source locations will 
be in the same file. As an example, APISet utilizes a BumpPtrAllocator to 
allocate and deduplicate strings. It is recommended to consider using the same 
allocator or a similar concept.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157810/new/

https://reviews.llvm.org/D157810

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to