[PATCH] D141414: [clang] add warning on shifting boolean type

angelomatnigoogle added a comment. Pardon me for losing sight on this change. Within the week, I will revisit this change based on the current outstanding comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141414/new/ https://reviews.llvm.org

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4608428 , @thakis wrote: > I think this is a useful feature, for the reasons mentioned on the thread. > > Since this is a superset of D115049 (... > right?), this should probably reve

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

shafik added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } We should use [bugprone-argument-comme

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, serge-sans-paille, nickdesaulniers, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch warns on `snprintf` calls whose `n` argument is known to be s

[clang] 3e50bcb - Test commit config

Author: erichkeane Date: 2023-08-22T16:39:30-07:00 New Revision: 3e50bcb44b7e850032d928ce53a582891336bc87 URL: https://github.com/llvm/llvm-project/commit/3e50bcb44b7e850032d928ce53a582891336bc87 DIFF: https://github.com/llvm/llvm-project/commit/3e50bcb44b7e850032d928ce53a582891336bc87.diff LO

[clang] dddfd93 - Revert "Test commit config"

Author: erichkeane Date: 2023-08-22T16:43:34-07:00 New Revision: dddfd93792b31e4bbeaeca3fe68fcefb289cfb51 URL: https://github.com/llvm/llvm-project/commit/dddfd93792b31e4bbeaeca3fe68fcefb289cfb51 DIFF: https://github.com/llvm/llvm-project/commit/dddfd93792b31e4bbeaeca3fe68fcefb289cfb51.diff LO

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. In D158559#4608397 , @ivanrodriguez3753 wrote: > In D158559#4608388 , @ABataev wrote: > >> 1. Always provide full context in the patch. > > Sure, would you mind mentioning what's missing?

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. In D158559#4608410 , @ivanrodriguez3753 wrote: > Also, should the underlying issue and test case be filed as an issue on > Github? I wasn't sure since this revision includes the bug and a description If you're going to fix this

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 552543. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index: clang-to

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

thetruestblue created this revision. thetruestblue added reviewers: kubamracek, yln, rsundahl, wrotki, usama54321, MaskRay, vitalybuka. Herald added a subscriber: Enna1. Herald added a project: All. thetruestblue requested review of this revision. Herald added projects: clang, Sanitizers. Herald a

[PATCH] D158571: [clang-format][NFC] Replace !is() with isNot()

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552550. AlexVlx marked an inline comment as done. AlexVlx retitled this revision from "[Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload" to "[HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload". AlexVlx removed

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552552. void marked 3 inline comments as done. void added a comment. Address Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clan

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void added inline comments. Comment at: clang/lib/AST/Decl.cpp:4541-4544 +bool FieldDecl::isFlexibleArrayMemberLike( +ASTContext &Ctx, +LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel, +bool IgnoreTemplateOrMacroSubstitution) const { nick

[clang] 0d9919d - Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

Author: Reid Kleckner Date: 2023-08-22T18:10:41-07:00 New Revision: 0d9919d362a7a70b2a7970861d897ecc47ec9e4d URL: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d DIFF: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d.diff

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552554. void added a comment. Fix clang-ast-dump issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h clang/include/clang/Bas

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rnk added a comment. I went ahead and pushed a revert of this, since this change was pretty disruptive, at least in our experience. I could be convinced that it's worth sunsetting this extension for accepting C-style format string macro code, but that doesn't seem like the original intent of th

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552556. AlexVlx retitled this revision from "[Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload". AlexVlx added a comment. Updating this to reflect t

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces absolute offs

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158523/new/ https://reviews.llvm.org/D158523

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ updated this revision to Diff 552560. NoQ added a comment. Rebase. Make warnings a bit more verbose than before. This plays nicely with our attempts to categorize unemitted fixits via `-mllvm -debug-only=SafeBuffers`, but this time it doesn't make sense to make the extra information debug-o

[clang-tools-extra] ba52a10 - [clang-tidy] Fix test to not depend on D153156, which was reverted

Author: Reid Kleckner Date: 2023-08-22T18:39:19-07:00 New Revision: ba52a10fca6fc7b791894c584233db012def68a5 URL: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5 DIFF: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5.diff

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552561. AlexVlx retitled this revision from "[Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload". AlexVlx added a comment. U

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When loading (transitive

[PATCH] D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals

rnk added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-size-empty.cpp:26 +namespace string_literals{ +string operator""s(const char *, size_t); +} I discovered that this test started to fail when I landed my rever

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 updated this revision to Diff 552566. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158469/new/ https://reviews.llvm.org/D158469 Files: clang/include/clang/Tooling/DependencyScanning/DependencyS

[PATCH] D155833: [HIP][Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552568. AlexVlx retitled this revision from "[Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload". AlexVlx added a comment. Updating this to reflect the outco

[clang] 6b6ea93 - [PowerPC][altivec] Correct modulo number of vec_promote on vector char

Author: Kai Luo Date: 2023-08-23T01:58:36Z New Revision: 6b6ea93125bd834cae22149e18b742d498dc79a3 URL: https://github.com/llvm/llvm-project/commit/6b6ea93125bd834cae22149e18b742d498dc79a3 DIFF: https://github.com/llvm/llvm-project/commit/6b6ea93125bd834cae22149e18b742d498dc79a3.diff LOG: [Powe

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vec_promote on vector char

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6ea93125bd: [PowerPC][altivec] Correct modulo number of vec_promote on vector char (authored by lkail). Repository: rG LLVM Github Monorepo CHA

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552575. AlexVlx edited the summary of this revision. AlexVlx added a comment. Updating to reflect the outcome of the RFC, which is that this will be added as a HIP extension exclusively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ htt

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

owenpan added a comment. In D156259#4607177 , @jp4a50 wrote: > Addressed all comments. Please let me know if there's anything else required > before merging. There are still a couple of comments unaddressed plus another that asked for changing `!is()`

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. So while working on D148474 I realized this PR introduced a new crash bug, see the following code: https://godbolt.org/z/h1EezGjbr template class B3 : A3 { template()> B3(); }; B3(); which is one of my test c

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier updated this revision to Diff 552579. fcloutier marked an inline comment as done. fcloutier added a comment. Add release note, ensure `bool` as a formatted formal parameter is accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158318/new/ https://reviews.llvm.org/D158318

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier added inline comments. Comment at: clang/lib/AST/FormatString.cpp:480-481 + break; +case BuiltinType::Half: +case BuiltinType::Float16: +case BuiltinType::Float: aaron.ballman wrote: > Should these be che

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. We have `getDynamicExtentWithOffset` to use, which can handle more general dynamic memory based cases than this fix. I'll abandon this one. There are issues worth clarifying and fixing: 1). Debugging APIs like `clang_analyzer_dumpExtent` in `ExprInspection` might be e

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) +return true; + return this->delegate(E->g

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 552591. iana added a comment. Only define nullptr_t in C++ if _MSC_EXTENSIONS is defined, even if __need_nullptr_t is explicitly set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; aaron.ballman wrote: > ldionne wrote: > > iana wrote: > > > aaron.ballman wrote: > >

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. One of the observable issue with inconsistent size type is void clang_analyzer_eval(int); typedef unsigned long long size_t; void *malloc(unsigned long size); void free(void *); void symbolic_longlong_and_int0(long long len) { char *a = malloc(5);

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 552596. myhsu marked 2 inline comments as done. myhsu added a comment. Addressed comments in `test/CodeGen/mrtd.c` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:10 +// X86: call x86_stdcallcc i32 @bar( +#ifndef mc68000 bar(arg); jrtc27 wrote: > Uh, this shouldn't be defined in ISO C; GCC's using builtin_define_std, so > you should only get `__mc68000`

[PATCH] D158499: [analyzer] Compute FAM dynamic size

steakhal added a comment. In D158499#4608847 , @danix800 wrote: > We have `getDynamicExtentWithOffset` to use, which can handle more general > dynamic memory based cases than this fix. > > I'll abandon this one. > > There are issues worth clarifying and f

[PATCH] D158582: WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j created this revision. Herald added subscribers: cfe-commits, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added projects: clang, All. lamb-j requested review of this revision. Herald added subscribers: MaskRay, wdng. Previously, for linking in amdgpu contexts, we always supp

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 552604. d0nc1h0t added a comment. Updated the patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatt

[clang] 39a41c8 - [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

Author: eopXD Date: 2023-08-22T23:41:23-07:00 New Revision: 39a41c8905618fc942100630b4ea37f0cb95e786 URL: https://github.com/llvm/llvm-project/commit/39a41c8905618fc942100630b4ea37f0cb95e786 DIFF: https://github.com/llvm/llvm-project/commit/39a41c8905618fc942100630b4ea37f0cb95e786.diff LOG: [C

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39a41c890561: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type (authored by eopXD). Repository: rG LLVM Github Monorepo CHA

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. > I suspected that the wrong cast modeling and how we infer what value ranges > are calculated is susceptible to such APSInt signedness issues, but I haven't > seen a case in the wild for extents. Thus, I didn't think of fixing it > either. But yes, we should. I think

[PATCH] D158513: [clang][dataflow] Add two repros for non-convergence involving pointers in loops.

mboehme added a comment. pre-merge failure appears to be unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158513/new/ https://reviews.llvm.org/D158513 ___ cfe-commits mailing list c

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 552608. tbaeder marked 2 inline comments as done. Herald added subscribers: steakhal, martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis

<    1   2   3