fcloutier added inline comments.
================ Comment at: clang/lib/AST/FormatString.cpp:480-481 + break; + case BuiltinType::Half: + case BuiltinType::Float16: + case BuiltinType::Float: ---------------- aaron.ballman wrote: > Should these be checking for `T == C.FloatTy` to return > `NoMatchPromotionTypeConfusion`? I don't think it's necessary. `T` is the format specifier's expected type, and no format specifier expects a `float` (due to floating-point types being promoted to `double` by default argument promotion), so there's never a case where `T` is `FloatTy`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158318/new/ https://reviews.llvm.org/D158318 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
