[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: > we'

[clang] ff08c8e - [SEH] Fix wrong argument passes to the call of OutlinedFinally.

Author: Jennifer Yu Date: 2023-08-21T17:07:38-07:00 New Revision: ff08c8e57e39d7970b65637595cdc221901f4ed1 URL: https://github.com/llvm/llvm-project/commit/ff08c8e57e39d7970b65637595cdc221901f4ed1 DIFF: https://github.com/llvm/llvm-project/commit/ff08c8e57e39d7970b65637595cdc221901f4ed1.diff L

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff08c8e57e39: [SEH] Fix wrong argument passes to the call of OutlinedFinally. (authored by jyu2). Changed prior to commit: https://reviews.llvm.or

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. In D153114#4604438 , @nridge wrote: > In D153114#4603579 , @sammccall > wrote: > >> - to identify what module names we must have PCMs for in order to build a >> given TU (either an ope

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

MaskRay added a comment. In D158461#4605084 , @brad wrote: > Isn't there more than this to do a full proper removal? > > Looking around it looks like the Ananas and Contiki support can be removed. > Ananas used > to use Clang but switched back to GCC and

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

MaskRay updated this revision to Diff 552171. MaskRay retitled this revision from "[Driver] Remove unlikely-working Minix.cpp" to "[Driver] Remove unlikely-working Minix.cpp and Contiki.cpp". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a project: LLVM. Herald

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although generating command lines

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 552177. ZijunZhao marked 9 inline comments as done. ZijunZhao added a comment. 1. Reformat test files in C/C2x 2. Update the definition and the test about `__STDC_VERSION_STDCKDINT_H__` 3. Update release docs and the introduction in the test file 4. Update R

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, cjdb, tbaeder, shafik. Herald added a subscriber: arphaman. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. D153359 addressed the d

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet added a comment. This breaks the one-note-for-one-overload-candidate rule of overload resolution failure diagnostics (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc221901f4ed1/clang/lib/Sema/SemaOverload.cpp#L11517-L11526), but in most cases this change would

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/C/C2x/n2683.c:16 + +bool flag_add = ckd_add(&result, a33, char_var); +bool flag_sub = ckd_sub(&result, bool_var, day); aaron.ballman wrote: > It looks like the builtins are missing some checks that a

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/lib/Headers/stdckdint.h:1 +/*=== stdckdint.h - Standard header for checking integer + *-=== aaron.ballman wrote: > hiraditya wrote: > > nit: format. > The formatting for this is still

[PATCH] D157385: [clang][CFG] Cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1473-1474 +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: [B1.3].~F() (Implicit destructor) +// CHECK-NEXT:5: CleanupFunction (cleanup_F) +// CHECK-N

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 552181. theo-lw added a comment. Ran clang-format on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/AttributeCommonInfo.h clang/lib

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 552179. jcsxky added a comment. add argument comment according to bugprone-argument-comment . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getFragmentsForType resulted in a bool typeIdentifier fra

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:140 +D0->getASTContext(), D1->getASTContext(), NonEquivalentDecls01, +StructuralEquivalenceKind::Default, false, false, false, +IgnoreTemplateParmDepth); --

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552184. void edited the summary of this revision. void added a comment. Make __builtin_dynamic_object_size use the __counted_by attribute to help determine the object size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, phosek, MaskRay. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be getRuntimePath till https://reviews.llvm.org/

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, MaskRay, phosek, danalbert, srhines. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[clang] c467245 - [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

Author: Chuanqi Xu Date: 2023-08-22T09:56:44+08:00 New Revision: c4672454743e942f148a1aff1e809dae73e464f6 URL: https://github.com/llvm/llvm-project/commit/c4672454743e942f148a1aff1e809dae73e464f6 DIFF: https://github.com/llvm/llvm-project/commit/c4672454743e942f148a1aff1e809dae73e464f6.diff LO

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4672454743e: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D157833?vs=550955&id=552187#toc

[clang] 6ee3b24 - Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

Author: YunQiang Su Date: 2023-08-21T22:13:50-04:00 New Revision: 6ee3b2a6410b8188d57d3bc5903674ae3187 URL: https://github.com/llvm/llvm-project/commit/6ee3b2a6410b8188d57d3bc5903674ae3187 DIFF: https://github.com/llvm/llvm-project/commit/6ee3b2a6410b8188d57d3bc5903674ae3187.diff L

[PATCH] D158183: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee3b2a6: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown (authored by wzssyqa, committed by brad). Herald added a project: c

[PATCH] D158476: [driver] Search for compatible Android runtime directories

MaskRay added a comment. > // Android target triples contain a target version. If we don't have > libraries for the exact target version, we should fall back to the next > newest version or a versionless path, if any. An Android maintainer can override my opinion but my feeling is that this ad

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed:

[clang] a0db738 - [clang][Interp] Add missing static_assert messages

Author: Douglas Yung Date: 2023-08-21T20:28:39-07:00 New Revision: a0db73850439c6fb72409dbef6d88ef2aef6f9f1 URL: https://github.com/llvm/llvm-project/commit/a0db73850439c6fb72409dbef6d88ef2aef6f9f1 DIFF: https://github.com/llvm/llvm-project/commit/a0db73850439c6fb72409dbef6d88ef2aef6f9f1.diff

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. In D148474#4490041 , @dim wrote: > FWIW, this fix works for the test cases I had via > https://bugs.freebsd.org/269067 and > https://github.com/llvm/llvm-project/issues/60182, but I got the following > failure during check-all:

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 552199. HerrCai0907 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterC

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 552200. BeMg added a comment. Herald added a subscriber: sunshaoce. Remove some condition because RFC doesn't support it. (Must include prefix arch|cpu|tune) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/ne

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:233 + ` check to + ignore false-positive for constexpr if statement in lambda expression. + `if constexpr`? Please also enclose it in double back-ticks. Repository: rG

[clang-tools-extra] 1c94124 - [clang-tidy]mark record initList as non-const param

Author: Congcong Cai Date: 2023-08-22T11:43:27+08:00 New Revision: 1c9412441b87eb15262fb4653015ff30c42d URL: https://github.com/llvm/llvm-project/commit/1c9412441b87eb15262fb4653015ff30c42d DIFF: https://github.com/llvm/llvm-project/commit/1c9412441b87eb15262fb4653015ff30c42d.diff

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9412441b87: [clang-tidy]mark record initList as non-const param (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

brad added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Driver/BUILD.gn:69 "ToolChains/CommonArgs.cpp", "ToolChains/Contiki.cpp", "ToolChains/CrossWindows.cpp", Here too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151730: [RISCV] Support target attribute for function

wangpc added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:376 + + if (AttrString.startswith("+") || AttrString.startswith("-")) { +// EXTENSION like arch=+v,+zbb,-c `-` is removed in https://github.com/riscv-non-isa/riscv-c-api-doc

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

MaskRay updated this revision to Diff 552204. MaskRay added a comment. update gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158461/new/ https://reviews.llvm.org/D158461 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTargets.h

[clang] be1516d - [PowerPC] Precommit test of `vec_promote` on `vector char`. NFC.

Author: Kai Luo Date: 2023-08-22T04:14:34Z New Revision: be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b URL: https://github.com/llvm/llvm-project/commit/be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b DIFF: https://github.com/llvm/llvm-project/commit/be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b.diff LOG: [Powe

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4597359 , @hvdijk wrote: > In D86310#4596841 , @tmgross wrote: > >> I think that D158169 seems to have fixed >> clang as well; after applying bo

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vector char

lkail created this revision. lkail added reviewers: PowerPC, nemanjai, qiucf. Herald added subscribers: sunshaoce, shchenz, kbarton. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to https://ww

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4605360 , @MaskRay wrote: >> // Android target triples contain a target version. If we don't have >> libraries for the exact target version, we should fall back to the next >> newest version or a versionless path, if

[clang] 07ab514 - [clang][ASTImporter]Skip check depth of friend template parameter

Author: huqizhi Date: 2023-08-22T13:16:11+08:00 New Revision: 07ab5140080eecdf9f0f6215f70377accb8696f1 URL: https://github.com/llvm/llvm-project/commit/07ab5140080eecdf9f0f6215f70377accb8696f1 DIFF: https://github.com/llvm/llvm-project/commit/07ab5140080eecdf9f0f6215f70377accb8696f1.diff LOG:

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07ab5140080e: [clang][ASTImporter]Skip check depth of friend template parameter (authored by jcsxky, committed by wangpc). Repository: rG LLVM Git

[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158402/new/ https://reviews.llvm.org/D158402 ___

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157953/new/ https://reviews.llvm.org/D157953 ___

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

Jim added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:3 +// RUN: %clang_cc1 -triple riscv64-none-linux-gnu -target-feature +zve64d \ +// RUN: -target-feature +f -target-feature +d -disable-O0-optnone \ +// RUN: -mvscale-min=4 -mvscale-max=4 -emit-llv

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

PiotrZSL created this revision. PiotrZSL added reviewers: malcolm.parsons, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Spec

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158480/new/ https://reviews.llvm.org/D158480 ___

[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

Jim added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2833 } + let Name = "vcreate_v", + UnMaskedPolicyScheme = NonePolicy, Can we add a blank line before this. Comment at: clang/include/clang/Basic/riscv_vec

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

Jim added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:3 +// RUN: %clang_cc1 -triple riscv64-none-linux-gnu -target-feature +zve64d \ +// RUN: -target-feature +f -target-feature +d -disable-O0-optnone \ +// RUN: -mvscale-min=4 -mvscale-max=4 -emit-llv

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail created this revision. lkail added reviewers: nemanjai, shchenz, stefanp, PowerPC, amyk. Herald added a subscriber: kbarton. Herald added a project: All. lkail requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Accordin

[PATCH] D158439: [Lex] Preambles should contain the global module fragment.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158439/new/ https://reviews.llvm.org/D158439

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail updated this revision to Diff 552226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158487/new/ https://reviews.llvm.org/D158487 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/PowerPC/builtins-ppc-vsx.c llvm/test/CodeGen/PowerPC/v

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

HerrCai0907 updated this revision to Diff 552227. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158480/new/ https://reviews.llvm.org/D158480 Files: clang-tools-extra/clang-tidy/readability/BracesA

[clang-tools-extra] 9b6859d - [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

Author: Congcong Cai Date: 2023-08-22T14:21:59+08:00 New Revision: 9b6859dc89b9578cc31811e6c122ed79ec58dac3 URL: https://github.com/llvm/llvm-project/commit/9b6859dc89b9578cc31811e6c122ed79ec58dac3 DIFF: https://github.com/llvm/llvm-project/commit/9b6859dc89b9578cc31811e6c122ed79ec58dac3.diff

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6859dc89b9: [clang-tidy][readability-braces-around-statements] ignore false-positive for… (authored by HerrCai0907). Repository: rG LLVM Github

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc. Herald added projects: clang, LLVM. Repo

<    1   2   3