[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 added a comment. In D156461#4583806 , @balazske wrote: > Normally what should happen is that a new move constructor is imported (with > a definition) and linked after the existing one (and the existing is not > modified). Does this violate the

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. @tbaeder Maybe you could land the dependencies of this patch so that we can progress it. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing lis

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added a comment. > Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github > issue) No problem! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 _

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBase, +ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) { + Decl *From, *To; cor3ntin wrote: > `ImportFunctionDeclBitShouldNotO

[clang] 6f7812f - [clang][Interp][NFC] Improve Pointer::print()

Author: Timm Bäder Date: 2023-08-17T09:21:51+02:00 New Revision: 6f7812fdabd9df282d1a9b4e42c17aa3aa77d431 URL: https://github.com/llvm/llvm-project/commit/6f7812fdabd9df282d1a9b4e42c17aa3aa77d431 DIFF: https://github.com/llvm/llvm-project/commit/6f7812fdabd9df282d1a9b4e42c17aa3aa77d431.diff LO

[clang] 3cd8196 - [clang][Interp][NFC] Declare Pointer::operator<< earlier

Author: Timm Bäder Date: 2023-08-17T09:21:51+02:00 New Revision: 3cd8196bc38c406329e9395f4cbb7cbb29a92d27 URL: https://github.com/llvm/llvm-project/commit/3cd8196bc38c406329e9395f4cbb7cbb29a92d27 DIFF: https://github.com/llvm/llvm-project/commit/3cd8196bc38c406329e9395f4cbb7cbb29a92d27.diff LO

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder abandoned this revision. tbaeder added a comment. I split out the CFG parts as https://reviews.llvm.org/D152504 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___ cfe-commits mailing list cf

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157596/new/ https://reviews.llvm.org/D157596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2676 + +if (ToT == PT_Float) { + const llvm::fltSemantics *ToSem = &Ctx.getFloatSemantics(ToQT); Might as well leave a comment here too, for symmetry CHANGES SINCE LA

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan updated this revision to Diff 551019. owenpan added a comment. Rebased to D158104 and simplified `getFunctionName` and `isCtorOrDtorName` a little. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/ https://reviews.llvm.org/D157963 Fil

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added a comment. I also investigated whether we could count those bits at compile time and statically assert on them, because a small typo or missed update could spend us a lot of time to dig for the cause. My first step is trying to count number of bits for a single bitfield, this is

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang-tools-extra.

[clang] 3568976 - Reland^2 "Fix __cfi_check not aligned to 4k on relocatable files with no executable code"

Author: Yi Kong Date: 2023-08-17T16:33:46+09:00 New Revision: 3568976375e305a7a41d62b9164ede7571ee16c5 URL: https://github.com/llvm/llvm-project/commit/3568976375e305a7a41d62b9164ede7571ee16c5 DIFF: https://github.com/llvm/llvm-project/commit/3568976375e305a7a41d62b9164ede7571ee16c5.diff LOG:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. In D158145#4594549 , @danix800 wrote: > I also investigated whether we could count those bits at compile time and > statically assert on them, > because a small typo or missed update could spend us a lot of time to dig for > th

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. Victor, this is proving quite tricky to review. There's already been a lot of updates and many of them are summarized as either "code refactor" or "clean-up". Please reduce traffic/noise and use more descriptive summaries. Also, rather than adding new features in thi

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551030. HerrCai0907 added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstPa

[clang] 6a06682 - [clang][NFC] fix several malformed links in ReleaseNotes.rst

Author: dingfei Date: 2023-08-17T15:50:29+08:00 New Revision: 6a06682806a7cea6a2b7b0e12091d19de74d9764 URL: https://github.com/llvm/llvm-project/commit/6a06682806a7cea6a2b7b0e12091d19de74d9764 DIFF: https://github.com/llvm/llvm-project/commit/6a06682806a7cea6a2b7b0e12091d19de74d9764.diff LOG:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBase, +ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) { + Decl *From, *To; cor3ntin wrote: > danix800 wrote: > > cor3ntin wro

[clang] eeac432 - Disable two tests without {arm, aarch64}-registered-target

Author: Jonas Hahnfeld Date: 2023-08-17T10:04:38+02:00 New Revision: eeac4321c517ee8afc30ebe62c5b1778efc1173d URL: https://github.com/llvm/llvm-project/commit/eeac4321c517ee8afc30ebe62c5b1778efc1173d DIFF: https://github.com/llvm/llvm-project/commit/eeac4321c517ee8afc30ebe62c5b1778efc1173d.diff

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Hahnfeld added a comment. I dsabled two tests without `{arm,aarch64}-registered-target` in rGeeac4321c517ee8afc30ebe62c5b1778efc1173d ; two post-commit comments inline Comment at: llvm/test/CodeGen/Generic/

[clang] b4e0589 - [clang][Verify] Show prefix in -verify error messages

Author: Timm Bäder Date: 2023-08-17T10:09:50+02:00 New Revision: b4e0589b2cd98a93aad449486bb2a52ab8790781 URL: https://github.com/llvm/llvm-project/commit/b4e0589b2cd98a93aad449486bb2a52ab8790781 DIFF: https://github.com/llvm/llvm-project/commit/b4e0589b2cd98a93aad449486bb2a52ab8790781.diff LO

[PATCH] D154688: [clang] Show verify prefix in error messages

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e0589b2cd9: [clang][Verify] Show prefix in -verify error messages (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https:/

[PATCH] D158155: [clang-format] Exclude kw_decltype in RemoveParentheses

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. >From https://en.cppreference.com/w/cpp/language/decltype: Note tha

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551037. danix800 added a comment. 1. Update ReleaseNotes.rst 2. Fix typos pointed out by @cor3ntin (thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files:

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie created this revision. Discookie added reviewers: NoQ, donat.nagy, balazske. Discookie added projects: clang, All. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Discookie requested

[clang] 8a25145 - [clang][Interp] Pass CallExpr to builtin functions

Author: Timm Bäder Date: 2023-08-17T10:20:58+02:00 New Revision: 8a25145058d29fe0fa06cd3cdb90fea7e21228bb URL: https://github.com/llvm/llvm-project/commit/8a25145058d29fe0fa06cd3cdb90fea7e21228bb DIFF: https://github.com/llvm/llvm-project/commit/8a25145058d29fe0fa06cd3cdb90fea7e21228bb.diff LO

[PATCH] D155545: [clang][Interp] Pass CallExpr to builtin functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a25145058d2: [clang][Interp] Pass CallExpr to builtin functions (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155545?

[clang] c4becd5 - [clang][Interp] Support __null

Author: Timm Bäder Date: 2023-08-17T10:28:37+02:00 New Revision: c4becd50ad437b44a303e9a14780ce600dd95146 URL: https://github.com/llvm/llvm-project/commit/c4becd50ad437b44a303e9a14780ce600dd95146 DIFF: https://github.com/llvm/llvm-project/commit/c4becd50ad437b44a303e9a14780ce600dd95146.diff LO

[PATCH] D155552: [clang][Interp] Support __null

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4becd50ad43: [clang][Interp] Support __null (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D12?vs=541366&id=551042#

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

bogner created this revision. bogner added reviewers: njames93, PiotrZSL, carlosgalvezp. Herald added subscribers: xazax.hun, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These te

[clang] 91af0d0 - [clang][Interp] Make sure we push integers of the correct size

Author: Timm Bäder Date: 2023-08-17T10:36:06+02:00 New Revision: 91af0d0a669880918eda2d2bd2d6185b2903a402 URL: https://github.com/llvm/llvm-project/commit/91af0d0a669880918eda2d2bd2d6185b2903a402 DIFF: https://github.com/llvm/llvm-project/commit/91af0d0a669880918eda2d2bd2d6185b2903a402.diff LO

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91af0d0a6698: [clang][Interp] Make sure we push integers of the correct size (authored by tbaeder). Changed prior to commit: https://reviews.llvm.

[PATCH] D158046: [X86] Support -march=gracemont

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: Why not handle this above (below tremont) as the next in the *mont series? Repository: rG LLVM Github Monorepo

[PATCH] D158158: [clang] Set FP options in Sema when instantiating CompoundStmt

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, efriedma, zahiraam. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. When an expression is instantiated, TreeTransform skips ImplicitCastExpr nodes, assuming

[clang] b719e41 - [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Author: Jonas Hahnfeld Date: 2023-08-17T10:39:47+02:00 New Revision: b719e410781ce9f3a2b316afea31c156bf99e036 URL: https://github.com/llvm/llvm-project/commit/b719e410781ce9f3a2b316afea31c156bf99e036 DIFF: https://github.com/llvm/llvm-project/commit/b719e410781ce9f3a2b316afea31c156bf99e036.diff

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb719e410781c: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI. (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ htt

[clang] b3469ce - [clang][Analysis] Handle && and || against variable and its negation as tautology

Author: Takuya Shimizu Date: 2023-08-17T17:55:48+09:00 New Revision: b3469ce6f80bce2b0a86026fd6867c4b04853466 URL: https://github.com/llvm/llvm-project/commit/b3469ce6f80bce2b0a86026fd6867c4b04853466 DIFF: https://github.com/llvm/llvm-project/commit/b3469ce6f80bce2b0a86026fd6867c4b04853466.diff

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hazohelet marked an inline comment as done. Closed by commit rGb3469ce6f80b: [clang][Analysis] Handle && and || against variable and its negation as… (authored by hazoh

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me with any extra tests required by David's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ ht

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551051. Fznamznon added a comment. Add a release note, apply feedback: - Do not report invalid initializers as missing - Fix wrong warning if record has bitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon marked 3 inline comments as done. Fznamznon added a comment. > Thank you for working on this! The changes should come with a release note. Thanks for feedback, I added a release note. > Can we silence the diagnostic in these cases? And this is done. Repository: rG LLVM Github Mono

[PATCH] D157879: [clang] Report missing designated initializers in C++

tbaeder added a comment. Tangentially related: Now that we have this `InitializedFields` set, would it be easy to add a warning for double-initialization of fields (that would also trigger in C)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15787

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

balazske added inline comments. Comment at: clang/unittests/AST/DeclTest.cpp:368 + ASTContext &Ctx = AST->getASTContext(); + Ctx.getTranslationUnitDecl()->dump(); + This dump is not needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/DeclTest.cpp:368 + ASTContext &Ctx = AST->getASTContext(); + Ctx.getTranslationUnitDecl()->dump(); + balazske wrote: > This dump is not needed? Yeah it's for debug only, I'll remove it. Repositor

[clang] d43a3d6 - [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

Author: Jonas Hahnfeld Date: 2023-08-17T11:54:05+02:00 New Revision: d43a3d6346961e639e29b8083b262416889e78ec URL: https://github.com/llvm/llvm-project/commit/d43a3d6346961e639e29b8083b262416889e78ec DIFF: https://github.com/llvm/llvm-project/commit/d43a3d6346961e639e29b8083b262416889e78ec.diff

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd43a3d634696: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15737

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 added a comment. Yes, I have a need for these setters :) but I cannot decide if the LLVM project in general or other people could profit from it. I am working on a C++-to-C transpiler based on clang. Other clang-based tool typically modify the intput file based on FileLocation informa

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked 3 inline comments as done. Closed by commit rG89361e2b98a9: [clang][Interp] Fix passing parameters of composite type (authored by tbaeder). Changed prio

[clang] 89361e2 - [clang][Interp] Fix passing parameters of composite type

Author: Timm Bäder Date: 2023-08-17T12:08:10+02:00 New Revision: 89361e2b98a9ce355bdde0ae02425ecbe5f9c06d URL: https://github.com/llvm/llvm-project/commit/89361e2b98a9ce355bdde0ae02425ecbe5f9c06d DIFF: https://github.com/llvm/llvm-project/commit/89361e2b98a9ce355bdde0ae02425ecbe5f9c06d.diff LO

[PATCH] D158165: [clang][AST] TextNodeDumper learned to output instantiated_from information

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158165 File

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cf10061 - [clang][Interp] Fully serialize Floating values to bytes

Author: Timm Bäder Date: 2023-08-17T12:41:39+02:00 New Revision: cf10061da75e41286c28690e45eee6ee70dad766 URL: https://github.com/llvm/llvm-project/commit/cf10061da75e41286c28690e45eee6ee70dad766 DIFF: https://github.com/llvm/llvm-project/commit/cf10061da75e41286c28690e45eee6ee70dad766.diff LO

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf10061da75e: [clang][Interp] Fully serialize Floating values to bytes (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551078. danix800 added a comment. Remove debug code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/D

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:51-54 +// For ARM64EC, symbol lookup in the MSVC linker has limited awareness +// of ARM64EC mangling ("#"/"$$h"). So object files need to refer to both +// the mangled and unmangl

[clang] 1740cf3 - [clang][Interp][NFC] Use std::byte to refer to Block data

Author: Timm Bäder Date: 2023-08-17T13:04:05+02:00 New Revision: 1740cf34533756befd06e878340b69ca1885041c URL: https://github.com/llvm/llvm-project/commit/1740cf34533756befd06e878340b69ca1885041c DIFF: https://github.com/llvm/llvm-project/commit/1740cf34533756befd06e878340b69ca1885041c.diff LO

[clang] d425720 - [clang][Interp] Implement __builtin_strlen

Author: Timm Bäder Date: 2023-08-17T13:10:46+02:00 New Revision: d425720aed48fd2c058a126ac961576d48c9732b URL: https://github.com/llvm/llvm-project/commit/d425720aed48fd2c058a126ac961576d48c9732b DIFF: https://github.com/llvm/llvm-project/commit/d425720aed48fd2c058a126ac961576d48c9732b.diff LO

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd425720aed48: [clang][Interp] Implement __builtin_strlen (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156042?vs=54341

[clang] 7b8f5f7 - No longer hang on typeof of a function type

Author: Aaron Ballman Date: 2023-08-17T07:15:30-04:00 New Revision: 7b8f5f7df71c48b281163e88054c84c06364023d URL: https://github.com/llvm/llvm-project/commit/7b8f5f7df71c48b281163e88054c84c06364023d DIFF: https://github.com/llvm/llvm-project/commit/7b8f5f7df71c48b281163e88054c84c06364023d.diff

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. In D157879#4594790 , @tbaeder wrote: > Tangentially related: Now that we have this `InitializedFields` set, would it > be easy to add a warning for double-initialization of fields (that would also > trigger in C)? Isn't a war

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:241 bool CheckMutable(InterpState &S, CodePtr OpPC, const Pointer &Ptr) { - assert(Ptr.isLive() && "Pointer is not live"); if (!Ptr.isMutable()) { aaron.ballman wrote: > I understand

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

tbaeder updated this revision to Diff 551087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/InterpBlock.h clang/lib/AST/Interp/InterpState.cpp clang/test/AST/Interp/lifeti

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

tbaeder added a comment. Ping @lzaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155430/new/ https://reviews.llvm.org/D155430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 approved would make rebasing easier :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-c

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551088. skatrak added a comment. Herald added subscribers: gysit, Dinistro. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/C

[clang] f8dadef - [CodeGen] Keep track of eagerly emitted globals

Author: Jonas Hahnfeld Date: 2023-08-17T13:26:22+02:00 New Revision: f8dadefd4afc8e1b7b9a1e69a0ba8df051e03328 URL: https://github.com/llvm/llvm-project/commit/f8dadefd4afc8e1b7b9a1e69a0ba8df051e03328 DIFF: https://github.com/llvm/llvm-project/commit/f8dadefd4afc8e1b7b9a1e69a0ba8df051e03328.diff

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8dadefd4afc: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added a comment. In D156320#4594584 , @awarzynski wrote: > Victor, this is proving quite tricky to review. There's already been a lot of > updates and many of them are summarized as either "code refactor" or > "clean-up". Please reduce traf

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

steelannelida added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158145#4594569 , @cor3ntin wrote: > In D158145#4594549 , @danix800 > wrote: > >> I also in

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Hahnfeld added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s 2

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

hazohelet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157526/new/ https://reviews.llvm.org/D157526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 0e17372 - Revert "[CodeGen] Keep track of eagerly emitted globals"

Author: Jonas Hahnfeld Date: 2023-08-17T14:21:39+02:00 New Revision: 0e17372b380467ac8339afdec992fbf887a11feb URL: https://github.com/llvm/llvm-project/commit/0e17372b380467ac8339afdec992fbf887a11feb DIFF: https://github.com/llvm/llvm-project/commit/0e17372b380467ac8339afdec992fbf887a11feb.diff

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158157/new/ https://reviews.llvm.org/D158157 ___

[clang] 91c4b55 - [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

Author: dingfei Date: 2023-08-17T20:28:41+08:00 New Revision: 91c4b5550ecfbb7afe7275c341b73a6d3a1bbd78 URL: https://github.com/llvm/llvm-project/commit/91c4b5550ecfbb7afe7275c341b73a6d3a1bbd78 DIFF: https://github.com/llvm/llvm-project/commit/91c4b5550ecfbb7afe7275c341b73a6d3a1bbd78.diff LOG:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91c4b5550ecf: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields (authored by dingfei ). Repository: rG LLVM Github Mon

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

hans added a comment. > Thanks! I agree. d9ad0681fad9a98f43d9baddb95d505b37153c48 (2013) renamed > `warn_drv_overriding_t_option` to `warn_drv_overriding_flag_option`. > Perhaps the original name `warn_drv_overriding_t_option` should be restored. That change also started using it for overriding

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

erichkeane added a comment. Sorry for the delay in review, I'm still on vacation. However, I don't like the idea of removing the satisfaction. I have to think about it more, but optimally we'd just not add the detail until we knew what the RHS value was, though our design doesn't particularly

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commits mailing list cfe-comm

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added a comment. Precommit CI still has a related failure, it seems. Comment at: clang/lib/Sema/SemaExpr.cpp:17317-17319 +if (TInfo->getType()->isSpecificBuiltinType(BuiltinType::Float) || +TInfo->getType()->isSpecificBuiltinType(BuiltinType::Half))

[PATCH] D158165: [clang][AST] TextNodeDumper learned to output instantiated_from information

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit. Comment at: clang/lib/AST/TextNodeDumper.cpp:1896 + + if (auto *Instance = D->getInstantiatedFromMemberFunction()) { +OS << " instan

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551113. skatrak added a comment. Change parent and update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/l

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. Sorry for the long radio silence here. There's a lot to chew on, and I put it off too long. Thanks for your patience! I agree we should get experimental modules support landed in some form on the LLVM 18 timeline. It's fine if this doesn't have extension points for la

[clang] ca1295c - [DebugInfo] Alternate (more efficient) MD5 fix

Author: Paul Robinson Date: 2023-08-17T07:03:47-07:00 New Revision: ca1295c5a15f03ede2fe620cc80d6a1e6e6735b8 URL: https://github.com/llvm/llvm-project/commit/ca1295c5a15f03ede2fe620cc80d6a1e6e6735b8 DIFF: https://github.com/llvm/llvm-project/commit/ca1295c5a15f03ede2fe620cc80d6a1e6e6735b8.diff

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca1295c5a15f: [DebugInfo] Alternate (more efficient) MD5 fix (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Mo

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. Detail added in the commit message, good idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 ___ cfe-commits mailing list cfe-commi

[clang] d7f7fb6 - [clang][AST] TextNodeDumper learned to output instantiated_from information

Author: Timo Stripf Date: 2023-08-17T14:11:16Z New Revision: d7f7fb6c1d9745f4d760962d2e572b861f730459 URL: https://github.com/llvm/llvm-project/commit/d7f7fb6c1d9745f4d760962d2e572b861f730459 DIFF: https://github.com/llvm/llvm-project/commit/d7f7fb6c1d9745f4d760962d2e572b861f730459.diff LOG: [

[PATCH] D158165: [clang][AST] TextNodeDumper learned to output instantiated_from information

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7f7fb6c1d97: [clang][AST] TextNodeDumper learned to output instantiated_from information (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D158165?vs=551068&id=551124#toc Repo

[clang] 6244e38 - [Sema] Add tests for handling of decls hidden by invalid decls

Author: John Brawn Date: 2023-08-17T15:25:53+01:00 New Revision: 6244e3840694e513ef885e8505e7744de8c9b959 URL: https://github.com/llvm/llvm-project/commit/6244e3840694e513ef885e8505e7744de8c9b959 DIFF: https://github.com/llvm/llvm-project/commit/6244e3840694e513ef885e8505e7744de8c9b959.diff LO

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > Why not handle this above (below tremont) as the next

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed a test for the behaviour when we have invalid decls in https://reviews.llvm.org/rG6244e3840694. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 551131. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ThreadSafety.cpp clang/test/Analysis/scopes-cfg-output.

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder updated this revision to Diff 551132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157596/new/ https://reviews.llvm.org/D157596 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/floats.cpp Index: clang/test/AST/In

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:234 +- Improved :doc:`readability-non-const-parameter.cpp + ` check to ignore Please keep alphabetical order (by check name) in this section. Repository: rG LLVM Gith

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao updated this revision to Diff 551138. rZhBoYao marked 2 inline comments as done. rZhBoYao added a comment. Thank Aaron and Vlad for reviewing this! Just updating the diff to reflect the final version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.ll

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2583f3acf59: [Clang] CWG1473: do not err on the lack of space after operator"" (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANG

[clang] f2583f3 - [Clang] CWG1473: do not err on the lack of space after operator""

Author: Po-yao Chang Date: 2023-08-17T23:10:37+08:00 New Revision: f2583f3acf596cc545c8c0e3cb28e712f4ebf21b URL: https://github.com/llvm/llvm-project/commit/f2583f3acf596cc545c8c0e3cb28e712f4ebf21b DIFF: https://github.com/llvm/llvm-project/commit/f2583f3acf596cc545c8c0e3cb28e712f4ebf21b.diff

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

nikic added a comment. Thanks! Can confirm that this recovers the compile-time regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 ___ cfe-commits maili

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158188 File

  1   2   3   >