danix800 added inline comments.
================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBase, + ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) { + Decl *From, *To; ---------------- cor3ntin wrote: > danix800 wrote: > > cor3ntin wrote: > > > `ImportFunctionDeclBitShouldNotOverwriteCtorDeclBits` > > I added the case into `DeclTest.cpp` because i think it can cover the root > > cause for both testcases. > > > > How about remove the somewhat repeated one in `ASTImporterTest.cpp`? > Now that you have written it, we can leave both tests i think. > Afaik one test serialization so they complement each other OK! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits