[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158055 Files: clang/include/clang/AST/Decl.h clang

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 added a comment. I added some missing (simple) setter methods to Decl and Expr classes. I did not comment them since typically simple setter methods are uncommented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://revie

[clang] ae84ad1 - [Driver] Select newest GCC installation on Solaris

Author: Rainer Orth Date: 2023-08-16T09:57:59+02:00 New Revision: ae84ad15efd7ef7da95146e900ec72ceadf98058 URL: https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058 DIFF: https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058.diff L

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae84ad15efd7: [Driver] Select newest GCC installation on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D157275?vs=55

[PATCH] D158056: [clang] Implement constexpr operator[] for vectors

DaPorkchop_ created this revision. DaPorkchop_ added reviewers: erichkeane, rsmith, efriedma, void. Herald added a project: All. DaPorkchop_ requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements the array subscript operator for ve

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. hey @victorkingi , I am still unsure about parsing these remarks options in two places: - CompilerInvocation.cpp - ExecuteCompilerInvocation.cpp I think that it is important to clarify the relations between the two. In particular, it's normally the job of CompilerIn

[clang] 373fcd5 - [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

Author: Kadir Cetinkaya Date: 2023-08-16T10:22:16+02:00 New Revision: 373fcd5d73a3ed5bedff771bcf6a3aba981155cc URL: https://github.com/llvm/llvm-project/commit/373fcd5d73a3ed5bedff771bcf6a3aba981155cc DIFF: https://github.com/llvm/llvm-project/commit/373fcd5d73a3ed5bedff771bcf6a3aba981155cc.dif

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rG373fcd5d73a3: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs (authored by k

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

tschuett added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:227 + // Specifies, using a regex, which successful optimization passes done, + // to include in the final optimization record file generated. If not provided awarzynski wr

[clang] 18252e6 - [Driver][unittest] Unbreak ToolChainTest.cpp compilation with -Werror

Author: Rainer Orth Date: 2023-08-16T10:37:14+02:00 New Revision: 18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e URL: https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e DIFF: https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e.diff L

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) HazardyKnusperkeks wrote: > Is a bit clearer. I moved this function up to here from below and only removed a couple

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet updated this revision to Diff 550662. kadircet marked an inline comment as done. kadircet added a comment. - Rename helper, update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157905/new/ https://reviews.llvm.org/D157905 Files:

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a usage of stdio.h, in places unrelated to st

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680

[PATCH] D157905: [include-cleaner] Filter references to identity macros

sammccall accepted this revision. sammccall added a comment. still LG, comments are still confusing me a little Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a usag

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy added a comment. In D156312#4589251 , @steakhal wrote: > I don't think we should do anything about it unless it's frequent enough. > Try to come up with a heuristic to be able to measure how often this happens, > if you really care. > Once you

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550668. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei updated this revision to Diff 550669. pengfei marked an inline comment as done. pengfei added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157485/new/ https://reviews.llvm.org/D157485 Files: clang/docs/Releas

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2581 + unsigned VectorWidth) { + if (!getTarget().getTriple().isX86() || VectorWidth < 512) +return; skan wrote: > Minor suggestion.

[clang] d77cba6 - [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

Author: Victor Campos Date: 2023-08-16T10:45:01+01:00 New Revision: d77cba6d474ab8ce5ece126499522de414c8089c URL: https://github.com/llvm/llvm-project/commit/d77cba6d474ab8ce5ece126499522de414c8089c DIFF: https://github.com/llvm/llvm-project/commit/d77cba6d474ab8ce5ece126499522de414c8089c.diff

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

This revision was automatically updated to reflect the committed changes. vhscampos marked an inline comment as done. Closed by commit rGd77cba6d474a: [Clang][DebugInfo] Emit narrower base types for structured binding declarations… (authored by vhscampos). Repository: rG LLVM Github Monorepo C

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan created this revision. zyounan added reviewers: saar.raz, erichkeane, ilya-biryukov, aaron.ballman. Herald added a subscriber: kadircet. Herald added a project: All. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're exp

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550683. zyounan added a comment. Rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/ExprConcepts.h clang/lib/Sema/Se

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

qiucf created this revision. qiucf added reviewers: nemanjai, stefanp, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. `mff

[clang] ec483c2 - [clang][ASTMatcher] Add matcher for 'MacroQualifiedType'

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: ec483c29a95cbaef460e3c8523af91ee1cc43e55 URL: https://github.com/llvm/llvm-project/commit/ec483c29a95cbaef460e3c8523af91ee1cc43e55 DIFF: https://github.com/llvm/llvm-project/commit/ec483c29a95cbaef460e3c8523af91ee1cc43e55.diff LOG:

[clang] 3b0eeb6 - [clang][ASTImporter] Add import of 'MacroQualifiedType'

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: 3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354 URL: https://github.com/llvm/llvm-project/commit/3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354 DIFF: https://github.com/llvm/llvm-project/commit/3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354.diff LOG:

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

This revision was automatically updated to reflect the committed changes. Closed by commit rGec483c29a95c: [clang][ASTMatcher] Add matcher for 'MacroQualifiedType' (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D157780: [ASTImporter] Add import of MacroQualifiedType

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0eeb6cdbd7: [clang][ASTImporter] Add import of 'MacroQualifiedType' (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] eabc7ad - [clang][ASTImporter] Remove extra FunctionTemplateDecl introduced by templated friend

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: eabc7add1f96e0b580cf4acf4f42ed3eb99df47b URL: https://github.com/llvm/llvm-project/commit/eabc7add1f96e0b580cf4acf4f42ed3eb99df47b DIFF: https://github.com/llvm/llvm-project/commit/eabc7add1f96e0b580cf4acf4f42ed3eb99df47b.diff LOG:

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeabc7add1f96: [clang][ASTImporter] Remove extra FunctionTemplateDecl introduced by templated… (authored by dingfei ). Repository:

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, stefanp, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `smmintrin.h` uses `__builtin_mf

[clang] 2459ed6 - [PowerPC] Add nmmintrin.h to copy list

Author: Qiu Chaofan Date: 2023-08-16T18:15:08+08:00 New Revision: 2459ed67805c1c6bd9d7db2f1e481b318960d7d8 URL: https://github.com/llvm/llvm-project/commit/2459ed67805c1c6bd9d7db2f1e481b318960d7d8 DIFF: https://github.com/llvm/llvm-project/commit/2459ed67805c1c6bd9d7db2f1e481b318960d7d8.diff L

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf marked 2 inline comments as done. qiucf added a comment. Thanks, fixed by rG2459ed67805c . `nmmintrin.h` just includes `smmintrin.h` so it's not critical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposit

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

eddyz87 added a comment. Hi @dblaikie, After this revision landed yesterday one BPF kernel selftest (written in C) stopped building. I narrowed the issue to the following example: #define SEC(n) __attribute__((section(n))) const int with_init SEC("foo") = 1; const int no_init SEC("foo"

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

eddyz87 added a comment. As an additional data point, the same example but w/o section specification compiles fine: const int with_init = 1; const int no_init; And puts both globals to the same section: $ clang -c t.c -o - | llvm-readelf --section-headers -s - Section Headers: [Nr]

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder updated this revision to Diff 550696. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158069/new/ https://reviews.llvm.org/D158069 Files: clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Pointer.h clang/unittests/AST/CMakeLists.txt clang/unittests/AST/Interp/CMakeLists.t

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder abandoned this revision. tbaeder added a comment. Superseeded by https://reviews.llvm.org/D156027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ c

[PATCH] D155858: Add a concept AST node.

sammccall added a comment. (There are still outstanding comments e.g. in ASTImport) I think it would be useful to add to the patch description: - the current deficiencies of ConceptReference that make it not a well-behaved AST node now - which of these are addressed in this patch (RecursiveASTV

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

tbaeder accepted this revision. tbaeder added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: JDevlieghere, zaks.anna, rjmccall, ahatanak. Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. aaron.ballman requested review of this revision. Her

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. Could you also add the nesting tests for outer scope directive? Currently it tests only for inner CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 ___ cfe-commits mailing lis

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 550703. donat.nagy added a comment. Updated the release notes. This could be the final version of this commit if you agree that it's good enough. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files:

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 2 inline comments as done. donat.nagy added inline comments. Comment at: clang/docs/analyzer/checkers.rst:81 + +Ensure the shift operands are in proper range before shifting. + donat.nagy wrote: > steakhal wrote: > > We should exactly elaborate

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. Having worked with phabricator for a long time, this is the first time I've seen it "pull a github" where it just doesn't want to show you the content of anything in the review. Ugh, sorry for that! You can click on Changeset List above to see the list of changed

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 550706. donat.nagy added a comment. A few minutes ago I accidentally re-uploaded the previous version of the patch; now I'm fixing this by uploading the actually updated variant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Context.h:88 + /// Returns the program. This is only needed for unittests. + Program &getProgram() const { return *P.get(); } + This should return a const ref Comment at: clang/

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 550707. hazohelet marked 3 inline comments as done. hazohelet added a comment. Address comments from Hubert - Bring back type prefix - NFC stylistic changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D15561

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

hans added a comment. Apologies for the delay, I'm still catching up with my post-vacation backlog. (For my notes, this came up in https://reviews.llvm.org/D153709) I think the root of this bug is how class-level dll attributes get propagated to class members. Here is an example: template

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550713. zyounan added a comment. Adapt to D157554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

sammccall added a comment. Thanks, this does look better. I agree with Nathan's comments and will leave final stamp to him. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:144 + + // This variable would be discarded directly at the end of this function. We + /

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:9079 +auto *IDC = TC->getImmediatelyDeclaredConstraint(); +assert(IDC && "ImmediatelyDeclaredConstraint can't be null here."); +ExprResult Constraint = SubstExpr(IDC, MLTAL); I'

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550719. victorkingi marked 9 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

sammccall added a comment. This would be a great fix to have! However I don't think the specific changes to the RecursiveASTVisitor are correct. I can see a couple of approaches: 1. prevent the RecursiveASTVisitor from traversing into uninteresting contexts, and drop the Encloses check in Visi

[clang] 871ee94 - [clang][ExprConst] Use call source range for 'in call to' diags

Author: Timm Bäder Date: 2023-08-16T15:22:29+02:00 New Revision: 871ee94141123f40cf0310ca89123c6c416c3d84 URL: https://github.com/llvm/llvm-project/commit/871ee94141123f40cf0310ca89123c6c416c3d84 DIFF: https://github.com/llvm/llvm-project/commit/871ee94141123f40cf0310ca89123c6c416c3d84.diff LO

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

This revision was automatically updated to reflect the committed changes. Closed by commit rG871ee9414112: [clang][ExprConst] Use call source range for 'in call to' diags (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156604?vs=548520&id=550724#toc Repository: rG L

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550725. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h fla

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.h:76-81 +RK_Missing,// Remark argument not present on the command line. +RK_Enabled,// Remark enabled via '-Rgroup'. +RK_EnabledEverything, // Remark en

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis updated this revision to Diff 550729. TIFitis added a comment. Updated test with correct function attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157994/new/ https://reviews.llvm.org/D157994 Files: clang/lib/CodeGen/CGOpenMPRun

[PATCH] D158056: [clang] Implement constexpr operator[] for vectors

DaPorkchop_ updated this revision to Diff 550731. DaPorkchop_ added a comment. Fixed test code for `CodeGenCXX/temporaries.cpp` Creating and extracting a reference to a temporary vector's element is now able to be evaluated at compile time, which made this test case fail (since it was looking for

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree this is a mess: the reason we think objective-c++-header is safe is that we have built-in support, but in the presence of query-driver that's not enough. In terms of testing this:

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. (This will look different/better after D155858 , taking it off my radar until then) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157989: [NFC] Initialize pointer field

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1ddc5850b1: [NFC][OpenMP] Initialize pointer field (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/ https://reviews.llvm.org

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

tschuett added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:227 + // Specifies, using a regex, which successful optimization passes done, + // to include in the final optimization record file generated. If not provided victorkingi w

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. @theo-lw -- are you planning to continue working on this review? (It's okay if you're not, I'm more wondering if I should remove you as the assignee on https://github.com/llvm/llvm-project/issues/58637) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177

[clang-tools-extra] a94c44c - [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

Author: Felix Date: 2023-08-16T15:02:56Z New Revision: a94c44cc0a5601e977b5cc1d2cfdee1488be62e9 URL: https://github.com/llvm/llvm-project/commit/a94c44cc0a5601e977b5cc1d2cfdee1488be62e9 DIFF: https://github.com/llvm/llvm-project/commit/a94c44cc0a5601e977b5cc1d2cfdee1488be62e9.diff LOG: [clang-

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94c44cc0a56: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155833/new/ https://reviews.llvm.org/D155833 ___ cfe-commits mailing list cfe-

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

sammccall created this revision. sammccall added reviewers: kadircet, aaron.ballman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Document the valid states: invalid/unset/pointer (Currently both

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/test/Driver/optimization-remark.f90:7 +! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS +! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s --check-pr

[clang] 5d9ccd7 - [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

Author: Akash Banerjee Date: 2023-08-16T16:35:28+01:00 New Revision: 5d9ccd7a96930351519ccbe5f85b127faa0dda9a URL: https://github.com/llvm/llvm-project/commit/5d9ccd7a96930351519ccbe5f85b127faa0dda9a DIFF: https://github.com/llvm/llvm-project/commit/5d9ccd7a96930351519ccbe5f85b127faa0dda9a.diff

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d9ccd7a9693: [OpenMP] Migrate dispatch related utility functions from Clang codegen to… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added a comment. Thanks for working on this! FWIW I had an old draft of this feature that may have interesting ideas: https://reviews.llvm.org/D122827 Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:44 +for (const auto &WhatIsThis :

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. At the moment, the TargetParser architecture is extensible. This complicates the addition of new architectures, operating systems, and so on. In the main discussion, it was proposed to redesign the architecture of this module in order to increase the possibility of adding

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. I'd hope there are common code paths where `isVLSTBuiltinType` would still be useful but I guess this step is required to make that happen anyway. If you permit a minor request

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

sammccall added a comment. Sorry about the delay, I think this is OK to add. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:500 +"User config is from clangd/config.yaml in the following directories \n" +"(unless specified with --default-config):\n"

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw added a comment. In D141177#4592158 , @aaron.ballman wrote: > @theo-lw -- are you planning to continue working on this review? (It's okay > if you're not, I'm more wondering if I should remove you as the assignee on > https://github.com/llvm/ll

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. In D141177#4592361 , @theo-lw wrote: > In D141177#4592158 , @aaron.ballman > wrote: > >> @theo-lw -- are you planning to continue working on this review? (It's okay >> if you're no

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot for doing this, i think this makes it a lot more obvious that this is a tristate struct rather than invalid just being a bit that can bit set for both null and non-null pointe

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

dang added a comment. Looks mostly good. Quick Question how do we handle inheritance to a template parameter? Comment at: clang/include/clang/ExtractAPI/API.h:665 + +struct ClassTemplateSpecRecord : CXXClassRecord { + ClassTemplateSpecRecord(StringRef USR, StringRef Name, Pre

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

aaron.ballman accepted this revision. aaron.ballman added a comment. Thank you for this! LGTM aside from a tiny nit. Comment at: clang/include/clang/Sema/Ownership.h:147 +/// It may be: +/// - a valid pointer to the result object +/// - unset (null but valid), for constructs th

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a usage of stdio.h, in places unrelated to st

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet updated this revision to Diff 550790. kadircet added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman. Herald added a reviewer: njames93. - Apply filtering only to macros that expand to themselves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. friendly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D129061: [Lex] Diagnose macro in command lines

aaron.ballman added a comment. This review went cold for about a year now (sorry for not noticing we hadn't answered your question!), so I'm uncertain if @jackhong12 is still interested in pursuing this. If not, that's totally fine, just let us know so we can remove you as the assignee on the i

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 550776. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante accepted this revision. Mordante added a comment. I'm happy with the libc++ changes, please wait a few days for @ldionne to react. In D112921#4584704 , @aaron.ballman wrote: > In D112921#4581641 , @rnk

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550800. victorkingi added a comment. added support for backend remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeG

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:1032-1043 +case llvm::DK_MachineOptimizationRemark: + optimizationRemarkHandler( + llvm::cast(di)); + break; +case llvm::DK_MachineOptimizationRemarkMissed: + opt

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

rnk added a comment. > That doesn't handle the second of your test cases though, where dllimport is > put on the member directly: > ... > It's not clear to me how we'd want to handle that. I don't think it comes up > in libc++, and I can't think of any code that would want to do that either, >

[clang] 063c42e - [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

Author: Owen Pan Date: 2023-08-16T10:45:54-07:00 New Revision: 063c42e919c01d7e64c1af5a10898fc84b06dfe8 URL: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8 DIFF: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8.diff LOG:

[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

This revision was automatically updated to reflect the committed changes. Closed by commit rG063c42e919c0: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

philnik added a comment. I think these changes would allow us to drop the `stddef.h` compat header from libc++, which would be really nice. Comment at: clang/lib/Headers/stddef.h:36-40 +#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L) || \ +(def

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added a comment. In D157757#4592766 , @philnik wrote: > I think these changes would allow us to drop the `stddef.h` compat header > from libc++, which would be really nice. I'd really rather not change how `nu

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana updated this revision to Diff 550823. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews.llvm.org/D157793 Files: clang/lib/Headers/stdarg.h clang/test/Headers/stdarg.c clang/test/Heade

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 550826. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h clang/test/Headers/stddef.c clang/test/Heade

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added a comment. In D157757#4592794 , @iana wrote: > In D157757#4592766 , @philnik wrote: > >> I think these changes would allow us to drop the `stddef.h` compat header >> from libc++, which would be really

[PATCH] D158104: [clang-format][NFC] Simplify getFirstNonComment() in the annotator

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15

  1   2   3   >