[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:417 + continue; +} else if (Feature.startswith("no-")) + Ret.Features.push_back("-" + Feature.split("-").second.str()); Is this tested? I don't see any "no-" in the th

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan created this revision. jacquesguan added reviewers: DavidTruby, efriedma, peterwaller-arm, paulwalker-arm, bsmith, c-rhodes, sdesmalen, rsandifo-arm, ctetreau, cameron.mcinally, aaron.ballman. Herald added a subscriber: psnobl. Herald added a project: All. jacquesguan requested review

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550578. fakepaper56 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. gracemont has some differen

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate added a comment. In D157297#4590580 , @pengfei wrote: > > I'd prefer macro to duplicated definitions. We have such precedents, e.g., > https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994 Do you means revert to

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 added a comment. I think the ASTImporter class has in general a completion problem. What do you think about rewriting it that any missing Visit* function for Type, Decl and Stmt produces an compiler error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a comment. In D157297#4590692 , @lygstate wrote: > In D157297#4590580 , @pengfei wrote: > >> > > > >> I'd prefer macro to duplicated definitions. We have such precedents, e.g., >> https://github.co

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550587. lygstate added a comment. Revert to version 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index: clang/lib/Headers/bmiintrin.h

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 updated this revision to Diff 550588. kaz7 added a comment. Update to follow suggestions. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include/clang/Driver/Options.td

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 marked 3 inline comments as done. kaz7 added inline comments. Comment at: clang/include/clang/Driver/Options.td:5166 +// VE feature flags +let Flags = [TargetSpecific, CC1Option] in { +def mvevpu : Flag<["-"], "mvevpu">, Group, MaskRay wrote: > Other feature

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16867-16868 +/// Convert character's code unit value to a string. +/// The code point needs to be zero-extended to 32-bits. +static void WriteCharValueForDiagnostic(uint32_t Value, const Bu

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe17667b33f1f: [Driver][DXC] Remove a bunch of options from DXC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158037/new/ https://revie

[clang] e17667b - [Driver][DXC] Remove a bunch of options from DXC

Author: Justin Bogner Date: 2023-08-15T21:38:20-07:00 New Revision: e17667b33f1f37354a19be6b09d6812a61a66e2a URL: https://github.com/llvm/llvm-project/commit/e17667b33f1f37354a19be6b09d6812a61a66e2a DIFF: https://github.com/llvm/llvm-project/commit/e17667b33f1f37354a19be6b09d6812a61a66e2a.diff

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550607. Amir added a comment. perf2prof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/utils/per

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 ___ cfe-commits mailing list cfe-commit

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a subscriber: aaron.ballman. pengfei added a comment. BTW, maybe @aaron.ballman knows why we don't support such syntax in C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 ___ cfe-co

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei added a comment. Ping~ It looks to me there's no concern about this solution in the RFC . I think we can move forward to land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan updated this revision to Diff 550627. jacquesguan added a comment. fix compile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://reviews.llvm.org/D158045 Files: clang/include/clang/AST/Type.h clang/lib/AST/ASTContex

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added a comment. `# REQUIRES: system-aix` in llvm/test/tools/llvm-ranlib/aix-X-option.test unfortunately makes most -X tests only work on AIX, which most contributors don't have access to. Ideally `-X` is usable when the user specifies `--format=bigarchive`. The environment variable `O

[PATCH] D157485: [X86][RFC] Support new feature AVX10

skan added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2581 + unsigned VectorWidth) { + if (!getTarget().getTriple().isX86() || VectorWidth < 512) +return; Minor suggestion. The code here may

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld added a comment. ping - this one is the only prerequisite left for three of my patches that were accepted yesterday... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156891/new/ https://reviews.llvm.org/D156891 ___

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

nikic added a comment. To avoid a full revert, I removed the deprecations in this patch in https://github.com/llvm/llvm-project/commit/348d36f1a2c8c776ce87e038bf15fc4cabd62702. Please do not deprecate methods that have remaining in-tree users and make sure that `-Werror=deprecated-declarations`

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added inline comments. Comment at: llvm/include/llvm/Object/ArchiveWriter.h:43 +enum SymtabWritingMode { + NoSymtab, // Do not write symbol table. Below you use `SymtabWritingMode::` for all members, so just make this enum scoped. ==

[PATCH] D157485: [X86][RFC] Support new feature AVX10

skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:927 + !STI.hasFeature(X86::FeatureAVX10_512bit)) +report_fatal_error("ZMM registers are not supported without AVX10-512BIT"); switch (TSFlags & X86II::OpPrefixMask) { ---

[PATCH] D78441: Delete NaCl support

MaskRay added a comment. In D78441#4074689 , @MaskRay wrote: > In D78441#4067440 , @dschuff wrote: > >> Sorry, no :) > > Is there a timeline for the removal? @dschuff :) Repository: rG LLVM Github Monorepo CHA

<    1   2   3