[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong seman

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti marked an inline comment as done. 5chmidti added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:91 + +// Local variables declared inside of the selected lambda cannot go out of +// scope. The DeclRefExprs that are import

[clang] 700ca0e - [NFC] Red Hat is two words

Author: Josh Stone Date: 2023-08-14T10:10:10-07:00 New Revision: 700ca0e7432d4ef485900f16d9f051e2bbc8523c URL: https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c DIFF: https://github.com/llvm/llvm-project/commit/700ca0e7432d4ef485900f16d9f051e2bbc8523c.diff LO

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4585268 , @aaron.ballman wrote: > In D157793#4583698 , @iana wrote: > >> In D157793#4583663 , @MaskRay >> wrote: >> Apple needs a _

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication between include-clean

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 550013. artem marked 5 inline comments as done. artem edited the summary of this revision. artem added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/docs/Rel

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:525 +// CHECK: !202 = !DILocation(line: 279, column: 8, scope: !194) +// CHECK: !203 = !DILocation(line: 279, column: 17, scope: !194) +// CHECK: !204 = !DILocation(line: 2

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. > If no suitable integer type is found in the target, no debug information is > emitted anymore in order to prevent wrong debug output. Why is emitting a bitfield type not an option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong semant

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

ellis created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157904 Files: clang/un

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added a subscriber: mstorsjo. smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4585685 , @iana wrote: > In D157793#4585268 , @aaron.ballman > wrote: > >> In D157793#4583698 , @iana wrote: >> >>> In D157793#4

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Despite being true positives, these results just confuse users. So filte

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7261 +/// Matches macro qualified types. +/// How about: Matches qualified types when the qualifier is applied via a macro. and then a second example like: ``` int *

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:24 + +// RUN: rm -rf %t.profdir && mkdir %t.profdir + Let's move this line down since we don't use it until line 31. Comment at: compiler-

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:665 +let Predicates = [HasStdExtZicfilp] in { +def : InstAlias<"lpad $imm20", (AUIPC X0, uimm20:$imm20)>; There is a designated spot in this file for InstAliases. Reposito

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 550030. jcsxky added a comment. fixed according to the review and add testcase to StructuralEquivalenceTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files:

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5496 + // execution of the await_suspend. To achieve this, we need to prevent the + // await_suspend get inlined before CoroSplit pass. + // Suggestion: > The `await_suspend` call perfor

[PATCH] D156205: [clang][WebAssembly] Link crt1 even in case of -shared

sbc100 added a comment. (update change title to use the `[clang][WebAssembly]`convention) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 ___ cfe-commits mailin

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. So, as I understand the discussion, after this patch, it will still be possible to get dwarf and codeview in the same compile, but users will have to resort to cc1 flags. I think that's a good end

[clang-tools-extra] 09a622b - [clangd] Fix typo in comment

Author: Eymen Ünay Date: 2023-08-14T20:07:58+02:00 New Revision: 09a622baa2d80ccc38eb42b6b58b39519704399f URL: https://github.com/llvm/llvm-project/commit/09a622baa2d80ccc38eb42b6b58b39519704399f DIFF: https://github.com/llvm/llvm-project/commit/09a622baa2d80ccc38eb42b6b58b39519704399f.diff LO

[PATCH] D157207: [clangd] Fix typo in comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG09a622baa2d8: [clangd] Fix typo in comment (authored by Eymay, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157207/new/ https://rev

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5831 +FoundTemplate->getFriendObjectKind() != Decl::FOK_None && +!D->specializations().empty(); +if (IsStructuralMatch(D, FoundTemplate, true, IgnoreDepth)) {

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

nhaehnle abandoned this revision. nhaehnle added a comment. Indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86154/new/ https://reviews.llvm.org/D86154 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4522 RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); + + Keep just one blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 550039. zequanwu marked 3 inline comments as done. zequanwu added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files: cl

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, P

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

arsenm created this revision. arsenm added reviewers: jcranmer-intel, kpn, sepavloff, andrew.w.kaylor, foad, bob80905. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D157911 F

[clang] 1ef3de6 - Disable sanitizer's on ifunc resolvers.

Author: Daniel Kiss Date: 2023-08-14T20:56:55+02:00 New Revision: 1ef3de6b09f6b21a383fc7cf1ce1283df738015a URL: https://github.com/llvm/llvm-project/commit/1ef3de6b09f6b21a383fc7cf1ce1283df738015a DIFF: https://github.com/llvm/llvm-project/commit/1ef3de6b09f6b21a383fc7cf1ce1283df738015a.diff L

[PATCH] D150262: Disable sanitizer's on ifunc resolvers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ef3de6b09f6: Disable sanitizer's on ifunc resolvers. (authored by danielkiss). Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. I think the best place to test `RISCVISAInfo.cpp` is `llvm/unittests/Support/RISCVISAInfoTest.cpp`. `clang/test/Driver/print-supported-extensions.c` can test just a few lines, so that changes to RISC-V extensions will generally not require updates to `clang/test/Driver

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

bob80905 added a comment. Release note for addition of exp10 builtin? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions t

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay added a comment. Please add a link to https://reviews.llvm.org/D87737 in the summary/commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 __

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

arsenm added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } shenhan wrote: > arsenm wrote: > > You cannot spam warnings he

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski marked 2 inline comments as done. awarzynski added a comment. Thank you all for reviewing! In D157837#4584387 , @bogner wrote: > I can't speak to which flags should be present in flang-new or not That's determined by what's tested/used in tes

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550047. awarzynski added a comment. Add missing `TargetSpecific` flag to the definition of `mcpu_EQ`, remove redundant `TODO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.o

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. In D157280#4586078 , @MaskRay wrote: > Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGO

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

dblaikie added inline comments. Comment at: clang/lib/AST/Decl.cpp:4510-4512 +for (const FieldDecl *Field : CXXRD->fields()) + if (Field->getType()->getAsCXXRecordDecl()) +return false; maybe `llvm::any_of`? Not especially shorter, but maybe make

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2cf195d5fb: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] cf2cf19 - [Profile] Allow online merging with debug info correlation.

Author: Zequan Wu Date: 2023-08-14T15:15:01-04:00 New Revision: cf2cf195d5fb0a07c122c5c274bd6deb0790e015 URL: https://github.com/llvm/llvm-project/commit/cf2cf195d5fb0a07c122c5c274bd6deb0790e015 DIFF: https://github.com/llvm/llvm-project/commit/cf2cf195d5fb0a07c122c5c274bd6deb0790e015.diff LOG

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

MaskRay added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

steakhal added a comment. Hmm. I guess the assertion is to silence some tool. And I think actually that function might very well also return null in some cases. Why do you think it cannot or at least should not return null in your context? I couldn't infer this from the context, neither from the

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

steakhal added a comment. If `getStmtForDiagnostics()` in general, never returns null, then shouldn't we mark the API with an appropriate attribute? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157888/new/ https://reviews.llvm.org/D157888 _

[clang] c4ada13 - [NFC][Clang] Fix static analyzer concern about null value dereference

Author: Elizabeth Andrews Date: 2023-08-14T12:19:45-07:00 New Revision: c4ada13e4b3e72543e454a12a6db085812114c0c URL: https://github.com/llvm/llvm-project/commit/c4ada13e4b3e72543e454a12a6db085812114c0c DIFF: https://github.com/llvm/llvm-project/commit/c4ada13e4b3e72543e454a12a6db085812114c0c.d

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4ada13e4b3e: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong sema

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions shenh

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

MaskRay accepted this revision. MaskRay added subscribers: python3kgae, beanz. MaskRay added a comment. This revision is now accepted and ready to land. > ... but it really doesn't scale well, as can be seen by things like the > somewhat recently introduced CLDXCOption. FYI @beanz @python3kgae D

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. Thanks for the updates - this is looking really good! A few more suggestions and then I'll scan the whole thing again (sorry, there's been quite a lot of code going back and forth). Comment at: flang/lib/Frontend/CompilerInvocation.cpp:1024 + //

[clang] f58330c - [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

Author: Justin Bogner Date: 2023-08-14T12:27:13-07:00 New Revision: f58330cbe44598eb2de0cca3b812f67fea0a71ca URL: https://github.com/llvm/llvm-project/commit/f58330cbe44598eb2de0cca3b812f67fea0a71ca DIFF: https://github.com/llvm/llvm-project/commit/f58330cbe44598eb2de0cca3b812f67fea0a71ca.diff

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf58330cbe445: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially (authored by bogner). Changed prior to commit: https://r

[PATCH] D157497: feat: Migrate isArch16Bit

MaskRay added a comment. In D157497#4584621 , @Pivnoy wrote: > This discussion was the main motivation for this change. > https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 > As a result, Triple should become a data class, and its d

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 550055. bogner edited the summary of this revision. bogner added a comment. Update comment wording to be less ambiguous about flags vs visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https:/

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu created this revision. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Debug info correlation is an option

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. In D157888#4586126 , @steakhal wrote: > Hmm. I guess the assertion is to silence some tool. And I think actually that > function might very well also return null in some cases. > Why do you think it cannot or at least should not

[PATCH] D157905: [include-cleaner] Filter references to identity macros

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:37 +namespace { +bool shouldSkipMacro(const Macro &M) { + static const auto *MacroNamesToIgnore = ne

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

abhina.sreeskantharajan added a comment. I've discussed offline with @hubert.reinterpretcast and agree with him that with the addition of fexec-charset support, the set of characters deemed printable will not be accurate when other encodings are used. This will be similar to the printf/scanf fo

[PATCH] D155081: Specify the developer policy around links to external resources

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Looks like a great improvement to the policy, thank you all for sorting through this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 __

[clang] c70dab0 - [NFC][Clang] Fix static analyzer concern about null value dereference

Author: Elizabeth Andrews Date: 2023-08-14T13:07:24-07:00 New Revision: c70dab026d377736c1281d3c8005bb5e578ec8b3 URL: https://github.com/llvm/llvm-project/commit/c70dab026d377736c1281d3c8005bb5e578ec8b3 DIFF: https://github.com/llvm/llvm-project/commit/c70dab026d377736c1281d3c8005bb5e578ec8b3.d

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

This revision was automatically updated to reflect the committed changes. Closed by commit rGc70dab026d37: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

beanz accepted this revision. beanz added a comment. LGTM. This is definitely an improvement over the awfulness we were doing. Thanks @bogner! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added a comment. In D155610#4586213 , @abhina.sreeskantharajan wrote: > I've discussed offline with @hubert.reinterpretcast and agree with him that > with the addition of fexec-charset support, the set of characters deemed > prin

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

sammccall accepted this revision. sammccall added a comment. Still LG once you're happy Comment at: clang/include/clang/Sema/Sema.h:3026 + void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc, + ExprResult DefaultArg);

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16876 + // other types. + if (CodePoint <= UCHAR_MAX) { +StringRef Escaped = escapeCStyle(CodePoint); cor3ntin wrote: > hubert.reinterpretcast wrote: > > For types othe

[clang] a16104e - [Option] Add "Visibility" field and clone the OptTable APIs to use it

Author: Justin Bogner Date: 2023-08-14T13:24:54-07:00 New Revision: a16104e6da6f36f3d72dbf53d10ba56495a0d65a URL: https://github.com/llvm/llvm-project/commit/a16104e6da6f36f3d72dbf53d10ba56495a0d65a DIFF: https://github.com/llvm/llvm-project/commit/a16104e6da6f36f3d72dbf53d10ba56495a0d65a.diff

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa16104e6da6f: [Option] Add "Visibility" field and clone the OptTable APIs to use it (authored by bogner). Repository: rG LLVM Github Monorepo CHA

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 updated this revision to Diff 550067. qiongsiwu1 added a comment. Fixing method parameter name format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst clan

[clang] 4e3b894 - Revert "[Option] Add "Visibility" field and clone the OptTable APIs to use it"

Author: Justin Bogner Date: 2023-08-14T13:31:02-07:00 New Revision: 4e3b89483a6922d3f48670bb1c50a37f342918c6 URL: https://github.com/llvm/llvm-project/commit/4e3b89483a6922d3f48670bb1c50a37f342918c6 DIFF: https://github.com/llvm/llvm-project/commit/4e3b89483a6922d3f48670bb1c50a37f342918c6.diff

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157326/new/ https://reviews.llvm.org/D157326

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157374/new/ https://reviews.llvm.org/D157374 _

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

efriedma added a comment. RecordDecl::hasFlexibleArrayMember() is supposed to reflect the standard's definition of a flexible array member, which only includes incomplete arrays. The places that care about other array members use separate checks. We wouldn't want to accidentally extend the no

[clang] 9e11d68 - Improve reliability of CompilationDatabaseTest

Author: Ellis Hoag Date: 2023-08-14T13:46:21-07:00 New Revision: 9e11d6850a5a5a3518f300769724a5c13d2e6ec6 URL: https://github.com/llvm/llvm-project/commit/9e11d6850a5a5a3518f300769724a5c13d2e6ec6 DIFF: https://github.com/llvm/llvm-project/commit/9e11d6850a5a5a3518f300769724a5c13d2e6ec6.diff LO

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e11d6850a5a: Improve reliability of CompilationDatabaseTest (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157497: feat: Migrate isArch16Bit

bulbazord added a comment. In D157497#4586165 , @MaskRay wrote: > In D157497#4584621 , @Pivnoy wrote: > >> This discussion was the main motivation for this change. >> https://discourse.llvm.org/t/rfc-refactor-trip

[clang] 11f3286 - [clang] Add aliasee field to AliasAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:40+02:00 New Revision: 11f3286585ce86df8107617536226dea24e74d94 URL: https://github.com/llvm/llvm-project/commit/11f3286585ce86df8107617536226dea24e74d94 DIFF: https://github.com/llvm/llvm-project/commit/11f3286585ce86df8107617536226dea24e74d94.d

[clang] 903e530 - [clang] Add cleanup_function field to CleanupAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 903e530bb8980a3c30ea5eb98d2ec1cd61d94b57 URL: https://github.com/llvm/llvm-project/commit/903e530bb8980a3c30ea5eb98d2ec1cd61d94b57 DIFF: https://github.com/llvm/llvm-project/commit/903e530bb8980a3c30ea5eb98d2ec1cd61d94b57.d

[clang] 3dadc29 - [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 3dadc290b21018d528bd6e46d8d596e1dbb68f3d URL: https://github.com/llvm/llvm-project/commit/3dadc290b21018d528bd6e46d8d596e1dbb68f3d DIFF: https://github.com/llvm/llvm-project/commit/3dadc290b21018d528bd6e46d8d596e1dbb68f3d.d

[clang] 4cf7666 - [clang] Add missing field to SectionAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 4cf7666b8f0962a21ab06769254391f633f07d1d URL: https://github.com/llvm/llvm-project/commit/4cf7666b8f0962a21ab06769254391f633f07d1d DIFF: https://github.com/llvm/llvm-project/commit/4cf7666b8f0962a21ab06769254391f633f07d1d.d

[clang] 2107d87 - [clang] Add missing field to VisibilityAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 2107d87c5a9103ffc4c0f76fc00ab203603f9df1 URL: https://github.com/llvm/llvm-project/commit/2107d87c5a9103ffc4c0f76fc00ab203603f9df1 DIFF: https://github.com/llvm/llvm-project/commit/2107d87c5a9103ffc4c0f76fc00ab203603f9df1.d

[clang] 2105c32 - [clang] Add missing field to TLSModelAttr json AST dump

Author: serge-sans-paille Date: 2023-08-14T22:59:45+02:00 New Revision: 2105c32b32bf3360f524f1f3a1e5af605821eff8 URL: https://github.com/llvm/llvm-project/commit/2105c32b32bf3360f524f1f3a1e5af605821eff8 DIFF: https://github.com/llvm/llvm-project/commit/2105c32b32bf3360f524f1f3a1e5af605821eff8.d

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11f3286585ce: [clang] Add aliasee field to AliasAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG903e530bb898: [clang] Add cleanup_function field to CleanupAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dadc290b210: [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump (authored by serge-sans-paille). Repository: rG LLVM Gith

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf7666b8f09: [clang] Add missing field to SectionAttr json AST dump (authored by serge-sans-paille). Changed prior to commit: https://reviews.llv

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550079. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-fea

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2107d87c5a91: [clang] Add missing field to VisibilityAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2105c32b32bf: [clang] Add missing field to TLSModelAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 550083. fakepaper56 added a comment. Update docs/RISCVUsage.rst to move zicfiss to experimental extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files:

[PATCH] D157917: clang/HIP: Use abs builtins instead of implementing them

arsenm created this revision. arsenm added reviewers: yaxunl, AlexVlx, JonChesterfield, jhuber6, doru1004. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. InstCombine already put these back together so there's no visible change in the -O1 tes

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

fakepaper56 updated this revision to Diff 550089. fakepaper56 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 550091. iana marked 3 inline comments as done. iana added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h c

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/lib/Headers/stddef.h:16 +defined(__need_wint_t) || \ +(defined(__STDC_WANT_LIB_EXT1__) && __STDC_WANT_LIB_EXT1__ >= 1)

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. > calling device functions via their associated host pointer What does this mean? Defining a function foo such that the host and each individual target each have their own machine code for it, such that &foo can be copied over to the target and then invoked to m

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 added a comment. In D157738#4586465 , @JonChesterfield wrote: >> calling device functions via their associated host pointer > > What does this mean? Defining a function foo such that the host and each > individual target each have their own mach

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commi

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie updated this revision to Diff 550097. dblaikie added a comment. Diagnose specific reasons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 Files: clang/include/clang/AST/Type.h clang/include/c

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) rnk wrote: > efriedma wrote: > > dblaikie wrote: > > > efriedma wrot

<    1   2   3   >