awarzynski marked 2 inline comments as done. awarzynski added a comment. Thank you all for reviewing!
In D157837#4584387 <https://reviews.llvm.org/D157837#4584387>, @bogner wrote: > I can't speak to which flags should be present in flang-new or not That's determined by what's tested/used in tests. > You'll need to update the patch to use the "ClangOption" spelling rather than > "Default" of course, as discussed in https://reviews.llvm.org/D157151 Yup, no problem. I may wait for your changes to land first. ================ Comment at: flang/test/Driver/target-cpu-features.f90:14 ! Negative test. ARM cpu with x86 target. -! RUN: not %flang --target=x86_64-linux-gnu -mcpu=cortex-a57 -c %s -### 2>&1 \ +! RUN: %flang --target=x86_64-linux-gnu -mcpu=cortex-a57 -c %s -### 2>&1 \ ! RUN: | FileCheck %s -check-prefix=CHECK-NO-A57 ---------------- tblah wrote: > Why doesn't this fail now? Missing `TargetSpecific` flag in the definition of the `mcpu_EQ` option. Sorry i didn't have time to debug earlier. To be fixed in the next revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
