[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie updated this revision to Diff 549206. dblaikie added a comment. Add a warning for MSVC pragma inconsistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 Files: clang/include/clang/AST/Type.h

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) efriedma wrote: > dblaikie wrote: > > rnk wrote: > > > rsmith wrote:

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

dblaikie added a comment. @rnk & I figured that the user probably isn't relying on this much - if they cared about a particular variable, they could use an attribute instead of a pragma. The pragma just being about "put all my const things over here and all my non-const things over there" - bug

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157584/new/ https://reviews.llvm.org/D157584 _

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 549232. void added a comment. Update to more match Qing's GCC implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

MaskRay updated this revision to Diff 549233. MaskRay retitled this revision from "[Driver] Default riscv*-linux* to -fdebug-default-version=4" to "[Driver] Default riscv*- triples to -fdebug-default-version=4". MaskRay edited the summary of this revision. MaskRay added a comment. Thanks for men

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter marked an inline comment as done. ccotter added a comment. @PiotrZSL would you mind landing this for me? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[clang] 33e3b2c - Fix assertion when -fasy-exception is used.

Author: Jennifer Yu Date: 2023-08-10T21:54:32-07:00 New Revision: 33e3b2c46084bc47ef4067ed487b24b58934d044 URL: https://github.com/llvm/llvm-project/commit/33e3b2c46084bc47ef4067ed487b24b58934d044 DIFF: https://github.com/llvm/llvm-project/commit/33e3b2c46084bc47ef4067ed487b24b58934d044.diff L

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e3b2c46084: Fix assertion when -fasy-exception is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added a comment. Please update docs/RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 549251. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-fea

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Comment at: clang/test/AST/Interp/literals.cpp:1047 - // expected-warning {{variable length array folded to constant array}} -} Ignore this block, that's just from rebasing. CHANGES SINCE LAST ACT

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; cor3ntin wrote: > Shouldn't that

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, I am OK with that, actually our downstream toolchain has downgrade the dwarf version to 4 too, because binutils/gdb not well support before... Repository: rG LLVM Github Monor

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

fakepaper56 updated this revision to Diff 549262. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-target-fea

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

eopXD added a comment. Sorry, my previous comment was wrong. Please allow me to correct myself here. --- I went through the v-spec again, it says that: > The vslide1up instruction places the x register argument at location 0 of the > destination vector register group, provided that element 0 i

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc added a comment. > I still think that modifying the generated test cases is needed. If you find > it tedious, may I open up a revision that resolves the problem while adding > you as co-author since you gave this problem the first try? @eopXD Yeah, it's OK! I will hand over the work to y

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

eopXD added a comment. You do agree with my latest comment that `long` is the righteous fix, right? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157476/new/ https://reviews.llvm.org/D157476 ___ cfe-c

[clang] ac2af81 - [clang][doc][RISCV][LoongArch] Remove release notes for changes backported to 17.0.x

Author: Alex Bradbury Date: 2023-08-10T08:14:38+01:00 New Revision: ac2af811a0b864df0089b454b61d484bfc1ad108 URL: https://github.com/llvm/llvm-project/commit/ac2af811a0b864df0089b454b61d484bfc1ad108 DIFF: https://github.com/llvm/llvm-project/commit/ac2af811a0b864df0089b454b61d484bfc1ad108.diff

[clang] b56ab41 - Revert "[clang][Interp] Basic support for bit fields"

Author: Timm Bäder Date: 2023-08-10T09:17:07+02:00 New Revision: b56ab41d54e6beb17c06eefbfcf306af2c4d8107 URL: https://github.com/llvm/llvm-project/commit/b56ab41d54e6beb17c06eefbfcf306af2c4d8107 DIFF: https://github.com/llvm/llvm-project/commit/b56ab41d54e6beb17c06eefbfcf306af2c4d8107.diff LO

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. clang-format is complaining in the pre-merge CI. Comment at: clang/test/lit.cfg.py:391 if "system-aix" in config.available_features: -config.substitutions.append(("llvm-nm", "env OBJECT_MODE=any llvm-nm")) -config.substitutions.append(("llvm

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49e0495 - [Clang] Produce a warning instead of an error in unevaluated strings before C++26

Author: Corentin Jabot Date: 2023-08-10T09:43:20+02:00 New Revision: 49e0495febec5b88dcbc3c0a8814441e207bd608 URL: https://github.com/llvm/llvm-project/commit/49e0495febec5b88dcbc3c0a8814441e207bd608 DIFF: https://github.com/llvm/llvm-project/commit/49e0495febec5b88dcbc3c0a8814441e207bd608.diff

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

jacquesguan updated this revision to Diff 548903. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl, Patryk27. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes bug https://g

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

CuriousGeorgiy added a comment. @MitalAshok > Instead of checking for hard-coded names, you can check functions with the > format(printf, x, y) attribute @NoQ pointed out this is too generic, and we should go for a case-by-case approach. > You also have to check for pointer types first. This

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

CuriousGeorgiy added a comment. @NoQ thank you for the feedback too! > So if you want to support non-standard functions, and you know that they have > the same portability issues, totally go for it! AFAIC, the functions I listed are very exotic, so I would rather skip them. > Probably a separa

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548916. strimo378 added a comment. Added more test cases and considering __declspec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157394/new/ https://reviews.llvm.org/D157394 Files: clang/lib/AST/DeclPrint

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:267 +// C2x/C++11-style attributes must appear before the declarator. +if (S == Attr::AS_CXX11 || S == Attr::AS_C2x) + return AttrLocation::BeforeDecl; strimo378 wrote: > giul

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157586/new/ https://reviews.llvm.org/D157586 _

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 added a comment. A better fix is https://reviews.llvm.org/D157584 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157586/new/ https://reviews.llvm.org/D157586 ___ cfe-commits mailing list cfe-com

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

awarzynski accepted this revision. awarzynski added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 ___ cfe-commits mailing list cfe-com

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc added a comment. In D157476#4575656 , @eopXD wrote: > You do agree with my latest comment that `long` is the righteous fix, right? > :) Oh sorry, somwhow I missed it. I still think that using the element type is the right way. Because user will

[clang] f808788 - [RISCV] Remove experimental for zihintntl

Author: Jianjian GUAN Date: 2023-08-10T17:04:49+08:00 New Revision: f808788487ab9db7da262a0b43483fb07bf6b50f URL: https://github.com/llvm/llvm-project/commit/f808788487ab9db7da262a0b43483fb07bf6b50f DIFF: https://github.com/llvm/llvm-project/commit/f808788487ab9db7da262a0b43483fb07bf6b50f.diff

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf808788487ab: [RISCV] Remove experimental for zihintntl (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a2684f7 - [RISCV][NFC] Use named arguments in newly added changes

Author: wangpc Date: 2023-08-10T17:14:13+08:00 New Revision: a2684f76204c2577d31c4db8b84558ba9150db0a URL: https://github.com/llvm/llvm-project/commit/a2684f76204c2577d31c4db8b84558ba9150db0a DIFF: https://github.com/llvm/llvm-project/commit/a2684f76204c2577d31c4db8b84558ba9150db0a.diff LOG: [

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2684f76204c: [RISCV][NFC] Use named arguments in newly added changes (authored by wangpc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. I have been misunderstanding the problem the whole time. I see the clear solution you have right now. No changes in the spec / test cases are needed. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

hazohelet added a comment. In D156604#4572994 , @tbaeder wrote: > While both of those suggestions are probably improvements (I haven't > checked), they also seem out of scope for this patch. This is just adding > source ranges. We can improve them later

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 548941. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h flang/lib/F

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Add a new `emitPrimCast` helper function and us

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal added a comment. I haven't gone deep into the implementation, but by only looking at the quality of the code and the structure I assume it implements the right behavior. I've checked the tests though, and they look good. I only found irrelevant nits. Awesome work. --- Have you consider

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 548948. hazohelet marked 2 inline comments as done. hazohelet added a comment. Address comments from Aaron - Use hex code for integer representation of textual types - NFC stylistic changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 548950. victorkingi added a comment. Removed false argument to ProcessWarningOption function to allow warning printing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D15

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2320-2321 +: public OMPClause, + private llvm::TrailingObjects { + OMPClause *MemoryOrderClause; Why need tail-allocation here for constant number of attributes? They can

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM with a few cosmetic suggestions. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4772 +QualType FinalTy = Context.getQualifiedType(IntTy, Quals); +Ty

[clang] e5a524b - Revert "Revert "[Flang][Sema] Move directive sets to a shared location""

Author: Sergio Afonso Date: 2023-08-10T11:54:45+01:00 New Revision: e5a524b8b5e9d11fbb12ad8ed9b2d998e05e6119 URL: https://github.com/llvm/llvm-project/commit/e5a524b8b5e9d11fbb12ad8ed9b2d998e05e6119 DIFF: https://github.com/llvm/llvm-project/commit/e5a524b8b5e9d11fbb12ad8ed9b2d998e05e6119.diff

[PATCH] D157493: Revert "Revert "[Flang][Sema] Move directive sets to a shared location""

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5a524b8b5e9: Revert "Revert "[Flang][Sema] Move directive sets to a shared location"" (authored by skatrak). Changed prior to commit: https://reviews.llvm.org/D157493?vs=548561&id=548962#toc Repositor

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 updated this revision to Diff 548964. strimo378 added a comment. Added test cases and applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 Files: clang/lib/AST/TextNodeDump

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Thanks for the feedback! I will resolve the problems in the next revision after some clarifications. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2697 +bool SanitizeBuiltin = SanOpts.has(SanitizerKind::Builtin); +bool SanitizeOverflow = SanOpts.ha

[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

MattDevereau updated this revision to Diff 548965. MattDevereau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. @sdesmalen I had to make an additional changes to `clang/lib/Basic/Targets/AArch64.cpp` and `clang/test/CodeGen/aarch64-sve-inline-asm-datatypes

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. I added a test case for demonstrating `NoexceptExpr` and `Exceptions` output. I don't know how to produce a FunctionProtoType output with ExceptionSourceDecl and ExceptionSourceTemplate. typedef/using is the only way I know to output types for the current AST dump and

[clang] 151214b - Silently accept -Wgnu-empty-initializer

Author: Aaron Ballman Date: 2023-08-10T07:24:05-04:00 New Revision: 151214b40d869455666ca76548a9e3ad639f79de URL: https://github.com/llvm/llvm-project/commit/151214b40d869455666ca76548a9e3ad639f79de DIFF: https://github.com/llvm/llvm-project/commit/151214b40d869455666ca76548a9e3ad639f79de.diff

[PATCH] D157503: Silently accept -Wgnu-empty-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG151214b40d86: Silently accept -Wgnu-empty-initializer (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157503/new/ https://reviews

[clang] 6e13e3c - [Flang][Driver] Enable Rpass and other R family options.

Author: Victor Kingi Date: 2023-08-10T12:37:28+01:00 New Revision: 6e13e3c3e5e29ec0757370e354ed5e62147e47c7 URL: https://github.com/llvm/llvm-project/commit/6e13e3c3e5e29ec0757370e354ed5e62147e47c7 DIFF: https://github.com/llvm/llvm-project/commit/6e13e3c3e5e29ec0757370e354ed5e62147e47c7.diff

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e13e3c3e5e2: [Flang][Driver] Enable Rpass and other R family options. (authored by Victor Kingi , committed by kiranchandramohan). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing lis

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

kadircet added a comment. Hi! After this patch clang seems to be crashing on: class a { static c a; void b(){a}; }; with stack trace and assertion error: $ ~/repos/llvm/build/bin/clang -xc++ repro.cc repro.cc:2:10: error: unknown type name 'c' 2 | static c a; |

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4575056 , @hubert.reinterpretcast wrote: > In D153701#4563919 , @yronglin > wrote: > >> The gap between these two numbers is very large. So I'think we can create >> addition

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

aaron.ballman added a comment. In D154503#4576393 , @kadircet wrote: > Hi! > > After this patch clang seems to be crashing on: > > class a { > static c a; > void b(){a}; > }; > > with stack trace and assertion error: > > $ ~/repos/llvm/build

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 4 inline comments as done. donat.nagy added a comment. Thanks for the suggestions, I answered those where I had something to say and I'll implement the rest of them. In D156312#4576120 , @steakhal wrote: > Have you considered checking

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

kadircet added a comment. In D154503#4576442 , @aaron.ballman wrote: > I'm not opposed to a revert if this is causing problems for your downstream, > but be sure to also remove the changes from the 17.x branch if you go this > route rather than fixing

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. This feels a bit more like a functional change than a non-functional change because it seems like we should be able to test this case (whereas, if we think `TC` can never be n

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

aaron.ballman added a comment. In D154503#4576475 , @kadircet wrote: > In D154503#4576442 , @aaron.ballman > wrote: > >> I'm not opposed to a revert if this is causing problems for your downstream, >> but be sur

[clang] 7d259b3 - Revert "[Sema] Fix handling of functions that hide classes"

Author: Kadir Cetinkaya Date: 2023-08-10T14:06:00+02:00 New Revision: 7d259b36d2e8148d13087844e6494ad3a5c63edf URL: https://github.com/llvm/llvm-project/commit/7d259b36d2e8148d13087844e6494ad3a5c63edf DIFF: https://github.com/llvm/llvm-project/commit/7d259b36d2e8148d13087844e6494ad3a5c63edf.dif

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder updated this revision to Diff 548985. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157596/new/ https://reviews.llvm.org/D157596 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/floats.cpp Index: clang/test/AST/In

[PATCH] D157606: [C2x] Support -std=c23 and -std=gnu23

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, jyknight, efriedma, hubert.reinterpretcast, cor3ntin. Herald added subscribers: kadircet, arphaman. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang, cla

[clang] 042abb4 - [clang] Move the Clang CI jobs off of the libc++ builders

Author: Louis Dionne Date: 2023-08-10T08:29:01-04:00 New Revision: 042abb477c3ff880ea66b36d81388eae05b0f457 URL: https://github.com/llvm/llvm-project/commit/042abb477c3ff880ea66b36d81388eae05b0f457 DIFF: https://github.com/llvm/llvm-project/commit/042abb477c3ff880ea66b36d81388eae05b0f457.diff

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

This revision was automatically updated to reflect the committed changes. Closed by commit rG042abb477c3f: [clang] Move the Clang CI jobs off of the libc++ builders (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ htt

[PATCH] D157331: [clang] Implement C23

aaron.ballman added a comment. In D157331#4575224 , @ZijunZhao wrote: > Another followup question: I check > https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2683.pdf and I only add > Core Proposal here. Do I need to add Supplemental Proposal, like som

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D155383#4576302 , @strimo378 wrote: > I added a test case for demonstrating `NoexceptExpr` and `Exceptions` output. > I don't know ho

[clang] 5a3753f - [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

Author: wangpc Date: 2023-08-10T20:41:44+08:00 New Revision: 5a3753f35632f8fd7920c5c99b1237113b5c435e URL: https://github.com/llvm/llvm-project/commit/5a3753f35632f8fd7920c5c99b1237113b5c435e DIFF: https://github.com/llvm/llvm-project/commit/5a3753f35632f8fd7920c5c99b1237113b5c435e.diff LOG: [

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a3753f35632: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet (authored by wangpc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157476/new/ http

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549000. victorkingi added a comment. Added warning tests in optimization-remark.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/F

[clang] d03f417 - [clang] Drop some references to typed pointers (getInt8PtrTy). NFC

Author: Bjorn Pettersson Date: 2023-08-10T15:07:06+02:00 New Revision: d03f4177dfbb6a910edde31acd0f14786b549bad URL: https://github.com/llvm/llvm-project/commit/d03f4177dfbb6a910edde31acd0f14786b549bad DIFF: https://github.com/llvm/llvm-project/commit/d03f4177dfbb6a910edde31acd0f14786b549bad.di

[PATCH] D157550: [clang] Drop some references to typed pointers (getInt8PtrTy). NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd03f4177dfbb: [clang] Drop some references to typed pointers (getInt8PtrTy). NFC (authored by bjope). Repository: rG LL

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4574797 , @MaskRay wrote: > In D155290#4572965 , @qiongsiwu1 > wrote: > >> Ping for review. >> >> If there are no comments on whether we should add `-lpthread` for platforms

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo created this revision. Herald added subscribers: PiotrZSL, kadircet, carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/records.cpp:509-512 + constexpr A *a2 = &b + 1; // expected-error {{must be initialized by a constant expression}} \ +// expected-note {{cannot access base class of pointer past the e

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4571435 , @vitalybuka wrote: >> Thanks! We might need someone from clangd to help here. The logs do not have >> any information explaining what's failing with the test, and looking at the >> test code, I strugg

[PATCH] D157606: [C2x] Support -std=c23 and -std=gnu23

cor3ntin added a comment. `Options.td` defines: `defvar c2x = LangOpts<"C2x">;` Does this need change as well? `UsersManual.rst` also needs an update, but that can be another patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157606/new/ https:/

[PATCH] D157606: [C2x] Support -std=c23 and -std=gnu23

aaron.ballman added a comment. In D157606#4576694 , @cor3ntin wrote: > `Options.td` defines: > `defvar c2x = LangOpts<"C2x">;` > > Does this need change as well? > > `UsersManual.rst` also needs an update, but that can be another patch Both of those chan

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. In D157554#4576478 , @aaron.ballman wrote: > This feels a bit more like a functional change than a non-functional change > because it seems like we should be able to test this case (whereas, if we > think `TC` can never be nul

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. (Whoops, somehow never got a mail for that reply) Yes, please. You can attribute the commit to "fridtjof " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 ___ cfe-commits m

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Seems like a straightforward extension, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157104/new/ https://reviews.llvm.org/D157104

[PATCH] D157606: [C2x] Support -std=c23 and -std=gnu23

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Fair enough! the rest looked sensible to me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157606/new/ https://reviews.llvm.org/D157606 _

[PATCH] D157613: [Clang][ExtendLifetimes][3/4] Add -fextend-lifetimes flag to Clang to extend the lifetime of local variables

StephenTozer created this revision. StephenTozer added reviewers: dblaikie, aprantl, echristo. StephenTozer added a project: debug-info. Herald added a reviewer: aaron.ballman. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: cfe-commits, MaskRa

[PATCH] D157618: [Clang][ExtendLifetimes][4/4] Add extend_lifetimes pragma to Clang to selectively disable -fextend-lifetimes for functions

StephenTozer created this revision. StephenTozer added reviewers: dblaikie, aprantl, echristo. StephenTozer added a project: debug-info. Herald added a reviewer: aaron.ballman. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: cfe-commits, wangpc

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

tbaeder added a comment. Generally LGTM, but the `erase` call could do with a comment before. And I'll let someone with more concepts experience handle whether this should be accepted or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157526/ne

[PATCH] D157619: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Create a new `getOrCreateFunction()` in `Context`, so

<    1   2