[PATCH] D156212: [clang][Interp] Implement remaining strcmp builtins

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

cor3ntin added a comment. In D156053#4531015 , @kiloalphaindia wrote: > The test is no more using any includes now. Hopefully this fixes it, > otherwise I will have to add something that prints the diagnostic. > > I don't have write permissions on the r

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is already merged, any more advice about this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

cor3ntin added a comment. This looks reasonable to me know. should we try to land that today? Sorry i could not get to it earlier! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

kiloalphaindia added a comment. Please use Kai Stierand as in 5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 ___

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder updated this revision to Diff 543854. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155394/new/ https://reviews.llvm.org/D155394 Files: clang/lib/AST/Interp/Floating.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

donat.nagy added a comment. Mostly LGTM, but I'd like to ask you to ensure consistent line wrapping (to e.g. 72 or 80 characters) in the free-flowing text that was added or rewritten by this commit. (I know that this is a minor question because the linebreaks won't be visible in the final outpu

[clang] fae7b98 - [Support] Change SetVector's default template parameter to SmallVector<*, 0>

Author: Fangrui Song Date: 2023-07-25T00:39:17-07:00 New Revision: fae7b98c221b5b28797f7b56b656b6b819d99f27 URL: https://github.com/llvm/llvm-project/commit/fae7b98c221b5b28797f7b56b656b6b819d99f27 DIFF: https://github.com/llvm/llvm-project/commit/fae7b98c221b5b28797f7b56b656b6b819d99f27.diff

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 543857. fakepaper56 added a comment. Fix bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; Initializer could indirectly depends on this field and set

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155270/new/ https://reviews.llvm.org/D155270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155548/new/ https://reviews.llvm.org/D155548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155572/new/ https://reviews.llvm.org/D155572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp updated this revision to Diff 543862. dkrupp added a comment. -lines wrapped to 80 characters CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145229/new/ https://reviews.llvm.org/D145229 Files: clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/checkers.rst ===

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

carlosgalvezp added a comment. Do we want to keep the `experimental` word in the flag? Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:266 +static cl::opt EnableModuleHeadersParsing("enable-module-headers-parsing", +

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

xen0n added a comment. Thank you (and your team, and of course other friends) for all your work this cycle! Comment at: llvm/docs/ReleaseNotes.rst:202-203 +* Adds assembler/disassembler support for the ``LSX``, ``LASX``, ``LVZ`` and + ``LBT`` ISA extensions. * The ``lp64s`

[PATCH] D156184: [OpenMP] Add the `ompx_attribute` clause for target directives

antmo added a comment. Hi, it looks like this patch broke some flang bots: - https://lab.llvm.org/buildbot/#/builders/176/builds/3408 - https://lab.llvm.org/buildbot/#/builders/198/builds/4028 - https://lab.llvm.org/buildbot/#/builders/197/builds/8491 - https://lab.llvm.org/buildbot/#/builders/19

[clang] 9dcd232 - [clang][driver][NFC] Call IsARMBigEndain function only for isARM and isThumb.

Author: Simi Pallipurath Date: 2023-07-25T09:20:59+01:00 New Revision: 9dcd232f4afabdad46e5bc2d71834765acd7738c URL: https://github.com/llvm/llvm-project/commit/9dcd232f4afabdad46e5bc2d71834765acd7738c DIFF: https://github.com/llvm/llvm-project/commit/9dcd232f4afabdad46e5bc2d71834765acd7738c.di

[PATCH] D155808: [clang][driver][NFC] Call IsARMBigEndain function only for isARM and isThumb.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dcd232f4afa: [clang][driver][NFC] Call IsARMBigEndain function only for isARM and isThumb. (authored by simpal01). Repository: rG LLVM Github Mon

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. In D151547#4531062 , @jacquesguan wrote: > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is already merged, > any more advice about this patch? Just that it needs a release note, and we need the newly defined overloaded

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN: llvm-nm --print-armap t_X32.a 2>&1 | FileCheck -

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 added a comment. I think we are vearing into somewhat uncharted territory here, but we should probably push forward and document the direction we choose. Should `-shared` modules also link with `crt1-reactor.o` by default then? Or should we add `crt1-shared.o` and use the whenever `-sh

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

imkiva created this revision. imkiva added a reviewer: craig.topper. imkiva added a project: LLVM. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer0

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:20 + +struct NotExtendedByDeclBoundToPredicate { + bool operator()(const internal::BoundNodesMap &Nodes) const { A comment might be good

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

SixWeining updated this revision to Diff 543867. SixWeining added a comment. Herald added a reviewer: alexander-shaposhnikov. Address @xen0n's comments and add some more recordable updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156195/new/

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:266 +static cl::opt EnableModuleHeadersParsing("enable-module-headers-parsing", +desc(R"( carlosgalvezp wrote: > --e

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt added a comment. > Should -shared modules also link with crt1-reactor.o by default then? Or > should we add crt1-shared.o and use the whenever -shared is passed. Should we > also make -shared incompatible with -mexec-model? It seems like -mexec-model > should only apply to the main module,

[clang] 86da763 - [Clang] Fix crash in CIndex, when visiting a static_assert without message

Author: Kai Stierand Date: 2023-07-25T10:53:14+02:00 New Revision: 86da763ab6ed19c58349d3f6f62d4bb52becab2c URL: https://github.com/llvm/llvm-project/commit/86da763ab6ed19c58349d3f6f62d4bb52becab2c DIFF: https://github.com/llvm/llvm-project/commit/86da763ab6ed19c58349d3f6f62d4bb52becab2c.diff

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && The current heuristic results in the following: ``` struct Base { void foo(int); }; struct Derived : Base { voi

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86da763ab6ed: [Clang] Fix crash in CIndex, when visiting a static_assert without message (authored by kiloalphaindia, committed by cor3ntin). Repos

[clang] 4cf11d8 - [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

Author: David Sherwood Date: 2023-07-25T08:55:45Z New Revision: 4cf11d8a65dfded59761ec52804a86277b9c0036 URL: https://github.com/llvm/llvm-project/commit/4cf11d8a65dfded59761ec52804a86277b9c0036 DIFF: https://github.com/llvm/llvm-project/commit/4cf11d8a65dfded59761ec52804a86277b9c0036.diff LOG

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf11d8a65df: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly (authored by david-arm). Repository: rG LLVM Github M

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

SixWeining updated this revision to Diff 543876. SixWeining added a comment. Move sanitizer changes to clang side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156195/new/ https://reviews.llvm.org/D156195 Files: clang/docs/ReleaseNotes.rst ll

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156195/new/ https://reviews.llvm.org/D156195

[clang] 6223050 - [docs] Add llvm & clang release notes for LoongArch

Author: Weining Lu Date: 2023-07-25T17:06:12+08:00 New Revision: 6223050db88bc5b41c13a593de67554d1e3b72ae URL: https://github.com/llvm/llvm-project/commit/6223050db88bc5b41c13a593de67554d1e3b72ae DIFF: https://github.com/llvm/llvm-project/commit/6223050db88bc5b41c13a593de67554d1e3b72ae.diff LO

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6223050db88b: [docs] Add llvm & clang release notes for LoongArch (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

imkiva updated this revision to Diff 543890. imkiva added a comment. Removed some tests that used `e` together with `f` or `d` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156214/new/ https://reviews.llvm.org/D156214 Files: clang/test/Driver/ri

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > should we try to land that today? I'm not sure. It causes failures in libc++ testing: Failed Tests (3): llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp llvm-libc++-shared.cfg.in :: std/ranges/range.access/rbegin.pass.cpp llvm-libc++-sh

[clang] 3d83912 - Revert rGfae7b98c221b5b28797f7b56b656b6b819d99f27 "[Support] Change SetVector's default template parameter to SmallVector<*, 0>"

Author: Simon Pilgrim Date: 2023-07-25T10:22:08+01:00 New Revision: 3d83912c0c7be63d24e54792b300f394931a363b URL: https://github.com/llvm/llvm-project/commit/3d83912c0c7be63d24e54792b300f394931a363b DIFF: https://github.com/llvm/llvm-project/commit/3d83912c0c7be63d24e54792b300f394931a363b.diff

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 543889. sandeepkosuri added a comment. - Added support for `thread_limit` clause on relevant combined directives which begin with `target` as per @ABataev 's comments. - Added additional LIT test cases to check codegen of the `thread_limit` on the newl

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

wangpc added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. I think the comment is outdated here. `E` can be combined with all

[clang] 4dbe2db - [clang][analyzer] Improved documentation for TaintPropagation Checker

Author: Daniel Krupp Date: 2023-07-25T11:34:11+02:00 New Revision: 4dbe2db02d03ffee27feb43a6ef332ca6a3cbca2 URL: https://github.com/llvm/llvm-project/commit/4dbe2db02d03ffee27feb43a6ef332ca6a3cbca2 DIFF: https://github.com/llvm/llvm-project/commit/4dbe2db02d03ffee27feb43a6ef332ca6a3cbca2.diff

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dbe2db02d03: [clang][analyzer] Improved documentation for TaintPropagation Checker (authored by dkrupp). Repository: rG LLVM Github Monorepo CHA

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

imkiva added a comment. address review comments Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. wangpc wrote: > I think the comment is outdate

[clang] c5a13e2 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-25T02:43:41-07:00 New Revision: c5a13e2c7e4c1769831c99ff2bf9f3690328c3d4 URL: https://github.com/llvm/llvm-project/commit/c5a13e2c7e4c1769831c99ff2bf9f3690328c3d4 DIFF: https://github.com/llvm/llvm-project/commit/c5a13e2c7e4c1769831c99ff2bf9f3690328c

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5a13e2c7e4c: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156133/new/ https://reviews.l

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 543902. SixWeining added a comment. update clang release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 Files: clang/docs/ReleaseNotes.rst clang/lib/Bas

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. TypeLocBu

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2471 + #ifdef __clang_analyzer__ +void csa_mark_sanitized(const void *); + #endif Have you considered unconditionally having this function with an empty body? That way it would hav

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. Overall LGTM except one small nit, thanks! Comment at: clang/docs/ReleaseNotes.rst:902 like GCC does. +- Adds support for the ``-march=native`` and ``-mtune=`` options and t

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

kiloalphaindia created this revision. kiloalphaindia added a reviewer: cor3ntin. Herald added a subscriber: shchenz. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: /home/buildbots/ppc6

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

kiloalphaindia added a comment. See: https://lab.llvm.org/buildbot/#/builders/57/builds/28680 I couldn't reproduce this on my system. Anyone knows how to test it before merging? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://re

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2471 + #ifdef __clang_analyzer__ +void csa_mark_sanitized(const void *); + #endif steakhal wrote: > Have you considered unconditionally having this function with an empty body? > Tha

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 543918. HazardyKnusperkeks marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp cl

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 543919. SixWeining added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 Files: clang/docs/ReleaseNotes.rst clang/lib/Bas

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:39 + ID) { + NotExtendedByDeclBoundToPredicate Predicate; + Predicate.ID = ID; xgupta wrote: > Can be written using direc

[PATCH] D156228: [clang-format][NFCish] Obey debug settings

HazardyKnusperkeks created this revision. HazardyKnusperkeks added a reviewer: klimek. HazardyKnusperkeks added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested r

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added subscribers: gmail.com, Google.com. AMP999 added a comment. BTW my Email in one of my previous patches is inserted incorrectly. I appreciate if you could possibly fix that for me. my Email in this 0fd4175907b40fe63131482c162d7e0f76000521

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

kiloalphaindia added a comment. Also affects: clang-ppc64-aix https://lab.llvm.org/buildbot/#/builders/214/builds/8649 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224 _

[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

atrosinenko added a comment. Sorry for a hung patch. After getting the approval I had doubts that I interpret the corner cases of LLVM IR correctly. Thus, I postponed the patch these days to not subtly break the stable targets while fixing one issue on MSP430. I can re-evaluate this patch if i

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

cor3ntin added a subscriber: aaron.ballman. cor3ntin added a comment. Thanks for the quick fix. Any idea why it would only show up on ppc64 @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

kiloalphaindia added a comment. It could also be a different version of gtest or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224 ___ cfe-commits mailing lis

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

aaron.ballman added a comment. In D156224#4531659 , @cor3ntin wrote: > Thanks for the quick fix. Any idea why it would only show up on ppc64 > @aaron.ballman ? Not certain, to be honest. The diagnostic is enabled by `-Wextra` so I would have imagined t

[clang] d031ff3 - [Sema] Fix handling of functions that hide classes

Author: John Brawn Date: 2023-07-25T12:30:41+01:00 New Revision: d031ff38779bd688c514136dbdcce3169ee82b6e URL: https://github.com/llvm/llvm-project/commit/d031ff38779bd688c514136dbdcce3169ee82b6e DIFF: https://github.com/llvm/llvm-project/commit/d031ff38779bd688c514136dbdcce3169ee82b6e.diff LO

[clang] 71be91e - HIP: Directly call rint builtins

Author: Matt Arsenault Date: 2023-07-25T07:54:11-04:00 New Revision: 71be91eba96d80d15689e4f516141c533c3c086d URL: https://github.com/llvm/llvm-project/commit/71be91eba96d80d15689e4f516141c533c3c086d DIFF: https://github.com/llvm/llvm-project/commit/71be91eba96d80d15689e4f516141c533c3c086d.diff

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. The first version of this that I committed caused a failure in clang/test/Modules/stress1.cpp so I reverted it. I've now committed a new version that handles the removal of existing decl when isPreferredLookupResult is true in a slightly different way, which should

[PATCH] D156229: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that the redundancy between these two classes has been eliminated, these c

[clang] e7ab698 - HIP: Directly call nearbyint builtins

Author: Matt Arsenault Date: 2023-07-25T07:56:31-04:00 New Revision: e7ab6982de87b14c9584e1267cd755561b4c063c URL: https://github.com/llvm/llvm-project/commit/e7ab6982de87b14c9584e1267cd755561b4c063c DIFF: https://github.com/llvm/llvm-project/commit/e7ab6982de87b14c9584e1267cd755561b4c063c.diff

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can break release builds that set `-Werror`

[clang] 0d12683 - Revert "[OpenMP] Add the `ompx_attribute` clause for target directives"

Author: Aaron Ballman Date: 2023-07-25T07:57:36-04:00 New Revision: 0d12683046ca75fb08e285f4622f2af5c82609dc URL: https://github.com/llvm/llvm-project/commit/0d12683046ca75fb08e285f4622f2af5c82609dc DIFF: https://github.com/llvm/llvm-project/commit/0d12683046ca75fb08e285f4622f2af5c82609dc.diff

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I was able to confirm on my machine that the warnings are no longer emitted. They were there when i committed the initial patch, i just missed them. Sorry about that Repository: rG LLV

[PATCH] D156184: [OpenMP] Add the `ompx_attribute` clause for target directives

aaron.ballman added a comment. In D156184#4531193 , @antmo wrote: > Hi, it looks like this patch broke some flang bots: > > - https://lab.llvm.org/buildbot/#/builders/176/builds/3408 > - https://lab.llvm.org/buildbot/#/builders/198/builds/4028 > - https:/

[clang] d0b54bb - [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

Author: Kai Stierand Date: 2023-07-25T13:58:30+02:00 New Revision: d0b54bb50e5110a004b41fc06dadf3fee70834b7 URL: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7 DIFF: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7.diff

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0b54bb50e51: [Clang] use unsigned integer constants in unit-test | fixes build error on… (authored by kiloalphaindia, committed by cor3ntin). Repo

[clang] 4706251 - Clear release notes for 18.x

Author: Tobias Hieta Date: 2023-07-25T13:58:49+02:00 New Revision: 4706251a3186c34da0ee8fd894f7e6b095da8fdc URL: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc DIFF: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc.diff

[clang-tools-extra] 4706251 - Clear release notes for 18.x

Author: Tobias Hieta Date: 2023-07-25T13:58:49+02:00 New Revision: 4706251a3186c34da0ee8fd894f7e6b095da8fdc URL: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc DIFF: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc.diff

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

asb added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. imkiva wrote: > wangpc wrote: > > I think the comment is outdated her

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (if you prefer to keep the named variable, `(void)StructVal2` is also fine) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156230/new/ http

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

aaron.ballman added subscribers: philnik, Mordante, ldionne. aaron.ballman added a comment. In D152003#4531404 , @Fznamznon wrote: >> should we try to land that today? > > I'm not sure. It causes failures in libc++ testing: > > Failed Tests (3): > l

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

asb added a comment. This seems functionally correct to me, but I'd welcome opinions from others who work more with the C intrinsics on if this is the best way to implement the overloading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

kiloalphaindia added a comment. I had copied the warning-flags from the build-bot command line and ended up as follows: -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-lon

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2469-2472 + // User csa_mark_sanitize function is for the analyzer only + #ifdef __clang_analyzer__ +void csa_mark_sanitized(const void *); + #endif I was thinking of this when I

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Feel free to add the comment about the implications of using the flag in the docs. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:270 +f

[clang] 73105a5 - HIP: Fix broken version check for deprecated macro

Author: Matt Arsenault Date: 2023-07-25T08:36:19-04:00 New Revision: 73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3 URL: https://github.com/llvm/llvm-project/commit/73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3 DIFF: https://github.com/llvm/llvm-project/commit/73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3.diff

[clang] 18914f7 - OpenMP: Fix broken c++ mode comment

Author: Matt Arsenault Date: 2023-07-25T08:36:19-04:00 New Revision: 18914f795523b7099cad0cf16ac4cd062ac998d4 URL: https://github.com/llvm/llvm-project/commit/18914f795523b7099cad0cf16ac4cd062ac998d4 DIFF: https://github.com/llvm/llvm-project/commit/18914f795523b7099cad0cf16ac4cd062ac998d4.diff

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:30 + +Clang provides partial HIP support on Intel GPUs using the CHIP-Star project ``_. CHIP-Star implements the HIP runtime over o

[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

cpsughrue created this revision. cpsughrue added reviewers: Bigcheese, jansvoboda11. Herald added a project: All. cpsughrue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow users to run a dependency scan with a cc1 command line in addi

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

mboehme added a comment. Abandoning. Already fixed at head in https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156230/new/ https://reviews.llvm.org/D156230

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 543941. SixWeining added a comment. add missing `.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/

[clang] 92c0611 - [LoongArch] Support -march=native and -mtune=

Author: Weining Lu Date: 2023-07-25T21:01:51+08:00 New Revision: 92c06114b2ea9900a3364fb395988dfb065758f7 URL: https://github.com/llvm/llvm-project/commit/92c06114b2ea9900a3364fb395988dfb065758f7 DIFF: https://github.com/llvm/llvm-project/commit/92c06114b2ea9900a3364fb395988dfb065758f7.diff LO

  1   2   3   4   >