[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao added a subscriber: cor3ntin. rZhBoYao added a comment. BTW, I am not sure if CWG2571 is implemented by @cor3ntin? If so, can we mark it as done on https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles the warning around it tho. CHANGES SINCE L

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added a comment. In D148131#4447426 , @owenpan wrote: > In D148131#4304960 , @jp4a50 wrote: > >> Hey @MyDeveloperDay @owenpan . I'd appreciate if you guys have time to >> consider this change. It's the las

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

aaron.ballman added inline comments. Comment at: clang/unittests/libclang/LibclangTest.cpp:1201 + const char testSource[] = R"cpp( +#include +static constexpr std::string_view message{"Hello World!"}; This is going to be testing whatever STL headers are install

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153969/new/ https://reviews.llvm.org/D153969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. In D156057#4527787 , @rZhBoYao wrote: > BTW, I am not sure if CWG2571 is implemented by > @cor3ntin? If so, can we mark it as done on > https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, but please wait one or two days for other reviewers. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:430 // Granite Rapids microarchitecture based processors

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

kiloalphaindia added a comment. Yes, I think so, too. Will have a look this evening. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new ForwardingDiagnosticConsumer(Compiler.getDiagnos

[PATCH] D156114: [Clang][LoongArch] Pre-commit test for Dxxxxxx

SixWeining created this revision. SixWeining added reviewers: xry111, xen0n, hev, wangleiat. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4527199 , @danlark wrote: > In D155809#4521494 , @rsmith wrote: > >> This looks correct to me, but it's still a little subtle. Perhaps it'd be >> clearer to map the metho

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

david-arm created this revision. david-arm added reviewers: sdesmalen, MattDevereau, hassnaa-arm. Herald added subscribers: ctetreau, psnobl, kristof.beyls. Herald added a reviewer: efriedma. Herald added a project: All. david-arm requested review of this revision. Herald added a project: clang. He

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining created this revision. SixWeining added reviewers: xry111, xen0n, hev, wangleiat. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. SixWeining requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Hera

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4527847 , @aaron.ballman wrote: > In D155809#4527199 , @danlark wrote: > >> In D155809#4521494 , @rsmith wrote: >> >>> This looks corr

[clang] b4a5b61 - [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating temp files

Author: Tony Tao Date: 2023-07-24T09:08:37-04:00 New Revision: b4a5b61d7675521e473c37921a2bdf771fd2bd3e URL: https://github.com/llvm/llvm-project/commit/b4a5b61d7675521e473c37921a2bdf771fd2bd3e DIFF: https://github.com/llvm/llvm-project/commit/b4a5b61d7675521e473c37921a2bdf771fd2bd3e.diff LOG:

[PATCH] D155651: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating temp files

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a5b61d7675: [SystemZ][z/OS] Add OpenFlags to CreateMissingDirectories path when creating… (authored by tltao, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xry111 added a comment. Ooops. These corner cases are really annoying. I think I should try `make check-gcc check-g++ RUNTESTFLAGS='ALT_CC_UNDER_TEST=clang ALT_CXX_UNDER_TEST=clang++ compat.exp'` in GCC test suite... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xry111 accepted this revision. xry111 added a comment. This revision is now accepted and ready to land. The change itself LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/ https://reviews.llvm.org/D156116

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin updated this revision to Diff 543504. cor3ntin added a comment. Add some VLA tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155955/new/ https://reviews.llvm.org/D155955 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rs

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

MattDevereau added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:17 + +void test_sve2p1_asm(void) { + register __SVCount_t x2 asm("pn0"); I think it would be better to keep this test similar to `test_sve_asm` in that it tests both end

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xen0n accepted this revision. xen0n added a comment. So this one is different than D151298 (I'm very glad that those registers are ultimately saved btw), and solves a real problem. Thanks for the timely catch before LLVM 17 ;-) Repository: rG LLVM Github Mo

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked 4 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:201 -/// Models a value of `struct` or `class` type, with a flat map of fields to -/// child storage locations, containing all accessible memb

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:3 +// RUN: -emit-llvm -o - %s | FileCheck %s -check-prefix=CHECK void test_sve_asm(void) { Could you also add a RUN line that compiles this to asm, just to make sure tha

[clang] 44f98d0 - [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

Author: Martin Braenne Date: 2023-07-24T13:20:01Z New Revision: 44f98d0101fe82352e7c5fa98f1b2e9dc1159200 URL: https://github.com/llvm/llvm-project/commit/44f98d0101fe82352e7c5fa98f1b2e9dc1159200 DIFF: https://github.com/llvm/llvm-project/commit/44f98d0101fe82352e7c5fa98f1b2e9dc1159200.diff LOG

[clang] c3cf630 - [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

Author: Martin Braenne Date: 2023-07-24T13:20:04Z New Revision: c3cf630d80a26a3bfc0845592f86e555addce3ca URL: https://github.com/llvm/llvm-project/commit/c3cf630d80a26a3bfc0845592f86e555addce3ca DIFF: https://github.com/llvm/llvm-project/commit/c3cf630d80a26a3bfc0845592f86e555addce3ca.diff LOG

[PATCH] D155813: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3cf630d80a2: [clang][dataflow] Remove checks that test for consistency between `StructValue`… (authored by mboehme). Repository: rG LLVM Github M

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rG44f98d0101fe: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and… (authored by

[PATCH] D156121: [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the offset

sdesmalen created this revision. sdesmalen added reviewers: bryanpkc, CarolineConcatto, dtemirbulatov. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao updated this revision to Diff 543514. rZhBoYao marked an inline comment as done. rZhBoYao added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ https://reviews.llvm.org/D156063 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D156121: [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the offset

bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM. Sorry for not catching this earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156121/new/ https://reviews.llvm.org/D156121 _

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e71bae9 - [clang][dataflow] Fix build failure due to -Wunused-variable in DataflowEnvironment.cpp (NFC)

Author: Jie Fu Date: 2023-07-24T21:35:52+08:00 New Revision: e71bae94b04391cb47680622666d448418c0d972 URL: https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972 DIFF: https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972.diff LOG: [

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 543510. hazohelet marked 4 inline comments as done. hazohelet added a comment. Address comments from Corentin - When emitting "lambda expression may not appear inside of a constant expression" error from `Sema::PopExpressionEvaluationContext`, mark the va

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

tbaeder updated this revision to Diff 543522. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156047/new/ https://reviews.llvm.org/D156047 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp clang/test/SemaCXX/sou

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. In D155539#4524543 , @yaxunl wrote: > In D155539#4524189 , @probinson > wrote: > >> This change to lang-std.cpp causes it not to verify _which_ language >> standard is the default. It

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added inline comments. Comment at: clang/test/SemaCXX/vartemplate-lambda.cpp:17 +// expected-note{{cannot be used in a constant expression}} \ +// expected-e

cfe-commits@lists.llvm.org

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:98-103 +def RC_X86_64_RegCallv4_Win : RC_X86_64_RegCall { + let GPR_8 = [AL, CL, DL, DIL, SIL, R8B, R9B, R11B, R12B, R14B, R15B]; + let GPR_16 = [AX, CX, DX, DI, SI, R8W, R9W, R11W, R12W, R14W, R15W

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao added a comment. Thanks for the reminder. I am aware of that. Browsing through 762672a73a1e and a560ccf2af7a , I believe the indeterminately sequenced requirement is met

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

david-arm updated this revision to Diff 543529. david-arm added a comment. - Addressed review comments on tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156115/new/ https://reviews.llvm.org/D156115 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/CodeGen/aarch64-sve-inlin

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4528094 , @probinson wrote: > In D155539#4524543 , @yaxunl wrote: > >> In D155539#4524189 , @probinson >> wrote: >> >>> This change to

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

kadircet added a comment. FWIW, details of pragma are explained in https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-always_keep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ https

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin updated this revision to Diff 543530. cor3ntin added a comment. Add more Vla tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155955/new/ https://reviews.llvm.org/D155955 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rs

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

danilaml added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1026 + // APValue stores array extents as unsigned, + // so anything that is greater that unsigned would overflow when + // constructing the array, we catch this here. ==

cfe-commits@lists.llvm.org

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:98-103 +def RC_X86_64_RegCallv4_Win : RC_X86_64_RegCall { + let GPR_8 = [AL, CL, DL, DIL, SIL, R8B, R9B, R11B, R12B, R14B, R15B]; + let GPR_16 = [AX, CX, DX, DI, SI, R8W, R9W, R11W, R12W, R14W, R15W

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

ilinpv added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +: DefaultAttrsIntrinsic<[llvm_i

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

madscientist added a comment. (just a note that another way to do this check is to look for some common intrinsic file in each directory generated by the compiler driver, and remove any directory containing those files. But, if the `-print-file-name=include` trick works reliably that's good to

[PATCH] D156093: [ASTImporter] Re-odering by lexical order for all imported decls within record

danix800 updated this revision to Diff 543535. danix800 retitled this revision from "[ASTImporter] Add extra sorting round for keeping lexical order of all imported decls within record" to "[ASTImporter] Re-odering by lexical order for all imported decls within record". danix800 edited the summar

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl created this revision. yaxunl added a reviewer: probinson. Herald added a project: All. yaxunl requested review of this revision. Recover the checking for the default language standard for C++. https://reviews.llvm.org/D156127 Files: clang/test/Preprocessor/lang-std.cpp Index: clang/

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4528137 , @yaxunl wrote: > In D155539#4528094 , @probinson > wrote: > >> In D155539#4524543 , @yaxunl wrote: >> >>> In D155539#4524189

[PATCH] D156128: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

sdesmalen created this revision. sdesmalen added a reviewer: bryanpkc. Herald added a subscriber: kristof.beyls. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo h

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

aaron.ballman added subscribers: thieta, tstellar, clang-vendors. aaron.ballman added a comment. The changes generally seem reasonable to me, but I'm not 100% sure of the impacts of tying this to constexpr steps. That's a vague measure that was used mostly as an escape hatch for recursive conste

[clang] a8cbd27 - [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the offset

Author: Sander de Smalen Date: 2023-07-24T14:29:45Z New Revision: a8cbd27d1f238e104a5d5ca345d93bc1f4d4ab1f URL: https://github.com/llvm/llvm-project/commit/a8cbd27d1f238e104a5d5ca345d93bc1f4d4ab1f DIFF: https://github.com/llvm/llvm-project/commit/a8cbd27d1f238e104a5d5ca345d93bc1f4d4ab1f.diff L

[PATCH] D156121: [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the offset

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8cbd27d1f23: [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the… (authored by sdesmalen). Repository: rG LLVM Github Mono

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

efwright updated this revision to Diff 543540. efwright added a comment. Dropping off a simple test case. If this looks about what you would expect for the tests I have a couple more involved ones that I can repurpose and add in. For more complex tests we have a couple of the benchmark codes fro

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 543545. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new/ https://reviews.llvm.org/D155175 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 543552. ymandel marked 2 inline comments as done. ymandel added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files: clang/include/

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:101-103 +/// groups topologically. As a result, the blocks in a series of loops are +/// ordered such that all nodes in loop `i` are earlier in the order than nodes +/// in loop `

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added a comment. Marking comments as resolved per my reply. I'm not sure if that's best practice! @tahonermann Looking forward to reviews CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming precommit CI finds no surprises. I'm struggling to think of other test cases that would match the changes; if @shafik has tests in mind, we can add them (post-commi

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 543557. oskarwirga added a comment. Properly refactor the code bc my last attempt was flawed -_- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias marked 6 inline comments as done. galenelias added a comment. In D151761#4524653 , @owenpan wrote: > FWIW, I think we can use a shorter name `AlignConsecutiveCaseStatements` > instead of `AlignConsecutiveShortCaseStatements`. My only hesitati

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 543558. galenelias added a comment. Addresses latest review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clan

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543559. rZhBoYao added a comment. Refactor VisitCXXOperatorCallExpr and mark CWG2571 as done in Clang 15 (deliberately the same version P2128R6 was implemented) since this patch only fix the diagnostics around it. CHANGES SINCE LAST ACTION https://revie

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EHScopeSt

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

ymandel added a comment. In D155890#4525144 , @carlosgalvezp wrote: > I have opened a refactoring ticket here: > https://github.com/llvm/llvm-project/issues/64037 Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. > Could you please also add a few tests for `gotol`? Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 ___ cfe-commits ma

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3525 + let Content = [{ +On classes, the ``equality_operator_compares_members_lexicographically`` +attribute informs clang that a call to ``operator==(const T&, const T&)`` is

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543571. victorkingi marked 3 inline comments as done. victorkingi added a comment. minor cleanup - dropped braces on single line if statements - moved opt_record options into [CC1Option, FC1Option, NoDriverOption] Group in clang/include/clang/Driver/Opti

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:166-171 + clang::driver::options::OPT_fno_stack_arrays, false)) opts.StackArrays = 1; - } + if (args.hasFlag(clang::driver::options::OPT_floop_versioning, -

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +// SME-SUBFEATURE-CONFLICT-REV

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:201 -/// Models a value of `struct` or `class` type, with a flat map of fields to -/// child storage locations, containing all accessible members of base struct -/// and class types.

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

MaskRay added a comment. In D155992#4527081 , @kadircet wrote: > thanks for doing this! > > as Sam pointed out this will result in invalidation of all the index shards, > but that's not something new. we already don't clean up non-relevant index > shard

[PATCH] D155808: [clang][driver] Call IsARMBigEndain function only for isARM and isThumb.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Sounds good to make `arm::isARMBigEndian` focus on AArch32 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155808/new/ https://reviews.llvm.o

[PATCH] D155808: [clang][driver] Call IsARMBigEndain function only for isARM and isThumb.

MaskRay added a comment. Add NFC if this is NFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155808/new/ https://reviews.llvm.org/D155808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added inline comments. Comment at: clang/lib/CodeGen/Targets/RISCV.cpp:178 return false; -if (isEmptyRecord(getContext(), Ty, true)) +if (isEmptyRecord(getContext(), Ty, true, true)) return true; I've observed (based on manually add

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

carlosgalvezp added a comment. The review is marked as accepted, should we land it? Let me know if you need help with that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 _

[PATCH] D156089: [Driver][XRay][test] Convert more tests to check 'target=...' after 016785d9316d8c5abc5fdf3cdb86479095bbb677

MaskRay added inline comments. Comment at: clang/test/Driver/XRay/xray-ignore-loops-flags.cpp:1 // This test ensures that when we invoke the clang compiler, that the -cc1 // options include the -fxray-ignore-loops flag we provide in the I have cleaned up a few

[clang] 0fa004e - Revert "[clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++"

Author: Alex Bradbury Date: 2023-07-24T16:58:48+01:00 New Revision: 0fa004e0724b4398f999b8bffbc37f524e41f66e URL: https://github.com/llvm/llvm-project/commit/0fa004e0724b4398f999b8bffbc37f524e41f66e DIFF: https://github.com/llvm/llvm-project/commit/0fa004e0724b4398f999b8bffbc37f524e41f66e.diff

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:187 +Value *AMDGPULateCodeGenPrepare::buildLegalLaneIntrinsic( +IRBuilder<> &B, Intrinsic::ID IID, Value *Data0, Value *Data1, Value *Lane0, jrbyrnes wrote: > ars

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

efriedma added a comment. The UINT_MAX thing seems like a straightforward bug; if we have time to fix it properly, I'd prefer not to add weird workarounds. The release note says "unless they are part of a constant expression", but I don't see any code in the implementation that distinguishes fo

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb reopened this revision. asb added a comment. This revision is now accepted and ready to land. Reopening as I've reverted following Roger's bug report. Comment at: clang/lib/CodeGen/Targets/RISCV.cpp:178 return false; -if (isEmptyRecord(getContext(), Ty, true)) +

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

arsenm added a comment. In D156040#4526036 , @JonChesterfield wrote: > I don't see how this conveys any information. The compiler writes the stack > size to be allocated. If it doesn't know what is sufficient, it's going to > request some maximum and h

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

ymandel added a comment. In D155890#4528560 , @carlosgalvezp wrote: > The review is marked as accepted, should we land it? Let me know if you need > help with that :) We're still waiting on some small changes: https://reviews.llvm.org/D155890#inline-1

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

arsenm added inline comments. Comment at: clang/test/Frontend/amdgcn-machine-analysis-remarks.cl:13 +// expected-remark@+2 {{LDS Size [bytes/block]: 0}} +// expected-remark@+1 {{Uses Dynamic Stack: False}} __kernel void foo() { Print right after the scra

[clang] 8698262 - [Clang] Fix consteval propagation for aggregates and defaulted constructors

Author: Corentin Jabot Date: 2023-07-24T18:15:38+02:00 New Revision: 8698262a4365bf22b5b0c96e77bfecd3dcf084a7 URL: https://github.com/llvm/llvm-project/commit/8698262a4365bf22b5b0c96e77bfecd3dcf084a7 DIFF: https://github.com/llvm/llvm-project/commit/8698262a4365bf22b5b0c96e77bfecd3dcf084a7.diff

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8698262a4365: [Clang] Fix consteval propagation for aggregates and defaulted constructors (authored by cor3ntin). Repository: rG LLVM Github Monor

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp updated this revision to Diff 543586. dkrupp marked 6 inline comments as done. dkrupp added a comment. Herald added a subscriber: wangpc. - changed the main example to a data sanitation example (sanitizeFileName()) instead of a data verification example - fixed typos - fixed sphinx warnin

[clang] 2f6b2da - [clang-format] Insert namespace comments with leading spaces

Author: Owen Pan Date: 2023-07-24T09:22:51-07:00 New Revision: 2f6b2dafb78345b3013797096e8e71677710ce48 URL: https://github.com/llvm/llvm-project/commit/2f6b2dafb78345b3013797096e8e71677710ce48 DIFF: https://github.com/llvm/llvm-project/commit/2f6b2dafb78345b3013797096e8e71677710ce48.diff LOG:

[PATCH] D156065: [clang-format] Insert namespace comments with leading spaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f6b2dafb783: [clang-format] Insert namespace comments with leading spaces (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156065/new/

[PATCH] D155808: [clang][driver][NFC] Call IsARMBigEndain function only for isARM and isThumb.

simpal01 added a comment. In D155808#4528543 , @MaskRay wrote: > Add NFC if this is NFC? Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155808/new/ https://reviews.llvm.org/D155808 __

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp added a comment. Thanks @donat.nagy for your review. I addressed your remarks. After patch https://reviews.llvm.org/D155848 these sanitizing examples work properly. Comment at: clang/docs/analyzer/checkers.rst:78-80 +The ``SuppressAddressSpaces`` option suppresses warn

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155705/new/ https://reviews.llvm.org/D155705 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

b-sumner added a comment. In D156040#4528606 , @arsenm wrote: > In D156040#4526036 , > @JonChesterfield wrote: > >> I don't see how this conveys any information. The compiler writes the stack >> size to be alloc

[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

SeanP updated this revision to Diff 543591. SeanP added a comment. fix up formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155234/new/ https://reviews.llvm.org/D155234 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/builtins.h clang/lib/Headers/float.h clang/l

<    1   2   3   4   >