arsenm added inline comments.
================
Comment at: clang/test/Frontend/amdgcn-machine-analysis-remarks.cl:13
+// expected-remark@+2 {{ LDS Size [bytes/block]: 0}}
+// expected-remark@+1 {{ Uses Dynamic Stack: False}}
__kernel void foo() {
----------------
Print right after the scratch size
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1305
CurrentProgramInfo.LDSSize);
+ std::string UsesDynamicStackStr =
+ CurrentProgramInfo.DynamicCallStack ? "True" : "False";
----------------
don't need std::string for simple literals? StringRef?
================
Comment at: llvm/test/CodeGen/AMDGPU/resource-optimization-remarks.ll:168
+}
+
+
----------------
Maybe add another that has a static component too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156040/new/
https://reviews.llvm.org/D156040
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
