[PATCH] D155368: [clang][Interp] __builtin_copysign

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 541325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155368/new/ https://reviews.llvm.org/D155368 Files: clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp ===

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155547: CPP-4580 Model lifetime of a variable declared in for condition in CFG correctly

2023-07-17 Thread Tomasz Kamiński via Phabricator via cfe-commits
tomasz-kaminski-sonarsource created this revision. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per [stmt.for] p1 (https://eel.is/c++draft/stmt.for#1)

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this makes sense to do, given that the `Consta

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

2023-07-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot for bearing with me, let's ship it! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:91 +const Inclusion &Inc, ParsedAST &AST, +std::shared_pt

[clang] 61760bb - [analyzer] Bind return value for assigment and copies of trivial empty classes

2023-07-17 Thread Tomasz Kamiński via cfe-commits
Author: Tomasz Kamiński Date: 2023-07-18T08:31:38+02:00 New Revision: 61760bb98c4694651261b2e10df3fa6f669098ed URL: https://github.com/llvm/llvm-project/commit/61760bb98c4694651261b2e10df3fa6f669098ed DIFF: https://github.com/llvm/llvm-project/commit/61760bb98c4694651261b2e10df3fa6f669098ed.dif

[PATCH] D155442: [analyzer] Bind return value for assigment and copies of trivial empty classes

2023-07-17 Thread Tomasz Kamiński via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61760bb98c46: [analyzer] Bind return value for assigment and copies of trivial empty classes (authored by tomasz-kaminski-sonarsource). Changed prio

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

2023-07-17 Thread Tomasz Kamiński via Phabricator via cfe-commits
tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:609 // CHECK-NEXT:1: [B9.2] (Lifetime ends) // CHECK-NEXT:T: continue; // CHECK-NEXT:Preds (1): B7 Note that the lifetime ends for `[B10.4]`/

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

2023-07-17 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a reviewer: sammccall. mstorsjo added a subscriber: sammccall. mstorsjo added a comment. Thanks for looking at my suggestion! At this point, I'd defer the judgement to the code owner, @sammccall - whether it's nicer to have a tighter set of dependencies, or to reduce the risk of c

[PATCH] D155147: [X86] Add SM3 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 541340. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address commments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/R

[PATCH] D155204: [clang][dataflow] Add `refreshStructValue()`.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:706-711 +/// This function is primarily intended for use by checks that set custom +/// properties on `StructValue`s to model the state of these values. Such checks +///

[PATCH] D155220: [IRGen] Remove 'Sve' from the name of some IR names that are shared with RISC-V now.

2023-07-17 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155220/new/ https://reviews.llvm.org/D155220

[PATCH] D155425: [include-cleaner] Record concept uses

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, massberg. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Most cases handled by adding VisitConceptReference to R

[clang] 4782597 - [clang][dataflow] Add a test for not explicitly initialized fields in aggregate initialization.

2023-07-17 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-17T07:26:08Z New Revision: 4782597e3cd1b26cf8bd437e36fd6320f55d3d89 URL: https://github.com/llvm/llvm-project/commit/4782597e3cd1b26cf8bd437e36fd6320f55d3d89 DIFF: https://github.com/llvm/llvm-project/commit/4782597e3cd1b26cf8bd437e36fd6320f55d3d89.diff LOG

[clang] 243a79c - [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in optional check.

2023-07-17 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-17T07:26:11Z New Revision: 243a79ca01f8142a8d8c9873ba58fefdafa48745 URL: https://github.com/llvm/llvm-project/commit/243a79ca01f8142a8d8c9873ba58fefdafa48745 DIFF: https://github.com/llvm/llvm-project/commit/243a79ca01f8142a8d8c9873ba58fefdafa48745.diff LOG

[clang] d17f455 - [clang][dataflow] Add `refreshStructValue()`.

2023-07-17 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-17T07:26:13Z New Revision: d17f455a6348806c73641e742af08b0a974e13d5 URL: https://github.com/llvm/llvm-project/commit/d17f455a6348806c73641e742af08b0a974e13d5 DIFF: https://github.com/llvm/llvm-project/commit/d17f455a6348806c73641e742af08b0a974e13d5.diff LOG

[clang] 6d76854 - [clang][dataflow] Add `DataflowEnvironment::createObject()`.

2023-07-17 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-17T07:26:10Z New Revision: 6d768548ecc0ca37026986f397392c1d0ace9736 URL: https://github.com/llvm/llvm-project/commit/6d768548ecc0ca37026986f397392c1d0ace9736 DIFF: https://github.com/llvm/llvm-project/commit/6d768548ecc0ca37026986f397392c1d0ace9736.diff LOG

[PATCH] D155074: [clang][dataflow] Add a test for not explicitly initialized fields in aggregate initialization.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4782597e3cd1: [clang][dataflow] Add a test for not explicitly initialized fields in aggregate… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D155075: [clang][dataflow] Add `DataflowEnvironment::createObject()`.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d768548ecc0: [clang][dataflow] Add `DataflowEnvironment::createObject()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D155202: [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in optional check.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG243a79ca01f8: [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in… (authored by mboe

[PATCH] D155204: [clang][dataflow] Add `refreshStructValue()`.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd17f455a6348: [clang][dataflow] Add `refreshStructValue()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540885. FreddyYe marked 15 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/R

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Kan Shengchen via Phabricator via cfe-commits
skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 ___ cfe

[PATCH] D155222: [RISCV][AArch64][IRGen] Add scalable->fixed as a special case in CreateCoercedStore.

2023-07-17 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155222/new/ https://reviews.llvm.org/D155222

[PATCH] D155222: [RISCV][AArch64][IRGen] Add scalable->fixed as a special case in CreateCoercedStore.

2023-07-17 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. It's been a while since I've looked at this code, what about this wouldnt work for predicates? I seem to recall fixed predicates using i8 vs i1 for scalable, is that issue? Happy with this regardless, just curious. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cc006ac - [clang] Fix delayed template parsing

2023-07-17 Thread Serge Pavlov via cfe-commits
Author: Serge Pavlov Date: 2023-07-17T14:51:34+07:00 New Revision: cc006acdd6d7280a85c63fe375a4c9d1738e3fcd URL: https://github.com/llvm/llvm-project/commit/cc006acdd6d7280a85c63fe375a4c9d1738e3fcd DIFF: https://github.com/llvm/llvm-project/commit/cc006acdd6d7280a85c63fe375a4c9d1738e3fcd.diff

[PATCH] D155380: [clang] Fix delayed template parsing

2023-07-17 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcc006acdd6d7: [clang] Fix delayed template parsing (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/ https://reviews.llvm.o

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

2023-07-17 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 _

[PATCH] D155147: Add SM3 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540892. FreddyYe marked 5 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540893. FreddyYe added a comment. Added FIXME for schedule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D155147: Add SM3 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8331 +VR128:$src2, (loadv4i32 addr:$src3), timm:$src4))]>, + Sched<[WriteVecIMul]>; + } skan wrote: > Is the schedule appropriate? I referred to SHA1MSG1'

[PATCH] D155148: Add SM4 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe marked 4 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8308 +RC:$src2))]>, + Sched<[WriteVecIMul]>; +def rm : I<0xda, MRMSrcMem, (outs RC:$dst), skan wrote: > From

[PATCH] D155148: Add SM4 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540900. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Re

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

2023-07-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 540902. cor3ntin added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add more tests for aggregates and a codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

2023-07-17 Thread Benjamin Bannier via Phabricator via cfe-commits
bbannier added a comment. Thanks for reviews and @xgupta for pushing this over the finish line. This had been lingering a long time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 __

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540909. FreddyYe added a comment. Remove `-check-prefix=CHECK` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D155147: Add SM3 instructions.

2023-07-17 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:21 + +static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_sm3msg1_epi32(__m128i __A, + __m128i __B, Doxygen descriptions? =

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

2023-07-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 540913. wangpc added a comment. - Rebase - Fix tests. @ldionne I don't know the details about DriverKit so I assumed that sized deallocation is available just like aligned allocation. @Mordante I will leave libcxx tests to folks who are more familiar with th

[PATCH] D155148: Add SM4 instructions.

2023-07-17 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/sm4intrin.h:17 + +#define _mm_sm4key4_epi32(A, B) \ + (__m128i) __builtin_ia32_vsm4key4128((__v4su)A, (__v4su)B) doxygen descriptions?

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-07-17 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta updated this revision to Diff 540914. xgupta marked 5 inline comments as done. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.c

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-07-17 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13635 + if (ECDHS && ECDHS->getInitVal() != 0 && ECDHS->getInitVal() != 1) +EnumConstantInBoolContext = true; +} xgupta wrote: > nickdesaulniers wrote: > > Hmm...I wonder if we

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

2023-07-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 540915. wangpc added a comment. - Add comments. - clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetT

[PATCH] D155429: [AMDGPU] Add targets gfx1150 and gfx1151

2023-07-17 Thread Jay Foad via Phabricator via cfe-commits
foad created this revision. foad added a reviewer: AMDGPU. Herald added subscribers: libc-commits, mattd, gchakrabarti, asavonic, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, emaste, arsenm. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Heral

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-07-17 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. We should not warn for macros. if (ENABLE_XYZ && x) {} } This pattern is used in real world codebases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 ___ cfe-commits mail

[PATCH] D155429: [AMDGPU] Add targets gfx1150 and gfx1151

2023-07-17 Thread David Stuttard via Phabricator via cfe-commits
dstuttard accepted this revision. dstuttard added a comment. This revision is now accepted and ready to land. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155429/n

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:657 + Style = getLLVMStyle(); + + Style.IndentPPDirectives = FormatStyle::PPDirectiveIndentStyle::PPDIS_None; Comment at: clang/unittests/Format/Format

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-07-17 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta updated this revision to Diff 540922. xgupta added a comment. Address xbolva00's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c

[PATCH] D155270: [clang][Interp] Basic support for bit fields

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 540927. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155270/new/ https://reviews.llvm.org/D155270 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Rec

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/sha512intrin.h:21 + +static __inline__ __m256i __DEFAULT_FN_ATTRS256 +_mm256_sha512msg1_epi64(__m256i __A, __m128i __B) { doxygen descriptions? Comment at: clang/test/CodeGen/X86/sha5

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

2023-07-17 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. No major problems were indicated with the patch stack, I plan to merge all of these soon. Small problems can be still corrected before or when the checker is put out from the alpha package. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D154764: [ASTImporter] Fields are imported first and reordered for correct layout.

2023-07-17 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. If I see correctly this change does that the re-ordered members are imported before all other, specially fields come before functions. This way order of fields is already correct when a function is imported. Comment at: clang/lib/AST/ASTImporter.cpp:

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

2023-07-17 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153458/new/ https://reviews.llvm.org/D153458

[PATCH] D155147: Add SM3 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540949. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/B

[PATCH] D155148: Add SM4 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540950. FreddyYe marked an inline comment as done. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Rel

[PATCH] D155146: Add SHA512 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 540951. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/B

[PATCH] D155442: [analyzer] Bind return value for assigment and copies of trivial empty classes

2023-07-17 Thread Tomasz Kamiński via Phabricator via cfe-commits
tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonars

[PATCH] D155148: Add SM4 instructions.

2023-07-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/sm4-builtins.c:5 +#include +#include + RKSimon wrote: > what is stddef.h needed for? Good catch! probably be copy paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155204: [clang][dataflow] Add `refreshStructValue()`.

2023-07-17 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:706-711 +/// This function is primarily intended for use by checks that set custom +/// properties on `StructValue`s to model the state of these values. Such checks +//

[clang] e6afacc - [clang][Interp] Diagnose callsite for implicit functions

2023-07-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-17T14:02:04+02:00 New Revision: e6afacc0347c8f95678d56692ebc409ae85b162c URL: https://github.com/llvm/llvm-project/commit/e6afacc0347c8f95678d56692ebc409ae85b162c DIFF: https://github.com/llvm/llvm-project/commit/e6afacc0347c8f95678d56692ebc409ae85b162c.diff LO

[PATCH] D154761: [clang][Interp] Diagnose callsite for implicit functions

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6afacc0347c: [clang][Interp] Diagnose callsite for implicit functions (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 92542f2 - [AMDGPU] Add targets gfx1150 and gfx1151

2023-07-17 Thread Jay Foad via cfe-commits
Author: Jay Foad Date: 2023-07-17T13:06:12+01:00 New Revision: 92542f2a400024e8a878242afe8231e17df345e5 URL: https://github.com/llvm/llvm-project/commit/92542f2a400024e8a878242afe8231e17df345e5 DIFF: https://github.com/llvm/llvm-project/commit/92542f2a400024e8a878242afe8231e17df345e5.diff LOG:

[PATCH] D155429: [AMDGPU] Add targets gfx1150 and gfx1151

2023-07-17 Thread Jay Foad via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92542f2a4000: [AMDGPU] Add targets gfx1150 and gfx1151 (authored by foad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D155445: [analyzer][docs] Add CSA release notes

2023-07-17 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus, donat.nagy, balazske, gamesh411, tripleCC, tomasz-kaminski-sonarsource, OikawaKirie. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

2023-07-17 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After this change, `StructValue` is just a wrapp

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

2023-07-17 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/avxvnniint16intrin.h:26 + +static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_dpwsud_epi32(__m128i __A, + __m128i __B, doxygen descriptio

[clang] a926a26 - [Triple] Add llvm::Triple::isLoongArch{32,64}

2023-07-17 Thread Weining Lu via cfe-commits
Author: Weining Lu Date: 2023-07-17T20:34:35+08:00 New Revision: a926a2660a7f1942261bb15a0553d7f3999456d1 URL: https://github.com/llvm/llvm-project/commit/a926a2660a7f1942261bb15a0553d7f3999456d1 DIFF: https://github.com/llvm/llvm-project/commit/a926a2660a7f1942261bb15a0553d7f3999456d1.diff LO

[PATCH] D155163: [Triple] Add llvm::Triple::isLoongArch{32,64}

2023-07-17 Thread Lu Weining via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa926a2660a7f: [Triple] Add llvm::Triple::isLoongArch{32,64} (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D155445: [analyzer][docs] Add CSA release notes

2023-07-17 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:907 + Any use of this flag will result in an error. + (`7cd1f3ad22e4

[clang] 3f928e7 - [clang][Interp][NFC] Fix a doc comment and a typo

2023-07-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-17T14:44:09+02:00 New Revision: 3f928e787b4eeb3ec501e785127229f2575ec769 URL: https://github.com/llvm/llvm-project/commit/3f928e787b4eeb3ec501e785127229f2575ec769 DIFF: https://github.com/llvm/llvm-project/commit/3f928e787b4eeb3ec501e785127229f2575ec769.diff LO

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

2023-07-17 Thread victorkingi via Phabricator via cfe-commits
victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

2023-07-17 Thread Digger Lin via Phabricator via cfe-commits
DiggerLin added a comment. Gentle ping , @jhenderson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

2023-07-17 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760 // CHECK-NEXT:2: [B1.1]++ -// CHECK-NEXT:3: [B2.2] (Lifetime ends) -// CHECK-NEXT:4: [B3.1] (Lifetime ends) +// CHECK-NEXT:3: [B2.4] (Lifetime ends) +// CHECK-NEXT:4:

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540981. sammccall added a comment. rebase and narrow scope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78038/new/ https://reviews.llvm.org/D78038 Files: clang-tools-extra/clangd/unittests/SymbolCollector

[PATCH] D155455: [Serialization] Read main file's HeaderFileInfo from PCH even if changed

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov. Herald added projects: clang, LLVM, clang-tools-extra. Because file size is p

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540985. sammccall marked an inline comment as done. sammccall added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78038/new/ https://reviews.llvm.org/D78038 Files: clang-tools-extra/clangd/

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. OK, time to revive this patch, sorry for letting it die. Meanwhile, the lexer change has landed separately, so that's gone. I've removed the gratuitous clangd indexing changes in order to focus this on the serialization hacks. Comment at: clang/lib

[clang] 1a88292 - Fix Clang Sphinx build

2023-07-17 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-07-17T09:01:51-04:00 New Revision: 1a88292e03da55977bb92ac5534ea7c082b5d886 URL: https://github.com/llvm/llvm-project/commit/1a88292e03da55977bb92ac5534ea7c082b5d886 DIFF: https://github.com/llvm/llvm-project/commit/1a88292e03da55977bb92ac5534ea7c082b5d886.diff

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

2023-07-17 Thread Tomasz Kamiński via Phabricator via cfe-commits
tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760 // CHECK-NEXT:2: [B1.1]++ -// CHECK-NEXT:3: [B2.2] (Lifetime ends) -// CHECK-NEXT:4: [B3.1] (L

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

2023-07-17 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan added a comment. Couple of quick comments. You probably need another frontend-forwarding test to check `fsave-optimization-record=`. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:392-395 +static void renderRemarksOptions(const ArgList &Args, ArgStringLis

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

2023-07-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc created this revision. wangpc added reviewers: reames, craig.topper, asb, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edw

[PATCH] D155445: [analyzer][docs] Add CSA release notes

2023-07-17 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/docs/ReleaseNotes.rst:907 + Any use of this flag will result in an error. + (`7cd1f3ad22e4 `_) +- Fixed a null-pointer dereference crash inside the ``MoveChecker``. -

[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

2023-07-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. ping on this one for when you have time I haven't rebased against latest config yet, it's a bit of a moving target :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140745/new/ https://reviews.llvm.org/D140745 __

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

2023-07-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 540989. wangpc added a comment. Add `+unaligned-vector-mem` if V exists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155456/new/ https://reviews.llvm.org/D155456 Files: clang/include/clang/Driver/Options.td

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

2023-07-17 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta created this revision. xgupta added reviewers: aaron.ballman, xbolva00. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The issue with size_t comes when we are trying to addd -Wtype-limits to -Wext

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

2023-07-17 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. I am not sure if this is correct but this passes `ninja check-clang`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 ___ cfe-commits ma

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

2023-07-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 540994. wangpc added a comment. Remove includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155456/new/ https://reviews.llvm.org/D155456 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

2023-07-17 Thread Tom Eccles via Phabricator via cfe-commits
tblah added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + What happens if an invalid or unsupported format is specified. Is

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-07-17 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. Patch LGTM, thanks. Just a note that you'll need to remove the trailing `__arm_streaming` attribute from `acle_sme_read.c` in order to be able to land the patch without causing test failures. Comment at: clang/test

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-07-17 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 ___ cfe-commits mailing list cfe-com

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

2023-07-17 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 updated this revision to Diff 540998. qiongsiwu1 added a comment. Revise the tests to use llvm tools to dump profile data to check for profile validity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-07-17 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_str.c:24 +// CHECK-NEXT:[[TMP0:%.*]] = getelementptr i8, ptr [[PTR:%.*]], i64 [[MULVL]] +// CHECK-NEXT:tail call void @llvm.aarch64.sme.str(i32 [[SLICE_BASE:%.*]], ptr [[TMP0

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

2023-07-17 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:795 - /* When PNS >= OldPNS, the last one wins. */ - if (!FilenamePat || parseFilenamePattern(FilenamePat, CopyFilenamePat)) resetFilenam

<    1   2   3   >