xazax.hun added inline comments.
================ Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760 // CHECK-NEXT: 2: [B1.1]++ -// CHECK-NEXT: 3: [B2.2] (Lifetime ends) -// CHECK-NEXT: 4: [B3.1] (Lifetime ends) +// CHECK-NEXT: 3: [B2.4] (Lifetime ends) +// CHECK-NEXT: 4: [B2.2] (Lifetime ends) ---------------- Would it be possible to add the variable name to the lifetime ends dumps? It would make interpreting these tests somewhat easier. (It is OK as a separate/follow-up patch.) ================ Comment at: clang/test/Analysis/nonreturn-destructors-cfg-output.cpp:99 +// +// CHECK: [B2 (NORETURN)] +// CHECK-NEXT: 1: [B3.3].~A() (Implicit destructor) ---------------- B3 and B5 look almost identical. Do we need both? If not, would there be a way to deduplicate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153273/new/ https://reviews.llvm.org/D153273 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
