[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

michaelplatings created this revision. michaelplatings added a reviewer: MaskRay. Herald added subscribers: kmitropoulou, asbirlea, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commi

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. In D153430#4453908 , @MaskRay wrote: > Thank you for implementing this warning. Side note: it would be better to (a) > fix the tests separately from (b) implementing the warning and (c) adding > tests to demonstrate the

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:319 + Prev->Previous->isOneOf(tok::period, tok::arrow)) || + (!Line.MustBeDeclaration && !Line.InMacroBody); Contexts.back().IsExpression = OperatorCalledAsMemberFunction; ---

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge created this revision. nridge added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Some project

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge added a comment. No tests yet, posting for early feedback. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:233 IndexOpts.StoreAllDocumentation = true; + // FIXME: Should we respect the Index.ReservedIdentifiers config here? // Sadly we can't use IndexOpts.Fi

[PATCH] D153409: [clang][dataflow] Add a test that we can access fields of anonymous records.

mboehme marked 2 inline comments as done. mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153409/new/ https://reviews.llvm.org/D153409 ___ cfe-com

[PATCH] D153851: [clang][dataflow] Output debug info if `getChild()` doesn't find field.

mboehme added a comment. Pre-merge failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153851/new/ https://reviews.llvm.org/D153851 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

tbaeder added a comment. Didn't remember and re-checked, using it that way makes the implementation harder I think: tsa2.c:7:54: error: incomplete definition of type 'struct Mutex' 7 | int counter GUARDED_BY(__builtin_instance_member(M)->M); |

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 535277. FreddyYe added a comment. 1. Fixed copy errors of some CPU's manglings 2. Updated resolver function checkers due to more complete feature list changes. 3. Added more cpu checks in attr-cpuspecific-cpus.c Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:137 Dict.handle("ClangTidy", [&](Node &N) { parse(F.ClangTidy, N); }); -Dict.handle("AllowStalePreamble", [&]

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. Notice that these two changes are both expected since a more complete feature list won't influence the _cpu_dispatch/specific multiversion to not work. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr g

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

sameerds created this revision. Herald added subscribers: kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. sameerds requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang, LLVM. This reverts commit

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

voertler added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151315/new/ https://reviews.llvm.org/D151315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

mboehme updated this revision to Diff 535284. mboehme added a comment. Ensure we model a field of an anonymous record even if the only place it's used is in an initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153852/new/ https://reviews.l

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153852/new/ https://reviews.llvm.org/D153852 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:137 Dict.handle("ClangTidy", [&](Node &N) { parse(F.ClangTidy, N); }); -Dict.handle("AllowStalePreamble", [&](Node &N) { - F.AllowStalePrea

[PATCH] D153954: Relax alpha.cplusplusEnumCastOutOfRange This checker previously gave many false positives, because only the enum

gamesh411 created this revision. Herald added subscribers: steakhal, martong, Szelethus, dkrupp. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project: All. gamesh411 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[clang-tools-extra] bd89f9e - [clangd] Always allow diagnostics from stale preambles

Author: Kadir Cetinkaya Date: 2023-06-28T10:41:45+02:00 New Revision: bd89f9ec293ea5e20e89d4bce49135431239cf3e URL: https://github.com/llvm/llvm-project/commit/bd89f9ec293ea5e20e89d4bce49135431239cf3e DIFF: https://github.com/llvm/llvm-project/commit/bd89f9ec293ea5e20e89d4bce49135431239cf3e.dif

[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGbd89f9ec293e: [clangd] Always allow diagnostics from stale preambles (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D153882?vs=53499

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535289. jyu2 added a comment. Thanks Alex for the review. This is to address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clan

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 added a comment. Thanks Alexey for the review. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier = ge

[clang] d04b198 - [clang][dataflow] Add a test that we can access fields of anonymous records.

Author: Martin Braenne Date: 2023-06-28T09:12:03Z New Revision: d04b198973c9bda2376209b460943ac393190752 URL: https://github.com/llvm/llvm-project/commit/d04b198973c9bda2376209b460943ac393190752 DIFF: https://github.com/llvm/llvm-project/commit/d04b198973c9bda2376209b460943ac393190752.diff LOG

[clang] 834a84d - [clang][dataflow] Output debug info if `getChild()` doesn't find field.

Author: Martin Braenne Date: 2023-06-28T09:12:08Z New Revision: 834a84d091ab7d196e966d8f08101136eb1c1e06 URL: https://github.com/llvm/llvm-project/commit/834a84d091ab7d196e966d8f08101136eb1c1e06 DIFF: https://github.com/llvm/llvm-project/commit/834a84d091ab7d196e966d8f08101136eb1c1e06.diff LOG

[PATCH] D153851: [clang][dataflow] Output debug info if `getChild()` doesn't find field.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG834a84d091ab: [clang][dataflow] Output debug info if `getChild()` doesn't find field. (authored by mboehme). Repository: rG LLVM Github Monorepo

[PATCH] D153409: [clang][dataflow] Add a test that we can access fields of anonymous records.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd04b198973c9: [clang][dataflow] Add a test that we can access fields of anonymous records. (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D153956: [clang][dataflow] Don't crash if copy constructor arg doesn't have a storage location.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I accidentally used `cast` instead of `cast_or_n

Re: [PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

Hi, sorry about that - are you able to provide a full log, or link to a failing bot? That error message doesn't show where in the LLVM code the error occurs. On Wed, Jun 28, 2023 at 7:52 AM Zixuan Wu via Phabricator < revi...@reviews.llvm.org> wrote: > zixuan-wu added a comment. > > Hi, there is

[PATCH] D153957: [C++20] [Modules] Allow Stmt::Profile to treat lambdas as equal conditionally

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, cor3ntin, aaron.ballman, tbaeder. ChuanqiXu added projects: clang-modules, clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[clang] 6f22de6 - [dataflow] Use consistent, symmetrical, non-mutating erased signature for join()

Author: Sam McCall Date: 2023-06-28T11:30:16+02:00 New Revision: 6f22de67c585156aea6a4554f96315094092d211 URL: https://github.com/llvm/llvm-project/commit/6f22de67c585156aea6a4554f96315094092d211 DIFF: https://github.com/llvm/llvm-project/commit/6f22de67c585156aea6a4554f96315094092d211.diff LO

[PATCH] D153908: [dataflow] Use consistent, symmetrical, non-mutating erased signature for join()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f22de67c585: [dataflow] Use consistent, symmetrical, non-mutating erased signature for join() (authored by sammccall). Repository: rG LLVM Github

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4455357 , @sammccall wrote: > Hi, sorry about that - are you able to provide a full log, or link to a > failing bot? > That error message doesn't show where in the LLVM code the error occurs. It can pass with gcc 8.

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun added a comment. Could you rebase this patch to the latest tip of tree? Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:73 + + // Whether this node is the head of a feedback edge within the interval. + bool IsFeedbackHead = false; -

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein updated this revision to Diff 535309. hokein added a comment. compare the file-permission bits in unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 Files: llvm/lib/Support/raw_ostream.cpp

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein added inline comments. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:500 + ASSERT_TRUE(!!Perms); + EXPECT_EQ(0, *Perms & llvm::sys::fs::all_exe); + jhenderson wrote: > hokein wrote: > > jhenderson wrote: > > > Here and below, rather than just c

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. In D153294#4448342 , @Fznamznon wrote: > I'm having a slight trouble with understanding why this part is required and > how to implement the test ... > > Also, simply adding a flag to `MaybeCreateExprWithCleanup` signaling

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added a comment. > What about > template > struct A { }; > > void foo() { > new struct A {}; > } > > I think this should be allowed, right? Yes, I think so. The patch helps to allow. Thanks, I'll add it to the test. > MSVC rejects the first but accepts the second which I think

[clang] 51bb9b1 - OpenMP: Add missing test coverage for nothrow new/delete

Author: Matt Arsenault Date: 2023-06-28T06:55:15-04:00 New Revision: 51bb9b12f87ea315f750490c39cd993507202861 URL: https://github.com/llvm/llvm-project/commit/51bb9b12f87ea315f750490c39cd993507202861 DIFF: https://github.com/llvm/llvm-project/commit/51bb9b12f87ea315f750490c39cd993507202861.diff

[clang] 0e17174 - OpenMP: Fix nothrow new/delete for amdgpu

Author: Matt Arsenault Date: 2023-06-28T06:55:16-04:00 New Revision: 0e17174d40b2d25a755d2ce9acf7c905f254746d URL: https://github.com/llvm/llvm-project/commit/0e17174d40b2d25a755d2ce9acf7c905f254746d DIFF: https://github.com/llvm/llvm-project/commit/0e17174d40b2d25a755d2ce9acf7c905f254746d.diff

[PATCH] D152850: OpenMP: Add missing test coverage for nothrow new/delete

arsenm closed this revision. arsenm added a comment. 51bb9b12f87ea315f750490c39cd993507202861 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152850/new/ https://reviews.llvm.org/D152850 __

[PATCH] D152851: OpenMP: Fix nothrow new/delete for amdgpu

arsenm closed this revision. arsenm added a comment. 0e17174d40b2d25a755d2ce9acf7c905f254746d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152851/new/ https://reviews.llvm.org/D152851 __

[PATCH] D153956: [clang][dataflow] Don't crash if copy constructor arg doesn't have a storage location.

mboehme added a comment. Pre-merge failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153956/new/ https://reviews.llvm.org/D153956 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon updated this revision to Diff 535317. Fznamznon added a comment. Add comma and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm.org/D153857 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Par

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy added a comment. The source code changes LGTM. I'll soon check the results on the open source projects and give a final approval based on that. By the way, I think this commit and the "display notes only if interesting" follow-up change (D153776 ) sh

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2221 +DSC_association, // A _Generic selection expression's type association +DSC_new // C++ new operator }; aaron.ballman wrote: > Adding the comma so the next pe

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

hazohelet added a comment. In D153690#4453001 , @cjdb wrote: > Excellent, thanks! LGTM, do you need assistance with merging? Thanks for the review. I'll land this myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153690/new/ https://review

[clang] abc8367 - [clang][dataflow] Don't crash if copy constructor arg doesn't have a storage location.

Author: Martin Braenne Date: 2023-06-28T11:15:52Z New Revision: abc8367413ff377b79e9743ca85252f209f81d65 URL: https://github.com/llvm/llvm-project/commit/abc8367413ff377b79e9743ca85252f209f81d65 DIFF: https://github.com/llvm/llvm-project/commit/abc8367413ff377b79e9743ca85252f209f81d65.diff LOG

[PATCH] D153956: [clang][dataflow] Don't crash if copy constructor arg doesn't have a storage location.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabc8367413ff: [clang][dataflow] Don't crash if copy constructor arg doesn't have a storage… (authored by mboehme). Repository: rG LLVM Github Mono

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The newly added tests crash without the other ch

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603 +// deallocation call of __kmpc_free_shared() is emitted later. +if (getLangOpts().OpenMP && getTarget().getTriple().isAMDGCN()) { + // Emit call to __kmpc_alloc_shared() instead of the alloc

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since an immediate invocation is a full expression itself - it requires an additional ExprWithCleanups node, but it can

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy requested changes to this revision. donat.nagy added a comment. This revision now requires changes to proceed. As I started to review the code of the follow-up commit D153776 , I noticed a dangling `StringRef` bug which belongs to this review. Moreov

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > I believe we should make the proposed change (add potentially redundant > ExprWithCleanups without touching the cleanups objects or flags) without > blocking on Richard's approval. I posted https://reviews.llvm.org/D153962 . Repository: rG LLVM Github Monorepo

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Using PointerValue to model pointers to data members does not look right to me, because a pointer to data member is an offset within an object that we apply this pointer to,

[PATCH] D144911: adding bf16 support to NVPTX

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't have much knowledge about the PTX ABI, but everything here makes perfect sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[clang-tools-extra] 8ceb419 - [clangd] Fix some typos, NFC

Author: Haojian Wu Date: 2023-06-28T14:05:21+02:00 New Revision: 8ceb4190fe9baa617bc65e99f0296531c88a5a79 URL: https://github.com/llvm/llvm-project/commit/8ceb4190fe9baa617bc65e99f0296531c88a5a79 DIFF: https://github.com/llvm/llvm-project/commit/8ceb4190fe9baa617bc65e99f0296531c88a5a79.diff LO

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

sammccall accepted this revision. sammccall added a comment. Per offline discussion, I think modelling pointer-to-member as PointerValue does make sense, though that's not completely obvious. Can we document this on PointerValue? (And that it points to a StorageLocation for the decl, which has n

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:356 + Member = cast(I); + MemberLoc = &cast(MemberLoc)->getChild(*Member);

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9818 + D.hasClausesOfKind() || + (CGM.getLangOpts().OpenMP >= 51 && D.getDirectiveKind() == OMPD_target && + D.hasClausesOfKind()); What if D is combined target direc

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier = getOpenMPSimpleClauseType

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153321/new/ https://reviews.llvm.org/D153321 ___

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. Marking mbcnt as convergent, together with https://reviews.llvm.org/D144756 prevent mbcnt to be merged, which fixed the reported issue. Do you have an alternative fix for the issue?

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

aaron.ballman resigned from this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D150803#4454188 , @sbc100 wrote: > In D150803#4454164 , @brendandahl > wrote: > >> In

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP updated this revision to Diff 535353. SeanP added a comment. Got old diff last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/T

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

sameerds added a comment. In D153953#4455794 , @yaxunl wrote: > Marking mbcnt as convergent, together with https://reviews.llvm.org/D144756 > prevent mbcnt to be merged, which fixed the reported issue. > > Do you have an alternative fix for the issue? I

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 535355. cor3ntin added a comment. Fix tests and handle variadic attributes. - With that all normal attributes are handled. Only attributes with custop parsing code and those specified as an enum are left untouched. Repository: rG LLVM Github Monorepo C

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} aaronpuchert wrote: > aaronpuchert wrote: > > tbaeder wrote: > > > This handles

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. Note that I have confirmed that all the change attributes require a StringLiteral and go through `checkStringLiteralArgumentAttr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 535356. cor3ntin added a comment. revert accidental changes to cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/check

[clang] 98390cc - [Clang] Reset FP options before function instantiations

Author: Serge Pavlov Date: 2023-06-28T20:11:54+07:00 New Revision: 98390ccb80569e8fbb20e6c996b4b8cff87fbec6 URL: https://github.com/llvm/llvm-project/commit/98390ccb80569e8fbb20e6c996b4b8cff87fbec6 DIFF: https://github.com/llvm/llvm-project/commit/98390ccb80569e8fbb20e6c996b4b8cff87fbec6.diff

[PATCH] D143241: [Clang] Reset FP options before function instantiations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98390ccb8056: [Clang] Reset FP options before function instantiations (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:356 + Member = cast(I); + MemberLoc = &cast(MemberLoc)->getChild(*Member); +} gribozavr2 wrote: > I

[PATCH] D153854: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153854/new/ https://reviews.llvm.org/D153854 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. In D153960#4455661 , @gribozavr2 wrote: > Using PointerValue to model pointers to data members does not look right to > me, because a pointer to data member is an offset within an object that we > apply this pointer to, it is n

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:236 +// `DeclRefExpr`s to fields and non-static methods aren't glvalues, and +// there's also no sensible `Value` we can assign to them, so s

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, erichkeane, shafik, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch fixes the reported regression caused by D146358

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam updated this revision to Diff 535368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c clang/test/Sema/fp-eval-pra

[PATCH] D105759: Implement P2361 Unevaluated string literals

erichkeane added a comment. Just 2 small nits, otherwise this all LGTM. Comment at: clang/lib/Parse/ParseDecl.cpp:430 +} +if (Expr.isInvalid()) { + SawError = true; Please put a newline between unchained 'if' statements... it makes tehse really ha

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2379 if (!Value.hasValue()) { assert(SubobjectDecl && "SubobjectDecl shall be non-null"); Info.FFDiag(DiagLoc, diag::note_constexpr_uninitialized) << SubobjectDecl; The reaso

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. In D153667#4450724 , @jhuber6 wrote: > In D153667#4450705 , @jrbyrnes > wrote: > >> In D153667#4450517 , @jhuber6 >> wrote: >> >>> What's the dif

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

asb updated this revision to Diff 535372. asb edited the summary of this revision. asb added a comment. Herald added a subscriber: wangpc. Update to 1.0-rc1 (no code changes needed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149248/new/ https://reviews.llvm.org/D149248 Files: cla

[PATCH] D153909: [AMDGPU] Always pass `-mcpu` to the `lld` linker

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153909/new/ https://reviews.llvm.org/D153909 ___

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 535373. cor3ntin added a comment. Address Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modern

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. friendly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. In D153667#4455943 , @yaxunl wrote: > For -fno-gpu-rdc case we do not use lto. Since -fno-gpu-rdc has one TU only, > we use the non-lto backend to get relocatable object, and use lld for > relocatable to shared object. This patc

[clang] 7653011 - [AMDGPU] Always pass `-mcpu` to the `lld` linker

Author: Joseph Huber Date: 2023-06-28T08:52:37-05:00 New Revision: 765301183f58a28af65b112db44218dc224b9fec URL: https://github.com/llvm/llvm-project/commit/765301183f58a28af65b112db44218dc224b9fec DIFF: https://github.com/llvm/llvm-project/commit/765301183f58a28af65b112db44218dc224b9fec.diff

[PATCH] D153909: [AMDGPU] Always pass `-mcpu` to the `lld` linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG765301183f58: [AMDGPU] Always pass `-mcpu` to the `lld` linker (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor issues, thank you! Comment at: clang/docs/ReleaseNotes.rst:98 +- Implemented `P1816R0: `_ and `P2082R1: `_, + which allows CTA

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603 +// deallocation call of __kmpc_free_shared() is emitted later. +if (getLangOpts().OpenMP && getTarget().getTriple().isAMDGCN()) { + // Emit call to __kmpc_alloc_shared() instead of the all

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

aaronpuchert added a comment. Tried this on our code base, and the number of new warnings seems acceptable. I'll still need to look through them in more detail, but there is one suspicious warning that boils down to this: > cat reference-bug.cpp struct __attribute__((capability("mutex"))) M

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added a comment. After implementation of D142001 and D143241 this patch is not neded anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:878 - if (!isIntOrBool(AL.getArgAsExpr(0))) { + Expr *First = AL.getArgAsExpr(0); + if (!isIntOrBool(First)) { erichkeane wrote: > Unrelated change here? What is this for? Some test

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. @sdesmalen Could you take a look at the patch stack again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits mailing lis

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 535389. azhan92 added a comment. Herald added subscribers: JDevlieghere, jdoerfert. Remove unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files:

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Oh wow, nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153890/new/ https://reviews.llvm.org/D153890

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks. These seem like important issues to fix. should we make a github issue to track them? Comment at: clang/test/CXX/drs/dr17xx.cpp:10 +namespace dr1710 { // dr1710:

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603 +// deallocation call of __kmpc_free_shared() is emitted later. +if (getLangOpts().OpenMP && getTarget().getTriple().isAMDGCN()) { + // Emit call to __kmpc_alloc_shared() instead of the alloc

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 535397. ymandel added a comment. Rebase and address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files: clang/include/clang/Analysis/Analyses/Inte

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme updated this revision to Diff 535401. mboehme marked an inline comment as done. mboehme added a comment. Don't produce values for pointers to members. For consistency, also make the NullToMemberPointer cast not produce any values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. PTAL Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:447 - StorageLocation *PointeeLoc = Env.getStorageLocationStrict(*SubExpr); - if (PointeeLoc == nullptr) break; While I'm here, streamline the code for th

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 535402. ymandel added a comment. Address more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files: clang/include/clang/Analysis/Analyses/IntervalPartiti

  1   2   3   >