xazax.hun added a comment.
Could you rebase this patch to the latest tip of tree?
================
Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:73
+
+ // Whether this node is the head of a feedback edge within the interval.
+ bool IsFeedbackHead = false;
----------------
Is feedback edge a special terminology? I think we might simply call these back
edges most of the time.
================
Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:83
-// Partitions `Cfg` into intervals and constructs a graph of the intervals,
+// Partitions `Cfg` into intervals and constructs a the graph of the intervals
// based on the edges between nodes in these intervals.
----------------
typo?
================
Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:87
+
+// (Further) partitions `Graph` into intervals and constructs a the graph of
the
+// intervals based on the edges between nodes (themselves intervals) in these
----------------
same typo here?
================
Comment at: clang/lib/Analysis/IntervalPartition.cpp:23-25
+namespace {
+template <typename Node> using NodeData = CFGInterval::NodeData<Node>;
+} // namespace
----------------
What is the reason for putting a using statement in an anonymous namespace?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153058/new/
https://reviews.llvm.org/D153058
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
