[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan created this revision. Herald added subscribers: kbarton, hiraditya, nemanjai. Herald added a project: All. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; NoQ wrote: > ziqingluo-90 wrote: >

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; HaohaiWen wrote: > skan wrot

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. Tests seem mostly fine, but since this is the primary patch for a major feature, consider adding more descriptions how this works? For example, you can add something like the following to the summary/commit message, which should make a curious reader know how to play wi

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2293 +// search of connected components. +if (!ParmsNeedFix.empty()) { + auto First = ParmsNeedFix.begin(), Last = First; ziqingluo-90 wrote: > NoQ wrote: > > ziqing

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4893 + // Stop evaluate if E is a RecoveryExpr. + if (isa(E)) +return false; yronglin wrote: > erichkeane wrote: > > I'd probably suggest `E->containsErrors()` instead, to cover case

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ddpagan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9823 +def err_omp_loop_reduction_clause : Error< + "reduction clause not handled with '#pragma omp loop bind(teams)'">; def warn_break_binds_to_switch : Warning< Should

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4988 + if (SS->getCond()->containsErrors() || + !EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed; yronglin wrote: > erichkeane wrote: > > It seems to me

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added a comment. I am wondering why we don't fold this into `-Wreserved-identifier` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:56 + NotStartsWithUnderscore, + ContainsDoubleUnderscore, +}; I would think starting with a double underscore would also not be allowed, at least that is my reading. CHANGE

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4989 if (SS->getCond()->isValueDependent()) { if (!EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed; As far as I can tell `Value` will still not be set if w

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/fuchsia/GlobalVariablesCheck.cpp:26 +void GlobalVariablesCheck::registerMatchers(MatchFinder *Finder) { + const auto is_global_or_static_candidate = + allOf(hasGlobalStorage(), isDefinition(), unless(i

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4003-4004 + // that are not referenced or used later. e.g.: if (int var = init()); + ConditionVar->setReferenced(false); + ConditionVar->setIsUsed(false); + Repository: rG LLVM Githu

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:123 {"xsfvcp", RISCVExtensionVersion{1, 0}}, +{"xsfcie", RISCVExtensionVersion{1, 0}}, {"xtheadba", RISCVExtensionVersion{1, 0}}, Alphabetize. Comme

[clang] efbb4aa - [clang][dataflow] Dump useful debugging information when we crash.

Author: Martin Braenne Date: 2023-06-23T06:49:28Z New Revision: efbb4aaacedf0ded734d0b40c42d4419d03a59ff URL: https://github.com/llvm/llvm-project/commit/efbb4aaacedf0ded734d0b40c42d4419d03a59ff DIFF: https://github.com/llvm/llvm-project/commit/efbb4aaacedf0ded734d0b40c42d4419d03a59ff.diff LOG

[PATCH] D153549: [clang][dataflow] Dump useful debugging information when we crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefbb4aaacedf: [clang][dataflow] Dump useful debugging information when we crash. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153549/

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153001/new/ https://reviews.llvm.org/D153001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

<    1   2   3