MaskRay added inline comments.
================ Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 + // Each section in COFF can directly contain relocations. + if (isa<COFFObjectFile>(&Obj) && Section.relocations().empty()) + continue; ---------------- HaohaiWen wrote: > skan wrote: > > Should we merge the check into line 1894? > It's more elegant to not merge. D153602 should make this change unneeded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
