[clang] 8feb842 - [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

Author: eopXD Date: 2023-06-08T09:37:07-07:00 New Revision: 8feb8423602351afa190f88977f71444cf15304f URL: https://github.com/llvm/llvm-project/commit/8feb8423602351afa190f88977f71444cf15304f DIFF: https://github.com/llvm/llvm-project/commit/8feb8423602351afa190f88977f71444cf15304f.diff LOG: [C

[PATCH] D152429: [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8feb84236023: [Clang][Type] Add static assertion to guard future expansion for BuiltinType… (authored by eopXD). Repository: rG LLVM Github Monore

[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits

eopXD updated this revision to Diff 529640. eopXD added a comment. Rebase upon landing of D152429 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152069/new/ https://reviews.llvm.org/D152069 Files: clang/include

[clang] bf87fcb - [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits

Author: eopXD Date: 2023-06-08T09:41:32-07:00 New Revision: bf87fcb799aacb426a92f7fc643da2dc2b3fa82d URL: https://github.com/llvm/llvm-project/commit/bf87fcb799aacb426a92f7fc643da2dc2b3fa82d DIFF: https://github.com/llvm/llvm-project/commit/bf87fcb799aacb426a92f7fc643da2dc2b3fa82d.diff LOG: [1

[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf87fcb799aa: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 9 bits (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl updated this revision to Diff 529644. yaxunl added a comment. warn if users try to enable/disable image-insts and do not emit image-insts as function attributes in IR CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151349/new/ https://reviews.llvm.org/D151349 Files: clang/inclu

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 529651. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D152303: [ExprConstant] fix ICE from Evaluate on _Atomic structs

nickdesaulniers updated this revision to Diff 529652. nickdesaulniers added a comment. - add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152303/new/ https://reviews.llvm.org/D152303 Files: clang/docs/ReleaseNotes.rst clang/lib/A

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(), Addr.isKnownNonNull(

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 529658. Sinitax added a comment. Rename warning to -Wincomplete-array-initializer-list for clarity, and add test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: include/clang/Basic/Diagnost

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:2123 + +def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone, "", [], [ImmCheck<3, ImmCheck0_15>]>; +def SVPSEL_COUNT_ALIAS_H : SInst<"svpsel_lane_c16", "}}Pmi", "Ps", Mer

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529667. scchan added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp clang/test/Driver/hip-toolcha

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 updated this revision to Diff 529663. MineGame159 added a comment. I have added the new functions into the file and now it successfully compiles the test but fails when running it. Also checked and made sure that `CINDEX_VERSION_MINOR` was already incremented in LLVM 17. Another thi

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 529671. Sinitax added a comment. Rebased changes onto commit tagged 'llvmorg-17-init', and added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: docs/ReleaseNotes.rst include/clan

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax added a comment. > Why do you make this a new warning group instead of just adding it to > -Wuninitialized? I think a separate group is best, since the warning emits false positives: an intentional empty-initialization (such as `char buf[BUF_SIZ] = { 0 }`) is indistinguishable from uni

[clang] 66d4dba - HIP: Directly call fmin/fmax builtins

Author: Matt Arsenault Date: 2023-06-08T13:49:40-04:00 New Revision: 66d4dbae02db2c0feb32ea844500f9758f078dd7 URL: https://github.com/llvm/llvm-project/commit/66d4dbae02db2c0feb32ea844500f9758f078dd7 DIFF: https://github.com/llvm/llvm-project/commit/66d4dbae02db2c0feb32ea844500f9758f078dd7.diff

[PATCH] D138395: HIP: Directly call fmin/fmax builtins

arsenm closed this revision. arsenm added a comment. 66d4dbae02db2c0feb32ea844500f9758f078dd7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138395/new/ https://reviews.llvm.org/D138395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 382550b - [Clang][RISCV] Adjust naming from `DeclareRISCVVectorBuiltins` to `DeclareRISCVSiFiveVectorBuiltins`. NFC

Author: eopXD Date: 2023-06-08T10:55:01-07:00 New Revision: 382550bf334b178f078c694b5e7331f6c7881f5e URL: https://github.com/llvm/llvm-project/commit/382550bf334b178f078c694b5e7331f6c7881f5e DIFF: https://github.com/llvm/llvm-project/commit/382550bf334b178f078c694b5e7331f6c7881f5e.diff LOG: [C

[PATCH] D152461: [LTO] Add a config option to make the final output bitcode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, MaskRay, fhahn, tra, yaxunl, JonChesterfield, tianshilei1992. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added proje

[PATCH] D152461: [LTO] Add a config option to make the final output bitcode

jhuber6 updated this revision to Diff 529682. jhuber6 added a comment. Remove leftover debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152461/new/ https://reviews.llvm.org/D152461 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cp

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

craig.topper added a comment. Do we need to check the immediate range in SemaChecking.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 ___ cfe-commits maili

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D152070 ___

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

craig.topper added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:730 } + case VectorTypeModifier::Tuple3: { +IsTuple = true; Could maybe merge these into a single case body and use math to compute NF? Repository: rG LLVM Gith

[PATCH] D152071: [3/11][Clang][RISCV] Expand all variants for unit stride segment load

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152071/new/ https://reviews.llvm.org/D152071 ___

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD updated this revision to Diff 529686. eopXD marked an inline comment as done. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D152070 Files: clang/includ

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(), Addr.isKnownNonNull())

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1401 +return getTriple().isX86() || getTriple().isAArch64() || + getTriple().isRISCV(); } Is this needed for target attribute? The description to me reads like

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 updated this revision to Diff 529691. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150910/new/ https://reviews.llvm.org/D150910 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h clang/include/clang/AST/OperationKinds.def clang/tools/libclang/CIndex.cpp

[clang] b51ae6d - HIP: Directly call signbit builtins

Author: Matt Arsenault Date: 2023-06-08T15:22:43-04:00 New Revision: b51ae6d31f86de2e47b1912eb045ea37a0c5de23 URL: https://github.com/llvm/llvm-project/commit/b51ae6d31f86de2e47b1912eb045ea37a0c5de23 DIFF: https://github.com/llvm/llvm-project/commit/b51ae6d31f86de2e47b1912eb045ea37a0c5de23.diff

[PATCH] D138396: HIP: Directly call signbit builtins

arsenm closed this revision. arsenm added a comment. b51ae6d31f86de2e47b1912eb045ea37a0c5de23 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138396/new/ https://reviews.llvm.org/D138396 __

[clang] d14ac1d - HIP: Directly call isinf builtins

Author: Matt Arsenault Date: 2023-06-08T15:25:01-04:00 New Revision: d14ac1d11a5cb3994c63ecaaa5c950636a289fa1 URL: https://github.com/llvm/llvm-project/commit/d14ac1d11a5cb3994c63ecaaa5c950636a289fa1 DIFF: https://github.com/llvm/llvm-project/commit/d14ac1d11a5cb3994c63ecaaa5c950636a289fa1.diff

[PATCH] D138399: HIP: Directly call isinf builtins

arsenm closed this revision. arsenm added a comment. d14ac1d11a5cb3994c63ecaaa5c950636a289fa1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138399/new/ https://reviews.llvm.org/D138399 __

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138504/new/ https://reviews.llvm.org/D138504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Yep, thanks. Anything under __llvm is fair game to change and there's a find& replace fix for anything that decided to call these directly. CHANGES SINCE LAST ACTION https

[clang] 31dfd2b - HIP: Directly call isnan builtin

Author: Matt Arsenault Date: 2023-06-08T16:08:24-04:00 New Revision: 31dfd2b99ce31ae076aa35867dbede052693a6c9 URL: https://github.com/llvm/llvm-project/commit/31dfd2b99ce31ae076aa35867dbede052693a6c9 DIFF: https://github.com/llvm/llvm-project/commit/31dfd2b99ce31ae076aa35867dbede052693a6c9.diff

[clang] 4524a31 - HIP: Directly call copysign builtins

Author: Matt Arsenault Date: 2023-06-08T16:16:11-04:00 New Revision: 4524a3159e8407d2b453293eff694f3a1534462d URL: https://github.com/llvm/llvm-project/commit/4524a3159e8407d2b453293eff694f3a1534462d DIFF: https://github.com/llvm/llvm-project/commit/4524a3159e8407d2b453293eff694f3a1534462d.diff

[clang] 9daab7f - [ExprConstant] fix ICE from Evaluate on _Atomic structs

Author: Nick Desaulniers Date: 2023-06-08T13:20:24-07:00 New Revision: 9daab7fb02d2a7340dbc78d15d248ef9aaf1214c URL: https://github.com/llvm/llvm-project/commit/9daab7fb02d2a7340dbc78d15d248ef9aaf1214c DIFF: https://github.com/llvm/llvm-project/commit/9daab7fb02d2a7340dbc78d15d248ef9aaf1214c.di

[PATCH] D152303: [ExprConstant] fix ICE from Evaluate on _Atomic structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9daab7fb02d2: [ExprConstant] fix ICE from Evaluate on _Atomic structs (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152303/new

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik updated this revision to Diff 529714. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152335/new/ https://reviews.llvm.org/D152335 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclAttr.cpp clang/test/Sema/attr-aligned.c I

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG086183c6c65f: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of… (authored by shafik). Herald added a project: clang. Ch

[clang] 086183c - [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

Author: Shafik Yaghmour Date: 2023-06-08T13:53:33-07:00 New Revision: 086183c6c65fc8106b8cae99af95c4974b975f51 URL: https://github.com/llvm/llvm-project/commit/086183c6c65fc8106b8cae99af95c4974b975f51 DIFF: https://github.com/llvm/llvm-project/commit/086183c6c65fc8106b8cae99af95c4974b975f51.dif

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. Overall looks good with few minor nits and a couple of questions. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:604 def int_nvvm_f # operation # variant : ClangBuiltin, DefaultAttrsIntrinsic<[llvm_i16_ty], [llvm_i16_ty, llvm_i1

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 529732. nickdesaulniers retitled this revision from "[clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first" to "[clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first". nick

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Squashed up into https://reviews.llvm.org/D151587. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151572/new/ https://reviews.llvm.org/D151572 ___

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. In D152279#4405901 , @asb wrote: > One of the key things we've been discussing on this at the LLVM call is that > we probably want to keep the small data limit for embedded targets. It'd be useful to hear from some concrete embe

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu created this revision. zequanwu added a reviewer: rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This assertion triggered when we have two base classes sharing the same offset and the fir

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDi

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai updated this revision to Diff 529735. vsapsai added a comment. Use different check for nullptr + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151523/new/ https://reviews.llvm.org/D151523 Files: clang/lib/AST/ASTStructuralEquival

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:266 + + // Sort and remove duplicates + std::sort(Result.begin(), Result.end()); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

HazardyKnusperkeks added a comment. Can you add a note to the release notes also please? Comment at: clang/include/clang/Format/Format.h:3709 + /// \version 17 + bool SpaceAfterOperatorKeyword; + O before T, please resort. Comment at: clang

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

rnk added a comment. Please do extend the simple record layout dumping format. I think it should be relatively simple to add string dumping and parsing to clang/lib/Frontend/LayoutOverrideSource.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai added a comment. In D151523#4396010 , @ahatanak wrote: > In D151523#4374808 , @vsapsai wrote: > >> Kinda a follow-up to D121176 . >> >> One big alternative that I've consi

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth created this revision. paulkirth added a reviewer: owenpan. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. paulkirth requested review of this revision. Herald added a comment. NO

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex added a comment. In D152443#4406923 , @HazardyKnusperkeks wrote: > Can you add a note to the release notes also please? Of course! Doing that right now :) Another thing i was wondering was if it would make sense to add a separate option fo

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 529747. akhuang added a comment. - move call operator emission into the path in `GenerateCode` - formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: c

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 529750. akhuang added a comment. remove print statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added a comment. In D137872#4357268 , @efriedma wrote: > In D137872#4348314 , @akhuang wrote: > >> In D137872#4327615 , @efriedma >> wrote: >> >>> I'm having a bi

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 529755. akhuang added a comment. more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/CodeGe

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu updated this revision to Diff 529757. zequanwu added a comment. Herald added subscribers: ChuanqiXu, mgrang. Extend the output and reading of -fdump-record-layouts-simple. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15247

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Looks good as long as people are happy with the condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151523/new/ https://reviews.llvm.

[PATCH] D152485: Fix regex in test case so that it doesn't match "coverage" in directory names

ahatanak created this revision. ahatanak added reviewers: tra, MaskRay. ahatanak added a project: clang. Herald added a subscriber: wenlei. Herald added a project: All. ahatanak requested review of this revision. The test case was failing because "-f{{[^"]*coverage.*}}" was matching the following

[PATCH] D152485: Fix regex in test case so that it doesn't match "coverage" in directory names

ahatanak added a comment. Example of the test failing: https://green.lab.llvm.org/green/job/coverage/467/consoleText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152485/new/ https://reviews.llvm.org/D152485 __

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 529780. akhuang added a comment. Fix ordering in the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529788. KitsuneAlex added a comment. Applied all suggested changes and added a suiting option for aformentioned edge-case for call expressions. Also added the missing release notes to the apropriate section. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529794. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529795. alexander-shaposhnikov marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp c

[PATCH] D132275: [clang] Create alloca to pass into static lambda

leonardchan added a comment. Ok here's some of my findings. So there's a step in the attributor where it replaces some instructions with `unreachable`. One step is: *** IR Dump Before AttributorPass on [module] *** ; Function Attrs: inlinehint minsize nounwind optsize define linkonce_odr d

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529798. KitsuneAlex added a comment. Some additional changes because i exceeded the maximum line width on multiple occasions. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to clang/include/clang

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } --

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529799. KitsuneAlex added a comment. I had some issues with Git there because i messed up a merge, so the diff was bad. Here's the proper diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ htt

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529801. alexander-shaposhnikov added a comment. Add missing parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaTyp

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529804. KitsuneAlex added a comment. Clean up the formatting with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443 Files: clang/docs/ClangFormatSty

[PATCH] D151634: [clang] Add test for CWG253

shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is Endill wrote: > shafik wrote: > > shafi

[clang] 60eb1da - [Modules] [Sema] Don't try to getAcceptableDecls during the iteration of noload_lookups

Author: Chuanqi Xu Date: 2023-06-09T11:32:06+08:00 New Revision: 60eb1da315559a9e20f9bf502fd10ba68f6d4085 URL: https://github.com/llvm/llvm-project/commit/60eb1da315559a9e20f9bf502fd10ba68f6d4085 DIFF: https://github.com/llvm/llvm-project/commit/60eb1da315559a9e20f9bf502fd10ba68f6d4085.diff LO

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added inline comments. Comment at: clang/test/SemaTemplate/aggregate-deduction-candidate.cpp:101 + + template struct E { +T t; I would also like to see this test: ``` template struct I { using type = T; }; template struct E { typename I::type

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 529818. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Cl

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines to show in a caret diagnostic">, + MarshallingInfoInt, "DiagnosticOptions::Default

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. > Add -fcaret-diagnostics-max-lines as a driver option `-fcaret-diagnostics-max-lines=` is more accurate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mai

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

dyung added a comment. If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add a negative for that? Or if we do a positive test for it as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 _

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/Driver/caret-diagnostics-max-lines.cpp:1 +//RUN: not %clang++ -fsyntax-only -fcaret-diagnostics-max-lines=2 %s 2>&1 | FileCheck %s -strict-whitespace + MaskRay wrote:

[PATCH] D132275: [clang] Create alloca to pass into static lambda

efriedma added a comment. > The first argument in the call is an undef but the argument type is also > marked as noundef, so this is unreachable It looks like your code was getting miscompiled? If I'm understanding correctly, without this patch, we assume the lambda body is unreachable, and s

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch marks the declarations with initializations in condition expressions such as `if (int var

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 529832. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/caret-diagnost

<    1   2