[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2348 + llvm::sys::Process::GetEnv("NO_COLOR"); + NoColor && !NoColor->empty() && NoColor->at(0) != '\0') { +// If the user set the NO_COLOR environment variable, we'll honor th

[PATCH] D152285: Add support for the NO_COLOR environment variable

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2348 + llvm::sys::Process::GetEnv("NO_COLOR"); + NoColor && !NoColor->empty() && NoColor->at(0) != '\0') { +// If the user set the NO_COLOR environment variable, we'll honor tha

[PATCH] D152285: Add support for the NO_COLOR environment variable

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2348 + llvm::sys::Process::GetEnv("NO_COLOR"); + NoColor && !NoColor->empty() && NoColor->at(0) != '\0') { +// If the user set the NO_COLOR environment variable, we'll honor tha

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529311. scchan added a comment. fix some formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp clang/test/

[PATCH] D152207: [HIP] Instruct lld to go through all archives

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165 + // --whole-archive flag such that all global symbols would be linked in. + LldArgs.push_back("--whole-archive"); + Though not strictly required, it's usually better to end `

[PATCH] D152285: Add support for the NO_COLOR environment variable

jhasse added a comment. In D152285#4403031 , @aaron.ballman wrote: > In D152285#4401348 , @MaskRay wrote: > >> If we don't intend to support both standards, we can close >> https://github.com/llvm/llvm-project/i

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. Can we use this approach for now and land this? It makes the "new driver" less broken than it currently is as it supports target ID compilation in the general term. Fixing the merging rules will be a rather large overhaul so I'd like this to work in the meantime. This

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529312. massberg added a comment. Fix formatting (once again). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files: clang/include/clang/Sema/Sema.h clang/lib/S

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529313. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rename option and support fewer options as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529315. michaelplatings marked an inline comment as done. michaelplatings added a comment. Change string literal as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https:/

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529316. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529317. JOE1994 added a comment. If `getPointerTo()` is used just to support an unnecessary bitcast, just get rid of the bitcast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529318. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246 + // No multilibs selected so return a single default multilib. + static llvm::SmallVector Default = {Multilib()}; + return llvm::iterator_range< + llvm::SmallVector::cons

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added a comment. In D150998#4403359 , @jhuber6 wrote: > Can we use this approach for now and land this? It makes the "new driver" > less broken than it currently is as it supports target ID compilation in the > general term. Fixing the merging ru

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

steakhal added a comment. In D152269#4403282 , @tripleCC wrote: > Yes, your changes are aligned with my intent. It seems like you have made > excellent optimizations to this patch. > To eliminate the following two warnings, I add the `-fobjc-arc`(enable

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. In D150998#4403401 , @yaxunl wrote: > In D150998#4403359 , @jhuber6 wrote: > >> Can we use this approach for now and land this? It makes the "new driver" >> less broken than it currently

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper added a comment. Ping * 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150926/new/ https://reviews.llvm.org/D150926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added a comment. In D150998#4403416 , @jhuber6 wrote: > In D150998#4403401 , @yaxunl wrote: > >> In D150998#4403359 , @jhuber6 >> wrote: >> >>> Can we use this app

[PATCH] D152285: Add support for the NO_COLOR environment variable

aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. In D152285#4403357 , @jhasse wrote: > In D152285#4403031 , @aaron.ballman > wrote: > >> In D152285#4401348

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. In D150998#4403444 , @yaxunl wrote: > what happens to > > clang -xhip a.c --offload-arch=gfx90a:xnack+ --offload-arch=gfx90a:xnack- > --offload-new-driver -fgpu-rdc > clang -xhip b.c --offload-arch=gfx90a:xnack+ --offload-arc

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin accepted this revision. cor3ntin added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152285/new/ https://reviews.llvm.org/D152285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] da0a7d5 - Add support for the NO_COLOR environment variable

Author: Aaron Ballman Date: 2023-06-07T11:55:06-04:00 New Revision: da0a7d5cfb0c65bcb54a1ba5ed6c93bb906648e4 URL: https://github.com/llvm/llvm-project/commit/da0a7d5cfb0c65bcb54a1ba5ed6c93bb906648e4 DIFF: https://github.com/llvm/llvm-project/commit/da0a7d5cfb0c65bcb54a1ba5ed6c93bb906648e4.diff

[PATCH] D152285: Add support for the NO_COLOR environment variable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaron.ballman marked an inline comment as done. Closed by commit rGda0a7d5cfb0c: Add support for the NO_COLOR environment variable (authored by aaron.ballman). Changed

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC added a comment. In D152269#4403404 , @steakhal wrote: > In D152269#4403282 , @tripleCC > wrote: > >> Yes, your changes are aligned with my intent. It seems like you have made >> excellent optimizations

[clang] 0a7ca80 - Fix parameter name in Sema::addInitCapture to ByRef.

Author: Jens Massberg Date: 2023-06-07T18:06:19+02:00 New Revision: 0a7ca80360584ff35cb58716e08855a913a3f4d0 URL: https://github.com/llvm/llvm-project/commit/0a7ca80360584ff35cb58716e08855a913a3f4d0 DIFF: https://github.com/llvm/llvm-project/commit/0a7ca80360584ff35cb58716e08855a913a3f4d0.diff

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a7ca8036058: Fix parameter name in Sema::addInitCapture to ByRef. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https:/

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. FYI, I'm not actively working on this, I did mess around with it a bit https://github.com/cor3ntin/llvm-project/commit/478ff7f1aa7a4046fa8b293dfb86489b930a but I'm extremely unfamiliar with that part of clang and i have no clue how to write tests. Feel free to take

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

tahonermann added a comment. > I wrote a paper https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3124.pdf It appears you back ported that paper from the future: "Date: 2024-22-04" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146924/new/ https:

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4484 + if (!TooManyActiveBits) { +AlignVal = Alignment.getZExtValue(); +// C++11 [dcl.align]p2: erichkeane wrote: > So looking more closely, THIS is the problem right here.

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

aaron.ballman accepted this revision. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please wait a day or so to land this in case @rjmccall disagrees with my assessment of the Objective-C changes. ===

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. Some tests that run with `-no-opaque-pointers` began failing after I updated the revision to get rid of bitcasts. The bitcasts are still needed if running Clang with `-no-opaque-pointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. This triggered an MSAN error: https://lab.llvm.org/buildbot/#/builders/237/builds/3127/steps/13/logs/stdio 1: ==1184292==WARNING: MemorySanitizer: use-of-uninitialized-value check:6'0 X~~~ er

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150998/new/ https://reviews.llvm.org/D150998 __

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. Thank you very much! I'm aware and currently trying to reproduce it locally and fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 _

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5201-5204 + if (auto EC = sys::fs::getUniqueID(FileName, ID)) { +assert(EC && + "Unable to get unique ID for file, during getTargetEntryUniqueInfo"); + } This loo

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5201-5204 + if (auto EC = sys::fs::getUniqueID(FileName, ID)) { +assert(EC && + "Unable to get unique ID for file, during getTargetEntryUniqueInfo"); + } fmaye

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. In D151761#4400693 , @HazardyKnusperkeks wrote: > In D151761#4400056 , @galenelias > wrote: > >> In D151761#4394758 , >> @MyDeveloperDay wro

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 529365. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529366. scchan added a comment. added a matching --no-whole-archive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp c

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Regarding the failing `Modules/crash-vfs-umbrella-frameworks.m` test, this is my understanding after debugging it. Whenever we find that `A.framework/Frameworks/B.framework` is a symlink, we treat `B` as a separate to

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 updated this revision to Diff 529367. jansvoboda11 added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151855/new/ https://reviews.llvm.org/D151855 Files: clang/include/clang/Lex/HeaderSearch.h clang/in

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2350 + +``vbool*_t`` types are not supported at this time. }]; Do you have test coverage that demonstrates this? Comment at: clang/lib/AST/Type.cpp:2437

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

benlangmuir added a subscriber: JDevlieghere. benlangmuir added a comment. > I think it should be fine to allow dropping the > A.framework/Frameworks/B.framework directory from the reproducer VFS I think technically this is wrong, since if you're missing the symlink, then A might not build -- e

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman added a comment. In D152351#4402785 , @arsenm wrote: > Also should get mentioned in the builtin docs and release notes +1, also, should there be named constants for the mask values? Comment at: clang/include/clang/Basic/

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. This patch seems to introduce some significant regressions to formatting. I've filed https://github.com/llvm/llvm-project/issues/63170 with some candidate code. I'll try to reduce the case as I can, but I'm guessing something is incorrect w/ how the indentation level

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. I'd also suggest reverting this until it can be fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-commits mailing list cf

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. In D151855#4403879 , @benlangmuir wrote: >> I think it should be fine to allow dropping the >> A.framework/Frameworks/B.framework directory from the reproducer VFS > > I think technically this is wrong, since if you're miss

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

phosek added a comment. We're planning to default to `-msmall-data-limit=0` for Android and Fuchsia so I'm supportive of this change because it means less complexity and fewer differences between platforms. I think it would be worth bringing up this topic at the RISC-V LLVM sync-up call tomorr

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, tianshilei1992, MaskRay, JonChesterfield, phosek. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang provides the `-mli

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

asb added a comment. In D152279#4403940 , @phosek wrote: > We're planning to default to `-msmall-data-limit=0` for Android and Fuchsia > so I'm supportive of this change because it means less complexity and fewer > differences between platforms. > > I t

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

JonChesterfield added a comment. That's cleaner than I expected, thanks. Might be reasonable to factor out the method as an initial NFC then insert the call to it along with the new test case as the functional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D152207: [HIP] Instruct lld to go through all archives

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:184 + // pair with the --whole-archive being added previously + LldArgs.push_back("--no-whole-archive"); For complete sentences in comments, capitalize and add a full stop. Act

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. Thanks for the review and the testing! >> [...] What do you think about this design direction? > > Could you elaborate on this part? In short, this review should've been a discourse thread about my "switch to the PreStmt route" plan: I wanted to ask for architectural

[clang] 4676885 - [clang] Implement P2564 "consteval must propagate up"

Author: Corentin Jabot Date: 2023-06-07T20:45:36+02:00 New Revision: 467688527017efb611b09c0cbf92f2d3ecdd1724 URL: https://github.com/llvm/llvm-project/commit/467688527017efb611b09c0cbf92f2d3ecdd1724 DIFF: https://github.com/llvm/llvm-project/commit/467688527017efb611b09c0cbf92f2d3ecdd1724.diff

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

This revision was automatically updated to reflect the committed changes. Closed by commit rG467688527017: [clang] Implement P2564 "consteval must propagate up" (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https:

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan added a comment. In D151954#4403921 , @paulkirth wrote: > This patch seems to introduce some significant regressions to formatting. > I've filed https://github.com/llvm/llvm-project/issues/63170 with some > candidate code. I'll try to reduce the

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik updated this revision to Diff 529396. shafik marked 2 inline comments as done. shafik added a comment. - Switched to using APSInt::operator> as discussed offline w/ Erich and Aaron CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152335/new/ https://reviews.llvm.org/D152335 Files:

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/test/Sema/attr-aligned.c:1 -// RUN: %clang_cc1 -triple i386-apple-darwin9 -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only -verify %s

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

tra added a comment. > clang in.bc -Xclang -mlink-builtin-bitcode -Xclang libdevice.10.bc If that's something we intend to expose to the user, should we consider promoting it to a top-level driver option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. In D152391#4404106 , @tra wrote: >> clang in.bc -Xclang -mlink-builtin-bitcode -Xclang libdevice.10.bc > > If that's something we intend to expose to the user, should we consider > promoting it to a top-level driver option? I'm

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Needs a release note. Also, the changing of order is POSSIBLY a change in behavior (in that we're now diagnosing 'out of range' before 'power of 2'), but I don't think we care. CHAN

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a release note. In D152335#4404114 , @erichkeane wrote: > Needs a release note. Also, the changing of order is POSSIBLY a change in > behavior (in that we're now diagnosing

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane added a comment. In D152335#4404118 , @aaron.ballman wrote: > LGTM with a release note. > > In D152335#4404114 , @erichkeane > wrote: > >> Needs a release note. Also, the changing of order is POSSIBL

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

rjmccall added inline comments. Comment at: clang/test/SemaObjCXX/parameters.mm:14-17 +struct test2 { virtual void foo() = 0; }; @interface Test2 -- (void) foo: (test2) foo; // expected-error {{parameter type 'test2' is an abstract class}} +- (void) foo: (test2) foo ; @end ---

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDirective && Line.Level < IndentForLevel.size()) +IndentForLevel.resize(Line.Level + 1

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529400. scchan added a comment. Removed redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp clang/test

[clang] 3090232 - [Clang][OpenMP] Rework recently moved getTargetEntryUniqueInfo to fix incorrect error breaking sanitizer

Author: Andrew Gozillon Date: 2023-06-07T14:30:25-05:00 New Revision: 309023263dba3b02bc885101faa47d110f662f99 URL: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99 DIFF: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99.dif

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto lambda2 = [] {}; // expected-error {{default

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4403828 , @galenelias wrote: > In D151761#4400693 , > @HazardyKnusperkeks wrote: > >> I'd say: align it. > > If it was straightforward, I would definitely agree to

[clang] 6dc1636 - [Clang] Check for abstract parameters only when functions are defined.

Author: Corentin Jabot Date: 2023-06-07T21:44:14+02:00 New Revision: 6dc1636815cb9321657f1cb7ac87a46553870dc7 URL: https://github.com/llvm/llvm-project/commit/6dc1636815cb9321657f1cb7ac87a46553870dc7 DIFF: https://github.com/llvm/llvm-project/commit/6dc1636815cb9321657f1cb7ac87a46553870dc7.diff

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc1636815cb: [Clang] Check for abstract parameters only when functions are defined. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152096?vs=529045&id=529408#toc Repository

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8338 // The attribute vector size must match -mrvv-vector-bits. - if (VecSize != VScale->first * MinElts * EltSize) { + unsigned ExpectedSize = VScale->first * MinElts * EltSize; + if (VecSize != Ex

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152369/new/ https://reviews.llvm.org/D152369 _

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. I have hopefully fixed the sanitizer issue (the incorrect assert, thank you again for the catch) with the following patch: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99 it was a slightly more involved change than I expected, I ha

[PATCH] D73459: [ARM] Add documentation for -march= and -mfpu= command line options

efriedma reopened this revision. efriedma added a comment. This revision is now accepted and ready to land. Herald added a project: All. This patch was reverted by 9624beb38a46037f69362650a52e06d8be4fd006 . I have a patch pla

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

efriedma created this revision. efriedma added reviewers: serge-sans-paille, aaron.ballman. Herald added a subscriber: dschuff. Herald added a project: All. efriedma requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. Back when the command-line ref

[clang] d2627cf - [clang-format] Add the KeepEmptyLinesAtEOF option

Author: Owen Pan Date: 2023-06-07T14:17:58-07:00 New Revision: d2627cf88d2553a4c2e850430bdb908a4b7d2e52 URL: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52 DIFF: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52.diff LOG:

[PATCH] D152305: [clang-format] Add the KeepEmptyLinesAtEOF option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152305/new/ https://rev

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. In D149162#4404271 , @agozillon wrote: > I have hopefully fixed the sanitizer issue (the incorrect assert, thank you > again for the catch) with the following patch: > https://github.com/llvm/llvm-project/commit/309023263dba3b02b

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. Are there any other comments on this patch? I would love to make this into clang-17! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___ cfe-commits mailing list cfe-comm

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529444. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGen/pr53127

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These two tests were pretty challenging to manage by hand, and in rebasing the next change in my stack I finally ran out of

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529446. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529447. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-alig

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. durin42 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This allows us to remove most of the special knowledge

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Just realized this is probably going to be a bit more painful. the attribute propagation pass requires a `CodeGenModule` which isn't built without an `ASTContext` so it's not available here. Nothing those functions do explicitly requires the full `CGM`, they only use th

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: tra. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. alexander-shaposhnikov requested review of this re

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: MaskRay. For programs that don't use RTTI, the rtti component is just replace

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

mcgrathr added a comment. It's not clear from the change description if this can be enabled orthogonally to relative-vtables. I think it should be possible to choose each switch independently, thus generating 4 variants of the vtable layout ABI. Does any runtime code (libc++abi) ever need to kn

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Scratch that, `ASTContext::getFunctionFeatureMap` is used. I wonder if we could forgo that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 __

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. In D149162#4404379 , @fmayer wrote: > In D149162#4404271 , @agozillon > wrote: > >> I have hopefully fixed the sanitizer issue (the incorrect assert, thank you >> again for the catch)

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404596 , @mcgrathr wrote: > It's not clear from the change description if this can be enabled > orthogonally to relative-vtables. I think it should be possible to choose > each switch independently, thus generati

[clang] e3f91ac - Fix namespace of operator<< defn

Author: Sam McCall Date: 2023-06-08T01:36:59+02:00 New Revision: e3f91acad38e6637f1589bb4b33e9c4b8b58581f URL: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f DIFF: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f.diff LO

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

dblaikie added a comment. https://github.com/llvm/llvm-project/issues/63169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 ___ cfe-commits mailing list cfe-com

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } Should it be `AuxTI && (AuxTI->getTriple().isAArch64() || AuxTI->getTriple

[clang] 94e7546 - Revert "[clang-format] Fix overlapping replacements before PPDirectives"

Author: Leonard Chan Date: 2023-06-07T23:44:32Z New Revision: 94e75469597f197f9c4b45baa6c8a576c78dbd02 URL: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02 DIFF: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02.diff LOG:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( vikramRH wrote: > arse

<    1   2   3   >