aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/AttrDocs.td:2350
+
+``vbool*_t`` types are not supported at this time.
}];
----------------
Do you have test coverage that demonstrates this?
================
Comment at: clang/lib/AST/Type.cpp:2437
switch (BT->getKind()) {
// FIXME: Support more than LMUL 1.
#define RVV_VECTOR_TYPE(Name, Id, SingletonId, NumEls, ElBits, NF, IsSigned,
IsFP) \
----------------
FIXME is now stale and can be removed?
================
Comment at: clang/lib/Sema/SemaType.cpp:8338
// The attribute vector size must match -mrvv-vector-bits.
- if (VecSize != VScale->first * MinElts * EltSize) {
+ unsigned ExpectedSize = VScale->first * MinElts * EltSize;
+ if (VecSize != ExpectedSize) {
----------------
Random thought I didn't think to ask earlier: is it possible for this
multiplication to overflow (if so, we should add test coverage to make sure we
don't do bad things)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150926/new/
https://reviews.llvm.org/D150926
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
