[clang] edd7c13 - Silence C++17 extension diagnostics in test; NFC

Author: Aaron Ballman Date: 2023-06-05T11:32:50-04:00 New Revision: edd7c13dc3991c63e8b2347bcdc60014d366e16f URL: https://github.com/llvm/llvm-project/commit/edd7c13dc3991c63e8b2347bcdc60014d366e16f DIFF: https://github.com/llvm/llvm-project/commit/edd7c13dc3991c63e8b2347bcdc60014d366e16f.diff

[clang] 985f5af - Silence C++17 extension warnings; NFC

Author: Aaron Ballman Date: 2023-06-05T11:35:03-04:00 New Revision: 985f5afcd7e521c1c590312c2080387f2e518b3e URL: https://github.com/llvm/llvm-project/commit/985f5afcd7e521c1c590312c2080387f2e518b3e DIFF: https://github.com/llvm/llvm-project/commit/985f5afcd7e521c1c590312c2080387f2e518b3e.diff

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

SR_team updated this revision to Diff 528458. SR_team added a comment. - moved lambda `FormatSize` to static function `formatSize()`; - extracted offset format code to static function `formatOffset()`; - always shows bytes in offset (for offset 4 showed `Offset: 0 bytes and 4 bits`) - added rende

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528461. michaelplatings added a comment. Add variable specifically for the purpose of specifying whether or not FP regs are available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector &Features) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; --

[libunwind] 17b0d90 - [libunwind] Removes CMake work-arounds.

Author: Mark de Wever Date: 2023-06-05T17:42:37+02:00 New Revision: 17b0d90e20eed93bd55a57c614565e7c9fbae3b1 URL: https://github.com/llvm/llvm-project/commit/17b0d90e20eed93bd55a57c614565e7c9fbae3b1 DIFF: https://github.com/llvm/llvm-project/commit/17b0d90e20eed93bd55a57c614565e7c9fbae3b1.diff

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528465. michaelplatings marked an inline comment as done. michaelplatings added a comment. Restore tweak to tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ htt

[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

yronglin added a comment. ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151121/new/ https://reviews.llvm.org/D151121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added a comment. Ping @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

erichkeane added a comment. I don't know much about this section, but I DO note that the pre-commit CI failures all seem related here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151121/new/ https://reviews.llvm.org/D151121

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM, but please wait at least a day for other people to have last-minute thoughts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553 HelpText<"Check stream handling functions">, + WeakDependencies<[NonNullParamChecker]>, Documentation; steakhal wrote: > What's the purpose of this hunk

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Thanks, that's much clearer. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553 HelpText<"Check stream handling functions">, + WeakDependencies<[NonNullParamChecker]>, Documentation; balazske wrote: > steakhal wrote: > > What's the

[clang-tools-extra] 4cb5e43 - [clangd] Show size, offset and padding for bit fields on hover

Author: SR_team Date: 2023-06-05T17:52:34+02:00 New Revision: 4cb5e436ae713579cfee00cfc8e516cf965b91e9 URL: https://github.com/llvm/llvm-project/commit/4cb5e436ae713579cfee00cfc8e516cf965b91e9 DIFF: https://github.com/llvm/llvm-project/commit/4cb5e436ae713579cfee00cfc8e516cf965b91e9.diff LOG:

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb5e436ae71: [clangd] Show size, offset and padding for bit fields on hover (authored by SR_team, committed by sammccall). Repository: rG LLVM Gi

[clang-tools-extra] 3f9f146 - [clangd] Move completion signatures and labelDetails

Author: Sam McCall Date: 2023-06-05T18:05:18+02:00 New Revision: 3f9f1463719d7491768e9a224ac089c8f9baab68 URL: https://github.com/llvm/llvm-project/commit/3f9f1463719d7491768e9a224ac089c8f9baab68 DIFF: https://github.com/llvm/llvm-project/commit/3f9f1463719d7491768e9a224ac089c8f9baab68.diff LO

[PATCH] D151253: [clangd] Move completion signatures and labelDetails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f9f1463719d: [clangd] Move completion signatures and labelDetails (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 528475. kushanam added a comment. Rebasing the D144911 patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: llvm/lib/Tar

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. Can the commit message have a description please? It's unclear to me why this is necessary (although I'm sure there's a good reason). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 __

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

cjdb added subscribers: shafik, erichkeane, aaron.ballman. cjdb added a comment. @aaron.ballman @erichkeane @shafik any reservations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 __

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

erichkeane added a comment. I don't have much of an opinion on the commit itself. It seems that suppressing that include stack does at least SOME work to make our error-novels less 'War and Peace', but I don't really get the bug report well enough to know whether we should be doing this. ==

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl added a comment. In D151349#4395312 , @arsenm wrote: > In D151349#4381569 , @yaxunl wrote: > >> In D151349#4381471 , @arsenm wrote: >> >>> In D151349#4377792

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a comment. In D149573#4395968 , @erichkeane wrote: > This all LGTM, but I want @tahonermann to do a pass as well, he knows more > about FP than I do, so I don't want to accept without his run-through. Thank you, @erichkeane for the review

[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

yronglin added a comment. In D151121#4378402 , @yronglin wrote: > The col number in diagnostic message seems not correct > https://godbolt.org/z/jnG5orhYW Thanks for your review @erichkeane , the column number in diagnostic message seems not correct ht

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 528492. ZarkoCA marked an inline comment as done. ZarkoCA removed a reviewer: jsji. ZarkoCA added a comment. Rebase and fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.o

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396244 , @cjdb wrote: > Can the commit message have a description please? It's unclear to me why this > is necessary (although I'm sure there's a good reason). Thanks! Done, also check https://github.com/llvm/llvm-

[PATCH] D152164: [CUDA][HIP] Externalize device var in anonymous namespace

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/anon-ns.cu:46 + +// COMMON-DAG: @[[STR1:.*]] = {{.*}} c"[[KERN1]]\00" +// COMMON-DAG: @[[STR2:.*]] = {{.*}} c"[[KERN2]]\00"

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. In D151833#4396399 , @charmitro wrote: > In D151833#4396244 , @cjdb wrote: > >> Can the commit message have a description please? It's unclear to me why >> this is necessary (although I'm su

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396426 , @cjdb wrote: > In D151833#4396399 , @charmitro > wrote: > >> In D151833#4396244 , @cjdb wrote: >> >>> Can the commit messa

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4395204 , @Fznamznon wrote: > In D147717#4393019 , @cor3ntin > wrote: > >> I think we should make sure to land this for clang 17. The rate of consteval >> bugs is no greater than

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added a comment. In D151952#4392329 , @rsmith wrote: > Taking a step back for a moment: what is the intended use case for this? My > concern is that most of the time you're going to want to make O(N) such > queries into a pack of N elements, result

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396008 , @charmitro wrote: > In D151833#4395956 , @aaron.ballman > wrote: > >> Do you need someone to commit on your behalf? If so, what name and email >> address would you

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. I already have another commit I plan to push, will do these together :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

aaron.ballman added a comment. In D147717#4396432 , @cjdb wrote: > In D147717#4395204 , @Fznamznon > wrote: > >> In D147717#4393019 , @cor3ntin >> wrote: >> >>> I think

[PATCH] D152180: [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

nathanchance created this revision. nathanchance added reviewers: aaron.ballman, nickdesaulniers, erichkeane. Herald added a project: All. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A variable declared with `__attribute__(

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. Works for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D152180: [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch! Comment at: clang/test/Sema/warn-unused-variables.c:35 +void c1(int *); +int f4(void) { + int __attribute__((cleanup(c1))) X1 = 4; `void` return type Repository:

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

philnik added a comment. https://github.com/llvm/llvm-project/issues/60709 seems also pretty scary to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cf

[PATCH] D132275: [clang] Create alloca to pass into static lambda

efriedma added a comment. Possibly the alloca doesn't get eliminated, or doesn't get eliminated early enough for attributor to kick in. Not sure what context would make that significant, off the top of my head. Is the lambda in question defined in an inline function (linkonce_odr)? Maybe we

[PATCH] D152180: [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

nathanchance updated this revision to Diff 528510. nathanchance added a comment. Change `f4()`'s return type to `void` (Nick) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152180/new/ https://reviews.llvm.org/D152180 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/warn-unused-va

[PATCH] D132275: [clang] Create alloca to pass into static lambda

efriedma added a comment. > EmitLambdaDelegatingInvokeBody emit an always_inline hint To clarify, I mean on the call instruction, not on either function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 _

[clang] 877210f - [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

Author: Nathan Chancellor Date: 2023-06-05T10:54:47-07:00 New Revision: 877210faa447f4cc7db87812f8ed80e398fedd61 URL: https://github.com/llvm/llvm-project/commit/877210faa447f4cc7db87812f8ed80e398fedd61 DIFF: https://github.com/llvm/llvm-project/commit/877210faa447f4cc7db87812f8ed80e398fedd61.d

[PATCH] D152180: [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG877210faa447: [Sema] Do not emit -Wunused-variable for variables declared with cleanup… (authored by nathanchance). Repository: rG LLVM Github Mon

[clang] 65ceb42 - Replace deprecated startswith_insensitive with starts_with_insensitive

Author: Fangrui Song Date: 2023-06-05T11:01:27-07:00 New Revision: 65ceb42d636ea758a2c9ecdfb7473d528983a1e2 URL: https://github.com/llvm/llvm-project/commit/65ceb42d636ea758a2c9ecdfb7473d528983a1e2 DIFF: https://github.com/llvm/llvm-project/commit/65ceb42d636ea758a2c9ecdfb7473d528983a1e2.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

tahonermann added a comment. > @tahonermann Just a quick note - I've made the changes you initially > suggested in the RFC. When you get a chance, could you have another look? Yes, I hope to today. If not, I'll make it a priority for tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 798c5ba - [clang][NFC] refactors value type traits so we can have more than bools

Author: Christopher Di Bella Date: 2023-06-05T18:07:18Z New Revision: 798c5ba770d30520a7cd6f431068ade2bda5a9f1 URL: https://github.com/llvm/llvm-project/commit/798c5ba770d30520a7cd6f431068ade2bda5a9f1 DIFF: https://github.com/llvm/llvm-project/commit/798c5ba770d30520a7cd6f431068ade2bda5a9f1.dif

[clang] 91be60b - Respect "-fdiagnostics-absolute-paths" on emit include location

Author: Charalampos Mitrodimas Date: 2023-06-05T18:07:18Z New Revision: 91be60b34715bfe930dd1c56414c62a63cdaaa9c URL: https://github.com/llvm/llvm-project/commit/91be60b34715bfe930dd1c56414c62a63cdaaa9c DIFF: https://github.com/llvm/llvm-project/commit/91be60b34715bfe930dd1c56414c62a63cdaaa9c.d

[PATCH] D152034: [clang][NFC] refactors value type traits so we can have more than bools

This revision was automatically updated to reflect the committed changes. Closed by commit rG798c5ba770d3: [clang][NFC] refactors value type traits so we can have more than bools (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15203

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

This revision was automatically updated to reflect the committed changes. Closed by commit rG91be60b34715: Respect "-fdiagnostics-absolute-paths" on emit include location (authored by charmitro, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 ___

[PATCH] D152164: [CUDA][HIP] Externalize device var in anonymous namespace

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/anon-ns.cu:46 + +// COMMON-DAG: @[[STR1:.*]] = {{.*}} c"[[KERN1]]\00" +// COMMON-DAG: @[[STR2:.*]] = {{.*}} c"[[KERN2]]\00" tra wrote: > Nit: I'd rename the

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStr

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 528526. kushanam added a comment. adding min and max for bf16 and refactoring the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: llvm/lib/Target/NVPTX

[PATCH] D144911: adding bf16 support to NVPTX

kushanam added a comment. In D144911#4389187 , @manishucsd wrote: > I tried this patch to resolve lowering `nvvm.mma.sync` on bf16 operands for > the PR 13858 > > nvvm.mma.sync A[%293, %295, %297, %299] B[

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono reopened this revision. Sedeniono added a comment. This revision is now accepted and ready to land. Ok, here is the 2nd attempt at fixing the issue. The patch is based on the current main branch. Regarding `LineJoiner::join()`: Turns out, not setting `A.Level` but reverting the origin

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 528531. Sedeniono added a comment. Herald added subscribers: llvm-commits, pcwang-thead. Herald added a project: LLVM. Fixes github issues #59178, #58464 and #62799. The problem was that the LevelIndentTracker remembered the indentation level of pre

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. Oh damn, I executed `arc diff --update D151047` on the main branch instead of my own local branch... Sorry. Can I somehow revert that? Or should I simply use the "abandon review" action and create a entirely new one? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D152180: [Sema] Do not emit -Wunused-variable for variables declared with cleanup attribute

erichkeane added a comment. I note I forgot to require a release note, so please add one of those (and make sure it gets incorporated in any cherry-pick that happens). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152180/new/ https://reviews.llvm.

[PATCH] D152186: [Clang] Add release note for 877210faa447

nathanchance created this revision. nathanchance added reviewers: erichkeane, nickdesaulniers. Herald added a project: All. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. @efriedma Thank you for all your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4396739 , @Sedeniono wrote: > Oh damn, I executed `arc diff --update D151047` on the main branch instead of > my own local branch... Sorry. > Can I somehow revert that? Or should I simply use the "abandon review"

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 ___ cfe-commits mailing list cfe-comm

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStringFrom

[PATCH] D152186: [Clang] Add release note for 877210faa447

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152186/new/ https://reviews.llvm.org/D152186

[PATCH] D152186: [Clang] Add release note for 877210faa447

erichkeane accepted this revision. erichkeane added a comment. 2 nits, otherwise LGTM! Thanks! Comment at: clang/docs/ReleaseNotes.rst:333 can be controlled using ``-fcaret-diagnostics-max-lines=``. +- Clang no longer emits ``-Wunused-variable`` for variables declared with

[clang] deecf89 - [Clang] Add release note for 877210faa447

Author: Nathan Chancellor Date: 2023-06-05T12:14:51-07:00 New Revision: deecf89a1361cf3407f0fe32e7085127ec0865dc URL: https://github.com/llvm/llvm-project/commit/deecf89a1361cf3407f0fe32e7085127ec0865dc DIFF: https://github.com/llvm/llvm-project/commit/deecf89a1361cf3407f0fe32e7085127ec0865dc.d

[PATCH] D152186: [Clang] Add release note for 877210faa447

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdeecf89a1361: [Clang] Add release note for 877210faa447 (authored by nathanchance). Changed prior to commit: https://reviews.llvm.org/D152186?vs=5

[PATCH] D152186: [Clang] Add release note for 877210faa447

nathanchance added a comment. Thanks, I landed it with those nits addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152186/new/ https://reviews.llvm.org/D152186 ___ cfe-commits mailing list cfe-co

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added a comment. I'd split the `llvm/` changes into a separate change. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:58-59 + !C.getDriver().IsCLMode() && !C.getDriver().IsFlangMode()) { +CmdArgs.push_back("-defaultlib:libcmt"); +CmdArgs.push_back("-defaul

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I experimented with this. Looks like it emits info only for //defined// methods, and not //used// methods. That is, if you change the test to say `void t1::f1() { f2(); }` you get DWARF for f1 but not f2. The way Sony does it, you get DWARF for f1 and f2. (Neither case

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 528547. Sedeniono added a comment. Next try at getting the 2nd attempt into review. This is again the complete fix, since the previous revision got reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1510

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. @barannikov88 ok, thanks. I just did that. The latest diff looks right. I wondered because phabricator suddenly showed changes in ocaml files, which I certainly did not want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D152034: [clang][NFC] refactors value type traits so we can have more than bools

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5591-5594 + default: +llvm_unreachable("reached the end of BuildTypeTrait because the type " + "trait's type is unaccounted for"); + } ``` llvm-project/cla

[clang] caf0072 - [Sema] Fix a warning

Author: Kazu Hirata Date: 2023-06-05T12:59:58-07:00 New Revision: caf00725923cb89af9b9478c53496e9f81ee4d6d URL: https://github.com/llvm/llvm-project/commit/caf00725923cb89af9b9478c53496e9f81ee4d6d DIFF: https://github.com/llvm/llvm-project/commit/caf00725923cb89af9b9478c53496e9f81ee4d6d.diff L

[PATCH] D152034: [clang][NFC] refactors value type traits so we can have more than bools

nickdesaulniers added a subscriber: kazu. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5591-5594 + default: +llvm_unreachable("reached the end of BuildTypeTrait because the type " + "trait's type is unaccounted for");

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Hera

[PATCH] D152195: [Clang] Fix access of friend function in local class

eandrews created this revision. eandrews added reviewers: erichkeane, aaron.ballman. Herald added a project: All. eandrews requested review of this revision. Clang currently emits an error when a friend of a local class tries to access it's private data members. This patch fixes the bug. https:

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

Manna added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756 if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() || ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) { const ObjCI

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStr

[clang] 5a64a82 - [Driver] Allow -fsanitize=kcfi with -fsanitize-minimal-runtime

Author: Sami Tolvanen Date: 2023-06-05T20:39:45Z New Revision: 5a64a826b9f0efab4ba7a8cdab4857794bbf07f3 URL: https://github.com/llvm/llvm-project/commit/5a64a826b9f0efab4ba7a8cdab4857794bbf07f3 DIFF: https://github.com/llvm/llvm-project/commit/5a64a826b9f0efab4ba7a8cdab4857794bbf07f3.diff LOG:

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. In D152017#4396906 , @probinson wrote: > I experimented with this. Looks like it emits info only for //defined// > methods, and not //used// methods. That is, if you change the test to say > `void t1::f1() { f2(); }` > you get D

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with dereference after null check

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStringFrom

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

jfurtek updated this revision to Diff 528567. jfurtek added a comment. - Another clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151923/new/ https://reviews.llvm.org/D151923 Files: clang/lib/AST/MicrosoftMangle.cpp llvm/include/

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 528571. nickdesaulniers added a comment. - recursively check for MaterializeTemporaryExpr from InitListExprs; all tests pass (that doesn't imply this patch is good though!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 528585. everythingfunctional added a comment. Update to latest main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews.llvm.org/D143592 Files: clang/include/clang/D

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 528586. everythingfunctional added a comment. Merge in updates from latest main branch and resolve conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews.llvm.org/D1435

[PATCH] D131594: Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added a comment. I'd omit the lit test cases for now since they're not necessary. There should be a test case in https://github.com/llvm/llvm-project/blob/86b6ac5d54d7fe5cd21beff64b5c2194b1368bdf/llvm/unittests/TargetParser/TripleTest.cpp though. Repository: rG LLVM Github Monorepo

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added a comment. Two points I'm not sure about in the current version: - Handling MaterializeTemporaryExpr in ConstExprEmitter doesn't make sense; ConstExprEmitter is not supposed to visit lvalues. (And I'm not sure what the new check is supposed to do; `E->isGLValue()` is always true

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. oh, side note: We don't emit DWARF descriptions of called non-member functions, generally (well, more often these days with optimized debug info call_site info we do need to emit function declarations for called functions) - so by analogy I'd have thought doing similar

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. FYI https://reviews.llvm.org/D151601 has landed in https://github.com/llvm/llvm-project/commit/dc90f42ea7b4f6d9e643f5ad2ba663eba2f9e421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D14491

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:615 setFP16OperationAction(Op, MVT::v2f16, Legal, Expand); - } - - for (const auto &Op : {ISD::FADD, ISD::FMUL, ISD::FSUB, ISD::FMA}) { setBF16OperationAction(Op, MVT::bf16, Legal, Prom

[PATCH] D119711: Add asan support for MSVC debug runtimes

rnk added subscribers: thieta, mstorsjo. rnk added a comment. + @mstorsjo @thieta Since we were talking about the complexity involved in choosing the correct ASan runtime, there is actually even more involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

cfe-commits@lists.llvm.org

nickdesaulniers updated this revision to Diff 528599. nickdesaulniers retitled this revision from "[Demangle] make llvm::demangle take std::string_view rather than const std::string&" to "reland: [Demangle] make llvm::demangle take std::string_view rather than const std::string&". nickdesaulniers

[PATCH] D131594: Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 528603. Prabhuk added a comment. Update the test. Remove unnecessary items in UEFI toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 528605. nickdesaulniers added a comment. - use @efriedma's suggestion w/ dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files: clang/lib/CodeGen/C

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added a comment. In D151587#4397272 , @efriedma wrote: > Two points I'm not sure about in the current version: > > - Handling MaterializeTemporaryExpr in ConstExprEmitter doesn't make sense; > ConstExprEmitter is not supposed to visit lva

<    1   2   3   >