[clang] a0d83c3 - Revert "[clang][Diagnostics] Split source ranges into line ranges before..."

Author: Timm Bäder Date: 2023-06-02T09:02:34+02:00 New Revision: a0d83c3dc364688a223e0031d134e2a1bde4ba78 URL: https://github.com/llvm/llvm-project/commit/a0d83c3dc364688a223e0031d134e2a1bde4ba78 DIFF: https://github.com/llvm/llvm-project/commit/a0d83c3dc364688a223e0031d134e2a1bde4ba78.diff LO

[PATCH] D151876: [NVPTX] Signed char and (unsigned)long overloads of ldg and ldu

jchlanda added a comment. In D151876#433 , @tra wrote: > I'd change the patch title: > > - `[NVPTX]` -> `[cuda, NVPTX]` as these are clang changes, not NVPTX back-end. > - `overloads ` -> `builtins` Sure, will do. Thank you. Repository: rG LLVM G

[clang] 3e37c98 - [cuda, NVPTX] Signed char and (unsigned)long builtins of ldg and ldu

Author: Jakub Chlanda Date: 2023-06-02T09:10:19+02:00 New Revision: 3e37c98bdb512425cab91f6cf156cc66d6103b2f URL: https://github.com/llvm/llvm-project/commit/3e37c98bdb512425cab91f6cf156cc66d6103b2f DIFF: https://github.com/llvm/llvm-project/commit/3e37c98bdb512425cab91f6cf156cc66d6103b2f.diff

[PATCH] D151876: [NVPTX] Signed char and (unsigned)long overloads of ldg and ldu

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e37c98bdb51: [cuda, NVPTX] Signed char and (unsigned)long builtins of ldg and ldu (authored by jchlanda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1518

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527764. akshaykhadse added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c cl

[PATCH] D151215: [clang][Diagnostics] Split source ranges into line ranges before...

tbaeder updated this revision to Diff 527766. tbaeder added a comment. @cor3ntin I added changes to the two brackets tests in `test/Parser/`. They look like an improvement to me, but maybe there's something I'm missing, so please have a quick look. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan updated this revision to Diff 527765. owenpan added a comment. Removed the `RootToken` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. If we could get rid of `BaseReg = BaseReg ? BaseReg : 1;` in `X86AsmParser::CreateMemForMSInlineAsm`, then we don't need any changes in the `X86Operand.h`. F27787125: image.png I was not able to find any failing tests after maki

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added a comment. I still think replacing the `1` with a valid register for the mode is the better fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

XinWang10 added a comment. In D151863#4390132 , @craig.topper wrote: > I still think replacing the `1` with a valid register for the mode is the > better fix. But if you give that, we couldn't take a mem operand without base reg. Repository: rG LLV

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. In D151863#4390132 , @craig.topper wrote: > I still think replacing the `1` with a valid register for the mode is the > better fix. So, should I create a new registers? Something like `X86::Sym16`, `X86::Sym32` and `X86::

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added a comment. In D151863#4390172 , @akshaykhadse wrote: > In D151863#4390132 , @craig.topper > wrote: > >> I still think replacing the `1` with a valid register for the mode is the >> better fix

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. I've thought about this a bit harder; it now seems better longer-term to enable unaligned accesses by default (making the UAL-less models the special case). But most importantly, there's new inf

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

hokein added a comment. Thanks, a few comments to simplify the code/test further. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:94 +/// shortest spelling. +std::string spellHeader(const IncludeSpellerInput &Input); } // namespace inclu

[PATCH] D151730: [RISCV] Support target attribute for function

kito-cheng added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-func-attr-target.c:10 +// CHECK-ASM: .option pop +__attribute__((target("arch=rv64g,+c,+v"))) void test1 () {} + It's ext list or full arch, can't mixed together. ``` ARCH-ATTR := 'ar

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4386128 , @tbaeder wrote: > Can you add a test case for the change? Looks like there's something similar > already in `clang/test/Frontend/absolute-paths.c` Is it possible to use substitutions inside let's say `NORM

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527783. akshaykhadse added a comment. Implement solution mentioned in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inl

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527797. akshaykhadse added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/test/

[clang-tools-extra] be8da1f - [clangd] Use FileManager for getCanonicalPath, NFC

Author: Haojian Wu Date: 2023-06-02T12:55:21+02:00 New Revision: be8da1f6e68603fd49ee7faa7c309f44f5b1a8b2 URL: https://github.com/llvm/llvm-project/commit/be8da1f6e68603fd49ee7faa7c309f44f5b1a8b2 DIFF: https://github.com/llvm/llvm-project/commit/be8da1f6e68603fd49ee7faa7c309f44f5b1a8b2.diff LO

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff updated this revision to Diff 527800. sepavloff added a comment. Use FPOptions from the place where template is defined rather than default Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ https://reviews.llvm.org/D143241 Files:

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon updated this revision to Diff 527808. Fznamznon added a comment. Transform the callee, add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D151634: [clang] Add test for CWG253

Endill updated this revision to Diff 527804. Endill edited the summary of this revision. Endill added a comment. Mark CWG78 as superseded by 2536 Expand CWG253 test @shafik I think rather than leave 78 out, we better mark it as superseded, so that we don't forget about it. Repository: rG LLV

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527812. VitaNuo added a comment. Escape the slashes in regex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.tx

[PATCH] D151990: Test for emitIncludeLocation with "-fdiagnostics-absolute-paths"

charmitro created this revision. Herald added a project: All. charmitro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151990 Files: clang/test/Frontend/absolute-paths-imp

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527822. VitaNuo added a comment. Remove path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cla

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4390279 , @charmitro wrote: > In D151833#4386128 , @tbaeder wrote: > >> Can you add a test case for the change? Looks like there's something similar >> already in `clang/test

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); Al

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

yaxunl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); Ale

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: This checks the same thing in both cases, but in the `NORMAL` case,

[PATCH] D150122: [Clang] Fix status of P0960

erichkeane accepted this revision. erichkeane added a comment. LGTM as well, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122 ___ cfe-commits mailing lis

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaType.cpp:956 // Determine whether the type argument is substitutable for the bound. if (typeArgObjC->isObjCIdType())

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

erichkeane accepted this revision. erichkeane added a comment. This looks fine to me. HOWEVER, please make sure to add this commit to `https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs` in a follow-up NFC commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

erichkeane added a comment. 1- This needs a release note. 2- I want others to comment on the name. I like its verbosity in that it'll discourage people from using it without knowing what it means, but I want to hear Aaron/others' opinion as well. 3- Trailing WS thing, I see you did a cleanup pa

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

hans added inline comments. Comment at: clang/docs/UsersManual.rst:578 + +.. option:: -fcaret-diagnostics-max-lines: + I think this is still a cc1-only option. Should it be made available as a driver option now? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527839. VitaNuo added a comment. Re-introduce path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added inline comments. Comment at: clang/docs/UsersManual.rst:578 + +.. option:: -fcaret-diagnostics-max-lines: + hans wrote: > I think this is still a cc1-only option. Should it be made available as a > driver option now? No strong opinion from my side,

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

erichkeane added a comment. Needs a release note. Also, is this something that has been requested by library? I'd hope this is something that will be used, so I'd like evidence of that. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not val

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151928/new/ https://reviews.llvm.org/D151928 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151947/new/ https://reviews.llvm.org/D151947 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/ https://reviews.llvm.org/D151957 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

erichkeane added a comment. I don't understand our consteval implementation enough to approve this, but I didn't see anything to comment on while going through this. Comment at: clang/include/clang/Sema/Sema.h:1071 FD->setWillHaveBody(true); - else +S.Exp

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > This checks the same thing in both cases, but in

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:956 // Determine whether the type argument is substitutable for the bound. if (typeArgObjC->isObjCIdType()) { // When the type argument is 'id', the only acceptable type e

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 527854. skatrak added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Update and remove OpenMP dialect dependency from the generic LLVM IR translation. Followed @kiranchandramohan's suggestion in the comments for D

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

Fznamznon added a comment. Nothing more from me, but I would wait for someone else's approval. Comment at: clang/lib/Sema/SemaExpr.cpp:18204 +const NamedDecl *ND = cast(DR->getDecl()); +if (const auto *MD = llvm::dyn_cast(ND); MD && (MD->isLambdaStaticInvoker()

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

stuij added a comment. This is going to be a very unhelpful comment. After looking through the changes, I don't have any comments to make, but I also don't feel comfortable to accept this revision as I don't feel to know enough about the front-end. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > This checks the same thing in

[clang] 24231df - [clang-format] Parse the Verilog language option in configuration

Author: sstwcw Date: 2023-06-02T14:59:27Z New Revision: 24231df9b8ef560cc6d3c713d5dba1de703e2cb9 URL: https://github.com/llvm/llvm-project/commit/24231df9b8ef560cc6d3c713d5dba1de703e2cb9 DIFF: https://github.com/llvm/llvm-project/commit/24231df9b8ef560cc6d3c713d5dba1de703e2cb9.diff LOG: [clang

[PATCH] D151632: [clang-format] Parse the Verilog language option in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG24231df9b8ef: [clang-format] Parse the Verilog language option in configuration (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151632/ne

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a comment. In D149573#4390863 , @stuij wrote: > This is going to be a very unhelpful comment. After looking through the > changes, I don't have any comments to make, but I also don't feel comfortable > to accept this revision as I don't fe

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > This c

[clang] cecd847 - [Clang][Parser] Accept GNU attributes preceding C++ attributes on templates

Author: Elizabeth Andrews Date: 2023-06-02T08:11:18-07:00 New Revision: cecd8471e4991b4bea5d2b38a3758cafdb1cbe29 URL: https://github.com/llvm/llvm-project/commit/cecd8471e4991b4bea5d2b38a3758cafdb1cbe29 DIFF: https://github.com/llvm/llvm-project/commit/cecd8471e4991b4bea5d2b38a3758cafdb1cbe29.d

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGcecd8471e499: [Clang][Parser] Accept GNU attributes preceding C++ attributes on templates (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D151837

[PATCH] D152002: [clang][wip] Better handling of dependent lambda. This is an attempt to fix GH62916. However, it breaks GH57960 I seem unable to find something that works for both issues.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152002 Files: clang/lib/Sema/SemaTemplateInstantiate.c

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527872. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-too

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per P1975R0 an expression like `static_cast(...)` defines the type of the expression as U[1]. Fixes https://github.com/

[clang-tools-extra] c28506b - [clang-tidy] Implement an include-cleaner check.

Author: Viktoriia Bakalova Date: 2023-06-02T15:21:20Z New Revision: c28506ba4b6961950849f8fdecd0cf7e503a14f9 URL: https://github.com/llvm/llvm-project/commit/c28506ba4b6961950849f8fdecd0cf7e503a14f9 DIFF: https://github.com/llvm/llvm-project/commit/c28506ba4b6961950849f8fdecd0cf7e503a14f9.diff

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc28506ba4b69: [clang-tidy] Implement an include-cleaner check. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://revi

[clang-tools-extra] 5c2072e - [clang-tidy] Fix docs.

Author: Viktoriia Bakalova Date: 2023-06-02T15:31:55Z New Revision: 5c2072e74b42d55e8bf7a9c8fee8800bad591f12 URL: https://github.com/llvm/llvm-project/commit/5c2072e74b42d55e8bf7a9c8fee8800bad591f12 DIFF: https://github.com/llvm/llvm-project/commit/5c2072e74b42d55e8bf7a9c8fee8800bad591f12.diff

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); I am not really sure this is

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5562 + if (IsDependent) +goto Return; + erichkeane wrote: > Oh, please don't do this. perhaps another way to do this if you want to avoid repeating the return expression would be a s

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); erichkeane wrote: > I am not

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); Fznamznon wrote: > erichkean

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

erichkeane added a comment. In D149573#4390895 , @codemzs wrote: > In D149573#4390863 , @stuij wrote: > >> This is going to be a very unhelpful comment. After looking through the >> changes, I don't have any comm

[clang] 19841e4 - [OpenMP] Fix transformed loop's var privacy

Author: Joel E. Denny Date: 2023-06-02T12:18:13-04:00 New Revision: 19841e4dcaabe573d35eb88a130fc34d32ecd708 URL: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708 DIFF: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708.diff

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19841e4dcaab: [OpenMP] Fix transformed loop's var privacy (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

jdenny added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151356/new/ https://reviews.llvm.org/D151356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151350/new/ https://reviews.llvm.org/D151350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8b5dbc3 - [CodeGen] Use llvm::LLVMContext::MD_invariant_load (NFC)

Author: Kazu Hirata Date: 2023-06-02T09:25:00-07:00 New Revision: 8b5dbc37a899faf0d2cb842bcb1ebc66a319c394 URL: https://github.com/llvm/llvm-project/commit/8b5dbc37a899faf0d2cb842bcb1ebc66a319c394 DIFF: https://github.com/llvm/llvm-project/commit/8b5dbc37a899faf0d2cb842bcb1ebc66a319c394.diff L

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a subscriber: aaron.ballman. codemzs added a comment. In D149573#4391013 , @erichkeane wrote: > In D149573#4390895 , @codemzs wrote: > >> In D149573#4390863

[clang] 5b77e75 - [Driver] Move -nostdinc like options into IncludePath_Group

Author: Fangrui Song Date: 2023-06-02T09:33:08-07:00 New Revision: 5b77e752dcd073846b89559d6c0e1a7699e58615 URL: https://github.com/llvm/llvm-project/commit/5b77e752dcd073846b89559d6c0e1a7699e58615 DIFF: https://github.com/llvm/llvm-project/commit/5b77e752dcd073846b89559d6c0e1a7699e58615.diff

[PATCH] D151944: [Driver] Move -nostdinc like options into IncludePath_Group

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b77e752dcd0: [Driver] Move -nostdinc like options into IncludePath_Group (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D151944?vs=527645&id=527884#toc Repository: rG LLVM

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

erichkeane added a comment. In D149573#4391083 , @codemzs wrote: > In D149573#4391013 , @erichkeane > wrote: > >> In D149573#4390895 , @codemzs >> wrote: >> >>> In D1495

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits would

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:796-802 +/// If this expression is not value-dependent, this stores the value. +unsigned Value : 8; /// The number of arguments to this type trait. According to [implimits] /// 8 bits

[PATCH] D151634: [clang] Add test for CWG253

shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > This is [issue 1380](ht

cfe-commits@lists.llvm.org

ilya-biryukov added a comment. @massberg did we figure out if there is anything else left from P2002R1? Are there blockers to landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 ___

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. with multiple declarations followed by a colon. Fixes #63010 Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. In D144911#4389187 , @manishucsd wrote: > I fail to compile this patch. Please find the compilation error below: > > [build] ./llvm-project/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:1117:40: > error: Variable not defined: 'hasPTX70'

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin updated this revision to Diff 527902. cor3ntin added a comment. revert ws changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152009/new/ https://reviews.llvm.org/D152009 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseExprC

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > shafik wrote: > > This

[clang-tools-extra] 860e439 - [Clang] Fix missing libraries for the include cleaner check

Author: Joseph Huber Date: 2023-06-02T12:43:55-05:00 New Revision: 860e439fb27f86b97bfd9acce5e27f4337c471c7 URL: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7 DIFF: https://github.com/llvm/llvm-project/commit/860e439fb27f86b97bfd9acce5e27f4337c471c7.diff

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStr

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

zibi created this revision. zibi added reviewers: Kai, fanbo-meng, abhina.sreeskantharajan. Herald added a reviewer: aaron.ballman. Herald added a project: All. zibi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [SystemZ} This revision fi

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie created this revision. dblaikie added a reviewer: probinson. Herald added a project: All. dblaikie requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Complete C++ type information can be quite expensive - and there's limited v

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152016/new/ https://reviews.llvm.org/D152016 _

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie updated this revision to Diff 527920. dblaikie added a comment. Updating commit message with extra details Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 Files: clang/include/clang/Basic/CodeG

[PATCH] D151601: [NVPTX] Coalesce register classes for {i16,f16,bf16}, {i32,v2f16,v2bf16}

tra added a comment. I've tested the change on a bunch of tensorflow tests and the patch didn't cause any apparent issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151601/new/ https://reviews.llvm.org/D151601

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

majnemer added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:190 +// greater throughput than single precision (32-bit) formats. +S_FloatTF32, Hmm, this says improved precision than half but the semantics you gave say 11 digits? Does NVI

[PATCH] D151601: [NVPTX] Coalesce register classes for {i16,f16,bf16}, {i32,v2f16,v2bf16}

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I cannot say that I 100% looked over every line, but in principle this seems fine, and if it's passing TF tests then that's pretty strong evidence this is working. Repository: rG LLVM Gith

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 527924. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - just failing clang/test/CodeGenCXX/atomicinit.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 527925. nickdesaulniers added a comment. - remove commented out code, still WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files: clang/lib/CodeGen/CGE

[clang] 583e028 - [test] Add -Wno-msvc-not-found to fix linker-opts.c on *-windows-msvc

Author: Fangrui Song Date: 2023-06-02T11:59:23-07:00 New Revision: 583e02831c6d081f43f2d5c5b9be5d773b7ae8b8 URL: https://github.com/llvm/llvm-project/commit/583e02831c6d081f43f2d5c5b9be5d773b7ae8b8 DIFF: https://github.com/llvm/llvm-project/commit/583e02831c6d081f43f2d5c5b9be5d773b7ae8b8.diff

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis accepted this revision. TIFitis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 _

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, w2yehia. qiongsiwu1 added a project: clang. Herald added subscribers: kbarton, inglorion, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 527931. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang

  1   2   >