[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG785b30b8a33a: [clang-tidy] Check for specific return types on all functions (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/ne

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Module.cpp:486 - if (Header H = getWrittenUmbrellaHeader()) { + if (auto H = getWrittenUmbrellaHeader()) { OS.indent(Indent

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526195. nickdesaulniers added a comment. Herald added subscribers: kerbowa, jvesely. - one more test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Module.h:160 + llvm::PointerUnion Umbrella; Would it make sense to implement `PointerLikeTypeTrai

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > Do we need an install target for `${cuda_wrapper_bits_files}` for the > `cuda-resource-headers` component as well? It

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151388/new/ https://reviews.llvm.org/D151388 ___ cfe-c

[clang] a2684ac - [HWASan] use hwasan linker for Android 14+

Author: Florian Mayer Date: 2023-05-26T14:25:46-07:00 New Revision: a2684acfb61d40f441e240035d7f1ba50da637c8 URL: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8 DIFF: https://github.com/llvm/llvm-project/commit/a2684acfb61d40f441e240035d7f1ba50da637c8.diff

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2684acfb61d: [HWASan] use hwasan linker for Android 14+ (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:42 + +struct MissingIncludeInfo { + SourceLocation SymRefLocation; let's put this struct into anon namespace Comment at: clang-tools-extra/cl

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis created this revision. Herald added subscribers: wlei, ormris, wenlei, steven_wu, hiraditya. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. ellis added reviewers: int3, tejohnson, xur. ellis updated this revision to Diff 526199. ellis added a comment. ellis edited

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson created this revision. tejohnson added a reviewer: snehasish. Herald added subscribers: ormris, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. First, removes the invocation of the memprof instrumentation passes fro

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL created this revision. PiotrZSL added reviewers: serge-sans-paille, carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Th

[clang] 9249129 - [clang][modules] NFCI: Distinguish as-written and effective umbrella directories

Author: Jan Svoboda Date: 2023-05-26T15:14:16-07:00 New Revision: 924912956ed570e433440108cc50bd0ee65605b5 URL: https://github.com/llvm/llvm-project/commit/924912956ed570e433440108cc50bd0ee65605b5 DIFF: https://github.com/llvm/llvm-project/commit/924912956ed570e433440108cc50bd0ee65605b5.diff L

[PATCH] D151581: [clang][modules] NFCI: Distinguish as-written and effective umbrella directories

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG924912956ed5: [clang][modules] NFCI: Distinguish as-written and effective umbrella directories (authored by jansvoboda11). Herald added a project: cl

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/Module.h:160 + llvm::PointerUnion Umbrella; benlangmuir wrote: > Would it make sense to implement `PointerLikeTypeTraits` for > FileEntryRef/DirectoryEntryRef so you don't need to

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. if this is registerOptimizerLastEPCallback, it can

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. vitalybuka wrote: > if this is registerOptimizerLast

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526210. nickdesaulniers added a comment. - fix string literals; still WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 Files: clang/lib/CodeGen/CGExprCon

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. tejohnson wrote: > vitalybuka wrote: > > if this is

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Either way is fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593 _

[clang] 89d71c1 - [Driver] Reject AIX-specific link options on non-AIX targets

Author: Fangrui Song Date: 2023-05-26T15:30:23-07:00 New Revision: 89d71c1efa85656b54bcd79b4278bc67690480e1 URL: https://github.com/llvm/llvm-project/commit/89d71c1efa85656b54bcd79b4278bc67690480e1 DIFF: https://github.com/llvm/llvm-project/commit/89d71c1efa85656b54bcd79b4278bc67690480e1.diff

[clang] d6e617c - [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

Author: Jan Svoboda Date: 2023-05-26T15:30:28-07:00 New Revision: d6e617c8efab582121e0a0a9d539652bdfd544da URL: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da DIFF: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da.diff L

[PATCH] D151584: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6e617c8efab: [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory (authored by jansvoboda11). Changed prior to commit: https://r

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? + CGM.GetAddrOfConstantStringFrom

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. vitalybuka wrote: > tejohnson wrote: > > vitalybuka

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa419ec4f256d: Fix runtime crash inside __kmpc_init_allocator (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a419ec4 - Fix runtime crash inside __kmpc_init_allocator

Author: Jennifer Yu Date: 2023-05-26T16:03:01-07:00 New Revision: a419ec4f256d279c91746a3962dd6dd2da45c304 URL: https://github.com/llvm/llvm-project/commit/a419ec4f256d279c91746a3962dd6dd2da45c304 DIFF: https://github.com/llvm/llvm-project/commit/a419ec4f256d279c91746a3962dd6dd2da45c304.diff L

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:604 def int_nvvm_f # operation # variant : ClangBuiltin, DefaultAttrsIntrinsic<[llvm_i16_ty], [llvm_i16_ty, llvm_i16_ty], tra wrote: > Availability of these new

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

snehasish accepted this revision. snehasish added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578 ___

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. observing failure in our amdgpu buildbot , 3 tests see: https://lab.llvm.org/staging/#/builders/247/builds/947 7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): Assertion `Table != nullptr && "Invalid table"' failed. if you have a quick fix, p

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > > `cuda-resource-headers

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. i think the extra two failures are not related to you patch. so ignore comment about these libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. apologies, i just realized its a new test that you xfailed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___ cfe-commits mailing lis

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. Here's a rough proof-of-concept patch coalescing i16/f16/bf16 to use the same Int16Regs register class: https://reviews.llvm.org/D151601 The changes are largely mechanical, replacing `%h` -> `%rs` in the tests and eliminating special cases we previously had for Float16Regis

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf354e971b09c: [MemProf] Clean up MemProf instrumentation pass invocation (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] f354e97 - [MemProf] Clean up MemProf instrumentation pass invocation

Author: Teresa Johnson Date: 2023-05-26T17:38:49-07:00 New Revision: f354e971b09c244147ff59eb65b34487755598c0 URL: https://github.com/llvm/llvm-project/commit/f354e971b09c244147ff59eb65b34487755598c0 DIFF: https://github.com/llvm/llvm-project/commit/f354e971b09c244147ff59eb65b34487755598c0.diff

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526227. tra added a comment. Verified that install works correctly with individual component installations: cmake -DCOMPONENT=cuda-resource-headers -P ./cmake_install.cmake cmake -DCOMPONENT=clang-resource-headers -P ./cmake_install.cmake Repository: rG L

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > qiongsiwu1 wrote: > > tra wrote: > > > qiongsiwu1 wrote: > > > > Do we need an install target for `${cuda_wrapper_bits_

[clang] af7aea3 - [Driver][test] Replace legacy -target with --target=

Author: Fangrui Song Date: 2023-05-26T19:01:39-07:00 New Revision: af7aea365a2ae8dc51938a614353e1586072ef83 URL: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83 DIFF: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83.diff

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

MaskRay accepted this revision as: MaskRay. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1356 +Arg *tools::getLastCSProfileGenerateArg(const ArgList &Args) { + auto *CSPGOGenerateArg = Ar

[clang] 0286b47 - [Driver] Remove redundant -z special case. NFC

Author: Fangrui Song Date: 2023-05-26T19:39:19-07:00 New Revision: 0286b47ae03356853736986f91f85c67115611ae URL: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae DIFF: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae.diff

[clang] ee15c1f - [Sema] Remove unused declaration ConvertIntegerToTypeWarnOnOverflow

Author: Kazu Hirata Date: 2023-05-26T20:07:49-07:00 New Revision: ee15c1fa84c2245866b0a202e896928621401f71 URL: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71 DIFF: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71.diff L

[clang] 8078e77 - [AST] Remove unused declaration enumerateVFPtrs

Author: Kazu Hirata Date: 2023-05-26T20:07:51-07:00 New Revision: 8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e URL: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e DIFF: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e.diff L

[clang] 54ab4b3 - [CodeGen] Remove unused declarations emitNonSPMDParallelCall and emitSPMDParallelCall

Author: Kazu Hirata Date: 2023-05-26T20:07:52-07:00 New Revision: 54ab4b3a2847127590cebdf17bc83288b7f03158 URL: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158 DIFF: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158.diff L

[clang-tools-extra] 7961848 - [clangd] Remove unused declaration onCallHierarchyOutgoingCalls

Author: Kazu Hirata Date: 2023-05-26T20:19:22-07:00 New Revision: 796184854c4db285bef503a4e57cd6c5aa54fa5d URL: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d DIFF: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d.diff L

[clang] 273303a - [Sema] Remove unused declaration startLambdaDefinition

Author: Kazu Hirata Date: 2023-05-26T20:19:23-07:00 New Revision: 273303ad66a32e5e599bef5ee18c3a9f589e530d URL: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d DIFF: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d.diff L

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: mattd, gchakrabarti, asavonic, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a projec

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

shafik added a comment. This PR seems related to this crash: https://github.com/llvm/llvm-project/issues/62958 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 0eb06cb3aa2700508c20da28f22ff91e7b82a436 Author: Roy Jacobson Date: Tue Mar 14 21:25

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit bb1ea2d6139a72340b426e114510c46d938645a6 Author: Nemanja Ivanovic Date: Mon May 9 08

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The last use was removed by: commit 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 Author: Hans Wennborg Date: Tue Feb

[clang] e621757 - [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support

Author: M. Zeeshan Siddiqui Date: 2023-05-27T13:33:50+08:00 New Revision: e62175736551abf40a3410bc246f58e650eb8158 URL: https://github.com/llvm/llvm-project/commit/e62175736551abf40a3410bc246f58e650eb8158 DIFF: https://github.com/llvm/llvm-project/commit/e62175736551abf40a3410bc246f58e650eb8158

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe62175736551: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and… (authored by codemzs, committed by pengfei). Changed prior

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added a comment. Thank you for your time! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { -

[PATCH] D151610: [Docs] Fix formatting issues in LanguageExtensions.rst

codemzs created this revision. codemzs added a reviewer: pengfei. Herald added a project: All. codemzs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Missing indentation. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

HerrCai0907 updated this revision to Diff 526245. HerrCai0907 added a comment. add cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 Files: clang/lib/Sema/SemaInit.cpp clang/test/CodeGenCXX/cxx20-p

<    1   2