benlangmuir accepted this revision.
benlangmuir added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Basic/Module.cpp:486
- if (Header H = getWrittenUmbrellaHeader()) {
+ if (auto H = getWrittenUmbrellaHeader()) {
OS.indent(Indent + 2);
----------------
These are on the edge, but I think I would lean towards spelling the typename
here since it's not obvious from the name of the API what exactly it would be
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151586/new/
https://reviews.llvm.org/D151586
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
