[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" + "#ifdef BAR\n" +

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5473 + if (Right.isOneOf(tok::kw___attribute, TT_AttributeMacro)) +return true; + jaredgrubb wrote: > HazardyKnusperkeks wrote: > > Does changing this return value make

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 added a comment. Currently, the functions just forward their arguments to the constructors (*), but I think more stuff should be pushed into them from `createTargetCodeGenInfo`. This is left for target maintainers. Implementations of the added functions will be distributed across *

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

HazardyKnusperkeks added a comment. LGTM, but someone other has to approve. Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:43-44 +struct ObjCPropertyEntry { + StringRef attribute; // eg, "readwrite" + StringRef value; // eg, the "foo" of the attribute "g

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D149193#4328553 , @MaskRay wrote: > In D149193#4328452 , @dblaikie > wrote: > >>> I agree that for mo

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > The linker is just lld so it should be the same conceptually. I'm just > figuring that even if the user is cross compiling we should respect -L passed > on the command line. Should I chang

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen created this revision. Herald added a project: All. qianzhen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch adds a new option -fkeep-static-variables to emit all static variables if required. This could be usef

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

samitolvanen updated this revision to Diff 520795. samitolvanen added a comment. Dropped the arch-specific KCFI machine function pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148385/new/ https://reviews.llvm.org/D148385 Files: clang/lib/Co

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 added a comment. In D150013#4330452 , @MaskRay wrote: > So it seems that there are configurations that we need -L (cross > compilation?). If we forward -L in some configurations, I think it'd be > better to do this consistently. > > The `LIBRARY

[PATCH] D150151: [clang] Prevent creation of new submodules in ASTWriter

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150151/new/ https://reviews.llvm.org/D150151 __

[clang] 5984ea2 - [clang] Prevent creation of new submodules in ASTWriter

Author: Ben Langmuir Date: 2023-05-09T13:02:36-07:00 New Revision: 5984ea216d2acbe5613b0af06ea27ef395ca9904 URL: https://github.com/llvm/llvm-project/commit/5984ea216d2acbe5613b0af06ea27ef395ca9904 DIFF: https://github.com/llvm/llvm-project/commit/5984ea216d2acbe5613b0af06ea27ef395ca9904.diff

[PATCH] D150151: [clang] Prevent creation of new submodules in ASTWriter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5984ea216d2a: [clang] Prevent creation of new submodules in ASTWriter (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

MaskRay added a comment. GCC has -fkeep-static-consts (which Clang supports) but not -fkeep-static-variables. > This could be useful in cases where the presence of all static variables as > symbols in the object file are required. Can you give a more compelling reason that this option is neede

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay added a comment. In D148665#4316310 , @peter.smith wrote: > My apologies for not responding. If I've got this right there are 4 related > patches: > D148573 (approved) > D148785

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4330504 , @MaskRay wrote: > Can you give a more compelling reason that this option is needed? This is intended to prevent "excessive transformation" to enable migration of existing applications (using a

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520807. HerrCai0907 added a comment. add more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520808. HerrCai0907 added a comment. add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sem

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( + Context, ArraySize->getType(), ArraySize->getBeginLoc(), erichkeane wrote: > HerrCai

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs marked 2 inline comments as done. codemzs added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:468 +LANGOPT(ExperimentalNewItaniumMangling, 1, 0, "experimental new Itanium mangling") + erichkeane wrote: > codemzs wrote: > > eric

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added a comment. Small insignificant note from me: When this lands, please be sure to add me as co-author. https://github.blog/2018-01-29-commit-together-with-co-authors/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ http

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam marked an inline comment as done. zahiraam added a comment. In D146148#4221651 , @rjmccall wrote: > In D146148#4220591 , @zahiraam > wrote: > >> In D146148#4220495

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

cebowleratibm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2207 +addUsedOrCompilerUsedGlobal(GV); + else if (CodeGenOpts.KeepStaticConsts && VD->getType().isConstQualified()) +addUsedOrCompilerUsedGlobal(GV); why no

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, thakis, mstorsjo, rsmith. Herald added a project: All. shafik requested review of this revision. Previously we allowed the ability to downgrade this diagnostic based on feedback that time was needed to fix code: D131

[clang] e9acf00 - [clang-format] Put a "trailing" space back in a unit test

Author: Owen Pan Date: 2023-05-09T14:42:32-07:00 New Revision: e9acf001e98b22ad4127155a5756402101c47795 URL: https://github.com/llvm/llvm-project/commit/e9acf001e98b22ad4127155a5756402101c47795 DIFF: https://github.com/llvm/llvm-project/commit/e9acf001e98b22ad4127155a5756402101c47795.diff LOG:

[clang] dbedcfd - [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

Author: Fangrui Song Date: 2023-05-09T14:43:46-07:00 New Revision: dbedcfdc2007e235d97b38db7693bd1f5ff443d8 URL: https://github.com/llvm/llvm-project/commit/dbedcfdc2007e235d97b38db7693bd1f5ff443d8 DIFF: https://github.com/llvm/llvm-project/commit/dbedcfdc2007e235d97b38db7693bd1f5ff443d8.diff

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbedcfdc2007: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking (authored by MaskRay). Changed prior to commit: https://review

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" +

[clang] 7f037e5 - [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

Author: Martin Storsjö Date: 2023-05-10T01:07:37+03:00 New Revision: 7f037e5645bd62fca6fc7c3e77962aafe2bc8b27 URL: https://github.com/llvm/llvm-project/commit/7f037e5645bd62fca6fc7c3e77962aafe2bc8b27 DIFF: https://github.com/llvm/llvm-project/commit/7f037e5645bd62fca6fc7c3e77962aafe2bc8b27.diff

[clang-tools-extra] b80febd - [clang-tidy] [test] Narrow down a special case to MSVC mode

Author: Martin Storsjö Date: 2023-05-10T01:07:45+03:00 New Revision: b80febdf43d33414bbc1c8d8a282a73d8f61a781 URL: https://github.com/llvm/llvm-project/commit/b80febdf43d33414bbc1c8d8a282a73d8f61a781 DIFF: https://github.com/llvm/llvm-project/commit/b80febdf43d33414bbc1c8d8a282a73d8f61a781.diff

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f037e5645bd: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only… (authored by mstorsjo). Repository: rG LLVM Github M

[PATCH] D149999: [clang-tidy] [test] Narrow down a special case to MSVC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGb80febdf43d3: [clang-tidy] [test] Narrow down a special case to MSVC mode (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

davidxl added a comment. This patch uses a cleaner method than the previous effort. There is some differences: 1. yamauchi's patch works for both iFDO and autoFDO, while this patch limits to iFDO 2. yamauchi's patch also handles size optimization (IIRC) at granularity smaller than function Lo

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland updated this revision to Diff 520847. michaelmaitland marked an inline comment as done. michaelmaitland added a comment. Remove extra space before VLUpperBound. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://revie

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:15 +class SiFive7IsWorstCaseMX MxList> { + string LLMUL = LargestLMUL.r; + bit c = !eq(mx, LLMUL); pcwang-thead wrote: > I think I have fixed the issue that `defar` ca

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs marked an inline comment as done. codemzs added a comment. Hi @rjmccall and @erichkeane, I would like to inquire about the necessity of implementing excess precision support for `std::bfloat16_t` in this patch. In reference to the discussion on https://reviews.llvm.org/D136919, it was m

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. In D146148#4330611 , @zahiraam wrote: > In D146148#4221651 , @rjmccall > wrote: > >> In D146148#4220591 , @zahiraam >> wrote: >> >>> In D146148

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. Hi @rjmccall and @erichkeane, I would like to inquire about the necessity of implementing excess precision support for `std::bfloat16_t` in this patch. In reference to the discussion on https://reviews.llvm.org/D136919, it was mentioned that introducing `std::bfloat16_

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 520859. ziqingluo-90 added a comment. Visit `LambdaExpr` properly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBas

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dyung added a comment. Hi @MaskRay, the test you modified clang/test/Driver/split-debug.c is failing on the PS5 Windows bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/20981 # command stderr: Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Driver\split-

[PATCH] D150209: [clang][Interp] Add more shift error checking

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:133 +// operand, and must not overflow the corresponding unsigned type. +// C++2a [expr.shift]p2: E1 << E2 is the unique value congruent to +// E1 x 2^E2 module 2^N. Maybe this qu

[clang] 8b16fc2 - [Driver][test] Exclude `-o /dev/null` test for Windows

Author: Fangrui Song Date: 2023-05-09T16:44:15-07:00 New Revision: 8b16fc2e17c0149125e339f45d66f6c4eac9fec8 URL: https://github.com/llvm/llvm-project/commit/8b16fc2e17c0149125e339f45d66f6c4eac9fec8 DIFF: https://github.com/llvm/llvm-project/commit/8b16fc2e17c0149125e339f45d66f6c4eac9fec8.diff

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added a comment. In D149193#4331015 , @dyung wrote: > Hi @MaskRay, the test you modified clang/test/Driver/split-debug.c is failing > on the PS5 Windows bot, can you take a look? > > https://lab.llvm.org/buildbot/#/builders/216/builds/20981 > >

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak updated this revision to Diff 520861. ahatanak added a comment. Disable `llvm-symbolizer` individually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 Files: clang/test/Driver/crash-diagnostic

[clang-tools-extra] 84deed2 - [clangd] Fix a build failure. NFC

Author: Younan Zhang Date: 2023-05-10T08:28:07+08:00 New Revision: 84deed2b7b6325f99d50ce46512de2c078cefb3a URL: https://github.com/llvm/llvm-project/commit/84deed2b7b6325f99d50ce46512de2c078cefb3a DIFF: https://github.com/llvm/llvm-project/commit/84deed2b7b6325f99d50ce46512de2c078cefb3a.diff

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks added a comment. In D149800#4330831 , @davidxl wrote: > This patch uses a cleaner method than the previous effort. There is some > differences: > > 1. yamauchi's patch works for both iFDO and autoFDO, while this patch limits > to iFDO > 2. yama

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &&D); +SemaDiagnosticBuilder &operator=(SemaDiag

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

tahonermann added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; Manna wrote: > sdesmalen wr

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

ikudrin added a comment. In D149119#4329274 , @tmatheson wrote: > LGTM, thank you for doing this. Please give it a couple of days in case > others have comments. Thanks! In D149119#4329285 , @jhenderson wrote:

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 520880. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150226/new/ https://reviews.llvm.org/D150226 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/ExprConstant.cpp clang/test/Se

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. I am wondering what section of the release notes to put this under. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150226/new/ https://reviews.llvm.org/D150226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 7adf384 - [docs] [C++20] [Modules] Remove the section 'Source content consistency'

Author: Chuanqi Xu Date: 2023-05-10T09:59:50+08:00 New Revision: 7adf3849e40e0b9faa3512874e2a1dc4cf86387a URL: https://github.com/llvm/llvm-project/commit/7adf3849e40e0b9faa3512874e2a1dc4cf86387a DIFF: https://github.com/llvm/llvm-project/commit/7adf3849e40e0b9faa3512874e2a1dc4cf86387a.diff LO

[PATCH] D137397: [Sanitizer] [Scudo] Add riscv64 support for scudo

MaskRay added a comment. Herald added a subscriber: asb. 2538e550420fed5036d224fd93e9145c845f0ffe contains `Reviewers: cryptoad, eugenis, vitalybuka, luismarques, hiraditya`. The reviewer list isn't useful. Just drop it for fu

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. Build failures look unrelated to my changes, it looks like it was failing before this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150226/new/ https://reviews.llvm.org/D150226 ___ cfe-commits mailing list cfe-commit

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 520904. 4vtomat added a comment. Remove -march=help alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/incl

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

MyDeveloperDay added a comment. Interesting Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:69 + // Ignore the comma separators. + continue; +} else if (Tok->isOneOf(tok::identifier, tok::kw_class)) { You need a unit tests that t

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520912. junaire added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Inte

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520913. junaire added a comment. Remove unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/in

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520914. junaire added a comment. Add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/incl

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:136 +if (LHS.isNegative()) + S.CCEDiag(E, diag::note_constexpr_lshift_of_negative) << 12; +else if (LHS.toUnsigned().countLeadingZeros() < static_cast(RHS)) shafik wrote: > Do w

<    1   2