[PATCH] D149165: [clangd] Deduplicate missing-include findings

VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:419 }); + // Put possibly equal diagnostics together for deduplication. + // The duplicates might be from macro arguments that get expanded multiple Could you m

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

mstorsjo added a comment. In D149119#4298024 , @phosek wrote: > Supporting only a single tool and simplifying the script would be my > preference as well. I see that the script already supports `llvm-readobj`, do > we need the `llvm-nm` support in that

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet updated this revision to Diff 517076. kadircet added a comment. - Reorganize string literals in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149165/new/ https://reviews.llvm.org/D149165 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:419 }); + // Put possibly equal diagnostics together for deduplication. + // The duplicates might be from macro arguments that get expanded

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Could you please split the change to printing + the test updates from all the other changes? The code changes get lost in the large diff. Comment at: llvm/include/ll

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149206/new/ https://reviews.llvm.org/D149206 ___

[clang] 3185e47 - [clang][Interp] Fix post-inc/dec operator result

Author: Timm Bäder Date: 2023-04-26T09:36:08+02:00 New Revision: 3185e47b5a8444e9fd70b746a7ad679dd131ffe4 URL: https://github.com/llvm/llvm-project/commit/3185e47b5a8444e9fd70b746a7ad679dd131ffe4 DIFF: https://github.com/llvm/llvm-project/commit/3185e47b5a8444e9fd70b746a7ad679dd131ffe4.diff LO

[PATCH] D148901: [clang][Interp] Fix post-inc/dec operator result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3185e47b5a84: [clang][Interp] Fix post-inc/dec operator result (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 517078. VincentWu marked 2 inline comments as done. VincentWu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/P

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:915 +return createStringError(errc::invalid_argument, + "'zcmt' is incompatible with 'c' or 'zcd' " + "extensions when 'd' extensions is s

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added a comment. @aaron.ballman Are you OK with the approach taken here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] 08f0725 - [clangd] Deduplicate missing-include findings

Author: Kadir Cetinkaya Date: 2023-04-26T10:33:55+02:00 New Revision: 08f0725a3a5471d16b8a1e9d1d55b9952300ac41 URL: https://github.com/llvm/llvm-project/commit/08f0725a3a5471d16b8a1e9d1d55b9952300ac41 DIFF: https://github.com/llvm/llvm-project/commit/08f0725a3a5471d16b8a1e9d1d55b9952300ac41.dif

[PATCH] D149165: [clangd] Deduplicate missing-include findings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f0725a3a54: [clangd] Deduplicate missing-include findings (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517093. hokein marked 8 inline comments as done. hokein added a comment. address review comments: - emit one annotation per textedit; - remove unnecessary std::optional in the protocol structure - add a lit test Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme updated this revision to Diff 517094. mboehme added a comment. Reworded release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/ https://reviews.llvm.org/D148110 Files: clang-tools-extra/clang-tidy/utils/ExprSequence.cpp

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517096. hokein added a comment. more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +/*description=*/std

[clang] 5794ea4 - [Sema] Fix _Alignas/isCXX11Attribute() FIXME

Author: Richard Sandiford Date: 2023-04-26T09:49:07+01:00 New Revision: 5794ea421a0d60802141a9f289cd2c9fa8f7416c URL: https://github.com/llvm/llvm-project/commit/5794ea421a0d60802141a9f289cd2c9fa8f7416c DIFF: https://github.com/llvm/llvm-project/commit/5794ea421a0d60802141a9f289cd2c9fa8f7416c.d

[PATCH] D149148: [Sema] Fix _Alignas/isCXX11Attribute() FIXME

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] a31b3a1 - [clang[[Interp][NFC] Make some Descriptor pointers const

Author: Timm Bäder Date: 2023-04-26T10:57:43+02:00 New Revision: a31b3a1a6d60cbb2ca9a110e70f0592aac574f1f URL: https://github.com/llvm/llvm-project/commit/a31b3a1a6d60cbb2ca9a110e70f0592aac574f1f DIFF: https://github.com/llvm/llvm-project/commit/a31b3a1a6d60cbb2ca9a110e70f0592aac574f1f.diff LO

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme updated this revision to Diff 517101. mboehme added a comment. Reworded release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/ https://reviews.llvm.org/D148110 Files: clang-tools-extra/clang-tidy/utils/ExprSequence.cpp

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:216-219 - Improved :doc:`bugprone-use-after-move - ` check to also cover constructor - initializers. + ` check: Also cover constructor + initializers. Fix check to understand that constructor

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

tmatheson added a comment. In D149119#4297540 , @ikudrin wrote: > If I understand it right, we might not be able to build `llvm-nm` in cases > like cross-platform building, right? LLVM has a way to build tools that need to run on the build machine as pa

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

asb created this revision. asb added reviewers: reames, kito-cheng, craig.topper, jrtc27, joshua-arch1. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruce

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

asb updated this revision to Diff 517105. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149246/new/ https://reviews.llvm.org/D149246 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo.cpp llvm/unittests/Support/RISCVISAInfoTest.cpp I

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

asb updated this revision to Diff 517106. asb added a comment. Add missing doc comment update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149246/new/ https://reviews.llvm.org/D149246 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInf

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. +- LGTM Comment at: clang-tools-extra/docs/ReleaseNotes.rst:217 - Improved :doc:`bugprone-use-after-move - ` check to also cover constructor - initializers. + ` check

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + sammccall wrote: > mboehme wrote: > > sammccall wro

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

DavidSpickett added a comment. Hi, these tests are failing on our (Linaro's) Windows on Arm buildbot. First appearance here https://lab.llvm.org/buildbot/#/builders/65/builds/9346 Still failing as of a few hours ago https://lab.llvm.org/buildbot/#/builders/65/builds/9360 (maybe you have fixed

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

bgraur added a comment. @aaron.ballman your patch (1395cde24b3641e284bb1daae7d56c189a2635e3 ) fixed all issues we encountered. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 517113. 4vtomat added a comment. Update to version 0.5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. @kadircet @nridge friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148663/new/ https://reviews.llvm.org/D148663 ___ cfe-commits m

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

asb created this revision. asb added reviewers: reames, craig.topper, kito-cheng. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Mart

[clang] 343bdb1 - [analyzer] Show taint origin and propagation correctly

Author: Daniel Krupp Date: 2023-04-26T12:43:36+02:00 New Revision: 343bdb10940cb2387c0b9bd3caccee7bb56c937b URL: https://github.com/llvm/llvm-project/commit/343bdb10940cb2387c0b9bd3caccee7bb56c937b DIFF: https://github.com/llvm/llvm-project/commit/343bdb10940cb2387c0b9bd3caccee7bb56c937b.diff

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added a comment. In D148783#4298398 , @DavidSpickett wrote: > Hi, these tests are failing on our (Linaro's) Windows on Arm buildbot. First > appearance here https://lab.llvm.org/buildbot/#/builders/65/builds/9346 > > Still failing as of a few hou

[clang-tools-extra] 4294619 - [clangd] Fix the window buildbot test failures

Author: Haojian Wu Date: 2023-04-26T12:59:45+02:00 New Revision: 4294619b4cdfed49502dcebc7efd5f044e587267 URL: https://github.com/llvm/llvm-project/commit/4294619b4cdfed49502dcebc7efd5f044e587267 DIFF: https://github.com/llvm/llvm-project/commit/4294619b4cdfed49502dcebc7efd5f044e587267.diff LO

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added a comment. should be fixed in https://github.com/llvm/llvm-project/commit/4294619b4cdfed49502dcebc7efd5f044e587267. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 __

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

ilya-biryukov added a comment. I wanted to chime in and provide a bit of context. This was a long time ago, so I might misremember, so take this with a grain of salt. Idea behind pushing the CDB over LSP was to allow the capable client to **fully** control the commands produced for the files. D

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +/*description=*/s

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

aaron.ballman added a comment. In D148730#4298401 , @bgraur wrote: > @aaron.ballman your patch (1395cde24b3641e284bb1daae7d56c189a2635e3 > ) fixed > all issues we encountered. Thanks!!

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In D147844#4293743 , @cjdb wrote: > In D147844#4293693 , @dblaikie > wrote: > >>> I think some of the cases are ambiguous while others are not. >> >> Data would be good to have - if

[PATCH] D148987: [clang][Interp] Check Neg ops for errors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a request to add a message to the assertion. Comment at: clang/lib/AST/Interp/Interp.h:436 + + assert(isIntegralType(Name)); S.Stk.push(Result); -

[PATCH] D149172: [clang][Interp] Emit proper diagnostic when comparing unrelated pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149172/new/ https://reviews.llvm.org/D149172

[PATCH] D149154: [clang][Interp] Emit diagnostic when comparing function pointers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:652-653 + const SourceInfo &Loc = S.Current->getSource(OpPC); + S.FFDiag(Loc, diag::note_constexpr_pointer_comparison_unspecified) + << LS << RS; + return false; tbaeder wrote:

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp closed this revision. dkrupp added a comment. Committed in 343bdb10940cb2387c0b9bd3caccee7bb56c937b . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, but please add a release note when landing the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 _

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. So what are next steps? Are we going for implementation of `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? @dblaikie @aprantl @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new

[clang] 8b39527 - [NFC] Wrap entire debug logging loop in LLVM_DEBUG

Author: Jordan Rupprecht Date: 2023-04-26T05:28:15-07:00 New Revision: 8b39527535ff50837da08509392e3268fb6129f0 URL: https://github.com/llvm/llvm-project/commit/8b39527535ff50837da08509392e3268fb6129f0 DIFF: https://github.com/llvm/llvm-project/commit/8b39527535ff50837da08509392e3268fb6129f0.di

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

steakhal added inline comments. Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2 +typedef typeof(sizeof(int)) size_t; +typedef signed long ssize_t; +typedef struct { `ssize_t`'s size should match the size of `size_t`. In this implementation, i

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1530-1541 + // Get platform dependent values of some macros. + // Try our best to parse this from the Preprocessor, otherwise fallback to a + // default value (what is

[PATCH] D149000: Update with warning message for comparison to NULL pointer

aaron.ballman added inline comments. Comment at: clang/test/Sema/conditional-expr.c:89 char x; - return &x) != ((void *) 0)) ? (*(&x) = ((char) 1)) : (void) ((void *) 0)), (unsigned long) ((void *) 0)); // expected-warning {{C99 forbids conditional expressions with only

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito added a comment. In D149210#4298124 , @nikic wrote: > Could you please split the change to printing + the test updates from all the > other changes? The code changes get lost in the large diff. Yes, that makes sense. The internal representa

[clang] de25473 - [analyzer] Fix comparison logic in ArrayBoundCheckerV2

Author: Donát Nagy Date: 2023-04-26T15:02:23+02:00 New Revision: de2547329b41ad6ea4ea876d12731bde5a6b64c5 URL: https://github.com/llvm/llvm-project/commit/de2547329b41ad6ea4ea876d12731bde5a6b64c5 DIFF: https://github.com/llvm/llvm-project/commit/de2547329b41ad6ea4ea876d12731bde5a6b64c5.diff LO

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy closed this revision. donat.nagy added a comment. Committed in rGde2547329b41ad6ea4ea876d12731bde5a6b64c5 (which accidentally refers to a wrong Phabricator review). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

donat.nagy added a comment. Commit rGde2547329b41ad6ea4ea876d12731bde5a6b64c5 accidentally refers to this review, but in fact it belongs to D148355 . Repository: rG LLVM Github Monorepo

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! I like it. Comment at: clang/include/clang/Frontend/Utils.h:44 class Preprocessor; +class FileManager; class PreprocessorOptions; nit: sort? Reposito

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// delcypher wrote: > @hnrklssn I just noticed

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added a subscriber: cjdb. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:863 + InliningDecisions.push_back(D.getCaller().str()); + for (size_t i = 0, e = InliningDecisions.size(); i != e; ++i) { +std::string S = llvm::dema

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > delcypher wrote: > > @hnrkls

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

hans added inline comments. Comment at: clang/test/Profile/misexpect-branch.c:10 // RUN: %clang_cc1 %s -O2 -o - -emit-llvm -fprofile-instrument-use-path=%t.profdata -verify=foo -fdiagnostics-misexpect-tolerance=10 -Wmisexpect -debug-info-kind=line-tables-only +// RUN: %clang

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito updated this revision to Diff 517150. ManuelJBrito added a comment. Split patch into print update and internal representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149210/new/ https://reviews.llvm.org/D149210 Files: clang/t

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 517151. Krishna-13-cyber added a comment. - Updated with re-adding the required diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files: c

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517154. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/c

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517157. hokein added a comment. fix the lit-test uri path on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/clangd/ClangdLSPServer.

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +/*description=*/std

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 517159. ivanmurashko added a comment. Commandeer the diff from @andrewjcg and made some chnages at the code (get it compatible with latest clang source code) and at the tests (move modules artefacts to temp folder to make the test execution more stable)

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

jsjodin requested changes to this revision. jsjodin added inline comments. This revision now requires changes to proceed. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:817 + /// LLVMModule. + llvm::Constant *getAddrOfDeclareTargetVar( + llvm::OffloadEntriesI

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

DavidSpickett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Decl

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. I generally think this is a good idea. I'd ask you add this to RISCVUsage under "The current known variances from the specification are", and mention it at the next sync up call, but otherwis

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

asb added a comment. +1 on this refactoring being a good idea. The RISC-V changes seem fine to me (haven't done a detailed line by line review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 __

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517166. pmatos marked 3 inline comments as done. pmatos added a comment. Fix Wasm table tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Lang

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy created this revision. donat.nagy added reviewers: steakhal, dkrupp, gamesh411. Herald added subscribers: manas, ASDenysPetrov, martong, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. don

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

asb added a comment. I just wanted to check on whether this is ready to review? Also, to what degree are these intrinsics standardised and where is the relevant specification for them? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/n

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

yaxunl added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:271 LANGOPT(GPUAllowDeviceInit, 1, 0, "allowing device side global init functions for HIP") -LANGOPT(GPUMaxThreadsPerBlock, 32, 1024, "default max threads per block for kernel launch bounds for

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. In D148066#4294924 , @kito-cheng wrote: >> My concern would be that as we don't gate CSR names on enabling the relevant >> extension, people could start using CSR names and encodings that could >> change, without opting in via -men

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. Thanks for the comments - I am working on addressing these at the moment. The LLVM part of the patch is just some refactoring and therefore should be pretty trivial, pinging @tlively in case he has some time. Comment at: clang/test/Sema/wasm-refs-and-ta

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. In D148066#4294924 , @kito-cheng wrote: >> My concern would be that as we don't gate CSR names on enabling the relevant >> extension, people could start using CSR names and encodings that could >> change, without opting in via -

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. FWIW, I've reviewed the CSR numbers vs the spec so LGTM from that perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 ___ cfe-comm

[clang] 62eec15 - [clang-rename] Exit gracefully when no input provided

Author: Shivam Gupta Date: 2023-04-26T20:23:14+05:30 New Revision: 62eec1584d2cd7634c31d4b82215fa8e260cf3b8 URL: https://github.com/llvm/llvm-project/commit/62eec1584d2cd7634c31d4b82215fa8e260cf3b8 DIFF: https://github.com/llvm/llvm-project/commit/62eec1584d2cd7634c31d4b82215fa8e260cf3b8.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG62eec1584d2c: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Changed prior to commit: http

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson marked 2 inline comments as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:942 +/// +/// \code +/// FOR element := 0 to 1 pengfei wrote: > Use `\code{.operation}` please, the same below. Our internal tool will > recog

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4298606 , @aaron.ballman wrote: > LGTM, but please add a release note when landing the changes. Thanks for the review, added a release note for change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 039ae62 - [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-04-26T08:04:31-07:00 New Revision: 039ae62405b6ea130b6f84cd54fea1e8599f1634 URL: https://github.com/llvm/llvm-project/commit/039ae62405b6ea130b6f84cd54fea1e8599f1634 DIFF: https://github.com/llvm/llvm-project/commit/039ae62405b6ea130b6f84cd54fea1e8599f1634.diff

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Approved, assuming we prefer `std::nullopt` over the default construction of `std::optional` and you `clang-format` the affected hunks, such as the declaration of `computeOffset`. Make sur

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rG039ae62405b6: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h (authored by probinson).

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Dec

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind

[clang] b56b15e - [dataflow] HTMLLogger - show the value of the current expr

Author: Sam McCall Date: 2023-04-26T17:15:23+02:00 New Revision: b56b15ed719b4b6a5fe1a0a8b5ece54467ab2fee URL: https://github.com/llvm/llvm-project/commit/b56b15ed719b4b6a5fe1a0a8b5ece54467ab2fee DIFF: https://github.com/llvm/llvm-project/commit/b56b15ed719b4b6a5fe1a0a8b5ece54467ab2fee.diff LO

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb56b15ed719b: [dataflow] HTMLLogger - show the value of the current expr (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI that reverted the change that disabled this as default and tried it for x86. It looks like this patch is working OK for us now: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch.c:10 // RUN: %clang_cc1 %s -O2 -o - -emit-llvm -fprofile-instrument-use-path=%t.profdata -verify=foo -fdiagnostics-misexpect-tolerance=10 -Wmisexpect -debug-info-kind=line-tables-only +// RUN: %c

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni updated this revision to Diff 517193. chapuni added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 Files: clang/lib/CodeGen/CMakeLists.txt llvm/include/llvm/CodeGen/Global

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

balazske updated this revision to Diff 517196. balazske added a comment. using `__restrict` instead of `restrict` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149158/new/ https://reviews.llvm.org/D149158 Files: clang/test/Analysis/Inputs/std-c-

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2 +typedef typeof(sizeof(int)) size_t; +typedef signed long ssize_t; +typedef struct { steakhal wrote: > `ssize_t`'s size

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517199. paulkirth added a comment. Migrate to a Driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149206/new/ https://reviews.llvm.org/D149206 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[clang] 22a748a - [Headers] Revise conditional for rdrand64_step

Author: Paul Robinson Date: 2023-04-26T09:00:29-07:00 New Revision: 22a748a51f2a2644f4dbc5e93615c9f3106e50d5 URL: https://github.com/llvm/llvm-project/commit/22a748a51f2a2644f4dbc5e93615c9f3106e50d5 DIFF: https://github.com/llvm/llvm-project/commit/22a748a51f2a2644f4dbc5e93615c9f3106e50d5.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Thanks Aaron! Yes, fair enough, that looks good to me, probably no need to move a sanity check to the front of `main()` in this case. Also, just as a note: I don't know how many people use `clang-rename` anymore (especially with `clangd` being present), I rewrote a lo

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); -if (!hasReachableDefinition(PartialSpec)) +if (PartialSpec->hasDef

  1   2   3   >