[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: luke, manas, frasercrmck, ASDenysPetrov, luismarques, apazos, sameer.abuasal, s.egerton, Jim, dkrupp, donat.nagy, jocewei, Szelethus, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, a.sidorin, edward-jon

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515367. chaitanyav added a comment. Update SemaCXX tests to use parentheses around conditional operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: cl

[PATCH] D148805: [Clang][OpenMP] Avoid emitting a __kmpc_alloc_shared for implicit casts which do not have their address taken

jdoerfert added a comment. I don't understand the concerns. A array to ptr decay, by itself, does not capture the pointer such that multiple threads can access it. You need to check the uses of the decay and decide based on them. Thus, I think this is fine. Repository: rG LLVM Github Monorep

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515372. MyDeveloperDay added a comment. Handle the case string Foo { set;get; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This set of changes looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___

[clang] 691c480 - [libcxxabi][demangle] create helper for std::string_view::starts_with

Author: Nick Desaulniers Date: 2023-04-20T10:02:32-07:00 New Revision: 691c4800be8018d8ad03f0e25be3672acbdfe403 URL: https://github.com/llvm/llvm-project/commit/691c4800be8018d8ad03f0e25be3672acbdfe403 DIFF: https://github.com/llvm/llvm-project/commit/691c4800be8018d8ad03f0e25be3672acbdfe403.di

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG691c4800be80: [libcxxabi][demangle] create helper for std::string_view::starts_with (authored by nickdesaulniers). Repository: rG LLVM Github Mono

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

rjmccall added a comment. Thank you. Per my comment here: > Also, AAPCS64 seems to define UnadjustedAlignment as the "natural alignment", > and there's a doc comment saying it's the max of the type alignments. That > makes me wonder if we should really be considering either the aligned > attr

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, asb, jrtc27, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

jrtc27 added a comment. Surprised that we didn't already do this; seems like a bit of an oversight. Comment at: clang/test/Driver/riscv-default-build-attributes.s:1 +// Enabled by default for assembly +// RUN: %clang --target=riscv64 -### %s 2>&1 \ Do we use //

[clang] cb7dffd - [RISCV] Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

Author: Eric Gouriou Date: 2023-04-20T18:25:19+01:00 New Revision: cb7dffdc9a83f400410657431bda14e79f6e0176 URL: https://github.com/llvm/llvm-project/commit/cb7dffdc9a83f400410657431bda14e79f6e0176 DIFF: https://github.com/llvm/llvm-project/commit/cb7dffdc9a83f400410657431bda14e79f6e0176.diff

[PATCH] D148483: [RISCV] Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb7dffdc9a83: [RISCV] Zvk (vector crypto) specification update to 0.5.1… (authored by ego, committed by asb). Herald added a project: clang. Herald a

[PATCH] D148483: [RISCV] Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

asb added a comment. In D148483#4283898 , @ego wrote: > Thanks for the clarification. I went with the additional alignment. I used to > overdo vertical alignment but it was beaten out of me by the Google C++ style > guide and automatic formatters. Yes,

[clang] c1ee219 - arm_bf16.td: fix copy/paste typo in comment header

Author: Dimitry Andric Date: 2023-04-20T19:43:51+02:00 New Revision: c1ee2192dd0f28cdf02a0544d25d0710c037bf9b URL: https://github.com/llvm/llvm-project/commit/c1ee2192dd0f28cdf02a0544d25d0710c037bf9b DIFF: https://github.com/llvm/llvm-project/commit/c1ee2192dd0f28cdf02a0544d25d0710c037bf9b.diff

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. That makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148176/new/ https://reviews.llvm.org/D148176

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

dblaikie added a comment. In D146595#4281710 , @aprantl wrote: > In D146595#4278361 , @dblaikie > wrote: > >> In D146595#4235340 , @augusto2112 >> wrote: >> >>> In D1465

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! I spotted a little more that needs to be done, but this is pretty close to ready. I *think* the precommit CI failures are unrelated to th

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515394. chaitanyav added a comment. Update test to use parentheses around conditional operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

aaron.ballman added a comment. In D146595#4284220 , @dblaikie wrote: > In D146595#4281710 , @aprantl wrote: > >> Now if we are going to say this explicitly DWARF only feature, that could be >> an argument to stic

[PATCH] D138224: WIP: AST{Reader,Writer} alternative

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Using `CompilerInstance` as the module storage dramatically increases memory usage (peak ~30GB) of `clang-scan-deps` when scanning LLVM. (Memory mapping serialized files peaks at ~300MB.) Repository: rG LLVM Github Monorepo

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Using `CompilerInstance` as the module storage dramatically increases memory usage (peak ~30GB) of `clang-scan-deps` when scanning LLVM. (Memory mapping serialized files peaks at ~300MB.) Repository: rG LLVM Github Monorepo

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

efriedma added a comment. In D148723#4283094 , @serge-sans-paille wrote: > In D148723#4280916 , @efriedma > wrote: > >> The point of an "inline builtin" is that the inline function is actually the >> original f

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8206 - for (auto B : CXXRD->bases()) + for (const auto &B : CXXRD->bases()) if (hasTemplateSpecializationInEncodedString(B.getType().getTypePtr(), CXXBaseSpecifier is less in size, but

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. ping Does the approach look right? Would it be better to put everything into cpp files and only expose a factory method e.g. createMyTargetCodeGenInfo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https:/

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim created this revision. dim added reviewers: t.p.northover, fpetrogalli, sdesmalen, az, LukeGeeson, stuij. Herald added a project: All. dim requested review of this revision. Herald added a project: clang. As of https://reviews.llvm.org/D79708, clang-tblgen generates both `arm_neon.h` and `arm

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

dblaikie added a comment. In D146595#4284268 , @aaron.ballman wrote: > In D146595#4284220 , @dblaikie > wrote: > >> In D146595#4281710 , @aprantl >> wrote: >> >>> Now i

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-default-build-attributes.s:1 +// Enabled by default for assembly +// RUN: %clang --target=riscv64 -### %s 2>&1 \ jrtc27 wrote: > Do we use /// for non-lit/FileCheck lines like we use ;; in IR

[clang] e766e3a - [clang][deps] Print timing information

Author: Jan Svoboda Date: 2023-04-20T11:18:32-07:00 New Revision: e766e3afedeba90dfbd0513a675a9bf32c5cc8e9 URL: https://github.com/llvm/llvm-project/commit/e766e3afedeba90dfbd0513a675a9bf32c5cc8e9 DIFF: https://github.com/llvm/llvm-project/commit/e766e3afedeba90dfbd0513a675a9bf32c5cc8e9.diff L

[PATCH] D147815: [clang][deps] Print timing information

This revision was automatically updated to reflect the committed changes. Closed by commit rGe766e3afedeb: [clang][deps] Print timing information (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D147815?vs=511802&id=515401#toc Repository: rG LLVM Github Monorepo

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] e06a91c - [clang][modules] Avoid re-exporting PCH imports on every later module import

Author: Ben Langmuir Date: 2023-04-20T11:29:23-07:00 New Revision: e06a91c5996b039cacd55e6ead0baf14424c740c URL: https://github.com/llvm/llvm-project/commit/e06a91c5996b039cacd55e6ead0baf14424c740c DIFF: https://github.com/llvm/llvm-project/commit/e06a91c5996b039cacd55e6ead0baf14424c740c.diff

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe06a91c5996b: [clang][modules] Avoid re-exporting PCH imports on every later module import (authored by benlangmuir). Repository: rG LLVM Github M

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim updated this revision to Diff 515409. dim added a comment. Also fix up arm_sve.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D148822 Files: clang/utils/TableGen/NeonEmitter.cpp clang/utils/TableGen/S

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8206 - for (auto B : CXXRD->bases()) + for (const auto &B : CXXRD->bases()) if (hasTemplateSpecializationInEncodedString(B.getType().getTypePtr(), Manna wrote: > CXXBaseSpecifier

[clang] 0191078 - Fix failure with team-wide allocated variable

Author: Doru Bercea Date: 2023-04-20T14:40:35-04:00 New Revision: 01910787d386584ea5a3d5dc317a908423ba39ed URL: https://github.com/llvm/llvm-project/commit/01910787d386584ea5a3d5dc317a908423ba39ed DIFF: https://github.com/llvm/llvm-project/commit/01910787d386584ea5a3d5dc317a908423ba39ed.diff L

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 closed this revision. doru1004 added a comment. Commit: 01910787d386584ea5a3d5dc317a908423ba39ed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 __

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. We used to support it that way and decided just not doing it. It is very hard to explain why a supported atomic results in error. Someone who really needs it can use intrinsic.

[PATCH] D148827: -fsanitize=function: support C

MaskRay created this revision. MaskRay added reviewers: Sanitizers, efriedma, pcc, peter.smith, sberg, samitolvanen. Herald added a subscriber: Enna1. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: cfe-co

[PATCH] D148827: -fsanitize=function: support C

MaskRay added a comment. This patch is also available https://github.com/MaskRay/llvm-project/tree/function-c , which may make inspecting stacked patches easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148827/new/ https://reviews.llvm.org/D

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

b-sumner added a comment. In D148796#4284504 , @rampitec wrote: > We used to support it that way and decided just not doing it. It is very hard > to explain why a supported atomic results in error. Someone who really needs > it can use intrinsic. I ten

[clang] 2811472 - [dataflow] Try to fix missing order dependency in HTMLLogger

Author: Sam McCall Date: 2023-04-20T21:37:53+02:00 New Revision: 28114722baabb468732a9cc24784abafd6c47792 URL: https://github.com/llvm/llvm-project/commit/28114722baabb468732a9cc24784abafd6c47792 DIFF: https://github.com/llvm/llvm-project/commit/28114722baabb468732a9cc24784abafd6c47792.diff LO

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. Sorry about the delay. I hope this is fixed by 28114722baabb468732a9cc24784abafd6c47792 . I wasn't able to reproduce the problem locally, so I'm not sure. add_llvm_library says DEPENDS is the same a

[PATCH] D148835: [clang] removes trailing whitespace

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane, dblaikie. Herald added subscribers: luke, steakhal, bzcheeseman, kosarev, pmatos, asb, ormris, frasercrmck, jdoerfert, martong, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, arphama

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515445. chaitanyav added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Place parentheses around conditional operator since & has higher precedence Repository: rG LLVM Github Monore

[clang] 1a0a030 - Add documentation for -Wwrite-strings

Author: Aaron Ballman Date: 2023-04-20T16:14:03-04:00 New Revision: 1a0a0305c03dc6cf42d042f39199ca37c16f6dda URL: https://github.com/llvm/llvm-project/commit/1a0a0305c03dc6cf42d042f39199ca37c16f6dda DIFF: https://github.com/llvm/llvm-project/commit/1a0a0305c03dc6cf42d042f39199ca37c16f6dda.diff

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 updated this revision to Diff 515455. jansvoboda11 added a comment. This revision is now accepted and ready to land. Move from `llvm::StringSwitch` back to binary search on sorted vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D148835: [clang] removes trailing whitespace

cjdb abandoned this revision. cjdb added a comment. I've had some very good input about why this probably shouldn't go ahead: git history erasure :') Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148835/new/ https://reviews.llvm.org/D148835 _

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.deduct/p9.cpp:2 +// RUN: %clang_cc1 -std=c++20 -verify %s +template +auto f(T) -> decltype([]() { T::invalid; } ()); Maybe helpful to quote p9? Comment at: clang/test/CXX/temp

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL marked 2 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/optional-value-conversion.cpp:16 + }; +} + njames93 wrote: > PiotrZSL wrote: > > njames93 wrote: > > > It'd be good to hav

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 515475. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Added support for ->, added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 515476. PiotrZSL added a comment. Marked check as one that provides fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files: clang-tools-extra/clang-tidy/bugp

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

PiotrZSL added a comment. @njames93 What do you thing ? Should bugprone-exception-escape provide warnings for all forward declarations and definition, or only for definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148462/new/ https://review

[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145197/new/ https://reviews.llvm.org/D145197 _

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

tahonermann added a comment. With the exception of the case involving the `Policy` class, these changes all look fine to me. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:562 if (UnMaskedPolicyScheme != PolicyScheme::SchemeNone) - for (auto P : Supported

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

craig.topper updated this revision to Diff 515484. craig.topper added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148817/new/ https://reviews.llvm.org/D148817 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D148263: [clang] Mark CWG2009 as N/A

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, from what I can tell this did not change anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148263/new/ https://reviews.llvm.org/D148

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

jrtc27 added a comment. Some more... hopefully spotted everything this time, sorry Comment at: clang/test/Driver/riscv-default-build-attributes.s:1 + Enabled by default for assembly +// RUN: %clang --target=riscv64 -### %s 2>&1 \ Comment

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515492. chaitanyav added a comment. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Place parentheses around conditional expression to prevent precedence warnings since -Werror is enabled on build Repository: rG LLVM Github Monor

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna updated this revision to Diff 515494. Manna marked an inline comment as done and an inline comment as not done. Manna edited the summary of this revision. Manna added a comment. I have removed the case involving the `Policy` class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14881

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 515497. cjdb marked 6 inline comments as done. cjdb added a comment. Herald added subscribers: aheejin, dschuff. - undoes whitespace changes as requested - documents feature I think the only thing left is to address the global new/delete and static member funct

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5756 + if (FunctionDecl *F = D->getAsFunction(); + F->isOverloadedOperator() || F->isCXXClassMember()) { +S.Diag(AL.getLoc(), diag::err_disable_adl_no_operators) cor3ntin wrote: > a

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

cjdb abandoned this revision. cjdb added a comment. Herald added a project: All. I think there was a clang-tidy patch that handled this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107292/new/ https://reviews.llvm.org/D107292 ___

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-default-build-attributes.s:3 +// RUN: %clang --target=riscv64 -### %s 2>&1 \ +// RUN:| FileCheck %s -check-prefix CHECK-ENABLED + jrtc27 wrote: > jrtc27 wrote: > > `=` for these > Also ar

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb abandoned this revision. cjdb added a comment. Abandoning, since this doesn't have consensus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ https://reviews.llvm.org/D135238 ___ cfe-commi

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

cjdb abandoned this revision. cjdb added a comment. Abandoning, since this doesn't have consensus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135239/new/ https://reviews.llvm.org/D135239 ___ cfe-commi

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv-default-build-attributes.s:3 +// RUN: %clang --target=riscv64 -### %s 2>&1 \ +// RUN:| FileCheck %s -check-prefix CHECK-ENABLED + craig.topper wrote: > jrtc27 wrote: > > jrtc27 wrote: > > > `=`

[PATCH] D135240: [clang] adds move-constructible type-trait builtins

cjdb abandoned this revision. cjdb added a comment. Abandoning, since this doesn't have consensus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135240/new/ https://reviews.llvm.org/D135240 ___ cfe-commi

[PATCH] D135338: [clang] adds move-assignable type-trait builtins

cjdb abandoned this revision. cjdb added a comment. Abandoning, since this doesn't have consensus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135338/new/ https://reviews.llvm.org/D135338 ___ cfe-commi

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb abandoned this revision. cjdb added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Abandoning since we're heading down a different design path now. Repository: rG LLVM Githu

[PATCH] D140125: [clang] splits diagnostic message into summary and reason

cjdb abandoned this revision. cjdb added a comment. Abandoning since we're going down a different design path now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140125/new/ https://reviews.llvm.org/D140125 _

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added a comment. @aaron.ballman are you okay with this being merged now, provided that it's off by default? Apologies for letting this one fall through the cracks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141310/new/ https://reviews.llvm

[PATCH] D148849: [OpenMP-OPT] Remove limit for heap to stack conversions of __kmpc_alloc_shared allocations

jdoerfert added a comment. Make a test for the attributor/openmp-opt, also don't use O2 in tests, the IR only test is sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148849/new/ https://revie

[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

craig.topper updated this revision to Diff 515511. craig.topper added a comment. Fix more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148817/new/ https://reviews.llvm.org/D148817 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. For the record, this also breaks (broke?) Halide: Assertion failed: (!(Elmt.getFragmentOrDefault() == Next.getFragmentOrDefault())), function operator(), file AssignmentTrackingAnalysis.cpp, line 2020. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Soumi! Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 ___

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515513. chaitanyav added a comment. clang-format the changes to the file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak created this revision. ahatanak added reviewers: delcypher, MaskRay, dblaikie. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. These tests don't require invoking llvm-symbolizer. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. These tests are all timing out after 600 seconds. https://green.lab.llvm.org/green/job/clang-stage1-RA/34005/#showFailuresLink Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 __

[PATCH] D146987: [Assignment Tracking] Enable by default

jmorse added a comment. In D146987#4285275 , @srj wrote: > For the record, this also breaks (broke?) Halide: > > Assertion failed: (!(Elmt.getFragmentOrDefault() == > Next.getFragmentOrDefault())), function operator(), file > AssignmentTrackingAnalysis.

[PATCH] D148849: [OpenMP-OPT] Remove limit for heap to stack conversions of __kmpc_alloc_shared allocations

doru1004 updated this revision to Diff 515516. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148849/new/ https://reviews.llvm.org/D148849 Files: llvm/lib/Transforms/IPO/AttributorAttributes.cpp llvm/test/Transforms/Attributor/heap_to_stack_gpu.l

[PATCH] D148849: [OpenMP-OPT] Remove limit for heap to stack conversions of __kmpc_alloc_shared allocations

doru1004 added a comment. In D148849#4285236 , @jdoerfert wrote: > Make a test for the attributor/openmp-opt, also don't use O2 > in tests, the IR only test is > sufficient. I removed the clang test since it

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. In D146987#4285299 , @jmorse wrote: > In D146987#4285275 , @srj wrote: > >> For the record, this also breaks (broke?) Halide: >> >> Assertion failed: (!(Elmt.getFragmentOrDefault() == >> Next

[PATCH] D148849: [OpenMP-OPT] Remove limit for heap to stack conversions of __kmpc_alloc_shared allocations

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148849/new/ https://reviews.llvm.org/D148849 ___

[PATCH] D146987: [Assignment Tracking] Enable by default

srj added a comment. >> That's a new one -- would you be able to give some context and a reproducer? >> Thanks for reporting! > > Yep -- as of LLVM commit 3c9083f6757cbaf6f8d6c601586d99a11faf642e > , Halide > is still broken.

[PATCH] D148596: [KMSAN] Enable on SystemZ

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 _

[clang] 43c307f - [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

Author: Igor Kudrin Date: 2023-04-20T17:02:17-07:00 New Revision: 43c307fd690ffa97877f371ff18530fcd0bddd82 URL: https://github.com/llvm/llvm-project/commit/43c307fd690ffa97877f371ff18530fcd0bddd82 DIFF: https://github.com/llvm/llvm-project/commit/43c307fd690ffa97877f371ff18530fcd0bddd82.diff L

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43c307fd690f: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows (authored by ikudrin). Repository: rG LLVM Github Monor

[PATCH] D148596: [KMSAN] Enable on SystemZ

MaskRay added inline comments. Comment at: llvm/test/Instrumentation/MemorySanitizer/SystemZ/basic-kernel.ll:12 + +; CHECK-LABEL: @Store1 +; CHECK: [[META_PTR:%[a-z0-9_]+]] = alloca { ptr, ptr }, align 8 `; CHECK-LABEL: define {{[^@]+}}@Store1(` to match the `@St

[PATCH] D148596: [KMSAN] Enable on SystemZ

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1498 +if (MS.TargetTriple.getArch() == Triple::systemz) + MS.MsanMetadataAlloca = IRB.CreateAlloca(MS.MsanMetadata, (unsigned)0); } Just use 0. Even

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

shafik added a comment. Do you know why these started timing out? I saw this locally the other day but could not figure out the root cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 ___

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

MaskRay added a comment. In D148851#4285583 , @shafik wrote: > Do you know why these started timing out? I saw this locally the other day > but could not figure out the root cause. D86170 provides some information about

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 515559. rsundahl added a comment. Rename fsanitize_address_stable_abi to fsanitize_stable_abi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/include/

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. FWIW I think it's still worth some data from applying this to a broad codebase like Chromium/wherever it's planned to be used - whether it's practical to make a codebase clean of this warning, what sort of challenges arise, whether we should consider/need some way to s

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. I'm OK with this, though I wouldn't mind a more robust/general solution to this - especially all gunit death tests have this problem too - they crash and spend significant time symbolizing, I think? So it'd be great if we could find some way to run those with symboliza

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. > I think we probably should add LLVM_DISABLE_SYMBOLIZATION=1 to the lit level, > not in individual tests. Though I'm not sure how to do that in a way that it doesn't apply to test that are genuinely failing, where a symbolized backtrace is helpful/important/exactly

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

Manna marked an inline comment as done. Manna added a comment. Thank you @tahonermann and @erichkeane for reviews and feedback. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4262 // will be using. - for (auto I : Attrs) { + for (const auto &I : Attrs) { const

[clang] 20d9aa1 - [doc] [C++20] [Modules] Document that the interfaces of header units is experimental

Author: Chuanqi Xu Date: 2023-04-21T10:43:24+08:00 New Revision: 20d9aa1a439f95468baa9cc40c5c6482ed7665d5 URL: https://github.com/llvm/llvm-project/commit/20d9aa1a439f95468baa9cc40c5c6482ed7665d5 DIFF: https://github.com/llvm/llvm-project/commit/20d9aa1a439f95468baa9cc40c5c6482ed7665d5.diff LO

<    1   2   3   >