jrtc27 added a comment.
Some more... hopefully spotted everything this time, sorry
================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:1
+//// Enabled by default for assembly
+// RUN: %clang --target=riscv64 -### %s 2>&1 \
----------------
================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:3
+// RUN: %clang --target=riscv64 -### %s 2>&1 \
+// RUN: | FileCheck %s -check-prefix CHECK-ENABLED
+
----------------
`=` for these
================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:3
+// RUN: %clang --target=riscv64 -### %s 2>&1 \
+// RUN: | FileCheck %s -check-prefix CHECK-ENABLED
+
----------------
jrtc27 wrote:
> `=` for these
Also aren't these indented 1 too many spaces?
================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:20
+// CHECK-ENABLED: "-riscv-add-build-attributes"
+// expected-warning {{argument unused during compilation:
'-mno-default-build-attributes'}}
----------------
There aren't any uses of -verify?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148817/new/
https://reviews.llvm.org/D148817
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
