[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > alexander-shaposh

[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, zequanwu. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Instead of using the v

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon updated this revision to Diff 513276. Fznamznon added a comment. Rebase, evaluate the expression only only time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 Files: clang/docs/ReleaseNotes.r

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12855 +!Condition.get()->isValueDependent() && +Condition.get()->isIntegerConstantExpr(S.Context)), KnownValue(HasKnownValue &&

[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

erichkeane added a comment. I think this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148245/new/ https://reviews.llvm.org/D148245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ac550984e83: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in… (authored by Ruturaj4, committed by dang). Changed p

[clang] 3ac5509 - [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Author: ruturaj4 Date: 2023-04-13T17:55:45+01:00 New Revision: 3ac550984e83c2478772c800b1f1b5cffd63a10d URL: https://github.com/llvm/llvm-project/commit/3ac550984e83c2478772c800b1f1b5cffd63a10d DIFF: https://github.com/llvm/llvm-project/commit/3ac550984e83c2478772c800b1f1b5cffd63a10d.diff LOG:

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee accepted this revision. browneee added a comment. This revision is now accepted and ready to land. Please fix the additional &. Do you need me to submit it for you? Comment at: compiler-rt/test/dfsan/custom.cpp:1645 + // taint the string pointer + dfsan_set_label(m_

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > erichkeane wrote:

[PATCH] D147935: [RISCV] Add SiFive extension support

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. Thank you @aaron.ballman for reviews and feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148189/new/ https://reviews.llvm.org/D148189 ___ cfe-commits mailing list cfe-commi

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon updated this revision to Diff 513290. Fznamznon added a comment. Use std::optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. The lit test failure seem unrelated to my fix: https://buildkite.com/llvm-project/premerge-checks/builds/146438#0187786e-2f04-40a2-acf1-78eee9f00e7f Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-pre-increment.cpp Repository: rG LLVM Github Monore

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstant

[PATCH] D147989: [clang] Fix Attribute Placement

jrtc27 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: Why not just always pass the full DeclSpec and handle the class case here, maybe with a bool to allow other users to not need to tre

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich abandoned this revision. philipp.tomsich added a comment. I just saw that the last response was "unsubmitted". Submitting and abandoning this revision (based on the discussion and the previously unsubmitted comment from my end). Comment at: llvm/include/llvm/T

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1163 +namespace { + Whats with this namespace addition? looks unnecessary and should be removed Comment at: clang-tools-extra

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194 + if (const auto *Destructor = llvm::dyn_cast(FD)) { +if (auto Err = DeclarationCleanups.add(tooling::Replacement( +SM, Destructor->getLocation(), 0, +

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); erichkeane wrote: > `std::string` is impli

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > craig.topper wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > >

[PATCH] D148260: [clang] Mark CWG2331 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup fro

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > aaron.ballman wrote: > > craig.topper wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > >

[clang] 363c98b - Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

Author: Fangrui Song Date: 2023-04-13T11:17:35-07:00 New Revision: 363c98b2d67986b9766bb1426739970ce6d9a6f3 URL: https://github.com/llvm/llvm-project/commit/363c98b2d67986b9766bb1426739970ce6d9a6f3 DIFF: https://github.com/llvm/llvm-project/commit/363c98b2d67986b9766bb1426739970ce6d9a6f3.diff

[clang] 6251b04 - [-Wunsafe-buffer-usage] A follow-up fix to 762af11d4c5d0bd1e76f23a07087773db09ef17d

Author: Ziqing Luo Date: 2023-04-13T11:24:46-07:00 New Revision: 6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0 URL: https://github.com/llvm/llvm-project/commit/6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0 DIFF: https://github.com/llvm/llvm-project/commit/6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0.diff LO

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 created this revision. Herald added subscribers: ekilmer, hoy, wenlei. Herald added a project: All. zhuhan0 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang may be built in an environment where Git is not avai

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Hmm, looking deeper, gdb (actually binutils), is doing something weird. https://github.com/bminor/binutils-gdb/blob/master/include/safe-ctype.h /* Prevent the users of safe-ctype.h from accidently using the routines from ctype.h. Initially, the approach was to

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148177/new/ https://reviews.llvm.org/D148177 __

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); nickdesaulniers wrote: > erichkeane wrote:

[PATCH] D148263: [clang] Mark CWG2009 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup fro

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

erichkeane added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); nickdesaulniers wrote: > nickdesaulniers wrote:

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

tahonermann added a comment. > It adds an include of #include <__format/formatter_integral.h> which ends up > including which has internal definitions of isupper/islower causing > clang to complain. > > Any suggestions on what would be the right fix here? It sounds like `safe-ctype.h` should a

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); erichkeane wrote: > nickdesaulniers wrote:

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124 ___

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Thanks, sent a patch to gdb at https://sourceware.org/pipermail/gdb-patches/2023-April/198870.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

MaskRay added a comment. In D148034#4264996 , @asb wrote: > In D148034#4262991 , @MaskRay wrote: > >> In D148034#4260376 , @asb wrote: >> >>> Will `--[no-]relax-gp` make i

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When libc++ is bootstrapped with clang using the cmake options -DLLVM_ENABLE_PROJECTS="clang;llvm;lldb" and

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 51. tkuchta added a comment. Thank you, I have uploaded a new diff with "&" fixed in the test function. How should be proceed with the other functions once strsep is done? Should I open another review or add the code to the current patch? CHANGES SINCE

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513335. aeubanks added a comment. Herald added a subscriber: martong. use IgnoreParens instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include

[PATCH] D148268: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC makes these string literals [1][2]. [1] https:/

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513337. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Ignor

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik updated this revision to Diff 513345. shafik marked an inline comment as done. shafik added a comment. - Update codegen test based on feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 Files: clang/lib/Sema/SemaDeclCXX.cpp cla

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

sgraenitz added a comment. This looks a lot better already than the implementation I know from Cling. Well done! OTOH it's a challenge to review since the patch is really big. Is there no way to break it up and test in isolation? Or strip away details that could be added in iterations? I had a

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

owenpan added a comment. In D147176#4265130 , @MyDeveloperDay wrote: > we should be good now Thanks! I really like these new rules! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://revie

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, initialized class members would have the LifetimeKind LK_MemInitializer, which does not allow for binding a

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513377. ayzhao added a comment. fix missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2130 + "initializer|a related result|a parameter of CF audited function|a " + "structured binding|a member subobject}0 " "%diff{of type $ with an %select{rvalue|lvalue}2 of type $|" --

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

jrbyrnes updated this revision to Diff 513386. jrbyrnes marked an inline comment as done. jrbyrnes added a comment. Use type mangling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/ https://reviews.llvm.org/D147732 Files: clang/include

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 513397. shafik marked 8 inline comments as done. shafik added a comment. - Updating diagnostic wording, formatting and names - Updated release notes - Updated c++ status - Updates tests to comment that they will change once we fully support P2448R2 - Various mi

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added inline comments. Comment at: clang/test/CXX/class/class.compare/class.compare.default/p4.cpp:162 + +my_struct obj; // extension-note {{in instantiation of template class 'GH61238::my_struct' requested here}} +} aaron.ballman wrote: > Can you add an

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst created this revision. t-troebst added a reviewer: nridge. t-troebst added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. t-troebst requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D148260: [clang] Mark CWG2331 as N/A

shafik added a comment. The defect report has two examples even though the first one is commented incorrectly considering the final resolution. I am sure they are covered in the test suite in other places but why not add them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst updated this revision to Diff 513406. t-troebst added a comment. Changed `isConstQualifed()` to the custom `isConst()` (though this `isConst()` behaves strangely for pointer types, we should fix this separately and keep them synced for now). Repository: rG LLVM Github Monorepo CHA

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > aaron.ballman wrote: > > > craig.topper wrote: > > > > aaron.ballman wrote: > > > >

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added a comment. We need SemaChecking.cpp code to check the range of the constant arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 ___ cf

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 513412. shafik added a comment. Fix DiagnosticSemaKinds.td , was missing an opening quote CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Dia

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2422 + // Log2LMUL to zero. Otherwise the RISCVVEmitter will expand + // lots of redunant intrinsic but have same names. + let Log2LMUL = [0] in r

[PATCH] D78644: [LSan] Enable for SystemZ

MaskRay added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/lsan/lsan_allocator.h:76 +#elif defined(__s390x__) +const uptr kAllocatorSpace = 0x400ULL; +const uptr kAllocatorSize = 0x400ULL; // 4T.

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:340 +// is not installed. +if (Lang == "objective-c++-header") { + Lang = "c++-header"; kadircet wrote: > this feels like too much of a layering violation a

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. Herald added a reviewer: rymiel. In D137327#4235255 , @MyDeveloperDay wrote: > In D137327#4234463 , @thieta wrote: > >> This was released in LLVM 16.0.0. > > The prior behaviour was there

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 Endill wrote: > erichkeane wrote: > >

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge updated this revision to Diff 513450. nridge marked 2 inline comments as done. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 Files: clang-tools-extra/clangd/

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in semantic highlighting tokens only if the +// client doesn't support a dedicated protocol for being informed about

<    1   2