tahonermann added a comment.

> It adds an include of #include <__format/formatter_integral.h> which ends up 
> including <locale> which has internal definitions of isupper/islower causing 
> clang to complain.
>
> Any suggestions on what would be the right fix here?

It sounds like `safe-ctype.h` should also add a `#include` of `<locale>` (when 
compiling as C++) to avoid interfering with the `std::locale` variants of those 
functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144331/new/

https://reviews.llvm.org/D144331

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to