[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:450 +void test() { + 1s; +} hokein wrote: > here is the `UserDefinedLiteral` AST node: > > ``` > `-UserDefinedLiteral 0x5556682e4500 'int' >

[clang] fd8745c - [clang] Do not require GNUInlineAttr for inline builtins

Author: serge-sans-paille Date: 2023-04-13T09:03:58+02:00 New Revision: fd8745c252bcd4bc974ce3ff30c19f1cc5c4e3e0 URL: https://github.com/llvm/llvm-project/commit/fd8745c252bcd4bc974ce3ff30c19f1cc5c4e3e0 DIFF: https://github.com/llvm/llvm-project/commit/fd8745c252bcd4bc974ce3ff30c19f1cc5c4e3e0.d

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8745c252bc: [clang] Do not require GNUInlineAttr for inline builtins (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/

[clang] c1f7636 - [C++20] [Modules] Continue parsing after we found reserved module names

Author: Chuanqi Xu Date: 2023-04-13T15:14:34+08:00 New Revision: c1f76363e0db41ab6eb9ebedd687ee098491e9b7 URL: https://github.com/llvm/llvm-project/commit/c1f76363e0db41ab6eb9ebedd687ee098491e9b7 DIFF: https://github.com/llvm/llvm-project/commit/c1f76363e0db41ab6eb9ebedd687ee098491e9b7.diff LO

[clang] 9d0b55f - [clang][ASTImporter] Fix import of typedef with unnamed structures

Author: Balázs Kéri Date: 2023-04-13T09:25:12+02:00 New Revision: 9d0b55f0e4ca55d04ee8abfdf021913ea3c30082 URL: https://github.com/llvm/llvm-project/commit/9d0b55f0e4ca55d04ee8abfdf021913ea3c30082 DIFF: https://github.com/llvm/llvm-project/commit/9d0b55f0e4ca55d04ee8abfdf021913ea3c30082.diff L

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d0b55f0e4ca: [clang][ASTImporter] Fix import of typedef with unnamed structures (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145868

[PATCH] D148200: [clang-format] Correctly handle "// clang-format off" above macros

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-projec

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Gentle ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147520/new/ https://reviews.llvm.org/D147520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thank you for the reports and revert, I will dig into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Do you have any thoughts on merging D147905 first, with a view to backporting D147905 to the 16.x branch?

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

bjope added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8627 + )"; + Decl *ToTU = getToTuDecl("", Lang_CXX11); + Decl *FromTU = getTuDecl(Code, Lang_CXX11); With Werror we get: ``` ../../clang/unittests/AST/ASTImporterTest.cpp:862

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:340 +// is not installed. +if (Lang == "objective-c++-header") { + Lang = "c++-header"; this feels like too much of a layering violation and might (will?)

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet updated this revision to Diff 513098. kadircet marked an inline comment as done. kadircet added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146941/new/ https://reviews.llvm.org/D146941 Files: clang-tools-extra/clan

[clang] 39938f2 - Fix warn-unsafe-buffer-usage-fixits-pre-increment.cpp for Windows

Author: Hans Wennborg Date: 2023-04-13T10:21:15+02:00 New Revision: 39938f2d096ca9ed03ecc17ea169ed3195682f18 URL: https://github.com/llvm/llvm-project/commit/39938f2d096ca9ed03ecc17ea169ed3195682f18 DIFF: https://github.com/llvm/llvm-project/commit/39938f2d096ca9ed03ecc17ea169ed3195682f18.diff

[libunwind] 5b9d969 - [libunwind] [SEH] Allow setting/getting the register UNW_X86_64_RIP

Author: Martin Storsjö Date: 2023-04-13T12:03:35+03:00 New Revision: 5b9d969e7c07d720080eac386467c1112c45a76f URL: https://github.com/llvm/llvm-project/commit/5b9d969e7c07d720080eac386467c1112c45a76f DIFF: https://github.com/llvm/llvm-project/commit/5b9d969e7c07d720080eac386467c1112c45a76f.diff

[libunwind] ebae562 - [libunwind] [SEH] Initialize _msContext with RtlCaptureContext

Author: Martin Storsjö Date: 2023-04-13T12:03:35+03:00 New Revision: ebae5622d11655feaa74e64151067897153f9c71 URL: https://github.com/llvm/llvm-project/commit/ebae5622d11655feaa74e64151067897153f9c71 DIFF: https://github.com/llvm/llvm-project/commit/ebae5622d11655feaa74e64151067897153f9c71.diff

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. friendly ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4263139 , @aeubanks wrote: > I'm seeing > > llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void > llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned > int): Assertion `A

[clang] e841d50 - [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

Author: Richard Sandiford Date: 2023-04-13T10:14:48+01:00 New Revision: e841d50926347c3596009dd4fbc4cbd1a1a2e0b8 URL: https://github.com/llvm/llvm-project/commit/e841d50926347c3596009dd4fbc4cbd1a1a2e0b8 DIFF: https://github.com/llvm/llvm-project/commit/e841d50926347c3596009dd4fbc4cbd1a1a2e0b8.d

[clang] b6d4d51 - [clang] Specify attribute syntax & spelling with a single argument

Author: Richard Sandiford Date: 2023-04-13T10:14:49+01:00 New Revision: b6d4d51f8f5aab311df34c753b925760578729bd URL: https://github.com/llvm/llvm-project/commit/b6d4d51f8f5aab311df34c753b925760578729bd DIFF: https://github.com/llvm/llvm-project/commit/b6d4d51f8f5aab311df34c753b925760578729bd.d

[clang] 265d87e - [clang] Allow attributes to be constructed from keyword tokens

Author: Richard Sandiford Date: 2023-04-13T10:14:49+01:00 New Revision: 265d87e46535bef2b718759ba39bb9fa30b1ef48 URL: https://github.com/llvm/llvm-project/commit/265d87e46535bef2b718759ba39bb9fa30b1ef48 DIFF: https://github.com/llvm/llvm-project/commit/265d87e46535bef2b718759ba39bb9fa30b1ef48.d

[clang] aec3f95 - [clang] Type safety tweak for AttributeCommonInfo::Form

Author: Richard Sandiford Date: 2023-04-13T10:14:49+01:00 New Revision: aec3f951bf368d45b441554dac6e027678f9f3ee URL: https://github.com/llvm/llvm-project/commit/aec3f951bf368d45b441554dac6e027678f9f3ee DIFF: https://github.com/llvm/llvm-project/commit/aec3f951bf368d45b441554dac6e027678f9f3ee.d

[clang] bd41371 - [clang] Fix FIXME in isAlignasAttribute()

Author: Richard Sandiford Date: 2023-04-13T10:14:50+01:00 New Revision: bd41371be02f6f5713459a2f6fe109cd3c01b4a4 URL: https://github.com/llvm/llvm-project/commit/bd41371be02f6f5713459a2f6fe109cd3c01b4a4 DIFF: https://github.com/llvm/llvm-project/commit/bd41371be02f6f5713459a2f6fe109cd3c01b4a4.d

[clang] 053bdb7 - [clang] Bump AS_GNU to 1

Author: Richard Sandiford Date: 2023-04-13T10:14:50+01:00 New Revision: 053bdb77b0ce4506d15ed381b6db0dddafe52c3e URL: https://github.com/llvm/llvm-project/commit/053bdb77b0ce4506d15ed381b6db0dddafe52c3e DIFF: https://github.com/llvm/llvm-project/commit/053bdb77b0ce4506d15ed381b6db0dddafe52c3e.d

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

This revision was automatically updated to reflect the committed changes. Closed by commit rGe841d5092634: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d4d51f8f5a: [clang] Specify attribute syntax & spelling with a single argument (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG265d87e46535: [clang] Allow attributes to be constructed from keyword tokens (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103

[PATCH] D148104: [clang] Type safety tweak for AttributeCommonInfo::Form

This revision was automatically updated to reflect the committed changes. Closed by commit rGaec3f951bf36: [clang] Type safety tweak for AttributeCommonInfo::Form (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148104/new/

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd41371be02f: [clang] Fix FIXME in isAlignasAttribute() (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148105/new/ https://review

[PATCH] D148148: [clang] Bump AS_GNU to 1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG053bdb77b0ce: [clang] Bump AS_GNU to 1 (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4263263 , @rupprecht wrote: > In D146987#4263048 , @MaskRay wrote: > >> The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d >>

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

hokein updated this revision to Diff 513134. hokein marked an inline comment as not done. hokein added a comment. use syntax::spelledTokensTouching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147686/new/ https://reviews.llvm.org/D147686 Files:

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:450 +void test() { + 1s; +} kadircet wrote: > hokein wrote: > > here is the `UserDefinedLiteral` AST node: > > > > ``` > > `-UserDefinedLiteral 0x55

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In some cases non-null non-constant yet valid expression may reach point where `ConditionResult` is created. For example

[PATCH] D146987: [Assignment Tracking] Enable by default

jmorse added a comment. Many thanks for all the feedback, In D146987#4263139 , @aeubanks wrote: > I'm seeing > > llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void > llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst

[clang] 1689a5d - [clang] fix an unused variable warning after 9d0b55f0e4ca55d04ee8abfdf021913ea3c30082

Author: Krasimir Georgiev Date: 2023-04-13T10:03:37Z New Revision: 1689a5d756f81d615bcfca8de2631b0ccc8a3917 URL: https://github.com/llvm/llvm-project/commit/1689a5d756f81d615bcfca8de2631b0ccc8a3917 DIFF: https://github.com/llvm/llvm-project/commit/1689a5d756f81d615bcfca8de2631b0ccc8a3917.diff

[PATCH] D148207: [mlir][Tensor] Drop SplitPaddingPatterns.

nicolasvasilache created this revision. Herald added subscribers: bviyer, hanchung, Moerafaat, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddl

[clang-tools-extra] 40276f7 - [include-fixer] Add the missing variant header to the STL header list.

Author: Haojian Wu Date: 2023-04-13T12:09:36+02:00 New Revision: 40276f78fd4dabc4368724c161ca918d6145ef75 URL: https://github.com/llvm/llvm-project/commit/40276f78fd4dabc4368724c161ca918d6145ef75 DIFF: https://github.com/llvm/llvm-project/commit/40276f78fd4dabc4368724c161ca918d6145ef75.diff LO

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 513144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options.td clan

[clang-tools-extra] 2524000 - [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

Author: Haojian Wu Date: 2023-04-13T12:17:39+02:00 New Revision: 2524000187fc56a3f818a6562199037a90108eda URL: https://github.com/llvm/llvm-project/commit/2524000187fc56a3f818a6562199037a90108eda DIFF: https://github.com/llvm/llvm-project/commit/2524000187fc56a3f818a6562199037a90108eda.diff LO

[PATCH] D147686: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2524000187fc: [clangd] Fix a nullptr-dereference crash in computeIncludeCleanerFindings. (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam created this revision. kaadam added reviewers: kiranchandramohan, bryanpkc, mstorsjo. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added a project: All. kaadam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the implementation looks good. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in sem

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4264491 , @jmorse wrote: > ... > H, that feels like a legitimate IR input where the configuration of > debug-info / intrinsics is just unexpected -- we probably shouldn't assert in > that situation but gracefully

[clang] 2031d7d - [mlir][Tensor] Drop SplitPaddingPatterns.

Author: Nicolas Vasilache Date: 2023-04-13T03:38:29-07:00 New Revision: 2031d7d66dc8bf7ce2168edf6eef6ba568c16d4f URL: https://github.com/llvm/llvm-project/commit/2031d7d66dc8bf7ce2168edf6eef6ba568c16d4f DIFF: https://github.com/llvm/llvm-project/commit/2031d7d66dc8bf7ce2168edf6eef6ba568c16d4f.d

[PATCH] D148207: [mlir][Tensor] Drop SplitPaddingPatterns.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2031d7d66dc8: [mlir][Tensor] Drop SplitPaddingPatterns. (authored by nicolasvasilache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:85 // This is the underlying decl used by TemplateSpecializationType, can be // null when ty

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513165. usaxena95 added a comment. More refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tool

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513168. usaxena95 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clan

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

kadircet updated this revision to Diff 513173. kadircet marked 2 inline comments as done. kadircet added a comment. - Update comments & test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148158/new/ https://reviews.llvm.org/D148158 Files: clang-

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:163 ElementsAre(Decl::ClassTemplatePartialSpecialization)); + // Incomplete templates don't have a specific specialization associated. + EXPECT_THAT(testWalk(R

[clang-tools-extra] 3d6d2ae - [include-cleaner] Handle incomplete template specializations

Author: Kadir Cetinkaya Date: 2023-04-13T13:34:12+02:00 New Revision: 3d6d2ae6f490f0698e3d4727ae44db34b30ea33e URL: https://github.com/llvm/llvm-project/commit/3d6d2ae6f490f0698e3d4727ae44db34b30ea33e DIFF: https://github.com/llvm/llvm-project/commit/3d6d2ae6f490f0698e3d4727ae44db34b30ea33e.dif

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6d2ae6f490: [include-cleaner] Handle incomplete template specializations (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 650d69f - [clang][NFC] Fix comment typo

Author: Timm Bäder Date: 2023-04-13T13:42:58+02:00 New Revision: 650d69ffe4d0ff2d2c84b8bf19555a8a9b10aae8 URL: https://github.com/llvm/llvm-project/commit/650d69ffe4d0ff2d2c84b8bf19555a8a9b10aae8 DIFF: https://github.com/llvm/llvm-project/commit/650d69ffe4d0ff2d2c84b8bf19555a8a9b10aae8.diff LO

Re: [clang] c1f7636 - [C++20] [Modules] Continue parsing after we found reserved module names

On Thu, Apr 13, 2023 at 3:14 AM Chuanqi Xu via cfe-commits wrote: > > > Author: Chuanqi Xu > Date: 2023-04-13T15:14:34+08:00 > New Revision: c1f76363e0db41ab6eb9ebedd687ee098491e9b7 > > URL: > https://github.com/llvm/llvm-project/commit/c1f76363e0db41ab6eb9ebedd687ee098491e9b7 > DIFF: > https://

[clang] dfafb7f - [clang][NFC] More range for loops in TextDiagnostic.cpp

Author: Timm Bäder Date: 2023-04-13T13:43:57+02:00 New Revision: dfafb7fe5af3e55ff35fb5dbc685a4337af5b29c URL: https://github.com/llvm/llvm-project/commit/dfafb7fe5af3e55ff35fb5dbc685a4337af5b29c DIFF: https://github.com/llvm/llvm-project/commit/dfafb7fe5af3e55ff35fb5dbc685a4337af5b29c.diff LO

[clang] 66202d8 - Make 'static assertion failed' diagnostics point to the static assertion expression

Author: Jorge Pinto Sousa Date: 2023-04-13T08:15:13-04:00 New Revision: 66202d83b5d47479ae0f8117aebb523ba7eff82d URL: https://github.com/llvm/llvm-project/commit/66202d83b5d47479ae0f8117aebb523ba7eff82d DIFF: https://github.com/llvm/llvm-project/commit/66202d83b5d47479ae0f8117aebb523ba7eff82d.d

[PATCH] D147745: Make 'static assertion failed' diagnostics point to the static assertion expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66202d83b5d4: Make 'static assertion failed' diagnostics point to the static assertion… (authored by sousajo, committed by aaron.ballman). Herald ad

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8627 + )"; + Decl *ToTU = getToTuDecl("", Lang_CXX11); + Decl *FromTU = getTuDecl(Code, Lang_CXX11); bjope wrote: > With Werror w

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! It's not strictly needed (the move constructor causes the implicit assignment operator to be deleted: https://eel.is/c++draft/class.copy.assign#2.sentence-2), but I think i

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Generally

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 ___ cfe-commits mailing list cfe-comm

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/defaulted_equality_ignore_unnamed_bitfields.cpp:23 + +// If it compares the unnamed bitfields it will first compare the named bit-field +// and then branch based on the result of that comparison. --

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

asb added a comment. In D148034#4262991 , @MaskRay wrote: > In D148034#4260376 , @asb wrote: > >> Will `--[no-]relax-gp` make its way into a minor gcc point release or do we >> need to wait for the next major rel

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

erichkeane added a comment. We're C++17 compilation now, so we should be able to use `std::string_view` (and I think we're supposed to?). Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledN

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat added a comment. In D147935#4259687 , @craig.topper wrote: > Is there a different patch with the .td for these intrinsics? Yes, it's in this patch: D148223 Comment at: clang/include/clang/Su

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

kadircet added a comment. we've got one more reference to `getCanonicalPath` in `clang-tools-extra/clangd/IncludeCleaner.cpp:320`, i guess the best way is just calling `getLastRef` on the FileEntry* Comment at: clang-tools-extra/clangd/SourceCode.cpp:518

[clang] 25d6123 - [clang][Interp] Make sure we have a variable scope for initializers

Author: Timm Bäder Date: 2023-04-13T15:35:30+02:00 New Revision: 25d6123854d16370463ba884e750f303d09e9001 URL: https://github.com/llvm/llvm-project/commit/25d6123854d16370463ba884e750f303d09e9001 DIFF: https://github.com/llvm/llvm-project/commit/25d6123854d16370463ba884e750f303d09e9001.diff LO

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25d6123854d1: [clang][Interp] Make sure we have a variable scope for initializers (authored by tbaeder). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D148200: [clang-format] Correctly indent comment above PP Directive

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148200/new/ https://reviews.llvm.org/D148200 ___

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. In D147176#4263621 , @owenpan wrote: > @MyDeveloperDay We keep getting "spammed" by [libc++][format] patches. Can > you delete the rule in H987 : > > "field": "differential.revision.title",

[clang] f508d9b - [clang][Interp] Don't create global variables more than once

Author: Timm Bäder Date: 2023-04-13T15:41:43+02:00 New Revision: f508d9b1d4fa48e7586b9587a22be23c976297a7 URL: https://github.com/llvm/llvm-project/commit/f508d9b1d4fa48e7586b9587a22be23c976297a7 DIFF: https://github.com/llvm/llvm-project/commit/f508d9b1d4fa48e7586b9587a22be23c976297a7.diff LO

[PATCH] D147535: [clang][Interp] Don't create global variables more than once

This revision was automatically updated to reflect the committed changes. Closed by commit rGf508d9b1d4fa: [clang][Interp] Don't create global variables more than once (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147535/new/

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. we should be good now F27132578: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://reviews.llvm.org/D147176 ___

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513219. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-to

[clang] 4a6a4f8 - [clang][Interp] Add a failing test case

Author: Timm Bäder Date: 2023-04-13T15:55:57+02:00 New Revision: 4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733 URL: https://github.com/llvm/llvm-project/commit/4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733 DIFF: https://github.com/llvm/llvm-project/commit/4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733.diff LO

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:876 Style.AlwaysBreakBeforeMultilineStrings); +IO.mapOptional("AlwaysBreakBeforeFunctionParameters", + Style.AlwaysBreakBeforeFunctionParameters); -

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

bjope added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8627 + )"; + Decl *ToTU = getToTuDecl("", Lang_CXX11); + Decl *FromTU = getTuDecl(Code, Lang_CXX11); balazske wrote: > bjope wrote: > > With Werror we get: > > > > ``` > > ..

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat updated this revision to Diff 513223. 4vtomat added a comment. Resolved Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213

[clang-tools-extra] ed365f4 - [clangd] Use FileEntryRef for canonicalizing filepaths.

Author: Utkarsh Saxena Date: 2023-04-13T16:49:30+02:00 New Revision: ed365f464a0a29da08d0a1011603c4cd337c9428 URL: https://github.com/llvm/llvm-project/commit/ed365f464a0a29da08d0a1011603c4cd337c9428 DIFF: https://github.com/llvm/llvm-project/commit/ed365f464a0a29da08d0a1011603c4cd337c9428.diff

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed365f464a0a: [clangd] Use FileEntryRef for canonicalizing filepaths. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ htt

[clang] 0529da5 - [Coverage] Handle invalid end location of an expression/statement.

Author: Zequan Wu Date: 2023-04-13T10:53:02-04:00 New Revision: 0529da5b948cf168f65bec65b0559139f4f5a426 URL: https://github.com/llvm/llvm-project/commit/0529da5b948cf168f65bec65b0559139f4f5a426 DIFF: https://github.com/llvm/llvm-project/commit/0529da5b948cf168f65bec65b0559139f4f5a426.diff LOG

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0529da5b948c: [Coverage] Handle invalid end location of an expression/statement. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D147073?vs=512971&id=513236#toc Repository:

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12855 +!Condition.get()->isValueDependent() && +Condition.get()->isIntegerConstantExpr(S.Context)), KnownValue(HasKnownValue &&

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; alexander-shaposhnikov wrote: > erich

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. IR that passes the verifier generally shouldn't crash llvm, so an alternative would be to make a verifier check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 _

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513252. zequanwu added a comment. Herald added a subscriber: MaskRay. - Move remove_dots to clang driver. - Revert changes to llc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C . +/// pengfei wrote: > We are using a special format to describute

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > alexander-shaposh

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

tahonermann added subscribers: cor3ntin, tahonermann. tahonermann added a comment. Adding Corentin for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 __

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > alexa

  1   2   >