[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 ___ cfe-commits mailing list cfe-com

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

kito-cheng added a comment. I would support have `-march=help`, but I know it's really not make scene to alias `-march=help` to `--print-supported-extensions` for other targets, what about redirect that in `Driver.cpp` for RISC-V only? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks updated this revision to Diff 509934. brooks added a comment. - Rebase - Add powerpc64le Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Co

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. Overall it looks like we are heading in a good direction. Here are some initial comments from my partial review. Comment at: clang/include/clang/Interpreter/Interpreter.h:109 + std::list &getPTUs(); + std::unique_ptr GenModule(); + -

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

dim accepted this revision. dim added a comment. LGTM again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. @agozillon Thanks for the updates, LGTM! Please wait for somebody to review the OpenMP changes before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. Just took a quick look. Comment at: clang/lib/Sema/SemaLookup.cpp:2082 +Module *DeclModule = SemaRef.getOwningModule(D); +if (DeclModule && !DeclModule->isModuleMapModule() && +!SemaRef.isModuleUnitOfCurrentTU(DeclModule) && --

[PATCH] D147307: [clang] Consider artificial always inline builtin as inline builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, tstellar, efriedma. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #61691 Repository: rG LLVM

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

nemanjai accepted this revision. nemanjai added a comment. My comments are minor nits that don't require another review, so LGTM. Comment at: clang/lib/Basic/Targets/OSTargets.h:245-250 switch (Triple.getArch()) { -default: +case llvm::Triple::ppc64le: case ll

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509958. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/c

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 3 inline comments as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the regul

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Please split this patch into three: 1. Code changes and testing for the driver and the FIR+OpenMP dialect generated. 2. Code changes and test for FIR+OpenMP to L

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 509982. jp4a50 added a comment. Replace DesignatedInitializerIndentWidth with BracedInitializerIndentWidth which applies to a broader range of initializers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/n

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. I've implemented BracedInitializerIndentWidth now with significantly extended test coverage (including checking that it is not applied *too* broadly). The actual implementation is just as simple as that for `DesignatedInitializerIndentWidth`. > For the yaml stuff, I for

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 created this revision. HerrCai0907 added a reviewer: LegalizeAdulthood. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: -return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', ty

[clang] cef69ce - [clang][Interp] Fix record initialization via CallExpr subclasses

Author: Timm Bäder Date: 2023-03-31T13:16:49+02:00 New Revision: cef69ce7791f2b6415ef3991347904381717a1ec URL: https://github.com/llvm/llvm-project/commit/cef69ce7791f2b6415ef3991347904381717a1ec DIFF: https://github.com/llvm/llvm-project/commit/cef69ce7791f2b6415ef3991347904381717a1ec.diff LO

[PATCH] D141772: [clang][Interp] Fix record initialization via CallExpr subclasses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef69ce7791f: [clang][Interp] Fix record initialization via CallExpr subclasses (authored by tbaeder). Changed prior to commit: https://reviews.ll

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak did you check generating the html from the rst? I can never re

[clang] aa32490 - [Assignment Tracking] Enable by default

Author: OCHyams Date: 2023-03-31T12:38:48+01:00 New Revision: aa32490bfe0b957c4f5583e14304f5e34b2b9bce URL: https://github.com/llvm/llvm-project/commit/aa32490bfe0b957c4f5583e14304f5e34b2b9bce DIFF: https://github.com/llvm/llvm-project/commit/aa32490bfe0b957c4f5583e14304f5e34b2b9bce.diff LOG:

[PATCH] D146987: [Assignment Tracking] Enable by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa32490bfe0b: [Assignment Tracking] Enable by default (authored by Orlando). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

PiotrZSL added a comment. Add test with scoped enums, to validate that it works correctly. In theory this change should suport them also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/ https://reviews.llvm.org/D147315 __

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

PiotrZSL added a comment. And update commit message to be more descriptive... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147315/new/ https://reviews.llvm.org/D147315 ___ cfe-commits mailing list cfe-c

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > The expected compile-time regression on ReleaseLTO-g is roughly 1.2% right, > in exchange for greater variable location coverage? The compile time tracker is currently reporting around 1.5% for an LTO build. However, it's disabled for LTO at the moment until that can

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:20 +#include "clang/Interpreter/PartialTranslationUnit.h" +#include "clang/Interpreter/Value.h" We can forward declare `Value`. Comment at: clang/in

[PATCH] D147318: [clang-format] Don't format typename template parameters as expression

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. bb4f6c4dca98a47054117708015bb2724256ee83

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 509998. v.g.vassilev added a comment. Herald added a subscriber: mgrang. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 Files: clang/include/clang/AST/DeclTemplate.h clang/lib/AST/DeclTempl

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith. Herald added a project: All. v.g.vassilev requested review of this revision. `isDeductionGuideName` looks up the underlying template and if the template name is qualified we miss that qualification resulting

[clang] 8d7ded3 - Fix a simple think-o; NFC

Author: Aaron Ballman Date: 2023-03-31T08:20:59-04:00 New Revision: 8d7ded37a693b9d6f9d4d887560a8e2f1ca05bd3 URL: https://github.com/llvm/llvm-project/commit/8d7ded37a693b9d6f9d4d887560a8e2f1ca05bd3 DIFF: https://github.com/llvm/llvm-project/commit/8d7ded37a693b9d6f9d4d887560a8e2f1ca05bd3.diff

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

rymiel added inline comments. Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: -return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', ty

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak MyDeveloperDay wrote: > did you check generating the html from the rst

[clang] d29f706 - [clang][Interp] Fix binary comma operators

Author: Timm Bäder Date: 2023-03-31T14:54:51+02:00 New Revision: d29f70670db8ca43a49b6df9112035dc4b646182 URL: https://github.com/llvm/llvm-project/commit/d29f70670db8ca43a49b6df9112035dc4b646182 DIFF: https://github.com/llvm/llvm-project/commit/d29f70670db8ca43a49b6df9112035dc4b646182.diff LO

[PATCH] D141784: [clang][Interp] Fix binary comma operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f70670db8: [clang][Interp] Fix binary comma operators (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D147321: [Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada created this revision. domada added reviewers: dpalermo, skatrak, TIFitis, RogerV-AMD, kiranchandramohan, agozillon, kiranktp, NimishMishra. domada added projects: Flang, OpenMP. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr,

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. Thanks for working on this! The `-ffile-reproducible` flag name refers to making `#file` directives reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader :) I don't know what others think, but it would be nice to not have to introduce any more flags

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the check! Please fix the missing space comment before landing. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCh

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. In D145264#4236173 , @kiranchandramohan wrote: > Please split this patch into three: > > 1. Code changes and testing for the driver and the FIR+OpenMP dialect > generated. > 2. Code changes and test for FIR+OpenMP to LLVM+Open

[clang] d472c55 - [clang][Interp] Fix double-printing InterpFrame::describe()

Author: Timm Bäder Date: 2023-03-31T15:25:30+02:00 New Revision: d472c55fa28a249e1845908b47a1be6f2e05a1cd URL: https://github.com/llvm/llvm-project/commit/d472c55fa28a249e1845908b47a1be6f2e05a1cd DIFF: https://github.com/llvm/llvm-project/commit/d472c55fa28a249e1845908b47a1be6f2e05a1cd.diff LO

[PATCH] D141831: [clang][Interp] Fix double-printing in InterpFrame::describe()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd472c55fa28a: [clang][Interp] Fix double-printing InterpFrame::describe() (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai accepted this revision. nemanjai added subscribers: maryammo, kamaub, stefanp. nemanjai added a comment. This revision is now accepted and ready to land. This looks fine to me. I'd like some of the devs that have added builtins with Sema checking in the past to have a look here as well.

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510014. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/inclu

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 9 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:119 + + std::unique_ptr GenModule(); + v.g.vassilev wrote: > We should not need this interface. `Interpreter::CompileDecl` needs it

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510017. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[clang] 8d2899a - [clang][Interp] Handle TypeTraitExprs

Author: Timm Bäder Date: 2023-03-31T15:54:44+02:00 New Revision: 8d2899acbcf1b8ce120bc219aeb30207d4422042 URL: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042 DIFF: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042.diff LO

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2899acbcf1: [clang][Interp] Handle TypeTraitExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added a comment. @carlosgalvezp Thank you, by any chance would you be able to look into other reviews ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 ___

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 510022. jp4a50 added a comment. Alphabetical ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Rel

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon created this revision. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. agozillon requested review of this re

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. The flag addition and FlagsAttr generation component of: https://reviews.llvm.org/D145264 the LLVM-IR generation will come in a subsequent phabricator patch once I have created some additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 943ef06 - [clang][Interp] Check This pointer without creating InterpFrame

Author: Timm Bäder Date: 2023-03-31T16:18:15+02:00 New Revision: 943ef06420105cad23e3caea24d6a274cdb0316f URL: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f DIFF: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f.diff LO

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG943ef0642010: [clang][Interp] Check This pointer without creating InterpFrame (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510027. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-to

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo abandoned this revision. VitaNuo added a comment. Erroneously created patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147325/new/ https://reviews.llvm.org/D147325 ___ cfe-commits mailing lis

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The deduplicated code is moved into initVars().

[PATCH] D147327: [clang-format] Add option for having one port on a line in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D147328: [clang-format] Handle enum in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Verilog has enum just like C. Repository: rG LLVM Github

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510032. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D147329: [clang-format] Handle Verilog struct literals

sstwcw created this revision. Herald added subscribers: cfe-commits, ctetreau. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously `isVerilogIdentifier` was mistaking the

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. Could I get a re-review on this one please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510036. VitaNuo added a comment. Remove extra formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510038. sstwcw added a comment. Generate doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Form

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510039. VitaNuo added a comment. Rename function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clan

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > > This needs the backend opti

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/XRefs.cpp:1348 + auto Loc = SM.getFileLoc(Ref.RefLocation); + for (const auto &H : Providers) { +auto MatchingIncludes = ConvertedMainFileIncludes.match(H);

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264 +- Improved :doc:`readability-static-accessed-through-instance + ` check to Please keep alphabetical order (by check name) in this section. Repository: rG LLVM G

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510042. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510041. tkuchta marked an inline comment as done. tkuchta added a comment. Hello, I applied the review comments for strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/df

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510047. tkuchta added a comment. Updates after the review of strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_abilist.txt

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl); I wonder if we should rename this to

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:100 +// used `StorageLocation` subclasses and make them use a `BumpPtrAllocat

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. there is a strange build error which seems unrelated to my change - please let me know if that's an issue, I will try to rebase to newest master then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 ___

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa084854266ca: [clang-tidy] Add readability-operators-representation check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144522?vs=508310&id=510055#toc Repository: rG LLVM

[clang-tools-extra] a084854 - [clang-tidy] Add readability-operators-representation check

Author: Piotr Zegar Date: 2023-03-31T16:07:16Z New Revision: a084854266ca60748982228a4c98d036bca5f762 URL: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762 DIFF: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762.diff LOG: [

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31308/new/ https://reviews.llvm.org/D31308 ___ cfe-commits mailing list cfe-commi

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107294/new/ https://reviews.llvm.org/D107294 _

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510056. krzysz00 edited the summary of this revision. krzysz00 added a comment. Per discussion on the s.buffer.load revision, don't make those changes, and so revert this patch back to what it used to be. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 510057. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files: clang/include

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4236522 , @hans wrote: > Thanks for working on this! > > The `-ffile-reproducible` flag name refers to making `#file` directives > reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader > :) I do

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

cjdb added a comment. Thanks so much for seeing this through; I'm unusually looking forward to rebuilding LLVM this weekend! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:82 + +.. option:: OverloadedOperators +

[clang] 758bca6 - [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

Author: Ben Langmuir Date: 2023-03-31T09:43:22-07:00 New Revision: 758bca6483853a743297b68bd88a5dba9d5247f2 URL: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2 DIFF: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2.diff

[PATCH] D147282: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG758bca648385: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added subscribers: debug-info, probinson. probinson added a comment. I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source and

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

ymandel accepted this revision. ymandel added a comment. Thank you! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl);

[PATCH] D146987: [Assignment Tracking] Enable by default

haowei added a comment. This patch (which enables assignment tracking) and D147312 breaks llvm runtime build for `runtimes-armv7-unknown-linux-gnueabihf` Error message: FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o /b/s/w/ir/cache/goma/clie

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon updated this revision to Diff 510080. agozillon added a comment. - Add FIR -> LLVM Dialect test here, more fitting than the other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147324/new/ https://reviews.llvm.org/D147324 Files: c

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added a comment. We're getting really close! Yes, that build error looks unrelated. Someone should fix it soon. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4237099 , @probinson wrote: > I think we cannot be 100% sure about source paths in a cross-compile > situation. Cross-compiling on platform A targeting platform B does not mean > your sources and debugger UI are on platf

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Fragmented this patch into https://reviews.llvm.org/D147344 (lowering) and https://reviews.llvm.org/D147324 (driver/tool changes and application of attribute). I will keep this patch open until the others are closed to give a big picture for easier reference. Reposi

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I think `debug_trampoline` both captures the semantics and makes it clear that this is related to debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 _

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

stefanp added a comment. Overall I think that this looks fine to me as well. I had a couple of minor comments and you may decide that you don't need to do either one so if that's the case just mention why in a comment and I will approve the patch. Comment at: clang/include/cl

[clang] 43825d1 - Revert "[Assignment Tracking] Enable by default"

Author: Haowei Wu Date: 2023-03-31T11:27:18-07:00 New Revision: 43825d19318695be48abe6f042369da00fbb808b URL: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b DIFF: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b.diff LOG

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

amyk added a comment. Overall looks OK to me, as well. I just had two questions that I wanted to ask. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpne

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

fangism added a comment. What's the current status of this changeset? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, efriedma, erichkeane, cor3ntin, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This implements support for allowing `{}` to consistently z

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510099. aaron.ballman added a comment. Oops, previous diff missed a change that was only locally staged. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147349/new/ https://reviews.llvm.org/D147349 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

maryammo added a comment. It looks good to me, just added a minor question as I was not able to verify that. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altive

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

royjacobson added a comment. There was some discussion of this last year in this review: https://reviews.llvm.org/D128750 It's such an edge case that I don't think we should lose sleep about it until/unless the committee finds time to clarify the issue. Repository: rG LLVM Github Monorepo

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak jp4a50 wrote: > MyDeveloperDay wrote: > > did you check ge

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:4185 + /// For Verilog, put each port on its own line in module instantiations. + ///

  1   2   >