[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. Hi @argentite, the test you added is failing on the PS4 linux builder because the test seems to require linking and the PS4 target requires an external linker which is not present on the system. Can the test be rewritten to not require linking? https://lab.llvm.org/build

[clang] e43247d - [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

Author: Dominik Adamski Date: 2023-03-29T02:23:37-05:00 New Revision: e43247dd329cabf7eb4dd4323b3422d3774e57a7 URL: https://github.com/llvm/llvm-project/commit/e43247dd329cabf7eb4dd4323b3422d3774e57a7 DIFF: https://github.com/llvm/llvm-project/commit/e43247dd329cabf7eb4dd4323b3422d3774e57a7.dif

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGe43247dd329c: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver (authored by domada). Changed prior to commit: https://reviews.llvm.org/D145579?vs=508977&id=509233#toc Repository: rG LLVM

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added a comment. Hi, @dyung ! It seems the dynamic library generation is failing from the lack of a linker. We need a test library to load at runtime in clang-repl. Do you have any idea how we can create one without a linker? Otherwise we can disable the test on PS4 as it is probably

[PATCH] D146717: [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:69 const MacroDefinition &MD) override; + using PPCallbacks::Elifdef; + using PPCallbacks::Elifndef; kadircet wrote: > why do we have these using decls? This is to

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4229693 , @argentite wrote: > Hi, @dyung ! It seems the dynamic library generation is failing from the lack > of a linker. We need a test library to load at runtime in clang-repl. Do you > have any idea how we can creat

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

BeMg updated this revision to Diff 509244. BeMg edited the summary of this revision. BeMg added a comment. Herald added a subscriber: jobnoorman. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143364/new/ https://reviews.llvm.org/D143364 Fil

[PATCH] D146717: [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146717/new/ https://reviews.llvm.org/D146717 _

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509249. Krishna-13-cyber added a comment. I have removed the redundant comments and have moved the `if' condition above with the ongoing conditional statement (to avoid printing obvious expressions). - Updated static_assert warning message - Added T

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added a comment. Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ c

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder updated this revision to Diff 509264. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 Files: clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h Index: clang/lib/A

[clang-tools-extra] 3ddfea0 - [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros.

Author: Haojian Wu Date: 2023-03-29T11:24:44+02:00 New Revision: 3ddfea07f8d033a7e78695baf282a54f0d6765e5 URL: https://github.com/llvm/llvm-project/commit/3ddfea07f8d033a7e78695baf282a54f0d6765e5 DIFF: https://github.com/llvm/llvm-project/commit/3ddfea07f8d033a7e78695baf282a54f0d6765e5.diff LO

[PATCH] D146717: [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ddfea07f8d0: [clangd] Handle the C++2b elifdef and elindef PP structure in… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:324-328 + LocalScope Scope(this); + if (!this->visitUnscopedCompoundStmt(Body)) return false; + + Scope.emitDestructors(); aaron.

[clang] 55916de - [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

Author: Michael Halkenhaeuser Date: 2023-03-29T11:31:17+02:00 New Revision: 55916de2d37742fe334c0726ccf9e584bdaed09f URL: https://github.com/llvm/llvm-project/commit/55916de2d37742fe334c0726ccf9e584bdaed09f DIFF: https://github.com/llvm/llvm-project/commit/55916de2d37742fe334c0726ccf9e584bdaed0

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

This revision was automatically updated to reflect the committed changes. Closed by commit rG55916de2d377: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading (authored by Michael Halkenhaeuser ). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 7911647 - Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"

Author: Daniel Grumberg Date: 2023-03-29T10:51:13+01:00 New Revision: 79116475124112051625b1a0665e35c861bb13fd URL: https://github.com/llvm/llvm-project/commit/79116475124112051625b1a0665e35c861bb13fd DIFF: https://github.com/llvm/llvm-project/commit/79116475124112051625b1a0665e35c861bb13fd.dif

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder updated this revision to Diff 509279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 Files: clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h Index: clang/lib/A

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder updated this revision to Diff 509281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 Files: clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h Index: clang/lib/A

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:338 +this->emitDestructors(); +this->Ctx->emitDestroy(*Idx, SourceInfo{}); + } aaron.ballman wrote: > Should we be setting `Idx =

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon updated this revision to Diff 509285. Fznamznon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use private shared_ptr in `DumpModuleInfoAction` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/n

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

simideveloper added a comment. hey, I was working on the same issue so can we collaborate on this issue? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + : Sty

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Make sure to include context in the patch you upload: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16732 +// Ignore BO_LOr operators at the toplevel. +if (Op->getOpcode() == BO_LOr) + return; tbaeder wrote: > You can just drop the comment and move this into the `if` statemen

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Format/Format.h:4299 InsertNewlineAtEOF == R.InsertNewlineAtEOF && IntegerLiteralSeparator

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3764-3767 if (!checkFunctionOrMethodParameterIndex(S, D, AL, 1, IdxExpr, Idx)) return; - + if (Idx.getASTIndex() >= getFunctionOrMethodNumParams(D)) +return; erichkeane wrote:

[PATCH] D147135: [include-cleaner] Visit the VarDecl in ASTWalker.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/clangd/issues/1554 Repository: rG LLVM Gi

[clang] 81358e9 - [clang][MinGW] Add asan DLL lib before other libs and objects

Author: Alvin Wong Date: 2023-03-29T19:04:35+08:00 New Revision: 81358e9193a9282372c145b63042b2852d3afa18 URL: https://github.com/llvm/llvm-project/commit/81358e9193a9282372c145b63042b2852d3afa18 DIFF: https://github.com/llvm/llvm-project/commit/81358e9193a9282372c145b63042b2852d3afa18.diff LO

[PATCH] D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang

dang created this revision. dang added reviewers: zixuw, ributzka. Herald added a subscriber: arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure that the current symbol is added to the parent

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

This revision was automatically updated to reflect the committed changes. Closed by commit rG81358e9193a9: [clang][MinGW] Add asan DLL lib before other libs and objects (authored by alvinhochun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146908/n

[PATCH] D147139: [clangd] Map references from include'd files to directives

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: r

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 509298. royjacobson added a comment. Add some ((packed)) tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.rst clang/lib/AS

[clang] d3291c6 - [RISCV][MC] Add support for the experimental zicond extension

Author: Alex Bradbury Date: 2023-03-29T12:17:50+01:00 New Revision: d3291c692c0a83b8b60e13ad1326e2b7d61e5f34 URL: https://github.com/llvm/llvm-project/commit/d3291c692c0a83b8b60e13ad1326e2b7d61e5f34 DIFF: https://github.com/llvm/llvm-project/commit/d3291c692c0a83b8b60e13ad1326e2b7d61e5f34.diff

[PATCH] D146946: [RISCV][MC] Add support for experimental zicond extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3291c692c0a: [RISCV][MC] Add support for the experimental zicond extension (authored by asb). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + : Style.Designate

[PATCH] D147121: [hwasan] remove requirment for PIE

Enna1 created this revision. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, cryptoad. Herald added a project: All. Enna1 updated this revision to Diff 509252. Enna1 added a comment. Enna1 edited the summary of this revision. Enna1 added reviewers: eugenis, alekseyshl, pcc, vitalyb

[clang] 6ce272b - [Doc][Clang] Update Clang 16 from 'unreleased' to 'full'

Author: Roy Jacobson Date: 2023-03-29T14:20:27+03:00 New Revision: 6ce272b3f4ceb54e31cac660371a1a9af94b70d7 URL: https://github.com/llvm/llvm-project/commit/6ce272b3f4ceb54e31cac660371a1a9af94b70d7 DIFF: https://github.com/llvm/llvm-project/commit/6ce272b3f4ceb54e31cac660371a1a9af94b70d7.diff

[clang] da71cba - [Doc][Clang] Update information about default standard version

Author: Roy Jacobson Date: 2023-03-29T14:25:27+03:00 New Revision: da71cbacfc3f2b7519356ca105b4c1cde0026106 URL: https://github.com/llvm/llvm-project/commit/da71cbacfc3f2b7519356ca105b4c1cde0026106 DIFF: https://github.com/llvm/llvm-project/commit/da71cbacfc3f2b7519356ca105b4c1cde0026106.diff

[PATCH] D147141: [clang][documentation][enhancement]Documented Optimization Flags

ipriyanshi1708 created this revision. Herald added a project: All. ipriyanshi1708 added reviewers: samtebbs, aaron.ballman. ipriyanshi1708 published this revision for review. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53681 . Optimization flags are not docume

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 509303. SBallantyne added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ https://reviews.llvm.org/D146814 Files: clang/include/clang/Driver/Options.td clang/lib/Drive

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509305. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cla

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 509306. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/__clang

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509307. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[clang] 41c92c0 - [Assignment Tracking] Give -fexperimental-assignment-tracking flag 3 options

Author: OCHyams Date: 2023-03-29T12:47:54+01:00 New Revision: 41c92c0dc679022bf270c460629e998380183a2c URL: https://github.com/llvm/llvm-project/commit/41c92c0dc679022bf270c460629e998380183a2c DIFF: https://github.com/llvm/llvm-project/commit/41c92c0dc679022bf270c460629e998380183a2c.diff LOG:

[PATCH] D146615: [Assignment Tracking] Give -fexperimental-assignment-tracking flag 3 options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41c92c0dc679: [Assignment Tracking] Give -fexperimental-assignment-tracking flag 3 options (authored by Orlando). Herald added a project: clang. Her

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509311. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[clang] ab49747 - [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

Author: Kiran Chandramohan Date: 2023-03-29T12:01:54Z New Revision: ab49747f9d67d82a1cf0f19196ff29f01d4384f5 URL: https://github.com/llvm/llvm-project/commit/ab49747f9d67d82a1cf0f19196ff29f01d4384f5 DIFF: https://github.com/llvm/llvm-project/commit/ab49747f9d67d82a1cf0f19196ff29f01d4384f5.diff

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab49747f9d67: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang (authored by kiranchandramohan, committed by SBallantyne). Reposit

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 509317. jrmolin added a comment. ran the formatter, ran the documentation generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: clang/docs/ClangFormatSt

[PATCH] D147144: [include-cleaner] Report references to operator calls as implicit

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Missing these references can result in false negatives in the used-ness ana

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. I think I have hit all the requests now. We're in the middle of building release candidates and testing, so management is taking longer and longer to get back to me about a style guide for my team. We added it, because it forces a consistent look across all function de

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b7424d0666: [Flang] Add debug flag to enable current debug information pass (authored by SBallantyne). Repository: rG LLVM Github Monorepo CHAN

[clang] e2b7424 - [Flang] Add debug flag to enable current debug information pass

Author: Sacha Ballantyne Date: 2023-03-29T12:21:26Z New Revision: e2b7424d06663f92b958c0b4649ed08b55216a49 URL: https://github.com/llvm/llvm-project/commit/e2b7424d06663f92b958c0b4649ed08b55216a49 DIFF: https://github.com/llvm/llvm-project/commit/e2b7424d06663f92b958c0b4649ed08b55216a49.diff L

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks much better to me, thank you! LGTM with one small nit for safety. Comment at: clang/include/clang/Frontend/FrontendActions.h:191 + DumpModuleInfoAct

[clang] 78b0689 - [Assignment Tracking] Follow up for D147129 - fix broken clang tests

Author: OCHyams Date: 2023-03-29T13:54:10+01:00 New Revision: 78b0689ff289f3ab52d5a90fc782d556c05f21ed URL: https://github.com/llvm/llvm-project/commit/78b0689ff289f3ab52d5a90fc782d556c05f21ed DIFF: https://github.com/llvm/llvm-project/commit/78b0689ff289f3ab52d5a90fc782d556c05f21ed.diff LOG:

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL added a comment. Ok, lets do that, I will change this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

erichkeane added a comment. In D146678#4229052 , @yeswalrus wrote: > In D146678#4220408 , @erichkeane > wrote: > >> In D146678#4220360 , @yeswalrus >> wrote: >> >>> -I c

[clang] 4444eeb - Improve requirement clause limitation on non templated function

Author: Erich Keane Date: 2023-03-29T06:27:25-07:00 New Revision: eeb753e5b7918141b830213cd3eae0c1fd75 URL: https://github.com/llvm/llvm-project/commit/eeb753e5b7918141b830213cd3eae0c1fd75 DIFF: https://github.com/llvm/llvm-project/commit/eeb753e5b7918141b830213cd3eae0c1fd75.diff L

[PATCH] D147070: Improve requirement clause limitation on non templated function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb753e5: Improve requirement clause limitation on non templated function (authored by erichkeane). Herald added a project: clang. Changed prior

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk updated this revision to Diff 509335. hvdijk added a comment. Apparently the test was already passing without my change, so I updated the test to make it a function that did not previously get the nounwind attribute. This also revealed that the test was more fragile than I realised: it de

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509342. qiongsiwu1 added a comment. Rebase and address feedback other than test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseN

[clang] 76e50f3 - Fix missing newline in ReleaseNotes which caused sphinx problems

Author: Erich Keane Date: 2023-03-29T06:37:01-07:00 New Revision: 76e50f38ba891e647b6da1ed64cf0879df6693ea URL: https://github.com/llvm/llvm-project/commit/76e50f38ba891e647b6da1ed64cf0879df6693ea DIFF: https://github.com/llvm/llvm-project/commit/76e50f38ba891e647b6da1ed64cf0879df6693ea.diff L

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk updated this revision to Diff 509355. hvdijk added a comment. Forgot to update the call to `foo()` to call `bar()` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147097/new/ https://reviews.llvm.org/D147097 Files: clang/lib/CodeGe

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but perhaps we should add an expected-failing test case for the `_BitInt` situation just so we don't forget about it. Comment at: clang/lib/AST/Interp/Pri

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:324-328 + LocalScope Scope(this); + if (!this->visitUnscopedCompoundStmt(Body)) return false;

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder updated this revision to Diff 509359. tbaeder set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146408/new/ https://reviews.llvm.org/D146408 Files: clang/lib/AST/Interp/ByteCodeE

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:108 +switch (Expr) { \ + TYPE_SWITCH_CASE(PT_Sint8, B) \ + TYPE_SWITCH_CASE(PT_Uint8, B

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509360. qiongsiwu1 added a comment. Moving the `-shared` check to the AIX linker and modifying the tests so we test pure linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.ll

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jeanPerier added a comment. @agozillon, in the test added here (omp-frontend-forwarding.f90), I am seeing failures in some patches windows pre-merge checks that I think are not related to the patches. Could you check if there is a stability/reproducibility issue with the omp-frontend-forwarding

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jhuber6 added a comment. In D145815#4230780 , @jeanPerier wrote: > @agozillon, in the test added here (omp-frontend-forwarding.f90), I am seeing > failures in some patches windows pre-merge checks that I think are not > related to the patches. > Could

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. In D145815#4230780 , @jeanPerier wrote: > @agozillon, in the test added here (omp-frontend-forwarding.f90), I am seeing > failures in some patches windows pre-merge checks that I think are not > related to the patches. > Coul

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder marked an inline comment as done. tbaeder added a comment. Thanks, I'll verify the patch once again with an msan build before I push, just to be sure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 ___

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509367. qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. Fix the LTO data sections check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 F

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:108 +switch (Expr) { \ + TYPE_SWITCH_CASE(PT_Sint8, B) \ + TYPE_SWITCH_CASE(PT_Ui

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:108 +switch (Expr) { \ + TYPE_SWITCH_CASE(PT_Sint8, B) \ + TYPE_SWITCH_CASE(PT_Uint8, B

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:108 +switch (Expr) { \ + TYPE_SWITCH_CASE(PT_Sint8, B) \ + TYPE_SWITCH_CASE(PT_Ui

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509372. Fznamznon added a comment. Add a little bit of safety. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

dang added a comment. You will need to rebase this as I made some changes recently to how `ExtractAPIVisitor` is structured. We can either set up a time to talk about it and do it together or I can handle doing this work once we are happy with this. Comment at: clang/lib/Extr

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" hubert.reinterpretcast wrote: > This

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. In D133102#3774151 , @alexfh wrote: > For example, LLVM coding standards recommends using early exits: > https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-si

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:176 + +// id is an qualified id type +if (!T->getAs()->isObjCQualifiedIdType()) { Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:176 + +

[clang] 1cfe1e7 - [clang][ExtractAPI] Add queried symbol to parent contexts in libclang

Author: Daniel Grumberg Date: 2023-03-29T16:32:26+01:00 New Revision: 1cfe1e732ad8e8148f6fa8fc0f0c86f4b965d567 URL: https://github.com/llvm/llvm-project/commit/1cfe1e732ad8e8148f6fa8fc0f0c86f4b965d567 DIFF: https://github.com/llvm/llvm-project/commit/1cfe1e732ad8e8148f6fa8fc0f0c86f4b965d567.dif

[PATCH] D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cfe1e732ad8: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang (authored by dang). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. In D128697#3638467 , @Sockke wrote: > In D128697#3619310 , > @LegalizeAdulthood wrote: > >> This whole check seems weird to me. I mean, alm

[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

pengfei created this revision. pengfei added reviewers: tentzen, efriedma, victork1996. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This change al

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jeanPerier added a comment. > Hi @jeanPerier, > > Thank you! I noticed this today as well and I'm currently looking into it, i > have a fix upcoming, just forcing another patch > (https://reviews.llvm.org/D144896) to test it via buildbot as I have no easy > access to a windows machine to test

[PATCH] D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses

LegalizeAdulthood added inline comments. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/redundant-void-arg.cpp:596 + +// Explicitly specifying `(void)` is a way to sidestep -Wvexing-parse,

[clang] 98ea471 - Properly Propagate RecoveryExpr through RequiresExpr

Author: Erich Keane Date: 2023-03-29T09:04:59-07:00 New Revision: 98ea4712828b0802c99b3e8a6808cdc908f5b5b9 URL: https://github.com/llvm/llvm-project/commit/98ea4712828b0802c99b3e8a6808cdc908f5b5b9 DIFF: https://github.com/llvm/llvm-project/commit/98ea4712828b0802c99b3e8a6808cdc908f5b5b9.diff L

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

tahonermann added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183 -clang::DumpModuleInfoAction dump_module_info; -dump_module_info.OutputStream = &result.GetOutputStream().AsRawOstream(); +std::shared_ptr Out( +&result.Get

[clang-tools-extra] 498c885 - [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation

Author: Piotr Zegar Date: 2023-03-29T16:08:54Z New Revision: 498c88563b7f6379d9e6ae4d89d182756fa1c0bc URL: https://github.com/llvm/llvm-project/commit/498c88563b7f6379d9e6ae4d89d182756fa1c0bc DIFF: https://github.com/llvm/llvm-project/commit/498c88563b7f6379d9e6ae4d89d182756fa1c0bc.diff LOG: [

[PATCH] D146887: [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG498c88563b7f: [clang-tidy] Fix if-constexpr false-positive in readability-misleading… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Changes look good to me. Thanks, Sindhu! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. "Walter Gray" Thank you, and sorry about the back and forth. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/ https://reviews.llvm.org/D146678 ___ cfe-commits mailing

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 509395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[clang] 6f2a865 - [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

Author: Sindhu Chittireddy Date: 2023-03-29T09:29:14-07:00 New Revision: 6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 URL: https://github.com/llvm/llvm-project/commit/6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 DIFF: https://github.com/llvm/llvm-project/commit/6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18.

[clang] bbc204b - [PS4][clang] Limit ThinLTO parallelism when requested

Author: Matthew Voss Date: 2023-03-29T09:36:46-07:00 New Revision: bbc204b944eea829a029268fff37faabdf61fcaf URL: https://github.com/llvm/llvm-project/commit/bbc204b944eea829a029268fff37faabdf61fcaf DIFF: https://github.com/llvm/llvm-project/commit/bbc204b944eea829a029268fff37faabdf61fcaf.diff

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added a comment. Thank you, @aaron.ballman and @tahonermann for your comments! This was committed to https://github.com/llvm/llvm-project.git with hash 6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 CHANGES SINCE LAST AC

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f48a1fce235: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain (authored by yeswalrus, committed by erichkeane). Changed prior

[clang] 1f48a1f - Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain

Author: Walter Gray Date: 2023-03-29T09:44:01-07:00 New Revision: 1f48a1fce23551cc24f5b598af5994f5cfc6b6d0 URL: https://github.com/llvm/llvm-project/commit/1f48a1fce23551cc24f5b598af5994f5cfc6b6d0 DIFF: https://github.com/llvm/llvm-project/commit/1f48a1fce23551cc24f5b598af5994f5cfc6b6d0.diff L

  1   2   >