hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/CollectMacros.h:69
const MacroDefinition &MD) override;
+ using PPCallbacks::Elifdef;
+ using PPCallbacks::Elifndef;
----------------
kadircet wrote:
> why do we have these using decls?
This is to suppress the -Woverloaded-virtual diagnostic from gcc
(https://godbolt.org/z/9b76fYbjx) -- PPCallback has two overloads of
`Elifdefs`, here we only override one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146717/new/
https://reviews.llvm.org/D146717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
