[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added a comment. In D145579#4224157 , @tschuett wrote: > Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From > the conversation, there seems to be more target specific behaviours. @tschuett No. I don't plan to further ref

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd7628461b3f: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] bd76284 - [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

Author: Chris Cotter Date: 2023-03-28T07:05:12Z New Revision: bd7628461b3f7dc3d1071b12686dc53515634f4c URL: https://github.com/llvm/llvm-project/commit/bd7628461b3f7dc3d1071b12686dc53515634f4c DIFF: https://github.com/llvm/llvm-project/commit/bd7628461b3f7dc3d1071b12686dc53515634f4c.diff LOG:

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

tschuett added a comment. I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the flang/lib/Frontend directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme updated this revision to Diff 508907. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 Files: clang/include/clang/Analysis/FlowSensitive/Transfer.h clang

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

recallmenot added a comment. In D70401#4205333 , @pcwang-thead wrote: > In D70401#4204511 , @recallmenot > wrote: > >> Hi, I'm working on CH32V003 for rust and it uses RV32EC core. >> I tried replacing my distros

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not going to use it, but I like what you've done ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146844/new/ https://reviews.llvm.org/D146844 __

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead. Invert the logic and have the defaul

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4155 if (Right.is(tok::colon)) - return false; + return Style.SpaceBeforeJsonColon; } else if (Style.isCSharp()) {

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

pcwang-thead added a comment. In D70401#4226549 , @recallmenot wrote: > In D70401#4205333 , @pcwang-thead > wrote: > >> In D70401#4204511 , @recallmenot >> wrote: >> >>> Hi

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme updated this revision to Diff 508916. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:35 + /// The result is guaranteed never to be null. + virtual const Environment *getEnvironment(const Stmt &S) const { +auto BlockIt =

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 2 inline comments as done. Closed by commit rG0608541aa4b5: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface. (authored by mboehme). Repository:

[clang] 0608541 - [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

Author: Martin Braenne Date: 2023-03-28T08:05:57Z New Revision: 0608541aa4b5932c092251b846e7b87576e4f2d4 URL: https://github.com/llvm/llvm-project/commit/0608541aa4b5932c092251b846e7b87576e4f2d4 DIFF: https://github.com/llvm/llvm-project/commit/0608541aa4b5932c092251b846e7b87576e4f2d4.diff LOG

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1173 +if (Ref.RT != include_cleaner::RefType::Explicit || +UsedSymbolNames.find(getRefName(Ref)) != UsedSymbolNames.end()) + return; creating these symbol

[PATCH] D147032: [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This avoids the risk of ODR violations. Reposi

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 508925. xiongji90 added a comment. Add floating point environment section in UserManual.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146188/new/ https://reviews.llvm.org/D146188 Files: clang/docs/Lang

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

This revision was automatically updated to reflect the committed changes. Closed by commit rG488185cca387: [Clang][DebugInfo][AMDGPU] Emit zero size bitfields in the debug info to… (authored by jmmartinez). Changed prior to commit: https://reviews.llvm.org/D144870?vs=508538&id=508926#toc Repos

[clang] 488185c - [Clang][DebugInfo][AMDGPU] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-03-28T10:07:32+02:00 New Revision: 488185cca3871a0ef2ec3b9b4c642dc6db6eeea5 URL: https://github.com/llvm/llvm-project/commit/488185cca3871a0ef2ec3b9b4c642dc6db6eeea5 DIFF: https://github.com/llvm/llvm-project/commit/488185cca3871a0ef2ec3b9b4c642dc

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 added a comment. In D146188#4224902 , @rjmccall wrote: > In D146188#4223249 , @xiongji90 > wrote: > >> Hi, @rjmccall and @sepavloff >> In UserManual, we include a section `Controlling Floating Point Be

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez added a comment. In D144870#4225437 , @probinson wrote: > One entirely optional suggestion on the test. LGTM. Thanks! I used `SECONDDUP` and `FIRSTDUP`. And thanks a lot for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4155 if (Right.is(tok::colon)) - return false; + return Style.SpaceBeforeJsonColon; } else if (Style.isCSharp()) { MyDeveloperDay wrote: > owenpan wrote: > > Do we ne

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

kadircet updated this revision to Diff 508934. kadircet added a comment. Herald added a project: clang-tools-extra. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ https://reviews.llvm.org/D146634 Files: clang-tools-extra/cl

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

kadircet added a comment. i've added a reproducer for https://reviews.llvm.org/D146634, can you patch that into here? unfortunately i couldn't get it to crash in any place other than through clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + : Style.Designat

[PATCH] D146892: [documentation]Fixed Random Typo

samtebbs added a comment. Thank you Ayushi. Since you don't have commit access yet, I can commit it for you if you'd like. I do wonder if we should change the commit title to be something like "[documentation] Fix some typos". What do you think? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Now MainFileMacros preserves eno

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samtebbs added a comment. Thank you Samuel. Since you don't have commit access, I can commit this for you if you'd like. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146370/new/ https://reviews.llvm.org/D146370 ___ cfe-commits mailing list

[clang] 1b59809 - [C++20] [Modules] Don't create duplicated deduction guides for duplicated classes

Author: Chuanqi Xu Date: 2023-03-28T17:51:38+08:00 New Revision: 1b5980997bc03659a41329c3dff96ff274e13d85 URL: https://github.com/llvm/llvm-project/commit/1b5980997bc03659a41329c3dff96ff274e13d85 DIFF: https://github.com/llvm/llvm-project/commit/1b5980997bc03659a41329c3dff96ff274e13d85.diff LO

[clang] 1bc2d43 - [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace.

Author: Martin Braenne Date: 2023-03-28T10:03:39Z New Revision: 1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158 URL: https://github.com/llvm/llvm-project/commit/1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158 DIFF: https://github.com/llvm/llvm-project/commit/1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158.diff LOG

[PATCH] D147032: [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc2d43e5c8f: [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147032

[PATCH] D146892: [documentation] Fix some typos

ayushi-8102 added a comment. Yeah I think It would be better this way! I have changed the commit title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ https://reviews.llvm.org/D146892 ___ cfe-

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508948. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Herald added a subscriber: mgrang. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.l

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments, see the updated version. Comment at: clang-tools-extra/clangd/Hover.cpp:1173 +if (Ref.RT != include_cleaner::RefType::Explicit || +UsedSymbolNames.find(getRefName(Ref)) != UsedSymbolNames.end()) + re

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508949. SBallantyne marked an inline comment as done. SBallantyne added a comment. Add common function addDebugKindInfo, update warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ http

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

mstorsjo added a comment. I tested this, and this does fix the repro from the linked issue. I wonder if we do want to move all of these before the app itself, or if it's enough to just move the reference to `asan_dynamic-.dll.a` earlier, and keep the rest as it was? Especially the whole-archive

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

samuelmaina created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. samuelmaina requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 508955. jplehr added a comment. Herald added a subscriber: sunshaoce. Rebase to make ready for land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/lib

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. @aaron.ballman Any further comments on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! (please fix the name in CommonArgs.h before landing this) It would be great to see a test that checks for debug info in the generated FIR/MLIR/LLVM-I

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

ilya-biryukov added a comment. In D146971#4224540 , @erichkeane wrote: > Ah, hrmph. I guess I was just hoping for some assert (perhaps even in > `GetFullTypeForDeclarator`?) to assert in order to give future folks a hint > as to why their change crashe

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. Passes CI. How should I proceed w.r.t. libomptarget tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun added a comment. In D146908#4226926 , @mstorsjo wrote: > I tested this, and this does fix the repro from the linked issue. Thanks for testing! > I wonder if we do want to move all of these before the app itself, or if it's > enough to just

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

mstorsjo added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:1 -// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address 2>&1 | FileCheck --check-prefix=ASAN-I686 %s -// ASAN-I686: "{{.*}}libclang_rt.asan_dynamic-i386.dll.a" -// ASAN-I686: "{{[^"]*}

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:1 -// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address 2>&1 | FileCheck --check-prefix=ASAN-I686 %s -// ASAN-I686: "{{.*}}libclang_rt.asan_dynamic-i386.dll.a" -// ASAN-I686: "{{[^"

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

mstorsjo added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:1 -// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address 2>&1 | FileCheck --check-prefix=ASAN-I686 %s -// ASAN-I686: "{{.*}}libclang_rt.asan_dynamic-i386.dll.a" -// ASAN-I686: "{{[^"]*}

[clang] 83c90e6 - [clang] Fix consteval initializers of temporaries

Author: Mariya Podchishchaeva Date: 2023-03-28T07:41:53-04:00 New Revision: 83c90e623a308a6313783f320eeaabc7e3f9f4b2 URL: https://github.com/llvm/llvm-project/commit/83c90e623a308a6313783f320eeaabc7e3f9f4b2 DIFF: https://github.com/llvm/llvm-project/commit/83c90e623a308a6313783f320eeaabc7e3f9f4

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c90e623a30: [clang] Fix consteval initializers of temporaries (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D146801?vs=508524&id=508963#toc Repository: rG LLVM Github M

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225275 , @dblaikie wrote: > Presumably adding an alias for `#pragma clang system_header` called > `system_module` wouldn't be too hard? (though the pragma is also being > removed from libc++ soon, I think, in f

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4224862 , @rjmccall wrote: > In D146148#4224094 , @aaron.ballman > wrote: > >> In D146148#4222306 , @zahiraam >> wrote: >> >>> In D1

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

Szelethus added a comment. Please run this on open source projects and upload the results. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:164-166 +/// This function is called when the current constraint represents the +/// opposite of a co

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

aaron.ballman added a comment. In D146973#4225645 , @jhuber6 wrote: > In D146973#4225641 , @aaron.ballman > wrote: > >>> This lets offloading languages such as OpenMP use the system string.h when >>> compiling f

[PATCH] D146986: Downgrade reserved module identifier error into a warning

iains added a comment. +1 for this as an interim solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146986/new/ https://reviews.llvm.org/D146986 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508970. SBallantyne marked an inline comment as done. SBallantyne added a comment. Fix case issue. As for tests for debug information being generated, these are already covered by various tests in flang/tests/Transforms, namely debug-line-table.fir, debu

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite updated this revision to Diff 508971. argentite marked an inline comment as done. argentite added a comment. Changed test to use a separate Input file for the dynamic library generation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added inline comments. Comment at: clang/test/Interpreter/dynamic-library.cpp:1 +// RUN: head -n 7 %s | %clang -xc++ -o %T/libdynamic-library-test.so -fPIC -shared - +int ultimate_answer = 0; v.g.vassilev wrote: > sgraenitz wrote: > > The use of `head`

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146338/new/ https://reviews.llvm.org/D146338 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon updated this revision to Diff 508974. Fznamznon added a comment. Rebase, add release note, fix grammar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 508975. VitaNuo added a comment. Smaller improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[clang] e574833 - Downgrade reserved module identifier error into a warning

Author: Aaron Ballman Date: 2023-03-28T08:53:44-04:00 New Revision: e574833c2bc46a39150156eb973d0efb142bc618 URL: https://github.com/llvm/llvm-project/commit/e574833c2bc46a39150156eb973d0efb142bc618 DIFF: https://github.com/llvm/llvm-project/commit/e574833c2bc46a39150156eb973d0efb142bc618.diff

[PATCH] D146986: Downgrade reserved module identifier error into a warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGe574833c2bc4: Downgrade reserved module identifier error into a warning (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146986/new

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508977. domada added a comment. Patch rebased and added new test for checking incorrect wavefront sizes AMDGPU target features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targ

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked 2 inline comments as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:149 +err.print(errorMsg.data(), llvm::errs()); +unsigned diagID = ci.getDiagnostics().getCustomDiagID( +clang::DiagnosticsEngine::Error, "Unsu

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaType.cpp:5949 assert(!T.isNull() && "T must not be null at the end of this function"); - if (D.isInvalidType()) + if (!AreDecl

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added a comment. In D145579#4226542 , @tschuett wrote: > I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the > flang/lib/Frontend directory. @tschuett No, I don't plan to modify f

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Targ

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good from my side. Comment at: clang-tools-extra/clangd/Hover.cpp:1175 + +for (const include_cleaner::Header &H : Providers) { + if (!Converted

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski added a comment. Thanks for the explanation! Still looking good apart from the function names ;) Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111 +llvm::codegenoptions::DebugInfoKind +DebugLevelToInfoKind(const llvm::opt::Arg &A); + awarzynsk

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thanks for implementing this, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4227114 , @aaron.ballman wrote: > Hmmm, I've had experience with SYCL as to how it goes when you have > difference between host and device; those kinds of bugs are incredibly hard > to track down. Pointer sizes being

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 _

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a comment. This will also need someone from the LLVM side to look at the LLVM-specific changes. Most of my comments were focused on the behavior of test cases, but there may be more comments coming for the code changes once I've got a better handle on the test behavior. =

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne added a comment. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111 +llvm::codegenoptions::DebugInfoKind +DebugLevelToInfoKind(const llvm::opt::Arg &A); + awarzynski wrote: > awarzynski wrote: > > CamelCase or camelCase? ;-) > Sorry, I meant

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 508986. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/un

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

kadircet accepted this revision. kadircet added a comment. thanks the pieces i looked at LG too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 ___ cfe-commits

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716 +if (!Args.hasFlag(options::OPT_fdata_sections, + options::OPT_fno_data_sections, UseSeparateSections) && +Args.hasArg(options::OPT_fno_data_sections)

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508994. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-too

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1175 + +for (const include_cleaner::Header &H : Providers) { + if (!ConvertedIncludes.match(H).empty()) { hokein wrote: > VitaNuo wrote: > > kadircet wrote: > > > note

[clang-tools-extra] 655baae - [clangd] Show used symbols on #include line hover.

Author: Viktoriia Bakalova Date: 2023-03-28T14:05:34Z New Revision: 655baae2af0b805a1c3e6d6338a32de05e342357 URL: https://github.com/llvm/llvm-project/commit/655baae2af0b805a1c3e6d6338a32de05e342357 DIFF: https://github.com/llvm/llvm-project/commit/655baae2af0b805a1c3e6d6338a32de05e342357.diff

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG655baae2af0b: [clangd] Show used symbols on #include line hover. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D146244?

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

aaron.ballman added a comment. In D146973#4227266 , @jhuber6 wrote: > In D146973#4227114 , @aaron.ballman > wrote: > >> Hmmm, I've had experience with SYCL as to how it goes when you have >> difference between h

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 509004. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3. Th

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB marked an inline comment as not done. RitanyaB added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *Target

[clang-tools-extra] 2fccca8 - [clangd] Fix build by replacing unsigned long with std::vector::size_type.

Author: Viktoriia Bakalova Date: 2023-03-28T14:16:50Z New Revision: 2fccca8d743613fac4d68f7b14799a672394f64b URL: https://github.com/llvm/llvm-project/commit/2fccca8d743613fac4d68f7b14799a672394f64b DIFF: https://github.com/llvm/llvm-project/commit/2fccca8d743613fac4d68f7b14799a672394f64b.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ cfe-commits mailing list cfe-commit

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added a comment. In D146148#4227088 , @zahiraam wrote: > In D146148#4224862 , @rjmccall > wrote: > >> In D146148#4224094 , >> @aaron.ballman wrote: >> >>>

[PATCH] D146885: [clang-tidy][NFC] add debug log when clean empty namespace

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. This shouldn't be delivered. Do such tests, locally, instead of committing them. This change impact clang, and all tools, not only clang-tidy, therfor [clang-tidy] prefix is misle

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4227433 , @aaron.ballman wrote: > I am not asking you to implement a library based off another implementation's > specification. I am relaying implementation experience with the design you've > chosen for your implem

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Targ

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though the change should come with a release note. Suggestion you can take or leave as you see fit: should we turn the places where we removed the null pointer check into assertions that the pointer is nonnull? Or are we

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509010. VitaNuo added a comment. Use vscode command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-too

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

aaron.ballman added a comment. In D146412#4223272 , @Fznamznon wrote: > In D146412#4220021 , @kastiglione > wrote: > >> I understand the potential for a use after free, since `OutputStream` is a >> raw pointer,

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509013. AMS21 added a comment. Implemented suggested fixes from reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files: clang-tools-extra/clang-tidy/performanc

[PATCH] D146995: [clang-format][NFC] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

jp4a50 added a comment. If you guys are happy with this, could you please merge it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146995/new/ https://reviews.llvm.org/D146995 ___ cfe-commits maili

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 509014. iains added a comment. rebased, retested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ https://reviews.llvm.org/D126959 Files: clang/include/clang/Basic/Module.h clang/include/clang/Lex/

[clang] 256914b - [AIX] Update release notes regarding -mxcoff-build-id and the profile runtime

Author: Wael Yehia Date: 2023-03-28T14:53:12Z New Revision: 256914bf1c13a7f2dc1343b9761cae15b8b37e00 URL: https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00 DIFF: https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00.diff LOG: [A

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509015. VitaNuo added a comment. Remove redundant code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509017. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/un

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509019. VitaNuo added a comment. Remove unrelated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

  1   2   3   >