brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead.
Invert the logic and have the default being true. Disable the few spots where it looks like IAS is currently not used. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D147030 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/integrated-as.c Index: clang/test/Driver/integrated-as.c =================================================================== --- clang/test/Driver/integrated-as.c +++ clang/test/Driver/integrated-as.c @@ -12,5 +12,4 @@ // NOFIAS-NOT: cc1as // NOFIAS: -cc1 -// NOFIAS: "-fno-verbose-asm" // NOFIAS: -no-integrated-as Index: clang/lib/Driver/ToolChains/Gnu.cpp =================================================================== --- clang/lib/Driver/ToolChains/Gnu.cpp +++ clang/lib/Driver/ToolChains/Gnu.cpp @@ -2916,44 +2916,15 @@ bool Generic_GCC::IsIntegratedAssemblerDefault() const { switch (getTriple().getArch()) { - case llvm::Triple::aarch64: - case llvm::Triple::aarch64_be: - case llvm::Triple::amdgcn: - case llvm::Triple::arm: - case llvm::Triple::armeb: - case llvm::Triple::avr: - case llvm::Triple::bpfel: - case llvm::Triple::bpfeb: - case llvm::Triple::csky: - case llvm::Triple::hexagon: - case llvm::Triple::lanai: - case llvm::Triple::loongarch32: - case llvm::Triple::loongarch64: - case llvm::Triple::m68k: - case llvm::Triple::mips: - case llvm::Triple::mipsel: - case llvm::Triple::mips64: - case llvm::Triple::mips64el: - case llvm::Triple::msp430: - case llvm::Triple::ppc: - case llvm::Triple::ppcle: - case llvm::Triple::ppc64: - case llvm::Triple::ppc64le: - case llvm::Triple::r600: - case llvm::Triple::riscv32: - case llvm::Triple::riscv64: - case llvm::Triple::sparc: - case llvm::Triple::sparcel: - case llvm::Triple::sparcv9: - case llvm::Triple::systemz: - case llvm::Triple::thumb: - case llvm::Triple::thumbeb: - case llvm::Triple::ve: - case llvm::Triple::x86: - case llvm::Triple::x86_64: - return true; - default: + case llvm::Triple::nvptx: + case llvm::Triple::nvptx64: + case llvm::Triple::xcore: return false; + default: + if (getTriple().getVendor() == llvm::Triple::Myriad) + return false; + else + return true; } }
Index: clang/test/Driver/integrated-as.c =================================================================== --- clang/test/Driver/integrated-as.c +++ clang/test/Driver/integrated-as.c @@ -12,5 +12,4 @@ // NOFIAS-NOT: cc1as // NOFIAS: -cc1 -// NOFIAS: "-fno-verbose-asm" // NOFIAS: -no-integrated-as Index: clang/lib/Driver/ToolChains/Gnu.cpp =================================================================== --- clang/lib/Driver/ToolChains/Gnu.cpp +++ clang/lib/Driver/ToolChains/Gnu.cpp @@ -2916,44 +2916,15 @@ bool Generic_GCC::IsIntegratedAssemblerDefault() const { switch (getTriple().getArch()) { - case llvm::Triple::aarch64: - case llvm::Triple::aarch64_be: - case llvm::Triple::amdgcn: - case llvm::Triple::arm: - case llvm::Triple::armeb: - case llvm::Triple::avr: - case llvm::Triple::bpfel: - case llvm::Triple::bpfeb: - case llvm::Triple::csky: - case llvm::Triple::hexagon: - case llvm::Triple::lanai: - case llvm::Triple::loongarch32: - case llvm::Triple::loongarch64: - case llvm::Triple::m68k: - case llvm::Triple::mips: - case llvm::Triple::mipsel: - case llvm::Triple::mips64: - case llvm::Triple::mips64el: - case llvm::Triple::msp430: - case llvm::Triple::ppc: - case llvm::Triple::ppcle: - case llvm::Triple::ppc64: - case llvm::Triple::ppc64le: - case llvm::Triple::r600: - case llvm::Triple::riscv32: - case llvm::Triple::riscv64: - case llvm::Triple::sparc: - case llvm::Triple::sparcel: - case llvm::Triple::sparcv9: - case llvm::Triple::systemz: - case llvm::Triple::thumb: - case llvm::Triple::thumbeb: - case llvm::Triple::ve: - case llvm::Triple::x86: - case llvm::Triple::x86_64: - return true; - default: + case llvm::Triple::nvptx: + case llvm::Triple::nvptx64: + case llvm::Triple::xcore: return false; + default: + if (getTriple().getVendor() == llvm::Triple::Myriad) + return false; + else + return true; } }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits