[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using Eugene.Zelenko wrote: > Please keep alphabetical order (by check name) in this sec

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added a comment. This change is correct for Linux. `llvm/CMakeLists.txt` says: if(CMAKE_SYSTEM_NAME MATCHES "BSD|Linux|OS390") set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON) Some rpath using OSes (notably macOS) use LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default=OFF. Is the rpath

[clang] c5d22f4 - [clang][Sema][NFC] Make local variable const

Author: Timm Bäder Date: 2023-03-23T08:23:00+01:00 New Revision: c5d22f4e1866549f0d8c3aad598c0153c31679e7 URL: https://github.com/llvm/llvm-project/commit/c5d22f4e1866549f0d8c3aad598c0153c31679e7 DIFF: https://github.com/llvm/llvm-project/commit/c5d22f4e1866549f0d8c3aad598c0153c31679e7.diff LO

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/UseEarlyExitsCheck.cpp:359 +void UseEarlyExitsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(translationUnitDecl(), this); +} This will trigger on all syste

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme marked an inline comment as done. mboehme added a comment. In D146514#4213302 , @xazax.hun wrote: > In D146514#4212528 , @mboehme wrote: > >> No, I think this is a different case. > > Sorry, I might have b

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using carlosgalvezp wrote: > Eugene.Zelenko wrote: > > Please keep alphabetical order (by che

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Switching status of review, once you will be ready with changes (or your decision), just mark it ready for review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 5acd29e - [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

Author: Martin Braenne Date: 2023-03-23T08:02:43Z New Revision: 5acd29eb4d9e411b3631c26babcd1d2655623f4a URL: https://github.com/llvm/llvm-project/commit/5acd29eb4d9e411b3631c26babcd1d2655623f4a DIFF: https://github.com/llvm/llvm-project/commit/5acd29eb4d9e411b3631c26babcd1d2655623f4a.diff LOG

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5acd29eb4d9e: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using PiotrZSL wrote: > carlosgalvezp wrote: > > Eugene.Zelenko wrote: > > > Please keep

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. FYI this commit breaks `clang/test/Index/index-file.cu` for me: warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] /home/jhahnfel/LLVM/src/clang/test/Inde

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

tomasz-kaminski-sonarsource added a comment. As a downstream, we have concerns with this change. From what I saw it breaks the behavior of the fix-it that wants to remove the whole variable definition (including the initializer). For example, I have unused, that I want to remove variable x and

[clang-tools-extra] b08d35f - [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Author: Carlos Galvez Date: 2023-03-23T08:31:12Z New Revision: b08d35f826a6b7696a02f1d811da7a2f951e74a1 URL: https://github.com/llvm/llvm-project/commit/b08d35f826a6b7696a02f1d811da7a2f951e74a1 DIFF: https://github.com/llvm/llvm-project/commit/b08d35f826a6b7696a02f1d811da7a2f951e74a1.diff LOG:

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

This revision was automatically updated to reflect the committed changes. Closed by commit rGb08d35f826a6: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder updated this revision to Diff 507646. tbaeder added a comment. Completely forgot to add the tests to the patch, oops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146408/new/ https://reviews.llvm.org/D146408 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Int

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 507648. tbaeder added a comment. Add some more tests for virtual destructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Contex

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great! Please fix the code style of the unit-test (see my other comment) before landing it. Comment at: clang-tools-extra/clangd/Hover.cpp: + //

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Tar

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

mariusz-sikora-at-amd created this revision. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm. Herald added a project: All. mariusz-sikora-at-amd requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wd

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

kadircet added a comment. I am aware that this null checking at leaves are not considered a sustainable solution and I agree with the sentiment there. But we're seeing an increasing number of crashes in production on invalid code recently. Happy to take a different course if there are alternati

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

MyDeveloperDay added a comment. I know this is like "telling my grandmother to suck eggs" but @klimek the change here to Format.h means you need to regenerate ClangFormatStyleOptions.rst via docs/tools/dump_format_style.py Impacting the next change to generate - D125171: Add a new clang-format

[clang] 0691bcb - [clang][Interp][NFC] Add tests for __fp16

Author: Timm Bäder Date: 2023-03-23T10:08:34+01:00 New Revision: 0691bcb18024a28e82e8dd9a08ab0820b40c9a37 URL: https://github.com/llvm/llvm-project/commit/0691bcb18024a28e82e8dd9a08ab0820b40c9a37 DIFF: https://github.com/llvm/llvm-project/commit/0691bcb18024a28e82e8dd9a08ab0820b40c9a37.diff LO

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

This revision was automatically updated to reflect the committed changes. Closed by commit rG0691bcb18024: [clang][Interp][NFC] Add tests for __fp16 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llv

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3663 +.. _Macros: + jrmolin wrote: > I didn't modify this section in the header at all. I assume someone modified > the Format.h file and didn't update the docs. that need

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1158 + const SourceManager &SM = AST.getSourceManager(); + std::set UsedSymbolNames; + include_cleaner::walkUsed( VitaNuo wrote: > hokein wrote: > > just want to check the intention,

[clang-tools-extra] 8c10256 - clang-tidy: Detect use-after-move in CXXCtorInitializer

Author: MarcoFalke Date: 2023-03-23T10:19:54+01:00 New Revision: 8c10256734cd47274671fcabe94f24f15ecd6209 URL: https://github.com/llvm/llvm-project/commit/8c10256734cd47274671fcabe94f24f15ecd6209 DIFF: https://github.com/llvm/llvm-project/commit/8c10256734cd47274671fcabe94f24f15ecd6209.diff LO

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c10256734cd: clang-tidy: Detect use-after-move in CXXCtorInitializer (authored by MarcoFalke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ ht

[clang] 814177e - Revert "[clang][Interp][NFC] Add tests for __fp16"

Author: Timm Bäder Date: 2023-03-23T10:33:51+01:00 New Revision: 814177e434d8daf70a3d67345c166d40457f68f1 URL: https://github.com/llvm/llvm-project/commit/814177e434d8daf70a3d67345c166d40457f68f1 DIFF: https://github.com/llvm/llvm-project/commit/814177e434d8daf70a3d67345c166d40457f68f1.diff LO

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

tbaeder added a comment. Meh, is `__fp16` something I need to check support for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 ___ cfe-commits mailing list cf

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added a project: clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Herald added a project: clang. Regenerate the style docume

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay added a comment. This is a missed change as part of D144170: [clang-format] Add simple macro replacements in formatting. and as this is NFC and its blocking other reviews I'm going to go ahead and commit, but I'm passing this by your eyes and I'

[clang] 7a5b957 - [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

Author: mydeveloperday Date: 2023-03-23T09:48:24Z New Revision: 7a5b95732ade6c2de69b26f1038aa0a5afc39393 URL: https://github.com/llvm/llvm-project/commit/7a5b95732ade6c2de69b26f1038aa0a5afc39393 DIFF: https://github.com/llvm/llvm-project/commit/7a5b95732ade6c2de69b26f1038aa0a5afc39393.diff LOG

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a5b95732ade: [clang-format] NFC Format.h and ClangFormatStyleOpti

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. if you go ahead an rebase your should get rG7a5b95732ade: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date that will remove the need for the Macro section in the rst

[clang] 7c92820 - Revert "[clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date"

Author: mydeveloperday Date: 2023-03-23T09:52:59Z New Revision: 7c928205c1f5a972f1f4dbeae83bd979c9a617d7 URL: https://github.com/llvm/llvm-project/commit/7c928205c1f5a972f1f4dbeae83bd979c9a617d7 DIFF: https://github.com/llvm/llvm-project/commit/7c928205c1f5a972f1f4dbeae83bd979c9a617d7.diff LOG

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507666. MyDeveloperDay added a comment. Ok it seems a fix has already been landed but its not correct (missing version) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangForma

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507668. MyDeveloperDay added a comment. incorrect yaml code block CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangFormatStyleOptions.rst Index: clang/docs/ClangFormatStyle

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507670. MyDeveloperDay added a comment. I've got out of practice... correct the diff properly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

foad added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:233 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2bf16, "V2sV2s*1V2s", "t", "atomic-global-pk-add-bf16-inst") +TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16, "V2sV2s*3V2s", "t",

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. Please rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang-tools-extra] b767784 - [clang-tidy][NFC] Fix broken link in Release Notes

Author: Carlos Galvez Date: 2023-03-23T10:30:15Z New Revision: b7677846da66fd003a538f87fd8de948cfcc3d6a URL: https://github.com/llvm/llvm-project/commit/b7677846da66fd003a538f87fd8de948cfcc3d6a DIFF: https://github.com/llvm/llvm-project/commit/b7677846da66fd003a538f87fd8de948cfcc3d6a.diff LOG:

[clang] 48f97e5 - [FlowSensitive] Log analysis progress for debugging purposes

Author: Sam McCall Date: 2023-03-23T11:36:21+01:00 New Revision: 48f97e5751372b4a64144605c5e9f7e5e13e382a URL: https://github.com/llvm/llvm-project/commit/48f97e5751372b4a64144605c5e9f7e5e13e382a DIFF: https://github.com/llvm/llvm-project/commit/48f97e5751372b4a64144605c5e9f7e5e13e382a.diff LO

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rG48f97e575137: [FlowSensitive] Log analysis progress for debugging purposes (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D144730?vs=507418&id=507678#toc Repository: rG LL

[PATCH] D146279: [clangd] Extend CollectMainFileMacros.

hokein updated this revision to Diff 507679. hokein marked an inline comment as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146279/new/ https://reviews.llvm.org/D146279 Files: clang-tools-extra/cl

[PATCH] D146279: [clangd] Extend CollectMainFileMacros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:48 public: - explicit CollectMainFileMacros(const SourceManager &SM, MainFileMacros &Out) - : SM(SM), Out(Out) {} + explicit CollectMainFileMacros(const SourceManager &SM, +

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Thank you!! Sorry for forgetting that I needed to do this, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 ___

Re: [PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

I am so sorry, thanks for sending out the patch already and fixing the layout! On Thu, Mar 23, 2023 at 10:08 AM MyDeveloperDay via Phabricator < revi...@reviews.llvm.org> wrote: > MyDeveloperDay added a comment. > > I know this is like "telling my grandmother to suck eggs" but @klimek the > chan

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100 + // Check if main file is the public interface for a private header. If so + // we shouldn't

[clang-tools-extra] 002c4b7 - [clangd] Extend CollectMainFileMacros.

Author: Haojian Wu Date: 2023-03-23T11:59:11+01:00 New Revision: 002c4b7b955b1fc8825b4d6b46bb079390bce812 URL: https://github.com/llvm/llvm-project/commit/002c4b7b955b1fc8825b4d6b46bb079390bce812 DIFF: https://github.com/llvm/llvm-project/commit/002c4b7b955b1fc8825b4d6b46bb079390bce812.diff LO

[PATCH] D146279: [clangd] Extend CollectMainFileMacros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002c4b7b955b: [clangd] Extend CollectMainFileMacros. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend.

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:731-736 +} else if (E.get()->isTypeDependent()) { + PP.Diag(StartLoc, diag::warn_pragma_debug_type_dependent_argument) +<< SourceRange(StartLoc, Tok.getLocation()); +} else if (E.get()-

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM, but you should also check in the test that `id` still renders as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https:/

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

mariusz-sikora-at-amd added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:233 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2bf16, "V2sV2s*1V2s", "t", "atomic-global-pk-add-bf16-inst") +TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16, "V2

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4215650 , @Hahnfeld wrote: > FYI this commit breaks `clang/test/Index/index-file.cu` for me: > > warning: CUDA version 11.8 is only partially supported > [-Wunknown-cuda-version] > warning: CUDA version 11.8

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

hokein added a comment. Thanks, and sorry for late response. The patch looks good to me in general. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:590 {"foldingRangeProvider", true}, + {"inactiveRegionsProvider", true}, }; nit: add tra

[clang] 18d5688 - Revert "libclang: Pass Clang install directory to driver via argv[0]."

Author: Aaron Ballman Date: 2023-03-23T08:05:58-04:00 New Revision: 18d56880a89ad7d58f8543d148facebd079cef19 URL: https://github.com/llvm/llvm-project/commit/18d56880a89ad7d58f8543d148facebd079cef19 DIFF: https://github.com/llvm/llvm-project/commit/18d56880a89ad7d58f8543d148facebd079cef19.diff

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

mikhail.ramalho updated this revision to Diff 507700. mikhail.ramalho marked 6 inline comments as done. mikhail.ramalho added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4216197 , @aaron.ballman wrote: > In D146497#4215650 , @Hahnfeld > wrote: > >> FYI this commit breaks `clang/test/Index/index-file.cu` for me: >> >> warning: CUDA vers

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

kadircet marked 2 inline comments as done. kadircet added a comment. thanks a lot for the review! Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:100 + // Check if main file is the public interface for a private header. If so + // we shouldn't diagnose

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

kadircet updated this revision to Diff 507701. kadircet added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146406/new/ https://reviews.llvm.org/D146406 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-too

[PATCH] D146406: [IncludeCleaner][clangd] Mark umbrella headers as users of private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43fcfdb1d6a6: [IncludeCleaner][clangd] Mark umbrella headers as users of private (authored by kadircet). Repository: rG LLVM Github Monorepo CHAN

[clang] 43fcfdb - [IncludeCleaner][clangd] Mark umbrella headers as users of private

Author: Kadir Cetinkaya Date: 2023-03-23T13:08:07+01:00 New Revision: 43fcfdb1d6a63129ffbb7d77174ccb56863d0b30 URL: https://github.com/llvm/llvm-project/commit/43fcfdb1d6a63129ffbb7d77174ccb56863d0b30 DIFF: https://github.com/llvm/llvm-project/commit/43fcfdb1d6a63129ffbb7d77174ccb56863d0b30.dif

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

mikhail.ramalho added inline comments. Comment at: libc/src/setjmp/riscv64/longjmp.h:56 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(buf) : "r"(val), "r"(buf) :); sivachandra wrote: > Why is this require

[PATCH] D146712: [clang-tidy] Add portability-non-portable-integer-constant check

Discookie created this revision. Discookie added reviewers: aaron.ballman, njames93, carlosgalvezp. Discookie added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, ChuanqiXu, xazax.hun. Herald added a project: All. Discookie requested review of this revision. This check finds int

[PATCH] D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. According to the G

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added a comment. Thanks for the update Comment at: clang/test/Interpreter/dynamic-library.cpp:1 +// RUN: head -n 7 %s | %clang -xc++ -o %T/libdynamic-library-test.so -fPIC -shared - +int ultimate_answer = 0; The use of `head` and `tail` here is a cre

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. In D146497#4216226 , @aaron.ballman wrote: > The issue doesn't reproduce for me locally on my Windows machine, so it may > be something specific to the VE setup. FWIW I'm not doing anything specific for VE, just set(CMAKE_C

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

aaron.ballman added a comment. In D146634#4215754 , @kadircet wrote: > I am aware that this null checking at leaves are not considered a sustainable > solution and I agree with the sentiment there. But we're seeing an increasing > number of crashes in p

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav added a comment. Will update the test to also include a Id instance method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https://reviews.llvm.org/D146671 ___ cfe-commits mailing l

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

v.g.vassilev added a comment. Thanks for working on this, looks like we are heading in a good direction! Comment at: clang/test/Interpreter/dynamic-library.cpp:1 +// RUN: head -n 7 %s | %clang -xc++ -o %T/libdynamic-library-test.so -fPIC -shared - +int ultimate_answer = 0; ---

[clang] c39dd7c - [RISCV][MC] Add support for RV64E

Author: Job Noorman Date: 2023-03-23T12:32:25Z New Revision: c39dd7c1db97fa367cb6282067b74cd8e55ef09a URL: https://github.com/llvm/llvm-project/commit/c39dd7c1db97fa367cb6282067b74cd8e55ef09a DIFF: https://github.com/llvm/llvm-project/commit/c39dd7c1db97fa367cb6282067b74cd8e55ef09a.diff LOG: [

[PATCH] D143570: [RISCV][MC] Add support for RV64E

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39dd7c1db97: [RISCV][MC] Add support for RV64E (authored by jobnoorman, committed by asb). Herald added a project: clang. Herald added a subscriber:

[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM. Fo

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4216278 , @Hahnfeld wrote: > In D146497#4216226 , @aaron.ballman > wrote: > >> The issue doesn't reproduce for me locally on my Windows machine, so it may >> be somethin

[clang] c6e9823 - [C++20][Modules] Introduce an implementation module.

Author: Iain Sandoe Date: 2023-03-23T12:47:44Z New Revision: c6e9823724ef6bdfee262289ee34d162db436af0 URL: https://github.com/llvm/llvm-project/commit/c6e9823724ef6bdfee262289ee34d162db436af0 DIFF: https://github.com/llvm/llvm-project/commit/c6e9823724ef6bdfee262289ee34d162db436af0.diff LOG: [

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. iains marked an inline comment as done. Closed by commit rGc6e9823724ef: [C++20][Modules] Introduce an implementation module. (authored by iains). Repository: rG LLV

[clang] e54cdd0 - [RISCV][clang][test] Fix missed test

Author: Job Noorman Date: 2023-03-23T12:49:06Z New Revision: e54cdd058e223bd62840e901b8b462c011d2fae5 URL: https://github.com/llvm/llvm-project/commit/e54cdd058e223bd62840e901b8b462c011d2fae5 DIFF: https://github.com/llvm/llvm-project/commit/e54cdd058e223bd62840e901b8b462c011d2fae5.diff LOG: [

[PATCH] D143570: [RISCV][MC] Add support for RV64E

asb added a comment. Apologies, the commited version of this patch missed the clang/test/Driver/riscv-arch.c change. rGe54cdd058e223bd62840e901b8b462c011d2fae5 committed to fix this. Repository: rG LLVM Github Monorepo

[PATCH] D146717: [clangd] Handle the C++2b elifdef and elindef PP structure in CollectMainFileMacros.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

aaron.ballman added a comment. The precommit CI failures are unrelated to your changes (the Debian one is related to flang failures and the libcxx one seems to be related to infrastructure), so no need to worry about them. Comment at: clang/test/Sema/complex-init-list.c:37 s

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4214972 , @alexander-shaposhnikov wrote: > Add more tests. > P.S. we already have tests with self-friends (in concepts.cpp), the test from > Richard's comment is also included (struct S12) (in a slightly simplified

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Targ

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2889 -defm BUFFER_ATOMIC_ADD_F32: MUBUF_Real_Atomic_vi <0x4d>; +let SubtargetPredicate = HasAtomicBufferGlobalPkAddF16NoRtnInsts in { defm BUFFER_ATOMIC_PK_ADD_F16 : MUBUF_Real_Atomic_vi <0x4

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

erichkeane added a comment. In D139705#4215653 , @tomasz-kaminski-sonarsource wrote: > As a downstream, we have concerns with this change. From what I saw it breaks > the behavior of the fix-it that wants to remove the whole variable definition > (incl

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall marked 15 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/CMakeLists.txt:22 +add_custom_command(OUTPUT HTMLLogger.inc + COMMAND "${Python3_EXECUTABLE}" bundle_resources.py + ${CMAKE_CURRENT_BINARY_DIR}/HTMLLogger

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 507718. sammccall marked 2 inline comments as done. sammccall added a comment. Address all comments except moving data from HTML => JSON Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://revie

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall planned changes to this revision. sammccall added a comment. Going to have a go at passing data via JSON Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 _

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/UseEarlyExitsCheck.cpp:359 +void UseEarlyExitsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(translationUnitDecl(), this); +} PiotrZSL wrote: > This will tr

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

tomasz-kaminski-sonarsource added a comment. In D139705#4216417 , @erichkeane wrote: > In D139705#4215653 , > @tomasz-kaminski-sonarsource wrote: > >> As a downstream, we have concerns with this change. From wha

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using the name of a template variable or concept in places where an expression was expected, Clang would drop the cxx

[PATCH] D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions

mariusz-sikora-at-amd updated this revision to Diff 507722. mariusz-sikora-at-amd added a comment. Changes after review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146701/new/ https://reviews.llvm.org/D146701 Files: clang/include/clang/Basic/

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Compiler explorer link demonstrating the issue this fixes https://godbolt.org/z/Tj3v5jbnq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

erichkeane added a comment. This generally looks good to me, but I get lost in the parser pretty quick, so hoping one of the other reviewers can take a look. Comment at: clang/test/Parser/cxx-template-template-recovery.cpp:27 + +static_assert(test); //expected-error {{too few

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav updated this revision to Diff 507725. chaitanyav added a comment. update test to check for id type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https://reviews.llvm.org/D146671 Files: clang/lib/ExtractAPI/DeclarationFragm

[clang] 8c7c1f1 - Silence unused variable warning in NDEBUG builds

Author: Benjamin Kramer Date: 2023-03-23T14:41:03+01:00 New Revision: 8c7c1f11ffaacf762e612c65440fd2cbb58ee426 URL: https://github.com/llvm/llvm-project/commit/8c7c1f11ffaacf762e612c65440fd2cbb58ee426 DIFF: https://github.com/llvm/llvm-project/commit/8c7c1f11ffaacf762e612c65440fd2cbb58ee426.dif

  1   2   3   >