[PATCH] D146595: [clang] Add clang trampoline attribute

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This revision now requires changes to proceed. I can see some minor utility to this for some kinds of libraries perhaps, but I'm on the fence about adding the attribute. Is

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp updated this revision to Diff 507428. wolfgangp added a comment. Instead of suppressing the error message we drop the dllimport/dllexport attribute when we see that a class has UniqueExternal linkage. This will suppress exporting or importing any members, which could not be accessed o

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. In D144651#4210787 , @fdeazeve wrote: > According to git-bisect, this patch is causing the LLDB bots to crash. > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console > > (They were failing for other reasons b

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. I think just checking that the toplevel binary operator is a logical or should be enough? Since that only fails if both operands evaluate to false, so we don't need to print the "false or false" diagnostic. Comment at: clang/test/SemaCXX/static-assert

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 507430. TIFitis added a comment. Updated tests. All tests pass now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp l

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4207915 , @efriedma wrote: > I'm concerned about the potential for false positives: > > - If a user doesn't mark a function noreturn, but it doesn't actually ever > return. Ok, but a user //can// fix that in t

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/D146155 ___ cfe-commits mailing list cfe-comm

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 507432. alexander-shaposhnikov edited the summary of this revision. alexander-shaposhnikov added a comment. New approach to constraints' comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507439. rymiel added a comment. Fix `true` edge case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittest

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507440. rymiel added a comment. Remove unnecessary musing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/uni

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. In D145642#4213256 , @usaxena95 wrote: > Another point: > While testing this patch, the following still fails to recognise. Might be > something special with `true`. > > auto y = [&] > requires true(Callable && callable) >

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1352 + + // Both at once? Probably not even valid. + Tokens = annotate("[] requires Foo (T t) requires Bar {}"); usaxena95 wrote:

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Hmm... there is a lot going on here that I'm not sure is necessary? I was able to change the `AreConstraintExpressionsEqual` 'if' body to just: +MultiLevelTemplateArgumentList OldMLTAL = +getTemplateArgumentsForComparison(*this, Old); +MultiLevel

[clang] ead9644 - [clang-format] Annotate noexcept, explicit specifiers as containing expressions

Author: Emilia Dreamer Date: 2023-03-22T20:27:17+02:00 New Revision: ead9644684e85e0611f3b0ff72926820f1277e09 URL: https://github.com/llvm/llvm-project/commit/ead9644684e85e0611f3b0ff72926820f1277e09 DIFF: https://github.com/llvm/llvm-project/commit/ead9644684e85e0611f3b0ff72926820f1277e09.diff

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGead9644684e8: [clang-format] Annotate noexcept, explicit specifiers as containing expressions (authored by rymiel). Repository: rG LLVM Github Mon

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. Yeah, this seems a bit burdensome for both the frontend (encoding more information, the author has to duplicate the name of the implementation function so there's a risk they get out of sync?) and the debugger (is the debugger expected to jump directly and not call the

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks for the comments, the changes in SemaTemplateInstantiateDecl.cpp are necessary, in particular, they enable us to handle the case template concept Constraint = true; template struct Iterator { template friend clas

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added a comment. Yeah this information is probably at least partially unavailable in the fully parsed AST. We have all the instantiations with their AST copied from the original template AST, but we no longer remember *why* we copied it (which is what the `CodeSynthesisContext` stack captur

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. So looking at the DWARF spec for this - I see what it's going for, but yeah, I wouldn't want to use a textual representation either at the source or bitcode level, ideally... - perhaps this should just be implemented in LLVM when something's being lowered to a trampoli

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

MaskRay added a comment. In D145646#4213547 , @gulfem wrote: > We started seeing a test failure in `avr-ld.c`. > > /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: > // LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4213943 , @alexander-shaposhnikov wrote: > @erichkeane - thanks for the comments, the changes in > SemaTemplateInstantiateDecl.cpp are necessary, in particular, they enable us > to handle the case > > template

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1676 +Inst->setLexicalDeclContext(Owner); +RecordInst->setLexicalDeclContext(Owner); + this bit is important Repository: rG LLVM Github Monorepo

[clang] 38d69df - [Driver][test] Fix avr-ld.c for -DCLANG_DEFAULT_LINKER=lld after D145646

Author: Fangrui Song Date: 2023-03-22T11:36:02-07:00 New Revision: 38d69df5c2dad0d4ceb08d840840ab083dd673fe URL: https://github.com/llvm/llvm-project/commit/38d69df5c2dad0d4ceb08d840840ab083dd673fe DIFF: https://github.com/llvm/llvm-project/commit/38d69df5c2dad0d4ceb08d840840ab083dd673fe.diff

[PATCH] D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Since the check belongs to the google module, it make

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel updated this revision to Diff 507451. rymiel added a comment. Reduce column limit for macro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141811/new/ https://reviews.llvm.org/D141811 Files: clang/lib/Format/TokenAnnotator.cpp clang

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4181-4191 +for (auto &UseDeviceOp : UseDeviceInfos) { + auto *UseDeviceVal = UseDeviceOp.first; + auto &UseDeviceInfo = UseDeviceOp.second;

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb created this revision. cjdb added reviewers: aaron.ballman, vaibhav.y, denik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per §3.27.5 and §3.27.7, the `rule.id` and `ruleId` properties need to be h

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputT

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Test suite name ca

[clang-tools-extra] 7e5c48b - [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

Author: Carlos Galvez Date: 2023-03-22T18:51:51Z New Revision: 7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d URL: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d DIFF: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d.diff LOG:

[PATCH] D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5c48b8bd9f: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder (authored by carlosgalvezp). Changed prior to commit: h

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507458. carlosgalvezp added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoog

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507464. carlosgalvezp added a comment. Add to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files: clang-tools-extra/clang-tidy/google/AvoidU

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507465. carlosgalvezp retitled this revision from "[clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name" to "[clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name". carlosgalvezp added

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507467. carlosgalvezp added a comment. Remove excessive newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files: clang-tools-extra/clang-tidy/google/Avo

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using Please keep alphabetical order (by check name) in this section. Repository: r

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

ymandel accepted this revision. ymandel added a comment. Awesome, thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:18 + +class ControlFlowContext; +class TypeErasedDataflowAnalysis; Maybe comment on the need for these vs including the hea

[PATCH] D146466: [clang] diagnose function fallthrough

dblaikie added a comment. In D146466#4213814 , @nickdesaulniers wrote: > In D146466#4207915 , @efriedma > wrote: > >> I'm concerned about the potential for false positives: >> >> - If a user doesn't mark a funct

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146535/new/ https://reviews.llvm.org/D146535 ___ cfe-commits mailing list cfe-commi

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang created this revision. dang added reviewers: zixuw, ributzka, bnbarham. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use CRTP to enable creating static

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:48 /// The EABI version to use - llvm::EABI EABIVersion; + llvm::EABI EABIVersion = llvm::EABI::Default; Looks good; this is consistent with the default initialization

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 507472. everythingfunctional added a comment. Herald added subscribers: jplehr, ormris, steven_wu, hiraditya. Address conflicts with main branch and fix new tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 added a comment. The template specialization information is still available but we may need to print it by ourselves. I will add a FIXME there and we will deal with it in a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added a comment. will add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument '-std=c++2b' not allowed with 'C'`. This is invoked by Meson during its configuration process and causes it to fail. Am I doing

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav updated this revision to Diff 507479. chaitanyav added a comment. Added tests to check for the right diagnostic messages and highlighting at correct place Update the release docs about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

bnbarham added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:170 bool operator()(SourceLocation Loc) { -// If the loc refers to a macro expansion we need to first get the file +// If the loc refersSourceLocationxpansion we need to first get t

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/X86/pr52289.ll:9 ; CHECK-NEXT: if.end: +; CHECK-NEXT:[[TMP0:%.*]] = add i32 [[A:%.*]], 1 +; CHECK-NEXT:[[CONV:%.*]] = and i32 [[TMP0]], 8 aeubanks wrote: > this is an instcom

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

zixuw added a comment. Good to see refactoring to make ExtractAPI easier to extend and use. Thanks Daniel! Some comments on the ExtractAPIVisitor part. I'll leave the libclang part to the experts. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:32 +template +c

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:628 +public: + ExtractAPIVisitor(ASTContext &Context, APISet &API) : Base(Context, API) {} + Same as above, should the constructor be `protected`? I guess it depends if w

[PATCH] D143704: [flang] Feature list plugin

Renaud-K reopened this revision. Renaud-K added a comment. This revision is now accepted and ready to land. Buildbot is failing with Failed Tests (2): Flang :: Examples/feature-list-class.f90 Flang :: Examples/feature-list-functions.f90 CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507483. doru1004 added a comment. Updated lit test to show variable added to compiler used vars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/C

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Could you post a link to the failed build please @Renaud-K? I'd like to see if I can diagnose what's going wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___ cf

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp openmp/libomptarget/test/offloading/target_c

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

manas added a comment. Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file? Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507486. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureL

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. The pre-commit was failing. Please do not commit without at least checking that the pre-commit is fine. https://buildkite.com/llvm-project/premerge-checks/builds/142487#018707c0-3ec0-4daa-a3a4-ffc815807994 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

gulfem added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507494. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: cl

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507497. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI (part 1) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Fi

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507503. cjdb edited the summary of this revision. cjdb added a comment. rebasing continues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: clang/include/clang/B

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

MaskRay added a comment. Thank you! (A somewhat common practice is to prefer `[test]` over `[NFC]` for pure-test changes (no code change) :) I see that " in a few -print tests" in the subject may render `[test]` unneeded.. perhaps what tag is used isn't really important.) Repository: rG LLV

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507510. cjdb added a comment. I think this corrects everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: clang/include/clang/Basic/Diagnostic.h clang/i

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507511. cjdb edited the summary of this revision. cjdb added a comment. And on this CL's side too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya added a comment. https://lists.riscv.org/g/sig-toolchains/message/548 has a proposal where X27 is one of the registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 _

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jhuber6 accepted this revision. jhuber6 added a comment. LG, thanks. If you include `Fixes: ` in the commit message it'll automatically close it by the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90 // Underscores are allowed to disable a test with the DISABLED_ prefix. -// https://github.com/google/googletest/blob/master/googletest/docs

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4261 + bool Temp; + return Val->getPointerDereferenceableBytes(M.getDataLayout(), Temp, Temp); } TIFitis wrote: > `getPointerDereferenceableBytes` doesn't fully support `Arg

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { paulkirth wrote: > craig.topper wrote: > > paulkirth wrote: > > > craig.topper wrote: > > >

[PATCH] D143704: [flang] Feature list plugin

AlexisPerry added a comment. In D143704#4214279 , @elmcdonough wrote: > Could you post a link to the failed build please @Renaud-K? I'd like to see > if I can diagnose what's going wrong. Here is another helpful issue link regarding the failed build:

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4214148 , @dblaikie wrote: > In D146466#4213814 , > @nickdesaulniers wrote: > >> In D146466#4207915 , @efriedma >> wrote: >>

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + aaron.ballman wrote: > I suspect this doesn't matter *too* much, but... on Windows, wouldn'

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:125 + // `-mroptr` implies the `-bforceimprw` linker option. + // The `-mroptr` option places constants in RO sections as much as possible. Delete `// `-mroptr` implies the `-bforc

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

glandium created this revision. glandium added a reviewer: thakis. Herald added a project: All. glandium requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When building clang with e.g. LLVM_ENABLE_RUNTIMES=libcxx;libunwind, those runt

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + pcc wrote: > aaron.ballman wrote: > > I suspect this doesn't matter *too* much, but... on W

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

MaskRay added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:1 +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr %s 2>&1 | \ +// RUN: FileCheck %s --check-prefixes=ROPTR,LINK Prefer `--target=` to `-target ` for new tests. =

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90 // Underscores are allowed to disable a test with the DISABLED_ prefix. -// https://github.com/google/googletest/blob/master/google

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked an inline comment as done. chaitanyav added a comment. @aaron.ballman Please review. Comment at: clang/test/Sema/complex-init-list.c:37 struct teststruct invalid1 = { 1, 2 }; // expected-warning {{excess elements}} -_Complex float invalid2 = { 1, 2, 3 }; //

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

denik added inline comments. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:103 +// Stable names +const char *const StaticDiagInfoStableNames[] = { +#define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR, \ As of now it's 4600 strings, arou

[clang] 201fdef - libclang: Pass Clang install directory to driver via argv[0].

Author: Peter Collingbourne Date: 2023-03-22T15:28:21-07:00 New Revision: 201fdef40dd6ec193d18d39638454a3c972f1fec URL: https://github.com/llvm/llvm-project/commit/201fdef40dd6ec193d18d39638454a3c972f1fec DIFF: https://github.com/llvm/llvm-project/commit/201fdef40dd6ec193d18d39638454a3c972f1fec

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

This revision was automatically updated to reflect the committed changes. Closed by commit rG201fdef40dd6: libclang: Pass Clang install directory to driver via argv[0]. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D146497?vs=506832&id=507525#toc Repository: rG LLVM Gi

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507527. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add enum to Multilib class for how print options should be calculated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] e7596a9 - [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference

Author: MalavikaSamak Date: 2023-03-22T15:32:51-07:00 New Revision: e7596a99fca6d1df14275f5293e447a4d87af06a URL: https://github.com/llvm/llvm-project/commit/e7596a99fca6d1df14275f5293e447a4d87af06a DIFF: https://github.com/llvm/llvm-project/commit/e7596a99fca6d1df14275f5293e447a4d87af06a.diff

[PATCH] D143206: [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7596a99fca6: [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference (authored by malavikasamak). Herald added a project: clang. Herald a

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

mysterymath created this revision. mysterymath added reviewers: haowei, phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag causes the toolchain dis

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:32 +template +class ExtractAPIVisitorBase : public RecursiveASTVisitor { public: zixuw wrote: > zixuw wrote: > > Would it be better to call this `ExtractAPIVisitorImpl` b

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 507535. iains marked 12 inline comments as done. iains edited the summary of this revision. iains added a comment. rebased, addressed review comments, and amended the description. the patch has been repurposed to provide a mechanism to track implementation TUs

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 507532. nextsilicon-itay-bookstein added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. Removed the empty string in the `getName()` invocation for the outlined helper's name. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:34 static std::unique_ptr textual(llvm::raw_ostream &); + // A logger that builds an HTML UI to inspect the analysis results. + // One file is written under the specified dir pe

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. > This is quite fragile, for a few reasons. > It's too easy for the user to get undiagnosed typos. e.g., they want to > dispatch to bar but accidentally dispatch to barf or bar() instead. > How does this work with overloaded functions? Templated functions with > spec

[PATCH] D146644: [documentation]Fixed Random Typos

ayushi-8102 added a comment. Hi @ipriyanshi1708 , I am also an Outreachy applicant and I have also resolved various typos related to this issue. I will be submitting my patch very soon. We can collaborate for this issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1672-1677 + // A module implementation unit has visibility of the decls in its implicitly + // imported interface. + if (getLangOpts().CPlusPlusModules && NewM && OldM

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. > Yes, but kernel developers would prefer to diagnose issues at compile time > when possible, rather that at runtime. Function fallthough is diagnosable at > compile time, as this patch demonstrates. I'm not saying the diagnostic is useless. I'm saying users are going

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 507539. jrmolin added a comment. I updated the code comment in Format.h and ran the docs generator. I didn't modify the Macros section, but that got updated when I ran the docs generator. We don't have a published style guide, unfortunately. I can work towar

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added a comment. I still don't know what `Please write it out long form` means for the unit test. Comment at: clang/docs/ClangFormatStyleOptions.rst:3663 +.. _Macros: + I didn't modify this section in the head

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang updated this revision to Diff 507543. dang added a comment. Addressing code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146656/new/ https://reviews.llvm.org/D146656 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang updated this revision to Diff 507544. dang added a comment. Adding back missing diffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146656/new/ https://reviews.llvm.org/D146656 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h cl

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ created this revision. NoQ added reviewers: jkorous, t-rasmud, ziqingluo-90, malavikasamak, aaron.ballman, gribozavr, ymandel, sgatev. Herald added subscribers: steakhal, martong. Herald added a project: All. NoQ requested review of this revision. Herald added a subscriber: MaskRay. This patc

[PATCH] D146595: [clang] Add clang trampoline attribute

aprantl added a comment. > If it's the latter, then, yeah, some "transparent to debugger" source > attribute might be appropriate - that lowers to a bit on the DISubprogram and > instructs LLVM to, if the function definition ends up lowering to a > trampoline, mark that for the debugger so it's

<    1   2   3   >