ymandel accepted this revision.
ymandel added a comment.
Awesome, thanks!
================
Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:18
+
+class ControlFlowContext;
+class TypeErasedDataflowAnalysis;
----------------
Maybe comment on the need for these vs including the headers.
================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:393
+ if (Opts.Log == nullptr) {
+ if (DataflowLog.getNumOccurrences()) {
+ LogOwner = Logger::textual(llvm::errs());
----------------
nit: `> 0`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144730/new/
https://reviews.llvm.org/D144730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
